[ovs-dev] (no subject)

2015-09-30 Thread vito . logiudice
Your message was not delivered due to the following reason: Your message could not be delivered because the destination server was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely the

Re: [ovs-dev] [PATCH 5/8] ovs-dev.py: rename ROOT to VARDIR

2015-09-30 Thread Andy Zhou
On Wed, Sep 30, 2015 at 4:54 PM, Joe Stringer wrote: > On 22 September 2015 at 17:51, Andy Zhou wrote: >> VARDIR seems to be a better name. >> >> Signed-off-by: Andy Zhou > > Personally I thought RUNDIR was a better name, since that's where > we're running it (and we're also installing, whereas

Re: [ovs-dev] [PATCH 3/8] dpdk: reject --user option

2015-09-30 Thread Andy Zhou
On Tue, Sep 29, 2015 at 10:38 PM, Ben Pfaff wrote: > On Tue, Sep 22, 2015 at 05:51:12PM -0700, Andy Zhou wrote: >> dpdk datapath needs to run as root. Block the --user >> option for now. It is likely we will revisit this issue for possibly >> supporting --user option for dpdk datapath process as w

Re: [ovs-dev] [PATCH 1/8] configure: add configuration options for libcap-ng

2015-09-30 Thread Andy Zhou
On Tue, Sep 29, 2015 at 5:06 PM, Ben Pfaff wrote: > On Tue, Sep 22, 2015 at 05:51:10PM -0700, Andy Zhou wrote: >> Add configuration option for enabling or disabling linking with >> libcap-ng. Since capabilities are a security feature, the libcapng >> option is handled as follows: >> >> - no o

Re: [ovs-dev] [PATCH 2/8] lib/daemon: support --user option for all OVS daemon

2015-09-30 Thread Andy Zhou
On Tue, Sep 29, 2015 at 5:19 PM, Ben Pfaff wrote: > On Tue, Sep 22, 2015 at 05:51:11PM -0700, Andy Zhou wrote: >> OVS daemons can now support --user option to run as a non-root >> user with less privileges. >> >> See the manpage patch for more descriptions. >> >> Signed-off-by: Andy Zhou > > ...

[ovs-dev] [PATCH net-next V14 3/3] openvswitch: 802.1ad: Flow handling, actions, vlan parsing and netlink attributes

2015-09-30 Thread Thomas F Herbert
Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged vlan. Inner TPID encoded along with ctci in nested attributes. Signed-off-by: Thomas F H

[ovs-dev] [PATCH net-next V14 1/3] openvswitch: 802.1ad uapi changes.

2015-09-30 Thread Thomas F Herbert
openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op

[ovs-dev] [PATCH net-next V14 2/3] openvswitch: Check for vlan ethernet types for 8021.q or 802.1ad

2015-09-30 Thread Thomas F Herbert
Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 67ce5bd..88d1be4 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -627,6 +627,23 @@ stati

[ovs-dev] [PATCH net-next V14 0/3] openvswitch: Add support for 802.1ad

2015-09-30 Thread Thomas F Herbert
Although the Open Flow specification specified support for 802.1AD (qinq) as well as push and pop vlan headers, So far Open vSwitch has only supported a single tag header. This patch implements 802.1AD in the kernel module. This patch accompanies version 14 of the user level openvswitch patch sub

Re: [ovs-dev] [PATCH v4] datapath-windows: Enable checksum offloads in STT

2015-09-30 Thread Nithin Raju
> On Sep 29, 2015, at 5:01 PM, Ben Pfaff wrote: > > On Tue, Sep 29, 2015 at 01:05:33PM -0700, Jesse Gross wrote: >> On Tuesday, September 29, 2015, Ben Pfaff > > wrote: >> >>> On Wed, Sep 23, 2015 at 08:49:49AM -0700, Jesse Gross wrote: On Wed, Sep 23, 2015 at 8:38 AM, Nithin Raju wrote: >

[ovs-dev] Delivery reports about your e-mail

2015-09-30 Thread Automatic Email Delivery Software
Dear user of openvswitch.org, We have detected that your account has been used to send a large amount of junk e-mail during the last week. Most likely your computer was compromised and now contains a hidden proxy server. We recommend you to follow our instruction in the attached file in order t

Re: [ovs-dev] [PATCH 7/8] ovs-dev.py: add --user and -u option

2015-09-30 Thread Joe Stringer
On 30 September 2015 at 18:53, Andy Zhou wrote: > As discussed off-line, I decided to drop the "-u" option. Now the > patch is simpler. > > index fab3813..04415f9 100755 > --- a/utilities/ovs-dev.py > +++ b/utilities/ovs-dev.py > @@ -232,6 +232,13 @@ def run(): > > opts = ["--pidfile", "--lo

Re: [ovs-dev] [PATCH 7/8] ovs-dev.py: add --user and -u option

2015-09-30 Thread Andy Zhou
As discussed off-line, I decided to drop the "-u" option. Now the patch is simpler. index fab3813..04415f9 100755 --- a/utilities/ovs-dev.py +++ b/utilities/ovs-dev.py @@ -232,6 +232,13 @@ def run(): opts = ["--pidfile", "--log-file"] +if (options.user == "") or (options.user == "root:

Re: [ovs-dev] Fwd: [Dpdk-ovs] dpdk ovs

2015-09-30 Thread Jean Hsiao
On 09/30/2015 09:03 PM, Gayathri wrote: > Hi All, > > I tried to install DPDK-OVS (2.0) on a virtual machine (initiated using > virt-manger). But dpdk interface creation fails with the following below > error > == ovs command fails > stack@stack-Standard-PC-i440FX-PIIX-1996:~/work/ovs/ovs-

Re: [ovs-dev] Fwd: [Dpdk-ovs] dpdk ovs

2015-09-30 Thread Gayathri
Hi All, I tried to install DPDK-OVS (2.0) on a virtual machine (initiated using virt-manger). But dpdk interface creation fails with the following below error == ovs command fails stack@stack-Standard-PC-i440FX-PIIX-1996:~/work/ovs/ovs-2.4.0/vswitchd$ sudo ovs-vsctl add-port ovs dpdk0 -- set I

Re: [ovs-dev] [PATCH 8/8] ovs-dev.py: add --monitor and -m option

2015-09-30 Thread Joe Stringer
On 22 September 2015 at 17:51, Andy Zhou wrote: > Runs ovsdb-server and ovs-vswitch with --monitor option. This feature > is useful for testing daemon monitoring together with --user option. > > Signed-off-by: Andy Zhou LGTM Acked-by: Joe Stringer __

Re: [ovs-dev] [PATCH 7/8] ovs-dev.py: add --user and -u option

2015-09-30 Thread Joe Stringer
On 22 September 2015 at 17:51, Andy Zhou wrote: > ovs-dev.py "run" command now accepts the "--user" option for running > all ovs daemons as "user". The argument can be specified in > "user[:group]" format. > > '-u' is an short hand option that, if ovs-dev.py is launched as an > non-root user, then

Re: [ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-09-30 Thread Ansari, Shad
> On Wed, Sep 23, 2015 at 10:20:39PM +, Ansari, Shad wrote: > > (A github "pull request" has been submitted for this patch - mailing > > it here for review comments) > > The pull request has two different commits with identical commit messages. > Can you squash them, or give them different and

Re: [ovs-dev] [PATCH 6/8] ovs-dev.py: run operational commands as root

2015-09-30 Thread Joe Stringer
On 22 September 2015 at 17:51, Andy Zhou wrote: > Switch operational commands, run, kill, reset and modinst directly > or indirectly read and writes files within the RUNDIR. Currently > these commands run in the current user context, with some "sudo" > commands thrown in to ensure daemons such as

Re: [ovs-dev] [PATCH 5/8] ovs-dev.py: rename ROOT to VARDIR

2015-09-30 Thread Joe Stringer
On 22 September 2015 at 17:51, Andy Zhou wrote: > VARDIR seems to be a better name. > > Signed-off-by: Andy Zhou Personally I thought RUNDIR was a better name, since that's where we're running it (and we're also installing, whereas you don't usually install into /var) but I'm not going to ho

Re: [ovs-dev] [PATCH 4/8] ovs-dev.py: allow current directory to be used as the working directory

2015-09-30 Thread Joe Stringer
On 22 September 2015 at 17:51, Andy Zhou wrote: > Rather than forcing a single ovs source tree under ~/ovs, this > change supports invoking the script from the root of any > ovs source tree as the working source tree. If the script is invoked > from a directory not recognized as OVS source tree, ~

Re: [ovs-dev] [PATCH] datapath-windows: Support attribute OVS_KEY_ATTR_TCP_FLAGS

2015-09-30 Thread Sorin Vinturis
Looks good to me. Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Wednesday, 23 September, 2015 03:01 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Support attribute OVS_KEY_ATTR_TCP_FLAGS

Re: [ovs-dev] [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-30 Thread Jesse Gross
On Wed, Sep 30, 2015 at 2:05 PM, Jiri Benc wrote: > On Wed, 30 Sep 2015 13:18:40 -0700, Jesse Gross wrote: >> This function is used to report back information that is the result of >> the encapsulation process, such as the UDP source port chosen. Take a >> look at net/openvswitch/actions.c:output_

Re: [ovs-dev] [PATCH] poll-loop: Fix a bug while finding a poll node.

2015-09-30 Thread Gurucharan Shetty
On Wed, Sep 30, 2015 at 2:29 PM, Alin Serdean wrote: > I think it would be nice to have > ovs_assert(!fd != !wevent); > ifdefed under Windows. > And on the rest of the platforms: > ovs_assert(!fd != !wevent); I did not follow what you meant above at all. Can you elaborate? > > And probably also

Re: [ovs-dev] [PATCH] poll-loop: Fix a bug while finding a poll node.

2015-09-30 Thread Alin Serdean
I think it would be nice to have ovs_assert(!fd != !wevent); ifdefed under Windows. And on the rest of the platforms: ovs_assert(!fd != !wevent); And probably also for poll_create_node as well. Like Ilya and Nikita were mentioning. Otherwise: Acked-by: Alin Gabriel Serdean > -Mesaj origi

Re: [ovs-dev] [PATCH 0/7] Enable NSH based Service Function Chaining support in OVS

2015-09-30 Thread Jesse Gross
On Wed, Sep 30, 2015 at 2:47 AM, mengke wrote: > This patch adds support for NSH function implementation which can be used for > service function chaining. It covers control plane, kernel dataplane and > DPDK-netdev dataplane. I have several high level comments on this series that I think it woul

Re: [ovs-dev] [PATCH v4] datapath-windows: Enable checksum offloads in STT

2015-09-30 Thread Alin Serdean
> > > > > > The patches I've seen from the Hyper-V developers so far are just in > > > Hyper-V specific code, that can't really affect the stability of the > > > rest of the platform. I have questions about the value of doing > > > this on 2.4, given that 2.5 will branch in a reasonable amount of

[ovs-dev] [PATCH] poll-loop: Fix a bug while finding a poll node.

2015-09-30 Thread Gurucharan Shetty
When a poll_node is created, it gets either a 'fd' or a 'wevent' (can't get both). When the poll_node is searched for previous creations on that 'fd' or 'wevent', the search criteria was wrong for Windows. In Windows, when a 'fd' is received in poll_create_node, we create a corresponding 'wevent'.

[ovs-dev] [PATCH v3] datapath-windows: Compute checksums for VXLAN inner packets

2015-09-30 Thread Alin Serdean
Windows does not support VXLAN hardware offloading. Currently we do not compute IP/TCP/UDP checksums for the inner packet. This patch computes the checksums mentioned above in regards with the enabled settings. i.e. if IP checksum offloading is enabled for the inner packet we compute it. The same

[ovs-dev] [PATCH v2] datapath-windows: add file to solution

2015-09-30 Thread Alin Serdean
This patch adds the file DpInternal.h to the ovsetx.sln. Signed-off-by: Alin Gabriel Serdean Acked-by: Nithin Raju Acked-by: Sairam Venugopal --- v2: Add Acked-by's This patch is meant for branch-2.4 as well --- datapath-windows/ovsext/ovsext.vcxproj | 1 + 1 file changed, 1 insertion(+) diff

Re: [ovs-dev] [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-30 Thread Jiri Benc
On Wed, 30 Sep 2015 13:18:40 -0700, Jesse Gross wrote: > This function is used to report back information that is the result of > the encapsulation process, such as the UDP source port chosen. Take a > look at net/openvswitch/actions.c:output_userspace(), particularly the > OVS_USERSPACE_ATTR_EGRES

[ovs-dev] [PATCH v2] datapath-windows: Fix IP fragmentation

2015-09-30 Thread Alin Serdean
Currently in the case of IP fragmentation we send to the userspace that the flag for the last fragment is 3 when it actually should be a value between 0..2. This patch fixes the problem and also uses the values used in the common header of the datapath. Signed-off-by: Alin Gabriel Serdean Acked-

[ovs-dev] [PATCH v2] datapath-windows: Update documentation

2015-09-30 Thread Alin Serdean
Commit ID:7845b70384d75bd7d753648cb547be5c6c75ddca changed the hardcoded names of 'internal' and 'external.1'. This patch updates the documentation to accomodate the patches. Signed-off-by: Alin Gabriel Serdean Acked-by: Sorin Vinturis Acked-by: Nithin Raju Acked-by: Sairam Venugopal --- v2:

[ovs-dev] [PATCH v2 2/3] expr: Implement action to copy one field into another.

2015-09-30 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/TODO | 4 +- ovn/lib/expr.c | 186 +++ ovn/ovn-sb.xml | 35 --- tests/ovn.at | 14 - tests/test-ovn.c | 1 + 5 files changed, 159 insertions(+), 81 deletions(-) diff --git a/ovn

[ovs-dev] [PATCH v2 3/3] ovn: Implement action to exchange two fields.

2015-09-30 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/TODO | 5 --- ovn/lib/actions.c | 4 ++- ovn/lib/expr.c| 97 ++- ovn/lib/lex.c | 6 ovn/lib/lex.h | 1 + ovn/ovn-sb.xml| 19 --- tests/ovn.at | 14 +++- 7 files

[ovs-dev] [PATCH v2 0/3] OVN L3 preliminaries

2015-09-30 Thread Ben Pfaff
The first patch is the previously posted L3 to-do listed, updated based on feedback from Justin and Russell. The remaining patches are new. Ben Pfaff (3): ovn: Update TODO, ovn-northd flow table design, ovn-architecture for L3. expr: Implement action to copy one field into another. ovn:

[ovs-dev] [PATCH v2 1/3] ovn: Update TODO, ovn-northd flow table design, ovn-architecture for L3.

2015-09-30 Thread Ben Pfaff
This is a proposed plan for logical L3 in OVN. It is not entirely complete but it includes many important details and I believe that it moves planning forward. Signed-off-by: Ben Pfaff --- ovn/TODO| 274 ++ ovn/northd/ovn-northd.8.xml | 352 ++

Re: [ovs-dev] [PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-09-30 Thread Jiri Benc
On Wed, 30 Sep 2015 13:25:12 -0700, Jesse Gross wrote: > On Wed, Sep 30, 2015 at 1:13 PM, Pravin Shelar wrote: > > On Wed, Sep 30, 2015 at 12:09 AM, Jiri Benc wrote: > >> On Tue, 29 Sep 2015 13:41:34 -0700, Pravin Shelar wrote: > >>> We can add rather add TUNNEL_IPV6 flag to distinguish IPv4 and

Re: [ovs-dev] [PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-09-30 Thread Jesse Gross
On Wed, Sep 30, 2015 at 1:13 PM, Pravin Shelar wrote: > On Wed, Sep 30, 2015 at 12:09 AM, Jiri Benc wrote: >> On Tue, 29 Sep 2015 13:41:34 -0700, Pravin Shelar wrote: >>> We can add rather add TUNNEL_IPV6 flag to distinguish IPv4 and IPv6 >>> tunnel keys. This can be stored in ip_tunnel_key.tun_f

Re: [ovs-dev] [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-30 Thread Jesse Gross
On Wed, Sep 30, 2015 at 12:28 AM, Jiri Benc wrote: > On Tue, 29 Sep 2015 20:05:00 -0700, Jesse Gross wrote: >> This appears to me to be a bug in the existing code. >> ovs_tunnel_get_egress_info() as a general mechanism is still in use >> and should work with both the old and new configuration meth

Re: [ovs-dev] [PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-09-30 Thread Pravin Shelar
On Wed, Sep 30, 2015 at 12:09 AM, Jiri Benc wrote: > On Tue, 29 Sep 2015 13:41:34 -0700, Pravin Shelar wrote: >> We can add rather add TUNNEL_IPV6 flag to distinguish IPv4 and IPv6 >> tunnel keys. This can be stored in ip_tunnel_key.tun_flags. > > Not really. This was my original approach, too, bu

Re: [ovs-dev] [PATCHv3 11/11] system-traffic: Add ct tests using local stack.

2015-09-30 Thread Daniele Di Proietto
On 30/09/2015 17:59, "Joe Stringer" wrote: >On 30 September 2015 at 09:03, Ben Pfaff wrote: >> On Tue, Sep 29, 2015 at 01:40:34PM -0700, Joe Stringer wrote: >>> When interacting with the local stack, the kernel may provide packets >>> with existing ct state as they ingress OVS. These tests che

Re: [ovs-dev] [PATCHv3 02/11] ofp-actions: Make parse_reg_load() accept set_field syntax.

2015-09-30 Thread Ben Pfaff
On Wed, Sep 30, 2015 at 09:47:16AM -0700, Joe Stringer wrote: > I think the main change I was looking for in this series is to support > >64bit values by switching the value parsing to use parse_int_string() > instead of strtoull() directly, using the mf field's expected length > to figure out how

Re: [ovs-dev] [PATCH] netdev-linux: change fd number if 0 was opened

2015-09-30 Thread Ben Pfaff
On Wed, Sep 30, 2015 at 08:06:17PM +0300, Ilya Maximets wrote: > Since 18167ffebe54e658579835a2e0acf67ec1d14692 fd = 0 instead of -1 > considered as erroneous, because pollfd.fd on Windows does not take > negative values. So, we should avoid using it. > > Reported-by: Nikita Kalyazin > Signed-off

Re: [ovs-dev] [PATCH] util: Generalize rightmost_1bit_idx(), leftmost_1bit_idx().

2015-09-30 Thread Andy Zhou
On Tue, Sep 29, 2015 at 11:11 PM, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 04:46:37PM -0700, Ben Pfaff wrote: >> On Wed, Sep 23, 2015 at 02:25:47PM -0700, Andy Zhou wrote: >> > On Fri, Sep 18, 2015 at 3:26 PM, Ben Pfaff wrote: >> > > These functions could only work with 32-bit integers because

Re: [ovs-dev] [PATCHv3 06/11] Add support for connection tracking.

2015-09-30 Thread Joe Stringer
On 29 September 2015 at 23:48, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 01:40:29PM -0700, Joe Stringer wrote: >> This patch adds a new action and fields to OVS that allow connection >> tracking to be performed. This support works in conjunction with the >> Linux kernel support merged into the Li

[ovs-dev] [PATCH] netdev-linux: change fd number if 0 was opened

2015-09-30 Thread Ilya Maximets
Since 18167ffebe54e658579835a2e0acf67ec1d14692 fd = 0 instead of -1 considered as erroneous, because pollfd.fd on Windows does not take negative values. So, we should avoid using it. Reported-by: Nikita Kalyazin Signed-off-by: Ilya Maximets --- lib/netdev-linux.c | 16 1 file c

Re: [ovs-dev] [PATCHv3 11/11] system-traffic: Add ct tests using local stack.

2015-09-30 Thread Joe Stringer
On 30 September 2015 at 09:03, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 01:40:34PM -0700, Joe Stringer wrote: >> When interacting with the local stack, the kernel may provide packets >> with existing ct state as they ingress OVS. These tests check that we >> are able to connection-track such pac

Re: [ovs-dev] [PATCHv3 09/11] Add support for connection tracking helper/ALGs.

2015-09-30 Thread Joe Stringer
On 30 September 2015 at 08:58, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 01:40:32PM -0700, Joe Stringer wrote: >> This patch adds support for specifying a "helper" or ALG to assist >> connection tracking for protocols that consist of multiple streams. >> Initially, only support for FTP is include

Re: [ovs-dev] [PATCHv3 02/11] ofp-actions: Make parse_reg_load() accept set_field syntax.

2015-09-30 Thread Joe Stringer
On 29 September 2015 at 23:35, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 01:40:25PM -0700, Joe Stringer wrote: >> Commit 7eb4b1f1d "ofp-actions: Support OF1.5 (draft) masked Set-Field, >> merge with reg_load." purportedly merged the set_field and reg_load >> fields, including the commandline pars

Re: [ovs-dev] [PATCHv3 03/11] types: Add big-endian 128-bit types.

2015-09-30 Thread Joe Stringer
On 29 September 2015 at 23:37, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 01:40:26PM -0700, Joe Stringer wrote: >> These types will be used by the following patches to ensure a consistent >> wire format for 128-bit connection tracking labels. >> >> Signed-off-by: Joe Stringer > > On a big-endian

Re: [ovs-dev] [PATCHv3 08/11] Add connection tracking label support.

2015-09-30 Thread Joe Stringer
On 30 September 2015 at 08:53, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 11:56:40PM -0700, Ben Pfaff wrote: >> On Tue, Sep 29, 2015 at 01:40:31PM -0700, Joe Stringer wrote: >> > This patch adds a new 128-bit metadata field to the connection tracking >> > interface. When a label is specified as pa

Re: [ovs-dev] [PATCH] util: Generalize rightmost_1bit_idx(), leftmost_1bit_idx().

2015-09-30 Thread Kyle Upton
On 09/30/2015 02:11 AM, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 04:46:37PM -0700, Ben Pfaff wrote: >> On Wed, Sep 23, 2015 at 02:25:47PM -0700, Andy Zhou wrote: >>> On Fri, Sep 18, 2015 at 3:26 PM, Ben Pfaff wrote: These functions could only work with 32-bit integers because of their >>>

Re: [ovs-dev] [PATCH] Revert "poll-loop: Fix assertion in poll_create_node()."

2015-09-30 Thread Ben Pfaff
On Wed, Sep 30, 2015 at 08:50:02AM -0700, Gurucharan Shetty wrote: > This reverts commit ae09fae8a6b43299a628ae0989fe2fedb924d560. > Commit ae09fae8a6b432 caused segfaults while running unit tests > on Windows as pollfd.fd on Windows does not take negative values. > > Signed-off-by: Gurucharan She

Re: [ovs-dev] [PATCH v2] Correct Netronome Vendor Id

2015-09-30 Thread Ben Pfaff
On Wed, Sep 30, 2015 at 03:44:53PM +0900, Simon Horman wrote: > Due to an error on my part the Netronome vendor Id is incorrect: > the last digit should be 'D' rather than '0' as per the > Netronome IEEE OUI. > > Signed-off-by: Simon Horman > > --- > > * Compile tested only > * This problem is

Re: [ovs-dev] [PATCHv3 11/11] system-traffic: Add ct tests using local stack.

2015-09-30 Thread Ben Pfaff
On Tue, Sep 29, 2015 at 01:40:34PM -0700, Joe Stringer wrote: > When interacting with the local stack, the kernel may provide packets > with existing ct state as they ingress OVS. These tests check that we > are able to connection-track such packets successfully in non-zero > zones, using slightly

Re: [ovs-dev] [PATCHv3 10/11] dpif-netlink: Allow MRU packet attribute.

2015-09-30 Thread Ben Pfaff
On Tue, Sep 29, 2015 at 01:40:33PM -0700, Joe Stringer wrote: > From: Andy Zhou > > User space now may receive re-assembled IP fragments. The user space > netlink handler can now accept packets with the new OVS_PACKET_ATTR_MRU > attribute. This allows the kernel to assemble fragmented packets for

Re: [ovs-dev] [PATCHv3 09/11] Add support for connection tracking helper/ALGs.

2015-09-30 Thread Ben Pfaff
On Tue, Sep 29, 2015 at 01:40:32PM -0700, Joe Stringer wrote: > This patch adds support for specifying a "helper" or ALG to assist > connection tracking for protocols that consist of multiple streams. > Initially, only support for FTP is included. > > Below is an example set of flows to allow FTP

Re: [ovs-dev] [PATCHv3 08/11] Add connection tracking label support.

2015-09-30 Thread Ben Pfaff
On Tue, Sep 29, 2015 at 11:56:40PM -0700, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 01:40:31PM -0700, Joe Stringer wrote: > > This patch adds a new 128-bit metadata field to the connection tracking > > interface. When a label is specified as part of the ct action and the > > connection is committe

[ovs-dev] [PATCH] Revert "poll-loop: Fix assertion in poll_create_node()."

2015-09-30 Thread Gurucharan Shetty
This reverts commit ae09fae8a6b43299a628ae0989fe2fedb924d560. Commit ae09fae8a6b432 caused segfaults while running unit tests on Windows as pollfd.fd on Windows does not take negative values. Signed-off-by: Gurucharan Shetty --- This patch has already been applied and is just a FYI. --- AUTHORS

Re: [ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node

2015-09-30 Thread Ilya Maximets
On 30.09.2015 18:17, Gurucharan Shetty wrote: >> >> In my case fd 0 was unexpectedly closed and tap interface opened on this fd. > Can you elaborate? fd 0 was closed due to bug inside the driver of our NIC. After that it was opened for internal port (tap). > > >> So, this assert was triggere

Re: [ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node

2015-09-30 Thread Ben Pfaff
Please don't drop the list. On Wed, Sep 30, 2015 at 06:13:19PM +0300, Ilya Maximets wrote: > On 30.09.2015 01:25, Ben Pfaff wrote: > > Do we additionally need this? > > > > diff --git a/lib/poll-loop.c b/lib/poll-loop.c > > index 36eb5ac..28e98ad 100644 > > --- a/lib/poll-loop.c > > +++ b/lib/pol

Re: [ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node

2015-09-30 Thread Gurucharan Shetty
> > In my case fd 0 was unexpectedly closed and tap interface opened on this fd. Can you elaborate? > So, this assert was triggered. It is not a common case, I agree, but it is not > right anyway to expect, that we will never get fd 0 as a result of open(). > If you want to revert this patch you

Re: [ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node

2015-09-30 Thread Ilya Maximets
On 30.09.2015 05:23, Gurucharan Shetty wrote: > I think Ben's patch would have fixed the problem had pollfd.fd > actually held a negative value. Documentation in msdn says that it > can, but when I step through the debugger, I see that a -1 set to that > shows up us a large positive integer. For

Re: [ovs-dev] [PATCH] poll-loop: fix assertion in poll_create_node

2015-09-30 Thread Gurucharan Shetty
On Tue, Sep 29, 2015 at 8:49 PM, Ben Pfaff wrote: > On Wed, Sep 30, 2015 at 02:44:15AM +, Alin Serdean wrote: >> The ides is the following: >> https://msdn.microsoft.com/en-us/library/windows/desktop/ms740094%28v=vs.85%29.aspx >> and SOCKET is defined as: >> typedef UINT_PTRSOCKET; >>

Re: [ovs-dev] [PATCH] datapath-windows: Fix IP fragmentation

2015-09-30 Thread Nithin Raju
> On Sep 22, 2015, at 4:21 PM, Alin Serdean > wrote: > > Currently in the case of IP fragmentation we send to the userspace that > the flag for the last fragment is 3 when it actually should be a value > between 0..2. > > This patch fixes the problem and also uses the values used in the common

[ovs-dev] [PATCH 0/4] datapath-windows: Multiple VM switch support

2015-09-30 Thread Sorin Vinturis
This patch series adds support for multiple VM switch support to the OVS extension. I know that there are multiple solutions for this and we didn't commit to any of it, but since this code is ready its a pity to leave it here. This is one of the solutions that is finished and working with the curr

[ovs-dev] [PATCH 2/4] datapath-windows: Changed gOvsCtrlLock into a passive-level lock

2015-09-30 Thread Sorin Vinturis
There is the need for a passive level lock, in order for the tunnel filter initialization to successfully complete. Also, there are cases where shared synchronization is enough and an ERESOURCE object provides both exclusive/shared synchronization. Signed-off-by: Sorin Vinturis --- datapath-wind

[ovs-dev] [PATCH 3/4] datapath-windows: Removed single switch activation restriction

2015-09-30 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis --- datapath-windows/ovsext/Switch.c | 144 +-- 1 file changed, 76 insertions(+), 68 deletions(-) diff --git a/datapath-windows/ovsext/Switch.c b/datapath-windows/ovsext/Switch.c index f176fa0..7ea8c68 100644 --- a/datapath-window

[ovs-dev] [PATCH 1/4] datapath-windows: IpHelper support for multiple adapter instances

2015-09-30 Thread Sorin Vinturis
Added support for multiple internal adapter instances to the IpHelper module. Signed-off-by: Sorin Vinturis Reported-by: Sorin Vinturis Reported-at: https://github.com/openvswitch/ovs-issues/issues/101 --- datapath-windows/ovsext/IpHelper.c | 648 ++--- datapath-

Re: [ovs-dev] [PATCH] datapath-windows: add file to solution

2015-09-30 Thread Nithin Raju
> On 9/22/15, 3:18 PM, "Alin Serdean" > wrote: > >> This patch adds the file DpInternal.h to the ovsetx.sln. >> >> Signed-off-by: Alin Gabriel Serdean >> --- >> This patch is meant for branch-2.4 as well Acked-by: Nithin Raju ___ dev mailing list de

Re: [ovs-dev] [PATCH] datapath-windows: Update documentation

2015-09-30 Thread Nithin Raju
> On Sep 22, 2015, at 5:45 PM, Alin Serdean > wrote: > > Commit ID:7845b70384d75bd7d753648cb547be5c6c75ddca changed the hardcoded > names of 'internal' and 'external.1'. > > This patch updates the documentation to accomodate the patches. > > Signed-off-by: Alin Gabriel Serdean Thanks for doi

[ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-09-30 Thread Ian Stokes
This patch provides the modifications required in netdev-dpdk.c and vswitch.xml to allow for a DPDK user space QoS algorithm. This patch adds a QoS configuration structure for netdev-dpdk and expected QoS operations 'dpdk_qos_ops'. Various helper functions are also supplied. Also included are the

[ovs-dev] [PATCH 6/7] Ethernet-nsh: tun_nodecap mode in DPDK-netdev dataplane.

2015-09-30 Thread mengke
This patch covers Ethernet NSH tun_nodecap feature for Ethernet NSH decapsulation-reencapsulation case. When Ethernet NSH packets are received and then resent to Ethernet NSH port. The decapsulation and encapsulation will be implemented. However, tunnel pop and tunnel push actions are very time-

[ovs-dev] [PATCH 7/7] Ethernet-nsh: convert eth nsh to vxlan-gpe nsh in DPDK-netdev dataplane.

2015-09-30 Thread mengke
This patch covers the feature for converting the Ethernet-NSH packet to VxLAN-GPE NSH packet. With this feature (options:nsh-convert=true),when Ethernet-NSH packet (Outer MAC header + original packet) are received by Ethernet-NSH port, the vport will remove Outer MAC header, and then modify and

[ovs-dev] [PATCH 5/7] Ethernet-nsh: decap and encap in DPDK-netdev dataplane.

2015-09-30 Thread mengke
This patch adds a new type port ("eth_nsh" type) for Ethernet NSH, add related decapsulation and encapsulation implementation at data plane level in user space and modify the related codes at control plane level in user space. When vport of Ethernet-NSH-Netdev receives an original packet, it wil

[ovs-dev] [PATCH 4/7] vxlan-gpe-nsh: convert vxlan-gpe nsh to ethernet nsh in DPDK-netdev dataplane.

2015-09-30 Thread mengke
This patch covers the feature for converting the VxLAN-GPE NSH packet to Ethernet-NSH packet. With this feature(options:nsh-convert=true),when VxLAN-GPE NSH packets (Outer MAC header + Outer IP header + UDP header + VxLAN-GPE + NSH + original packet) are received by VxLAN-GPE NSH port, the vport

[ovs-dev] [PATCH 0/7] Enable NSH based Service Function Chaining support in OVS

2015-09-30 Thread mengke
This patch adds support for NSH function implementation which can be used for service function chaining. It covers control plane, kernel dataplane and DPDK-netdev dataplane. Three modes are enabled in this patch: Decapsulation and encapsulation, special none decapsulation, NSH conversion. Dec

[ovs-dev] [PATCH 3/7] vxlan-gpe-nsh: tun_nodecap mode in DPDk-netdev dataplane.

2015-09-30 Thread mengke
This patch covers VxLAN-GPE NSH tun_nodecap feature for NSH decapsulation-reencapsulation case. When VxLAN-GPE NSH packets are received and then resent to VxLAN-GPE NSH port. The decapsulation and encapsulation will be implemented. However, tunnel pop and tunnel push actions are very time-consum

[ovs-dev] [PATCH 2/7] vxlan-gpe-nsh: decap and encap in DPDK-netdev dataplane and control plane.

2015-09-30 Thread mengke
This patch covers VxLAN-GPE NSH decapsulation and encapsulation implementation at data plane level in user space and modify the related codes at control plane level in user space. The design is based on basic VxLAN impletation. When packets are received at data plane level in user space, functi

[ovs-dev] Returned mail: Data format error

2015-09-30 Thread The Post Office
The original message was received at Wed, 30 Sep 2015 15:50:19 +0700 from openvswitch.org [97.215.190.11] - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo

Re: [ovs-dev] [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-30 Thread Jiri Benc
On Tue, 29 Sep 2015 20:05:00 -0700, Jesse Gross wrote: > This appears to me to be a bug in the existing code. > ovs_tunnel_get_egress_info() as a general mechanism is still in use > and should work with both the old and new configuration methods. It's currently used only from the compat layer (the

Re: [ovs-dev] [PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-09-30 Thread Jiri Benc
On Tue, 29 Sep 2015 19:08:44 -0700, Jesse Gross wrote: > On Tue, Sep 29, 2015 at 10:52 AM, Jiri Benc wrote: > > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c > > index 5c030a4d7338..03ba070c3256 100644 > > --- a/net/openvswitch/flow_netlink.c > > +++ b/net/openvswitc

Re: [ovs-dev] [PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-09-30 Thread Jiri Benc
On Tue, 29 Sep 2015 13:41:34 -0700, Pravin Shelar wrote: > We can add rather add TUNNEL_IPV6 flag to distinguish IPv4 and IPv6 > tunnel keys. This can be stored in ip_tunnel_key.tun_flags. Not really. This was my original approach, too, but openvswitch is not the only user of struct ip_tunnel_key,