On 22 September 2015 at 17:51, Andy Zhou <az...@nicira.com> wrote:
> Switch operational commands, run, kill, reset and modinst directly
> or indirectly read and writes files within the RUNDIR. Currently
> these commands run in the current user context, with some "sudo"
> commands thrown in to ensure daemons such as ovs-vswichd will be
> launched as root.
>
> This approach works fine as long as ovs-dev.py is always
> run as root, (but then the 'sudo' commands added are redundant).
> When invoking ovs-dev.py as non-root, files in RUNDIR will be mixed
> with root created file and non-root created files, making it confusing
> to decide whether to run ovs-appctl as root or not. Multiple
> invocations of ovs-dev.py as root or non-root causes permission issues
> since the same file created by a different user may no longer be
> accessible when user changes.
>
> This patch improves the situation by always run those four operational
> commands as root. When they are invoked as non-root, "sudo" will be
> used automatically by re-run the command with sudo. VARDIR will now
> always be access as root. The next patch will add --user and -u option
> to allow for downgrading to running all daemons as non-root.
>
> Signed-off-by: Andy Zhou <az...@nicira.com>
Thanks for fixing this. I think I figured out fairly quick that
non-root usage was broken so naturally avoided using it as a common
user.
> @@ -202,8 +209,8 @@ def reset():
> _sh("ovs-dpctl", "del-dp", dp.strip())
> commands.append(reset)
>
> -
> def run():
> + sudo()
> kill()
> for d in ["log", "run"]:
> d = "%s/%s" % (VARDIR, d)
Unrelated whitespace change. Generally pythonistas use pep8 to
style-check code, and it'll complain about this kind of thing.
Otherwise,
Acked-by: Joe Stringer <joestrin...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
