On Wed, Aug 26, 2015 at 10:20:48PM -0700, Ben Pfaff wrote:
> A lot of tests need to initialize the OVS_RUNDIR, OVS_LOGDIR, etc.
> variables to point to the directory in which the tests run. Until now,
> each of them has had to do this individually, which is redundant. This
> commit starts to do t
This is a really basic test of the OVN features. It verifies that basic
L2 connectivity works as expected over a 3-hypervisor setup with 3 VMs
per hypervisor and all 9 VMs on a single logical switch.
I wanted to test stateless ACLs also but there's no simple way to set them
up with ovn-nbctl. I
A shell function doesn't need quoted and unquoted variants and it
integrates naturally with other shell code.
Signed-off-by: Ben Pfaff
---
tests/ofproto-dpif.at | 61 ---
tests/ofproto-macros.at | 4 +--
tests/ofproto.at | 6 ++
A lot of tests need to initialize the OVS_RUNDIR, OVS_LOGDIR, etc.
variables to point to the directory in which the tests run. Until now,
each of them has had to do this individually, which is redundant. This
commit starts to do this automatically.
Signed-off-by: Ben Pfaff
---
tests/jsonrpc-py
This allows the ARP cache to be prepopulated for testing purposes, so
that tests don't lose the first packet to each destination. (I guess
this feature could have other uses too.)
Signed-off-by: Ben Pfaff
---
lib/tnl-arp-cache.c | 67 +
ofprot
This avoids packet duplication when native tunneling is used.
The right solution is to adjust the native tunneling code so that
it discards packets not directed to the current host. I expect
to see a patch for that correct solution soon, see:
http://openvswitch.org/pipermail/dev/2015-September/059
This makes the pcap files written by netdev-dummy up-to-date even if one
kills the process with a signal. This could be a performance hit if
the pcap file writer were to be used in some kind of performance critical
situation, but so far it's only used in netdev-dummy, which is just for
testing.
S
Thx applied this patch to master~!
Thanks,
Alex Wang,
On 29 August 2015 at 11:37, Joe Stringer wrote:
> On 29 August 2015 at 00:42, Alex Wang wrote:
> > When dpdk configuration changes, all pmd threads are recreated
> > and rx queues of each port are reloaded. After this process,
> > rx queue
On 1 September 2015 at 19:42, Joe Stringer wrote:
> Hi Alex, a minor comment, otherwise
>
> On 29 August 2015 at 18:44, Alex Wang wrote:
> > This commit adds logic using ovs barrier to allow main thread pause
> > all revalidators. This new feature will be used in a later patch.
> >
> > Signed-o
Hi Ben,
I have tested the patch , it works , now I don't see an update with just
the _version change.
Thanks for the quick response .
Best Regards,
Rishi Raj
On Mon, Aug 31, 2015 at 10:22 PM, Ben Pfaff wrote:
> On Mon, Aug 31, 2015 at 09:10:19AM +0530, RishiRaj Maulick wrote:
> > Hi ,
> >
> >
Hi Alex, a minor comment, otherwise
On 29 August 2015 at 18:44, Alex Wang wrote:
> This commit adds logic using ovs barrier to allow main thread pause
> all revalidators. This new feature will be used in a later patch.
>
> Signed-off-by: Alex Wang
Acked-by: Joe Stringer
> --- a/ofproto/ofpro
On Tue, Sep 01, 2015 at 07:14:00PM -0700, Pravin Shelar wrote:
> On Tue, Sep 1, 2015 at 4:56 PM, Ben Pfaff wrote:
> > I think I've come across a bug in OVS native tunneling, or at any rate
> > an important difference between Linux kernel and OVS native tunneling.
> > In Linux kernel tunneling, a t
On Tue, Sep 1, 2015 at 4:56 PM, Ben Pfaff wrote:
> I think I've come across a bug in OVS native tunneling, or at any rate
> an important difference between Linux kernel and OVS native tunneling.
> In Linux kernel tunneling, a tunnel packet received by the kernel first
> passes through the kernel I
Sorry for pushing the wrong button :)
On Tue, Sep 1, 2015 at 4:26 PM, Ben Pfaff wrote:
> On Tue, Sep 1, 2015 at 4:23 PM, Jarno Rajahalme wrote:
>>> On Sep 1, 2015, at 3:34 PM, Andy Zhou wrote:
>>>
I'm really uncertain about patches 7 and 8 because they didn't make a
significant d
> On Sep 1, 2015, at 6:09 PM, Russell Bryant wrote:
>
> On 09/01/2015 09:02 PM, Justin Pettit wrote:
>>
>>> On Sep 1, 2015, at 5:37 PM, Russell Bryant wrote:
>>>
>>> On 09/01/2015 08:21 PM, Justin Pettit wrote:
Signed-off-by: Justin Pettit
+ ovn-northd is responsible for
On 09/01/2015 09:02 PM, Justin Pettit wrote:
>
>> On Sep 1, 2015, at 5:37 PM, Russell Bryant wrote:
>>
>> On 09/01/2015 08:21 PM, Justin Pettit wrote:
>>> Signed-off-by: Justin Pettit
>>>
>>> + ovn-northd is responsible for populating the
>>> + , so the stages are an implementation
>>
> On Sep 1, 2015, at 5:37 PM, Russell Bryant wrote:
>
> On 09/01/2015 08:21 PM, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>>
>> + ovn-northd is responsible for populating the
>> + , so the stages are an implementation
>
> Should you add "table" here?
>
> the table
Don
On 09/01/2015 08:21 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
some wording suggestions inline, but otherwise:
Acked-by: Russell Bryant
> ---
> ovn/ovn-sb.xml | 43 +++
> 1 files changed, 43 insertions(+), 0 deletions(-)
>
> diff --git a
On 09/01/2015 08:21 PM, Justin Pettit wrote:
> The old documentation incorrectly attributed logical flow generation to
> the CMS instead of ovn-northd. This also corrects how a database is
> referenced in the documentation.
>
> Signed-off-by: Justin Pettit
Acked-by: Russell Bryant
--
Russell
On 09/01/2015 08:21 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
> ovn/ovn-architecture.7.xml |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml
> index c9ac597..85a74a9 100644
> --- a/ovn/ovn-ar
On 09/01/2015 04:35 PM, Ben Pfaff wrote:
> Reviewing the ovn-controller code I started to notice a common pattern:
>
> struct smap ext_ids = SMAP_INITIALIZER(&ext_ids);
> smap_add(&ext_ids, "ovn-patch-port", network);
> ovsrec_port_set_external_ids(port, &ext_ids);
> smap_destroy(&
The old documentation incorrectly attributed logical flow generation to
the CMS instead of ovn-northd. This also corrects how a database is
referenced in the documentation.
Signed-off-by: Justin Pettit
---
ovn/ovn-sb.xml | 23 ---
1 files changed, 12 insertions(+), 11 dele
Signed-off-by: Justin Pettit
---
ovn/ovn-sb.xml | 43 +++
1 files changed, 43 insertions(+), 0 deletions(-)
diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml
index 38837c1..cbae2e9 100644
--- a/ovn/ovn-sb.xml
+++ b/ovn/ovn-sb.xml
@@ -321,6 +321,49 @@
t
Signed-off-by: Justin Pettit
---
ovn/ovn-architecture.7.xml |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml
index c9ac597..85a74a9 100644
--- a/ovn/ovn-architecture.7.xml
+++ b/ovn/ovn-architecture.7.xml
@@ -457,7 +
I think I've come across a bug in OVS native tunneling, or at any rate
an important difference between Linux kernel and OVS native tunneling.
In Linux kernel tunneling, a tunnel packet received by the kernel first
passes through the kernel IP stack. Among other things, the IP stack
drops packets t
Signed-off-by: Marcelo Amaral
When OpenStack create a virtual router using OpenDaylight,
the default gateway does not respond ping, since it does not
implement the full network stack. The solution is the reply the
gateway pings from OVS.
However, currently OVS does not allow changing icmp
messa
On Tue, Sep 1, 2015 at 4:23 PM, Jarno Rajahalme wrote:
>> On Sep 1, 2015, at 3:34 PM, Andy Zhou wrote:
>>
>>>
>>> I'm really uncertain about patches 7 and 8 because they didn't make a
>>> significant difference. I'm happy with the rest of the patches.
>>
>> Thanks for the review. I dropped 7 and
> On Sep 1, 2015, at 3:34 PM, Andy Zhou wrote:
>
>>
>> I'm really uncertain about patches 7 and 8 because they didn't make a
>> significant difference. I'm happy with the rest of the patches.
>
> Thanks for the review. I dropped 7 and 8, and
> pushed the reset.
I hope nothing bad happens :
>
> I'm really uncertain about patches 7 and 8 because they didn't make a
> significant difference. I'm happy with the rest of the patches.
Thanks for the review. I dropped 7 and 8, and pushed the reset.
___
dev mailing list
dev@openvswitch.org
http://o
When a Group is deleted, all Flows that reference the deleted Group should
also be deleted (automatically). Flows that reference a Group via Write
Actions are not found by the function ofpacts_output_to_group and are
therefore not deleted.
Testing: I only tested that the patch fixed the described
On 09/01/2015 04:55 PM, Ben Pfaff wrote:
> On Wed, Aug 26, 2015 at 11:07:54AM -0400, Russell Bryant wrote:
>> Introduce a new logical port type called "localnet". A logical port
>> with this type also has an option called "network_name". A "localnet"
>> logical port represents a connection to a n
I forgot to add you in the chain Ben. Sorry. Next time will let you know as
well.
Frequency is ok IMO.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ben Pfaff
Trimis: Tuesday, September 1, 2015 11:37 PM
Către: Nithin Raju
Cc: dev@openvswitch.org
Subie
On Tue, Sep 01, 2015 at 05:56:09PM -0300, Thadeu Lima de Souza Cascardo wrote:
> When using virtualization, new ports are created and removed all the time.
> These
> ports do not persist after a system reboot, for example. They may be created
> again by the virtualization manager, but that will ha
On Tue, Sep 01, 2015 at 05:07:26PM -0300, Thadeu Lima de Souza Cascardo wrote:
> On Fri, Aug 28, 2015 at 04:13:05PM -0700, Ben Pfaff wrote:
> > On Fri, Aug 28, 2015 at 04:31:40PM -0300, Thadeu Lima de Souza Cascardo
> > wrote:
> > > When using virtualization, new ports are created and removed all
When using virtualization, new ports are created and removed all the time. These
ports do not persist after a system reboot, for example. They may be created
again by the virtualization manager, but that will happen after the vswitch is
already running, and the virtualization manager will add them
On Wed, Aug 26, 2015 at 11:07:54AM -0400, Russell Bryant wrote:
> Introduce a new logical port type called "localnet". A logical port
> with this type also has an option called "network_name". A "localnet"
> logical port represents a connection to a network that is locally
> accessible from each
On Tue, Sep 01, 2015 at 08:14:43PM +, Nithin Raju wrote:
> > On Sep 1, 2015, at 10:36 AM, Ben Pfaff wrote:
> >
> > No one was present for the #openvswitch Hyper-V meeting in IRC today.
> > Should we reschedule it or, alternatively, is there a consensus that we
> > don't need a weekly meeting
Reviewing the ovn-controller code I started to notice a common pattern:
struct smap ext_ids = SMAP_INITIALIZER(&ext_ids);
smap_add(&ext_ids, "ovn-patch-port", network);
ovsrec_port_set_external_ids(port, &ext_ids);
smap_destroy(&ext_ids);
This seemed like a bit too much code for s
>
>> Third, this may be a good opportunity to fix a design mistake in
>> "monitor", which is that it sends too much data when a row is modified:
>> it sends both the old and new values for columns that have changed, as
>> well as the value of every column that did not change. I thought that
>> wou
> On Sep 1, 2015, at 10:36 AM, Ben Pfaff wrote:
>
> No one was present for the #openvswitch Hyper-V meeting in IRC today.
> Should we reschedule it or, alternatively, is there a consensus that we
> don't need a weekly meeting anymore?
Ben,
Alin had sent a note saying he won’t be able to attend,
On Fri, Aug 28, 2015 at 04:13:05PM -0700, Ben Pfaff wrote:
> On Fri, Aug 28, 2015 at 04:31:40PM -0300, Thadeu Lima de Souza Cascardo wrote:
> > When using virtualization, new ports are created and removed all the time.
> > These
> > ports do not persist after a system reboot, for example. They may
On Tue, Sep 01, 2015 at 03:09:04PM -0400, Russell Bryant wrote:
> On 09/01/2015 02:29 PM, Ben Pfaff wrote:
> > [This is probably threaded wrong; somehow the patch didn't make it into
> > my inbox and I had to apply it from the archive.]
>
> Weird. I use git-send-email and always give it the messa
On 09/01/2015 02:29 PM, Ben Pfaff wrote:
> [This is probably threaded wrong; somehow the patch didn't make it into
> my inbox and I had to apply it from the archive.]
Weird. I use git-send-email and always give it the message-id of patch
0/N of the last revision to reply to.
> It seems that, whe
[This is probably threaded wrong; somehow the patch didn't make it into
my inbox and I had to apply it from the archive.]
It seems that, when create_br_int() creates the integration bridge, it
should return it to get_br_int() so that it can return it (instead of
NULL).
Should we add some text to
Ben Pfaff wrote on 01/09/2015 06:55:30 PM:
> From: Ben Pfaff
> To: Liran Schour/Haifa/IBM@IBMIL
> Cc: dev
> Date: 01/09/2015 06:55 PM
> Subject: Re: OVN: RFC add a new JSON-RPC selective monitoring method
>
> On Mon, Aug 31, 2015 at 01:19:35PM +0300, Liran Schour wrote:
> > Following the discu
On Wed, Aug 26, 2015 at 11:07:52AM -0400, Russell Bryant wrote:
> Add a new OVN configuration entry in the Open_vSwitch database called
> "ovn-bridge-mappings". This allows the configuration of mappings
> between a physical network name and an OVS bridge that provides
> connectivity to that networ
Yeah, there's another Ethan Jackson at MSR unfortunately.
On Tue, Sep 1, 2015 at 10:42 AM, Ben Pfaff wrote:
> On Tue, Sep 01, 2015 at 10:38:26AM -0700, Ethan J. Jackson wrote:
>> From: Ethan Jackson
>>
>> Signed-off-by: Ethan J. Jackson
>> ---
>> AUTHORS | 2 +-
>> 1 file changed, 1 insertion(
On Tue, Sep 01, 2015 at 10:38:26AM -0700, Ethan J. Jackson wrote:
> From: Ethan Jackson
>
> Signed-off-by: Ethan J. Jackson
> ---
> AUTHORS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/AUTHORS b/AUTHORS
> index 41e7f57..6c0989a 100644
> --- a/AUTHORS
> +++ b/AUTHORS
Leather elbow patches are reserved for candidates. You should know better
Justin.
Ethan
On Tue, Sep 1, 2015 at 10:40 AM, Justin Pettit wrote:
> Have you been fitted for your leather elbow patches yet?
>
> Acked-by: Justin Pettit
>
> --Justin
>
>
> > On Sep 1, 2015, at 10:38 AM, Ethan J. Jacks
Have you been fitted for your leather elbow patches yet?
Acked-by: Justin Pettit
--Justin
> On Sep 1, 2015, at 10:38 AM, Ethan J. Jackson wrote:
>
> From: Ethan Jackson
>
> Signed-off-by: Ethan J. Jackson
> ---
> AUTHORS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --g
From: Ethan Jackson
Signed-off-by: Ethan J. Jackson
---
AUTHORS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index 41e7f57..6c0989a 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -61,7 +61,7 @@ Edward Tomasz Napiera??a tr...@freebsd.org
Eitan Eliahue
No one was present for the #openvswitch Hyper-V meeting in IRC today.
Should we reschedule it or, alternatively, is there a consensus that we
don't need a weekly meeting anymore?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/list
Thanks Sorin, applied to both branches.
On Tue, Sep 01, 2015 at 05:17:44PM +, Sorin Vinturis wrote:
> Ben, the v2 version is fine. Please commit this version to the 2.4 branch
> also.
>
> Thanks,
> Sorin
>
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Tues
Ben, the v2 version is fine. Please commit this version to the 2.4 branch also.
Thanks,
Sorin
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Tuesday, 1 September, 2015 18:37
To: Sorin Vinturis
Cc: dev@openvswitch.org; Nithin Raju
Subject: Re: [ovs-dev] [PATCH v2] datap
Nithin,
The documentation for the NdisFRegisterFilterDriver() function states the
following:
" Drivers that call NdisFRegisterFilterDriver must be prepared for an immediate
call to any of their FilterXxx functions."
So all initialization must be done before calling the above function.
-Sorin
On Mon, Aug 31, 2015 at 01:19:35PM +0300, Liran Schour wrote:
> Following the discussion on overcoming OVN scalability issues by allowing
> clients to monitor only rows that meet specific criteria
> (http://openvswitch.org/pipermail/dev/2015-August/059149.html), I propose
> to amend the OVSDB pro
Sorin, do you want me to take this version or will you post a v3?
Thanks,
Ben.
On Tue, Sep 01, 2015 at 03:36:08PM +, Nithin Raju wrote:
> hi Ben,
> Yes, I do understand the need for the patch now. Sorin pointed it out.
>
> However, I just sent out a comment which if correct reduces the size
hi Ben,
Yes, I do understand the need for the patch now. Sorin pointed it out.
However, I just sent out a comment which if correct reduces the size of the
patch. Upto Sorin to take up the comment or not.
I am ok with the current version of the patch too, since there’s no correctness
issue.
Acke
Nithin, does this version resolve the concerns you had about v1?
Thanks,
Ben.
On Tue, Sep 01, 2015 at 02:21:09PM +, Sorin Vinturis wrote:
> Signed-off-by: Sorin Vinturis
> Acked-by: Alin Gabriel Serdean
> ---
> datapath-windows/ovsext/Driver.c | 20 ++--
> 1 file changed,
> On Sep 1, 2015, at 8:06 AM, Sorin Vinturis
> wrote:
>
> Nithin,
>
> In my tests with Driver Verifier enabled I bumped into a situation when
> NdisFRegisterFilterDriver() failed. In this case DriverEntry() returned an
> error, without releasing the spinlocks allocated in OvsInit(), which res
On Fri, Aug 21, 2015 at 02:56:48PM -0700, Andy Zhou wrote:
> On Fri, Aug 21, 2015 at 10:48 AM, Ben Pfaff wrote:
> > On Tue, Aug 11, 2015 at 05:55:14PM -0700, Andy Zhou wrote:
> >> Json string are usually created and freed immediately. Thus, there
> >> should not be any downside in creating a large
On Tue, Aug 11, 2015 at 05:55:11PM -0700, Andy Zhou wrote:
> Make use of ofpbuf_use_ds() to simplify code.
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 11, 2015 at 05:55:12PM -0700, Andy Zhou wrote:
> There is no external users for ofpbuf_use() directly.
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 11, 2015 at 05:55:09PM -0700, Andy Zhou wrote:
> Add an API to convert a dynamic string object into ofpbuf.
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/d
Nithin,
In my tests with Driver Verifier enabled I bumped into a situation when
NdisFRegisterFilterDriver() failed. In this case DriverEntry() returned an
error, without releasing the spinlocks allocated in OvsInit(), which resulted
in a memory leak BSOD triggered by the Driver Verifier. The pa
Sorin,
Unless I’m missing something here, what is the new cleanup added in this patch?
It seems more of code refactoring. Is that right?
-- Nithin
> On Sep 1, 2015, at 5:16 AM, Sorin Vinturis
> wrote:
>
> Signed-off-by: Sorin Vinturis
> ---
> datapath-windows/ovsext/Driver.c | 20 +++
Signed-off-by: Sorin Vinturis
Acked-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Driver.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/datapath-windows/ovsext/Driver.c b/datapath-windows/ovsext/Driver.c
index 13fcde2..853886e 100644
--- a/data
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Tuesday, September 1, 2015 3:16 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH] datapath-windows: Proper cleanup in case of driver
init failure
Sign
Signed-off-by: Sorin Vinturis
---
datapath-windows/ovsext/Driver.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/datapath-windows/ovsext/Driver.c b/datapath-windows/ovsext/Driver.c
index 13fcde2..853886e 100644
--- a/datapath-windows/ovsext/Driver.c
+++
From: Ambika Arora
This patch adds support for Openflow1.4 error codes for set-async-config.
In this patch, a new error type, OFPET_ASYNC_CONFIG_FAILED is introduced
that enables the switch to properly inform the controller when controller
tries to set invalid mask or unsupported configuration.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi Daniele
Apologies for the lag - I've been away/offline for a few weeks.
On 12/08/15 22:34, Daniele Di Proietto wrote:
> There has been some discussion lately about the status of the Open
> vSwitch port to DPDK. While part of the code has been t
Hi Ben,
Greetings!
This is in reference to the patch series "Implementation of OpenFlow 1.4
Vacancy Events"[Version 3] which is under review.
1. [PATCH v3 1/3] : Implement Openflow 1.4 Vacancy Events for OFPT_TABLE_MOD.
2. [PATCH v3 2/3] : Implement Vacancy Events for OFPMP_TABLE_DESC.
3. [PAT
15 Steps For Better love life
style2
{ text-align: center; color: #D90003; font-family:
Cambria, 'Hoefler Text', 'Liberation Serif', Times, 'Times New Roman', serif;
font-size: 20px; font-weight: bold;
}
style4
{border: 1px solid #707070;
}
style5
{text-align: center; c
73 matches
Mail list logo
