> On Sep 1, 2015, at 6:09 PM, Russell Bryant <rbry...@redhat.com> wrote:
> 
> On 09/01/2015 09:02 PM, Justin Pettit wrote:
>> 
>>> On Sep 1, 2015, at 5:37 PM, Russell Bryant <rbry...@redhat.com> wrote:
>>> 
>>> On 09/01/2015 08:21 PM, Justin Pettit wrote:
>>>> Signed-off-by: Justin Pettit <jpet...@nicira.com>
>>>> 
>>>> +      <code>ovn-northd</code> is responsible for populating the
>>>> +      <ref table="Logical_Flow"/>, so the stages are an implementation
>>> 
>>> Should you add "table" here?
>>> 
>>> the <ref table="Logical_Flow"/> table
>> 
>> Done.  Thanks.
>> 
>>>> +        L2 Destination Lookup (Table 1): Forwards known unicast
>>>> +        addresses to the appropriate logical port.  Unicast packets to
>>>> +        unknown hosts are forwarded to logical ports configured to have
>>>> +        an <code>unknown</code> addresses.  Broadcast, and multicast are
>>> 
>>> "an unknown addresses" would read better as "an unknown set of
>>> addresses" or just "unknown addresses".
>> 
>> The <code> block was trying to indicate the special value "unknown" in the 
>> "mac" column, not emphasize it.  How about this instead?
> 
> Right, I was just lazy and didn't re-type it.  I meant for it to still
> be there.
> 
>>        Unicast packets to unknown hosts are forwarded to
>>        logical ports configured with the special <code>unknown</code> 
>>        mac address. 
> 
> Perfect, thanks.

Thanks for the reviews.  I pushed the series.

--Justin


_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to