Re: [ovs-dev] [ovn-controller-vtep V6 01/12] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-08-07 Thread Alex Wang
How about this version~, If you think it is good, I'll apply the first 5 patches~ Thanks, Alex Wang, On Fri, Aug 7, 2015 at 11:58 PM, Alex Wang wrote: > In a gateway like the VTEP L2 gateway, physical vlans belonging to > the same logical network form a "logical switch". Each logical switch >

[ovs-dev] [ovn-controller-vtep V6 01/12] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-08-07 Thread Alex Wang
In a gateway like the VTEP L2 gateway, physical vlans belonging to the same logical network form a "logical switch". Each logical switch has a dedicated tunnel key and will keep records of all MACs learned from the owned vlans. So user can just send packet to a "logical switch" and the gateway wi

Re: [ovs-dev] [ovn-controller-vtep V5 05/12] idl-loop: Move idl-loop into ovsdb-idl library.

2015-08-07 Thread Alex Wang
On Fri, Aug 7, 2015 at 11:40 AM, Russell Bryant wrote: > On 08/07/2015 03:46 AM, Alex Wang wrote: > > idl-loop is needed in implementing other controller (i.e., vtep > controller). > > So, this commit moves the logic into ovsdb-idl library module. > > > > Signed-off-by: Alex Wang > > This looks

Re: [ovs-dev] [ovn-controller-vtep V5 03/12] ovn-sbctl: Add ovn-sbctl.

2015-08-07 Thread Alex Wang
On Fri, Aug 7, 2015 at 11:13 AM, Russell Bryant wrote: > > +\n\ > > +SouthBound DB commands:\n\ > > + showprint overview of database contents\n\ > > +\n\ > > +Chassis commands:\n\ > > + chassis-add CHASSIS create a new chassis named CHASSIS\n\ > > encap-type and

Re: [ovs-dev] [PATCH v2 7/7] flow: Add struct flowmap.

2015-08-07 Thread Jarno Rajahalme
> On Aug 6, 2015, at 5:39 PM, Jarno Rajahalme wrote: > >> On Aug 6, 2015, at 16:29, Jesse Gross wrote: > >> >>> On Thu, Aug 6, 2015 at 4:17 PM, Jarno Rajahalme >>> wrote: >>> Struct miniflow is now sometimes used just as a map. Define a new >>> struct flowmap for that purpose. The flowmap

[ovs-dev] [PATCH v4 7/9] classifier: Simplify minimask_hash().

2015-08-07 Thread Jarno Rajahalme
minimask_hash() can be simplified as each value is known to be non-zero. Move miniflow_hash() into test-classifier.c as miniflow_hash__() as it is no longer needed elsewhere. Signed-off-by: Jarno Rajahalme --- lib/classifier-private.h | 38 +- tests/test-clas

[ovs-dev] [PATCH v4 8/9] flow: Add struct flowmap.

2015-08-07 Thread Jarno Rajahalme
Struct miniflow is now sometimes used just as a map. Define a new struct flowmap for that purpose. The flowmap is defined as an array of maps, and it is automatically sized according to the size of struct flow, so it will be easier to maintain in the future. It would have been tempting to use th

[ovs-dev] [PATCH v4 6/9] classifier: Do not use mf_value.

2015-08-07 Thread Jarno Rajahalme
mf_value has grown bigger than needed for storing the biggest supported prefix (IPv6 address length). Define a new type to be used instead of mf_value. This makes classifier lookups a bit faster. Signed-off-by: Jarno Rajahalme --- lib/classifier.c | 14 ++ 1 file changed, 10 insert

[ovs-dev] [PATCH v4 5/9] classifier: Remove unused hash functions.

2015-08-07 Thread Jarno Rajahalme
Remove unused cls_rule_hash() and minimatch_hash() functions. Signed-off-by: Jarno Rajahalme --- lib/classifier-private.h | 7 --- lib/classifier.c | 7 --- lib/classifier.h | 1 - 3 files changed, 15 deletions(-) diff --git a/lib/classifier-private.h b/lib/classifier-pr

[ovs-dev] [PATCH v4 4/9] classifier: Pre-compute stage masks.

2015-08-07 Thread Jarno Rajahalme
This makes stage mask computation happen only when a subtable is inserted and allows simplification of the main lookup function. Classifier benchmark shows that this speeds up the classification (with wildcards) about 5%. Signed-off-by: Jarno Rajahalme --- lib/classifier-private.h | 107 +++

[ovs-dev] [PATCH v4 3/9] test-classifier: Add benchmark.

2015-08-07 Thread Jarno Rajahalme
Add a benchmark command for classifier lookup performance testing. Usage: ovstest test-classifier benchmark Where: - The number of rules to install for lookups. More rules makes misses less likely. - How many different priorities to use. Using only 1

[ovs-dev] [PATCH v4 9/9] classifier: Retire partitions.

2015-08-07 Thread Jarno Rajahalme
Classifier partitions allowed skipping subtables when if was known from the flow's metadata field that the subtable cannot possibly match. This functionality was later implemented in a more general fashion by staged lookup, where the first stage also covers the metadata field, among the rest of th

[ovs-dev] [PATCH v4 1/9] classifier: Fix comment.

2015-08-07 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/classifier.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/classifier.c b/lib/classifier.c index fc6a1f5..0a6855e 100644 --- a/lib/classifier.c +++ b/lib/classifier.c @@ -283,11 +283,10 @@ cls_rule_is_catchall(const struct cl

[ovs-dev] [PATCH v4 2/9] flow: Avoid compile errors.

2015-08-07 Thread Jarno Rajahalme
GCC (4.7) sees too wide shifts when there are none, refactor to circumvent the false error. Signed-off-by: Jarno Rajahalme --- lib/flow.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index af51aac..61d9bdf 10064

Re: [ovs-dev] [ovn-controller-vtep V5 02/12] ovn-nbctl: Move ovn-nbctl to utilities directory.

2015-08-07 Thread Alex Wang
On Fri, Aug 7, 2015 at 10:23 AM, Russell Bryant wrote: > On 08/07/2015 01:18 PM, Russell Bryant wrote: > > On 08/07/2015 03:46 AM, Alex Wang wrote: > >> Signed-off-by: Alex Wang > >> --- > >> V5: > >> - new patch. > >> --- > >> ovn/.gitignore |2 -- > >> ovn/automake.mk

[ovs-dev] [PATCH 5/5] kmod-traffic: Add basic vxlan tunnel sanity test.

2015-08-07 Thread Joe Stringer
Signed-off-by: Joe Stringer --- tests/system-common-macros.at | 38 ++ tests/system-kmod-macros.at | 10 -- tests/system-traffic.at | 38 ++ 3 files changed, 84 insertions(+), 2 deletions(-) diff --git a/test

[ovs-dev] [PATCH 4/5] system-macros: Create ADD_BR variant.

2015-08-07 Thread Joe Stringer
This patch splits ADD_BR into two commands, so they can be used from different contexts: ADD_BR(...) is a standalone command to add a bridge to OVS, and allows additional ovs-vsctl arguments to be passed. It uses _ADD_BR(). _ADD_BR(...) is the implementation-specific ovs-vsctl arguments to set up

[ovs-dev] [PATCH 1/5] system-kmod-macros: Fix VSWITCHD_STOP.

2015-08-07 Thread Joe Stringer
This was renamed. Surprisingly, the tests still pass without this, however the extra checks that this command performs were not executed. Fix the macro definition. Signed-off-by: Joe Stringer --- tests/system-kmod-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test

[ovs-dev] [PATCH 3/5] system-traffic: Check ping-by-ping output.

2015-08-07 Thread Joe Stringer
Rather than saving all of the ping output to a file then checking at the end, check each ping and fail as soon as there is a connectivity failure. Signed-off-by: Joe Stringer --- tests/system-common-macros.at | 6 ++ tests/system-traffic.at | 44 ---

[ovs-dev] [PATCH 0/5] Extend system tests to include tunnel.

2015-08-07 Thread Joe Stringer
Various minor fixups and extensions to the system tests, followed by a basic tunnel sanity test for vxlan. Joe Stringer (5): system-kmod-macros: Fix VSWITCHD_STOP. system-common-macros: Don't use bash to exec in ns. system-traffic: Check ping-by-ping output. system-macros: Create ADD_BR va

[ovs-dev] [PATCH 2/5] system-common-macros: Don't use bash to exec in ns.

2015-08-07 Thread Joe Stringer
ip netns exec $namespace $command doesn't need to use bash to execute the command. Remove it. Signed-off-by: Joe Stringer --- tests/system-common-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 1321

[ovs-dev] [PATCH] ovn-architecture: Document the registers used for logical ports.

2015-08-07 Thread Justin Pettit
When reviewing the OpenFlow flows generated by ovn-controller, it's nice to have this information. Signed-off-by: Justin Pettit --- ovn/ovn-architecture.7.xml | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architectur

Re: [ovs-dev] [PATCH] ovn-controller: Fix flows between two local ports.

2015-08-07 Thread Justin Pettit
> On Aug 7, 2015, at 3:40 PM, Russell Bryant wrote: > > On 08/07/2015 06:05 PM, Justin Pettit wrote: >> A flow was missing from the remote output table that causes local >> packets to be resubmitted to the local ouptut table. >> >> Reported-by: Russell Bryant >> Signed-off-by: Justin Pettit >

Re: [ovs-dev] [ovn-controller-vtep V5 01/12] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-08-07 Thread Russell Bryant
On 08/07/2015 06:43 PM, Alex Wang wrote: > Thx so much for the quick review, Russell !!! > > Please see my comments inline, > > On Fri, Aug 7, 2015 at 10:13 AM, Russell Bryant > wrote: > > On 08/07/2015 03:46 AM, Alex Wang wrote: > > In a gateway like the VTEP

Re: [ovs-dev] [ovn-controller-vtep V5 01/12] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-08-07 Thread Alex Wang
Thx so much for the quick review, Russell !!! Please see my comments inline, On Fri, Aug 7, 2015 at 10:13 AM, Russell Bryant wrote: > On 08/07/2015 03:46 AM, Alex Wang wrote: > > In a gateway like the VTEP L2 gateway, physical vlans belonging to > > the same logical network form a "logical swit

Re: [ovs-dev] [PATCH] ovn-controller: Fix flows between two local ports.

2015-08-07 Thread Russell Bryant
On 08/07/2015 06:05 PM, Justin Pettit wrote: > A flow was missing from the remote output table that causes local > packets to be resubmitted to the local ouptut table. > > Reported-by: Russell Bryant > Signed-off-by: Justin Pettit Works for me. Thanks again for finding the root cause! Acked-b

Re: [ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2015-08-07 Thread Alex Wang
Thx for reporting this, I worry this may not be an ovs issue, but to do with the dpdk driver... Here is my analysis, please correct me if wrong, When pmd threads are spawned, each of them will take ownership of port queues in a round robin fashion... In other words, each port queue will be read

Re: [ovs-dev] [PATCH] ovn: Fix flows between 2 local ports.

2015-08-07 Thread Russell Bryant
On 08/07/2015 06:11 PM, Justin Pettit wrote: > Thanks for tracking down the issue and supplying a patch, Russell. > However, I think the core problem was that there was a missing flow. > Specifically, the one described in the last sentence from this part > of the ovn-architecture man page: > >

Re: [ovs-dev] [ovn-controller-vtep V5 09/12] ovn-controller-vtep: Add binding module.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > This commit adds the binding module to ovn-controller-vtep. The > module will scan through the Port_Binding table in ovnsb. If there is > a port binding entry for a logical switch on the vtep gateway chassis's > "vtep_logical_switches", sets the port bin

Re: [ovs-dev] [PATCH] ovn: Fix flows between 2 local ports.

2015-08-07 Thread Justin Pettit
Thanks for tracking down the issue and supplying a patch, Russell. However, I think the core problem was that there was a missing flow. Specifically, the one described in the last sentence from this part of the ovn-architecture man page: Each flow in table 32 matches on a

[ovs-dev] [PATCH] ovn-controller: Fix flows between two local ports.

2015-08-07 Thread Justin Pettit
A flow was missing from the remote output table that causes local packets to be resubmitted to the local ouptut table. Reported-by: Russell Bryant Signed-off-by: Justin Pettit --- ovn/controller/physical.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/ovn/

Re: [ovs-dev] [ovn-controller-vtep V5 09/12] ovn-controller-vtep: Add binding module.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > This commit adds the binding module to ovn-controller-vtep. The > module will scan through the Port_Binding table in ovnsb. If there is > a port binding entry for a logical switch on the vtep gateway chassis's > "vtep_logical_switches", sets the port bin

Re: [ovs-dev] [ovn-controller-vtep V5 08/12] ovn-controller-vtep: Add gateway module.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > This commit adds the gateway module to ovn-controller-vtep. The > module will register the physical switches to ovnsb as chassis and > constantly update the "vtep_logical_switches" column in Chassis table. > > Limitation (Recorded in TODO file): > > - D

Re: [ovs-dev] [PATCH v2 0/4] Vagrant userspace testsuite

2015-08-07 Thread Joe Stringer
On 7 August 2015 at 11:40, Daniele Di Proietto wrote: > This series adds a new testsuite for the userspace datapath that runs > the already written kmod-sanity tests. The reason for this are > explained in the 3rd commit message. > > The testsuite is called `system userspace-testsuite` and can be

Re: [ovs-dev] [PATCH net-next v3] openvswitch: Make 100 percents packets sampled when sampling rate is 1.

2015-08-07 Thread David Miller
From: Wenyu Zhang Date: Wed, 5 Aug 2015 00:30:47 -0700 > When sampling rate is 1, the sampling probability is UINT32_MAX. The packet > should be sampled even the prandom32() generate the number of UINT32_MAX. > And none packet need be sampled when the probability is 0. > > Signed-off-by: Wenyu Z

Re: [ovs-dev] [ovn-controller-vtep V5 07/12] ovsdb-idl: Move get_initial_snapshot() to ovsdb-idl.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > The same function is defined in both ovn-controller.c and > ovn-controller-vtep.c, so worth librarizing. > > Signed-off-by: Alex Wang Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@open

Re: [ovs-dev] [ovn-controller-vtep V5 06/12] ovn: Add controller for VTEP gateway.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > This commit lays down the foundation for a new controller in OVN, the > ovn-controller-vtep, for controlling the vtep enabled gateways. > > Signed-off-by: Alex Wang > diff --git a/ovn/controller-vtep/ovn-controller-vtep.c > b/ovn/controller-vtep/ovn-co

[ovs-dev] [PATCH v2 3/4] tests: Add system-userspace-testsuite.

2015-08-07 Thread Daniele Di Proietto
The new system-userspace-testsuite, which can be launched via `make check-system-userspace`, reuses the kmod tests on the userspace datapath. The userspace datapath is already tested by the main testsuite (and that's not going to change), but having also the system-userspace-testsuite has the foll

Re: [ovs-dev] [PATCH 0/3] Vagrant userspace testsuite

2015-08-07 Thread Daniele Di Proietto
On 07/08/2015 19:15, "Joe Stringer" wrote: >On 4 August 2015 at 11:00, Daniele Di Proietto >wrote: >> This series adds a new testsuite for the userspace datapath that runs >> the already written kmod-sanity tests. The reason for this are >> explained in the 3rd commit message. >> >> The first

[ovs-dev] [PATCH v2 4/4] Vagrantfile: Add test_ovs_system_userspace provision.

2015-08-07 Thread Daniele Di Proietto
Add 'test_ovs_system_userspace' provision. Command: # vagrant provision --provision-with=test_ovs_system_userspace will run "make check-system-userspace" in the vagrant launched VM. It may be more convenient to run this tests inside a vm rather than in the host, because they interact wit

[ovs-dev] [PATCH v2 2/4] tests: Introduce NS_EXEC and NS_CHECK_EXEC for system tests.

2015-08-07 Thread Daniele Di Proietto
Instead of repeating every time "ip netns exec ..." it is better to introduce some macros. Signed-off-by: Daniele Di Proietto --- tests/system-common-macros.at | 27 +-- tests/system-traffic.at | 24 2 files changed, 33 insertions(+), 18 del

[ovs-dev] [PATCH v2 0/4] Vagrant userspace testsuite

2015-08-07 Thread Daniele Di Proietto
This series adds a new testsuite for the userspace datapath that runs the already written kmod-sanity tests. The reason for this are explained in the 3rd commit message. The testsuite is called `system userspace-testsuite` and can be launched with `make check-system-userspace`. v1 -> v2: * Dropp

[ovs-dev] [PATCH v2 1/4] tests: Rename kmod-testsuite to system-kmod-testsuite.

2015-08-07 Thread Daniele Di Proietto
The name makes more sense, especially with the addition of a userspace system testsuite. No functional change in this commit. Signed-off-by: Daniele Di Proietto --- tests/.gitignore | 2 +- tests/automake.mk | 24 - tests/kmod-macros.at | 35

Re: [ovs-dev] [ovn-controller-vtep V5 05/12] idl-loop: Move idl-loop into ovsdb-idl library.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > idl-loop is needed in implementing other controller (i.e., vtep controller). > So, this commit moves the logic into ovsdb-idl library module. > > Signed-off-by: Alex Wang This looks fine to me. I have a comment but it's not a blocker. It's up to you i

Re: [ovs-dev] [ovn-controller-vtep V5 04/12] ovn-northd: Pass logical port type and options to ovn-sb database.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > Signed-off-by: Alex Wang Nice catch, thanks! It's not needed now, but at some point we might want to move this test into a new file that tests the things ovn-northd is supposed to do. Just a thought. Thanks for adding tests. It's helping me see how I

Re: [ovs-dev] [PATCH 2/3] kmod-macros: Don't unload kmod in VSWITCHD_STOP.

2015-08-07 Thread Joe Stringer
On 6 August 2015 at 18:37, Andy Zhou wrote: > On Thu, Aug 6, 2015 at 3:58 PM, Joe Stringer wrote: >> On 30 July 2015 at 12:51, Joe Stringer wrote: >>> On 30 July 2015 at 11:57, Andy Zhou wrote: On Wed, Jul 29, 2015 at 4:52 PM, Joe Stringer wrote: > We already queue the removal o

Re: [ovs-dev] [PATCH 0/3] Vagrant userspace testsuite

2015-08-07 Thread Joe Stringer
On 4 August 2015 at 11:00, Daniele Di Proietto wrote: > This series adds a new testsuite for the userspace datapath that runs > the already written kmod-sanity tests. The reason for this are > explained in the 3rd commit message. > > The first two commits just move some code (without modifing it)

Re: [ovs-dev] [ovn-controller-vtep V5 03/12] ovn-sbctl: Add ovn-sbctl.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > This commit adds ovn-sbctl to ovn family by using the db-ctl-base > library. > > Signed-off-by: Alex Wang > Acked-by: Ben Pfaff I verified that the tests pass and also played around with it manually. Everything worked as expected. I only found one mi

Re: [ovs-dev] [ovn-controller-vtep V5 02/12] ovn-nbctl: Move ovn-nbctl to utilities directory.

2015-08-07 Thread Russell Bryant
On 08/07/2015 01:18 PM, Russell Bryant wrote: > On 08/07/2015 03:46 AM, Alex Wang wrote: >> Signed-off-by: Alex Wang >> --- >> V5: >> - new patch. >> --- >> ovn/.gitignore |2 -- >> ovn/automake.mk | 11 +++ >> ovn/utilities/.gitignore

Re: [ovs-dev] [ovn-controller-vtep V5 02/12] ovn-nbctl: Move ovn-nbctl to utilities directory.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > Signed-off-by: Alex Wang > --- > V5: > - new patch. > --- > ovn/.gitignore |2 -- > ovn/automake.mk | 11 +++ > ovn/utilities/.gitignore|3 +++ > ovn/utilities/automake.mk |

Re: [ovs-dev] [ovn-controller-vtep V5 01/12] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-08-07 Thread Russell Bryant
On 08/07/2015 03:46 AM, Alex Wang wrote: > In a gateway like the VTEP L2 gateway, physical vlans belonging to > the same logical network form a "logical switch". Each logical switch > has a dedicated tunnel key and will keep records of all MACs learned > from the owned vlans. So user can just sen

Re: [ovs-dev] datapath forwarding

2015-08-07 Thread Raul Suarez Marin
Hello, Thank you for replying. I managed to see printk() on dmesg, I was debugging wrong (I'm new in this kernel-space area). I traced my mistake and I found it, thank you very much for your help Kind regards, Raúl 2015-08-06 20:14 GMT+02:00 Joe Stringer : > --verbose makes the ovs-ofctl proce

Re: [ovs-dev] upcall processing in userspace

2015-08-07 Thread Jarno Rajahalme
Uday, ofproto-dpif-upcall.c calls into ofproto-dpif-xlate.c that performs flow lookups and thereby find the actions that should be applied to the packet. For example, action types are discerned in do_xlate_actions(). The “normal” action is actually a special port number (OFPP_NORMAL) and is pro

[ovs-dev] upcall processing in userspace

2015-08-07 Thread ravulakollu.kumar
Hi Team, I am debugging upcall processing in ofproto-dpif-upcall.c file . I am not able to visualize how opfbuf structure is being filled with actions(Note: My bridge is configured without OF rules, meaning actions=NORMAL). I could see packet is being flooded for unknown mac, vlan in the code.

[ovs-dev] openvswitch inside a docker container

2015-08-07 Thread Yoo, Jay
I've created a ryu container and openvswitch container with ovs-vsctl bridge connecting the port to ryu container and host containers. I ran simple_switch.py on ryu to learn l2 switching and still I can't ping among containers. Any thoughts? Best Regards, Jay Yoo, Ph.D. Johns Hopkins Univers

[ovs-dev] With our goods you'll increase drive tenfold!

2015-08-07 Thread Elsa
Bluep|lule is chaper than you can imagine. Feel the love energy! Buy at our shop. On our site all the necessary for you pharmaceuticals! B E A C upon, and there was that luxurious after-dinner atmosphere when ___ dev mailing li

Re: [ovs-dev] [RFC] dpdk: support multiple queues in vhost

2015-08-07 Thread Flavio Leitner
On Fri, Aug 07, 2015 at 08:43:23AM -0400, Thomas F Herbert wrote: > On 8/6/15 5:29 PM, Flavio Leitner wrote: > >On Thu, Aug 06, 2015 at 03:24:29PM -0400, Thomas F Herbert wrote: > >>On 8/6/15 1:40 PM, Flavio Leitner wrote: > >>>On Thu, Aug 06, 2015 at 12:39:29PM -0400, Thomas F Herbert wrote: > >>>

Re: [ovs-dev] [RFC] dpdk: support multiple queues in vhost

2015-08-07 Thread Thomas F Herbert
On 8/6/15 5:29 PM, Flavio Leitner wrote: On Thu, Aug 06, 2015 at 03:24:29PM -0400, Thomas F Herbert wrote: On 8/6/15 1:40 PM, Flavio Leitner wrote: On Thu, Aug 06, 2015 at 12:39:29PM -0400, Thomas F Herbert wrote: On 7/31/15 6:30 PM, Flavio Leitner wrote: This RFC is based on the vhost multip

[ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2015-08-07 Thread Ilya Maximets
In multiqueue mode several pmd threads may process one port, but different queues. Flow doesn't depend on queue. So, while miss upcall processing, all threads (except first for that port) will receive error = ENOSPC due to ukey_install failure. Therefore they will not add the flow to flow_table an

Re: [ovs-dev] [PATCH] dpif: allow adding ukeys for same flow by different pmds

2015-08-07 Thread Ilya Maximets
Ok. I think, it will be better. I'll prepare new version. On 06.08.2015 23:32, Joe Stringer wrote: > On 6 August 2015 at 00:54, Ilya Maximets wrote: >> ping. >> >> On 30.07.2015 18:29, Ilya Maximets wrote: >>> In multiqueue mode several pmd threads may process one >>> port, but different queues.

[ovs-dev] [ovn-controller-vtep V5 10/12] ovn-controller-vtep: Add vtep module.

2015-08-07 Thread Alex Wang
This commit adds the vtep module to ovn-controller-vtep. The module will scan through the Port_Binding table in OVN-SB database, and update the vtep logcial switches tunnel keys. Signed-off-by: Alex Wang --- V5: new patch. --- ovn/controller-vtep/automake.mk |4 +- ovn/controller-

[ovs-dev] [ovn-controller-vtep V5 12/12] ovn: Update TODOs related to vtep controller.

2015-08-07 Thread Alex Wang
Signed-off-by: Alex Wang --- V5: new patch. --- ovn/TODO | 21 + 1 file changed, 21 insertions(+) diff --git a/ovn/TODO b/ovn/TODO index 356b3ba..71c307c 100644 --- a/ovn/TODO +++ b/ovn/TODO @@ -80,3 +80,24 @@ So far, both ovn-controller and ovn-controller-vtep only all

[ovs-dev] [ovn-controller-vtep V5 07/12] ovsdb-idl: Move get_initial_snapshot() to ovsdb-idl.

2015-08-07 Thread Alex Wang
The same function is defined in both ovn-controller.c and ovn-controller-vtep.c, so worth librarizing. Signed-off-by: Alex Wang --- V5: - new patch. --- lib/ovsdb-idl.c | 15 +++ lib/ovsdb-idl.h |1 + ovn/controller-vtep/ovn-c

[ovs-dev] [ovn-controller-vtep V5 11/12] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-08-07 Thread Alex Wang
This commit extends the vtep module to support creating the 'Ucast_Macs_Remote' table entries in the vtep database for MAC addresses on the ovn logical ports. Signed-off-by: Alex Wang --- V4->V5: - rebase on top of master. - rewrite the feature since a lot have changed. V3->V4: - add logic to re

[ovs-dev] [ovn-controller-vtep V5 09/12] ovn-controller-vtep: Add binding module.

2015-08-07 Thread Alex Wang
This commit adds the binding module to ovn-controller-vtep. The module will scan through the Port_Binding table in ovnsb. If there is a port binding entry for a logical switch on the vtep gateway chassis's "vtep_logical_switches", sets the port binding's chassis column to the vtep gateway chassis

[ovs-dev] [ovn-controller-vtep V5 06/12] ovn: Add controller for VTEP gateway.

2015-08-07 Thread Alex Wang
This commit lays down the foundation for a new controller in OVN, the ovn-controller-vtep, for controlling the vtep enabled gateways. Signed-off-by: Alex Wang --- V4->V5: - rebase on top of master. - use ovsdb_idl_loop to avoid block commit. V3->V4: - rebase to master. V2->V3: - rebase to mast

[ovs-dev] [ovn-controller-vtep V5 08/12] ovn-controller-vtep: Add gateway module.

2015-08-07 Thread Alex Wang
This commit adds the gateway module to ovn-controller-vtep. The module will register the physical switches to ovnsb as chassis and constantly update the "vtep_logical_switches" column in Chassis table. Limitation (Recorded in TODO file): - Do not support reading multiple tunnel ips of physical s

[ovs-dev] [ovn-controller-vtep V5 03/12] ovn-sbctl: Add ovn-sbctl.

2015-08-07 Thread Alex Wang
This commit adds ovn-sbctl to ovn family by using the db-ctl-base library. Signed-off-by: Alex Wang Acked-by: Ben Pfaff --- V4->V5: - rebase on top of master. - change ovn-sbctl command format to target-action (e.g., chassis-add). V3->V4: - mention ovn-sbctl should never be used in normal oper

[ovs-dev] [ovn-controller-vtep V5 04/12] ovn-northd: Pass logical port type and options to ovn-sb database.

2015-08-07 Thread Alex Wang
Signed-off-by: Alex Wang --- V5: - new patch. --- ovn/northd/ovn-northd.c |2 ++ tests/ovn-sbctl.at | 13 + 2 files changed, 15 insertions(+) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index cf8e222..796070f 100644 --- a/ovn/northd/ovn-northd.c +++ b/ov

[ovs-dev] [ovn-controller-vtep V5 05/12] idl-loop: Move idl-loop into ovsdb-idl library.

2015-08-07 Thread Alex Wang
idl-loop is needed in implementing other controller (i.e., vtep controller). So, this commit moves the logic into ovsdb-idl library module. Signed-off-by: Alex Wang --- V5: - new patch. --- lib/ovsdb-idl.c | 72 ++ lib/ovsdb-idl.h | 26

[ovs-dev] [ovn-controller-vtep V5 01/12] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-08-07 Thread Alex Wang
In a gateway like the VTEP L2 gateway, physical vlans belonging to the same logical network form a "logical switch". Each logical switch has a dedicated tunnel key and will keep records of all MACs learned from the owned vlans. So user can just send packet to a "logical switch" and the gateway wi

[ovs-dev] [ovn-controller-vtep V5 02/12] ovn-nbctl: Move ovn-nbctl to utilities directory.

2015-08-07 Thread Alex Wang
Signed-off-by: Alex Wang --- V5: - new patch. --- ovn/.gitignore |2 -- ovn/automake.mk | 11 +++ ovn/utilities/.gitignore|3 +++ ovn/utilities/automake.mk | 14 +++--- ovn/{ => utilities}/ovn-nbctl.8.xml |

[ovs-dev] [ovn-controller-vtep V5 00/12] Implement ovn-controller-vtep.

2015-08-07 Thread Alex Wang
This series adds a new ovn controller, ovn-controller-vtep, for VTEP enabled physical switches. This V5 is not simply a rebase on top of the current master. With the additon of logcial port 'type' and 'options' columns in ovn-nb schema, and the new way of generating tunnel keys, this series conta