On 08/07/2015 03:46 AM, Alex Wang wrote:
> This commit adds ovn-sbctl to ovn family by using the db-ctl-base
> library.
> 
> Signed-off-by: Alex Wang <al...@nicira.com>
> Acked-by: Ben Pfaff <b...@nicira.com>

I verified that the tests pass and also played around with it manually.
 Everything worked as expected.  I only found one minor doc issue.  Nice
work!

Acked-by: Russell Bryant <rbry...@redhat.com>

> +static void
> +usage(void)
> +{
> +    printf("\
> +%s: ovs-vswitchd management utility\n\
> +\n\
> +for debugging and testing only, never use it in production\n\
> +\n\
> +usage: %s [OPTIONS] COMMAND [ARG...]\n\
> +\n\
> +SouthBound DB commands:\n\
> +  show                        print overview of database contents\n\
> +\n\
> +Chassis commands:\n\
> +  chassis-add CHASSIS         create a new chassis named CHASSIS\n\

encap-type and encap-ip are required here, as well.  They're shown in
the man page but missing from this usage output.

-- 
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to