Currently pmd threads select queues in pmd_load_queues() according to
get_n_pmd_threads_on_numa(). This behavior leads to race between pmds,
beacause dp_netdev_set_pmds_on_numa() starts them one by one and
current number of threads changes incrementally.
As a result we may have the following situa
This commit makes netdev_linux_set_in4() cache the result of previous
reading of in4 address (successful or not).
Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
---
PATCH->V2:
- Add Ack.
---
lib/netdev-linux.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a
The get_in6() API defined in netdev-provider.h requires the return
of error values when the 'netdev' has no assigned IPv6 address or
the 'netdev' does not support IPv6. However, the netdev_linux_get_in6()
implementation does not follow this (always return 0). And this
causes the a bug in deleting
This commit renames the rtnetlink-link.{c,h} to rtnetlink.{c,h}
and extends the module to support RTNLGRP_IPV4_IFADDR and
RTNLGRP_IPV4_IFADDR multicast groups. A later patch will start
using this module to react to interface address changes.
Signed-off-by: Alex Wang
---
PATCH->V2:
- new patch,
Currently the netdev_linux_notify_sock only joins multicast group
RTNLGRP_LINK for link status change notification. Some ovs features
also require the detection of ip addresses changes and update of the
netdev-linux's cache. To achieve this, we need to make
netdev_linux_notify_sock join the multi
Thx for the review, I'll attach the Ack in my new series. And hold off
push until entire series
gets Ack'ed~
On Mon, Jul 27, 2015 at 3:06 PM, Ben Pfaff wrote:
> On Fri, Jul 24, 2015 at 02:36:07PM -0700, Alex Wang wrote:
> > This commit makes netdev_linux_set_in4() cache the result of previous
>
Thx for the comments,
Yeah, I think we need to be able to parse the
RTNLGRP_IPV4_IFADDR/RTNLGRP_IPV6_IFADDR messages.
I attempted to extend the rtnetlink-link module, and resent a new seres,
Thanks,
Alex Wang,
On Mon, Jul 27, 2015 at 3:04 PM, Ben Pfaff wrote:
> On Fri, Jul 24, 2015 at 02:36:0
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> On Jul 24, 2015, at 5:44 AM, Sorin Vinturis
> wrote:
>
> If an error appears when creating a tunnel vport the cleanup is performed
> twice, which causes the tunnel vport to be released also twice and
> generate a BSOD.
>
> This patch modifies the tunnel filter cleanup logic to avoid this issu
I guess we need an if-notifier-windows.c also.
On Mon, Jul 27, 2015 at 03:55:52PM -0700, Gurucharan Shetty wrote:
> I wonder what happens for Windows here.
>
> On Mon, Jul 27, 2015 at 3:51 PM, Ben Pfaff wrote:
> > On Mon, Jul 27, 2015 at 02:24:20PM -0300, Thadeu Lima de Souza Cascardo
> > wrote
I wonder what happens for Windows here.
On Mon, Jul 27, 2015 at 3:51 PM, Ben Pfaff wrote:
> On Mon, Jul 27, 2015 at 02:24:20PM -0300, Thadeu Lima de Souza Cascardo wrote:
>> Whenever system interfaces are removed, added or change state, reconfigure
>> bridge. This allows late interfaces to be add
On Mon, Jul 27, 2015 at 02:24:20PM -0300, Thadeu Lima de Souza Cascardo wrote:
> Whenever system interfaces are removed, added or change state, reconfigure
> bridge. This allows late interfaces to be added to the datapath when they are
> added to the system after ovs-vswitchd is started.
>
> Signe
On Mon, Jul 27, 2015 at 02:24:19PM -0300, Thadeu Lima de Souza Cascardo wrote:
> When devices are created, they are announced using RTM_IFANNOUNCE messages
> using
> PF_ROUTE.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
Do you know anyone who might be qualified to properly review this? It
On Mon, Jul 27, 2015 at 02:24:18PM -0300, Thadeu Lima de Souza Cascardo wrote:
> rtbsd.h requires net/if.h for IF_NAMESIZE. This was not caught because rtbsd.c
> did not include rtbsd.h as its first header.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
This seemed obviously correct to me so I
On Mon, Jul 27, 2015 at 3:29 PM, Ben Pfaff wrote:
> On Mon, Jul 27, 2015 at 01:44:33PM -0700, Gurucharan Shetty wrote:
>> We should use closesocket() while closing sockets so that
>> closing sockets work fine on both POSIX and Windows.
>> (In POSIX, we #define closesocket close)
>>
>> Without this
Thanks for the correction.
Acked-by: Ben Pfaff
On Mon, Jul 27, 2015 at 03:38:39PM -0700, Gurucharan Shetty wrote:
> We do use AT_XFAIL_IF in tests:
>
> grep AT_XFAIL_IF *.at
>
> json.at: AT_XFAIL_IF([$PYTHON -c "exit(len(u'\U00010800'))"; test $? -ne 1])
> ofproto-dpif.at: [AT_XFAIL_IF([tes
We do use AT_XFAIL_IF in tests:
grep AT_XFAIL_IF *.at
json.at: AT_XFAIL_IF([$PYTHON -c "exit(len(u'\U00010800'))"; test $? -ne 1])
ofproto-dpif.at: [AT_XFAIL_IF([test "$IS_WIN32" = "yes"])
ofproto-dpif.at:AT_XFAIL_IF([test "$IS_WIN32" = "yes"])
ofproto-dpif.at:AT_XFAIL_IF([test "$IS_WIN32" = "
On Mon, Jul 27, 2015 at 01:44:34PM -0700, Gurucharan Shetty wrote:
> sflow is not supported on Windows. So skip the
> test.
>
> Signed-off-by: Gurucharan Shetty
AT_XFAIL_IF and AT_SKIP_IF are different. I think we only use the
latter so far.
___
dev m
On Mon, Jul 27, 2015 at 01:44:33PM -0700, Gurucharan Shetty wrote:
> We should use closesocket() while closing sockets so that
> closing sockets work fine on both POSIX and Windows.
> (In POSIX, we #define closesocket close)
>
> Without this change, sflow unit tests would cause ovs-vswitchd
> to c
On Mon, Jul 27, 2015 at 03:17:26PM -0700, Ben Pfaff wrote:
> On Mon, Jul 27, 2015 at 01:52:00PM -0700, Andy Zhou wrote:
> > On Fri, Jul 24, 2015 at 3:36 PM, Ben Pfaff wrote:
> > > When a mirror was restricted to particular VLANs, this code was
> > > allocating,
> > > copying, and freeing a 512-by
On Mon, Jul 27, 2015 at 01:52:00PM -0700, Andy Zhou wrote:
> On Fri, Jul 24, 2015 at 3:36 PM, Ben Pfaff wrote:
> > When a mirror was restricted to particular VLANs, this code was allocating,
> > copying, and freeing a 512-byte block of memory just to check the value of
> > a single bit in the bloc
On Fri, Jul 24, 2015 at 02:36:07PM -0700, Alex Wang wrote:
> This commit makes netdev_linux_set_in4() cache the result of previous
> reading of in4 address (successful or not).
>
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
___
dev mailing list
dev@
On Fri, Jul 24, 2015 at 02:36:06PM -0700, Alex Wang wrote:
> The get_in6() API defined in netdev-provider.h requires the return
> of error values when the 'netdev' has no assigned IPv6 address or
> the 'netdev' does not support IPv6. However, the netdev_linux_get_in6()
> implementation does not fo
On Fri, Jul 24, 2015 at 02:36:05PM -0700, Alex Wang wrote:
> Currently the netdev_linux_notify_sock only joins multicast group
> RTNLGRP_LINK for link status change notification. Some ovs features
> also require the detection of ip addresses changes and update of the
> netdev-linux's cache. To ac
sflow is not supported on Windows. So skip the
test.
Signed-off-by: Gurucharan Shetty
---
tests/ofproto-dpif.at |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 5b063d2..54098da 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.
We should use closesocket() while closing sockets so that
closing sockets work fine on both POSIX and Windows.
(In POSIX, we #define closesocket close)
Without this change, sflow unit tests would cause ovs-vswitchd
to crash in Windows.
Signed-off-by: Gurucharan Shetty
---
ofproto/collectors.c |
On Mon, Jul 27, 2015 at 9:59 AM, Anoob Soman wrote:
> Hi All,
>
> I am aware there had been some discussion on running lldpad and open-fcoe
> utils (like fcoemon) on top of ovs, but couldn’t figure out a way to
> successfully run lldpad and fcoemon on top of openvswitch.
>
> I did some experimenta
I think I'll hold off this series a bit, and adopt the similar changes as
you did
in the "Change strategy for tunnel keys" series.
Also, with Russell's change, the table could be renamed again,
At the same time, I'll help with reviews,
Thanks,
Alex Wang,
On Mon, Jul 27, 2015 at 1:33 PM, Ben Pfa
Ben, thanks for rebasing. I will review it soon.
On Mon, Jul 27, 2015 at 1:56 PM, Ben Pfaff wrote:
> I spent some time recently looking at the results of "ovs-ofctl
> dump-table-features". It was really distressing because of the volume of
> information. Every table yielded well over 100 lines
I spent some time recently looking at the results of "ovs-ofctl
dump-table-features". It was really distressing because of the volume of
information. Every table yielded well over 100 lines of output and for 253
(visible) tables that meant over 25,300 lines of output total, which is
basically unu
On Fri, Jul 24, 2015 at 3:36 PM, Ben Pfaff wrote:
> When a mirror was restricted to particular VLANs, this code was allocating,
> copying, and freeing a 512-byte block of memory just to check the value of
> a single bit in the block. This fixes the problem.
>
> Found by inspection.
>
> Signed-off
On Thu, Jul 16, 2015 at 12:56:23AM -0700, Alex Wang wrote:
> This commit adds ovn-sbctl to ovn family by using the db-ctl-base
> library.
>
> As a side effect, we move the ovn-nbctl/ovn-sbctl related files
> into ovn/utilities.
>
> Signed-off-by: Alex Wang
> Acked-by: Ben Pfaff
>
> ---
> V3->V
On Thu, Jul 16, 2015 at 12:56:22AM -0700, Alex Wang wrote:
> In a gateway like the VTEP L2 gateway, physical vlans belonging to
> the same logical network form a "logical switch". Each logical switch
> has a dedicated tunnel key and will keep records of all MACs learned
> from the owned vlans. So
On Tue, Jul 21, 2015 at 3:35 PM, Pravin B Shelar wrote:
> diff --git a/datapath-windows/ovsext/Debug.h b/datapath-windows/ovsext/Debug.h
> index 4b7b526..e4e55ac 100644
> --- a/datapath-windows/ovsext/Debug.h
> +++ b/datapath-windows/ovsext/Debug.h
> @@ -31,7 +31,6 @@
> #define OVS_DBG_CHECKSUM B
On Thu, Jul 23, 2015 at 05:06:36PM +0530, niti1...@gmail.com wrote:
> From: Niti Rohilla
>
> This patch adds support for Openflow1.4 Group & meter change notification
> messages. In a multi controller environment, when a controller modifies the
> state of group and meter table, the request that s
On Sun, Jul 26, 2015 at 7:52 AM, Thomas F Herbert
wrote:
> Add support for 802.1ad including the ability to push and pop double
> tagged vlans. Add support for 802.1ad to netlink parsing and flow
> conversion. Uses double nested encap attributes to represent double
> tagged vlan. Inner TPID encode
On Tue, Jul 21, 2015 at 9:52 PM, Pravin B Shelar wrote:
> v2.3.0 - 14 Aug 2014
> diff --git a/datapath/vport-gre.c b/datapath/vport-gre.c
> index 7bbcf57..8a47ab2 100644
> --- a/datapath/vport-gre.c
> +++ b/datapath/vport-gre.c
> @@ -330,6 +330,7 @@ static struct vport *gre64_create(const struct
On Fri, Jul 24, 2015 at 2:28 AM, Zang MingJie wrote:
> Newer kernel will do gro on vxlan packet, after gro the tcp checksum
> encapsulated in the packet is wrong but the origin checksum is already
> verified.
>
> The patch skips verifying checksum of all gro packets.
I think this solution is too
rtbsd.h requires net/if.h for IF_NAMESIZE. This was not caught because rtbsd.c
did not include rtbsd.h as its first header.
Signed-off-by: Thadeu Lima de Souza Cascardo
---
lib/rtbsd.c | 3 ++-
lib/rtbsd.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/rtbsd.c b/lib/rtb
Whenever system interfaces are removed, added or change state, reconfigure
bridge. This allows late interfaces to be added to the datapath when they are
added to the system after ovs-vswitchd is started.
Signed-off-by: Thadeu Lima de Souza Cascardo
---
lib/automake.mk | 3 +++
lib/if-noti
When devices are created, they are announced using RTM_IFANNOUNCE messages using
PF_ROUTE.
Signed-off-by: Thadeu Lima de Souza Cascardo
---
lib/rtbsd.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/lib/rtbsd.c b/lib/rtbsd.c
index 8fc88e4..5f58f5a 1
On Thu, Jul 23, 2015 at 05:05:44PM +0530, niti1...@gmail.com wrote:
> From: Niti Rohilla
>
> This patch adds support for Openflow1.4 set/get asynchronous configuration
> messages. OpenVSwitch already supports set/get asynchronous configuration
> messages for Openflow1.3. In this patch OFPT_SET_AS
Hi All,
I am aware there had been some discussion on running lldpad and
open-fcoe utils (like fcoemon) on top of ovs, but couldn’t figure out a
way to successfully run lldpad and fcoemon on top of openvswitch.
I did some experimentation with openvswitch and open-fcoe and now I am
trying to g
Thanks for the updated patch.
One comment below
On 27/07/2015 13:19, "Ilya Maximets" wrote:
>Currently pmd threads select queues in pmd_load_queues() according to
>get_n_pmd_threads_on_numa(). This behavior leads to race between pmds,
>beacause dp_netdev_set_pmds_on_numa() starts them one by on
The original message was received at Tue, 28 Jul 2015 00:59:30 +0800
from [117.182.158.19]
- The following addresses had permanent fatal errors -
- Transcript of the session follows -
... while talking to openvswitch.org.:
550 5.1.2 ... Host unknown (Name server: host not found)
The original message was received at Mon, 27 Jul 2015 23:54:57 +0800 from
openvswitch.com [26.44.141.137]
- The following addresses had permanent fatal errors -
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo
Hi All,
I am analyzing code for openvswitch with kernel datapath. For a mac learning
switch implementation, I wanted to
Understand the code flow when a packet is arrived on vport(netdev). I could see
upcalls to userspace when the packet
received on vport(netdev). Upcall handler doing DPIF_OP_FLO
Hi,
Good day!
My name is Jim and I'm curious to know if you are currently
interested/seeking to purchase any email lists.
We are a Multi-channel Database and Marketing Services Company, primly
specialized in all types of mailing lists like email lists, direct mail
lists, phone/fax list
Hi Ben,
Greetings!
This is in reference to the patch series "OF1.4 Group and Meter change
notification (EXT-235)" which is under review.
1. [PATCH v4 1/2] : ofproto: Implement OF1.4 Set/Get asynchronous
configuration messages.
2. [PATCH v1 2/2] : ofproto: Implement OF1.4 Group & Meter change
no
Currently pmd threads select queues in pmd_load_queues() according to
get_n_pmd_threads_on_numa(). This behavior leads to race between pmds,
beacause dp_netdev_set_pmds_on_numa() starts them one by one and
current number of threads changes incrementally.
As a result we may have the following situa
Ok. I will.
Thanks to you.
On 27.07.2015 14:12, Daniele Di Proietto wrote:
> That looks better to me. Minor comment: we usually prefer
> 'sizeof *pmds' to 'sizeof(struct dp_netdev_pmd_thread*)'
>
> https://github.com/openvswitch/ovs/blob/master/CodingStyle.md#user-content-
> expressions
>
> Wo
That looks better to me. Minor comment: we usually prefer
'sizeof *pmds' to 'sizeof(struct dp_netdev_pmd_thread*)'
https://github.com/openvswitch/ovs/blob/master/CodingStyle.md#user-content-
expressions
Would you mind changing that, updating the commit message and
resending to the list?
Thanks!
Previous diff was completely wrong. Sorry.
@@ -2971,6 +2970,7 @@ dp_netdev_set_pmds_on_numa(struct dp_netdev *dp, int
numa_id)
* pmd threads for the numa node. */
if (!n_pmds) {
int can_have, n_unpinned, i;
+struct dp_netdev_pmd_thread **pmds;
n_unpinned = o
On 07/26/15 at 08:57pm, David Miller wrote:
> From: Nicolas Dichtel
> Date: Thu, 23 Jul 2015 11:29:07 +0200
>
> > With CONFIG_VXLAN=m and CONFIG_OPENVSWITCH=y, there was the following
> > compilation error:
> > LD init/built-in.o
> > net/built-in.o: In function `vxlan_tnl_create':
> >
From: Thomas F Herbert
Date: Sun, 26 Jul 2015 10:52:34 -0400
> Signed-off-by: Thomas F Herbert
> ---
> include/linux/if_vlan.h | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
> index 67ce5bd..88d1be4 100644
> --- a/i
Sorry,
without dp_netdev_reload_pmds(dp) at the end.
On 27.07.2015 10:58, Ilya Maximets wrote:
> Yes, I think, this way is better. But it may be more simple
> if we just keep all the dp_netdev_pmd_thread structures.
> There is no need to search over all pmd threads on system.
>
> Like this:
>
>
Yes, I think, this way is better. But it may be more simple
if we just keep all the dp_netdev_pmd_thread structures.
There is no need to search over all pmd threads on system.
Like this:
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 79c4612..8e4c025 100644
--- a/lib/dpif-netdev.c
+++ b
57 matches
Mail list logo
