On Tue, Jul 21, 2015 at 9:52 PM, Pravin B Shelar <[email protected]> wrote: > v2.3.0 - 14 Aug 2014 > diff --git a/datapath/vport-gre.c b/datapath/vport-gre.c > index 7bbcf57..8a47ab2 100644 > --- a/datapath/vport-gre.c > +++ b/datapath/vport-gre.c > @@ -330,6 +330,7 @@ static struct vport *gre64_create(const struct > vport_parms *parms) > struct vport *vport; > int err; > > + pr_warn("GRE64 tunnel protocol is deprecated."); [...] > diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c > index ea9abf9..d2bd129 100644 > --- a/lib/netdev-vport.c > +++ b/lib/netdev-vport.c > @@ -242,6 +242,13 @@ netdev_vport_alloc(void) > return &netdev->up; > } > > +static struct netdev * > +netdev_gre64_vport_alloc(void) > +{ > + VLOG_WARN("GRE64 tunnel protocol is deprecated."); > + return netdev_vport_alloc(); > +}
For both of these two log messages, I think I would include the version number where it will be removed and also make them only warn once overall. Otherwise looks good though: Acked-by: Jesse Gross <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
