Re: [ovs-dev] [PATCH] hmap: Fix typo in comment.

2015-07-12 Thread Ben Pfaff
On Sun, Jul 12, 2015 at 09:25:14PM -0700, Justin Pettit wrote: > > > On Jul 12, 2015, at 9:04 PM, Ben Pfaff wrote: > > > > * This function is appropriate when 'hmap' will soon have about as many > > * elements as it before. If 'hmap' will likely have fewer elements than > > I think there's a

Re: [ovs-dev] [PATCH] hmap: Fix typo in comment.

2015-07-12 Thread Justin Pettit
> On Jul 12, 2015, at 9:04 PM, Ben Pfaff wrote: > > * This function is appropriate when 'hmap' will soon have about as many > * elements as it before. If 'hmap' will likely have fewer elements than I think there's a "did" missing before "before". > - * before, use hmap_destroy() followed b

[ovs-dev] [PATCH] hmap: Fix typo in comment.

2015-07-12 Thread Ben Pfaff
This particular typo dates to 2010! Signed-off-by: Ben Pfaff --- lib/hmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/hmap.c b/lib/hmap.c index 938dbc2..590b3d7 100644 --- a/lib/hmap.c +++ b/lib/hmap.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009, 2010, 2012

Re: [ovs-dev] [PATCH] dpif-netlink: Suppress DPIF_FP_PROBE here instead of in ofproto-dpif.

2015-07-12 Thread Ben Pfaff
On Sun, Jul 12, 2015 at 02:52:38PM -0700, Gurucharan Shetty wrote: > On Sat, Jul 11, 2015 at 8:27 AM, Ben Pfaff wrote: > > Commit 22b4ccf4f (ofproto-dpif: Don't try to use dpif_probe_feature() with > > Windows datapath.) stopped ofproto-dpif from trying to use the DPIF_FP_PROBE > > feature of the

Re: [ovs-dev] [PATCH] xml2nroff: Allow comments in block XML.

2015-07-12 Thread Ben Pfaff
Thanks, I'll apply this in a minute. On Sun, Jul 12, 2015 at 02:34:43PM -0700, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > > On Jul 12, 2015, at 11:59 AM, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > --- > > python/build/nroff.py | 2 ++ > > 1 file changed, 2 i

Re: [ovs-dev] [PATCH] nicira-ext: Fix typo in comment.

2015-07-12 Thread Ben Pfaff
Thanks, I'll apply this in a minute. On Sun, Jul 12, 2015 at 11:10:55PM +0300, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > > > On Jul 12, 2015, at 21:54, Ben Pfaff wrote: > > > > --- > > include/openflow/nicira-ext.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [ovs-dev] [PATCH] dpif-netlink: Suppress DPIF_FP_PROBE here instead of in ofproto-dpif.

2015-07-12 Thread Gurucharan Shetty
On Sat, Jul 11, 2015 at 8:27 AM, Ben Pfaff wrote: > Commit 22b4ccf4f (ofproto-dpif: Don't try to use dpif_probe_feature() with > Windows datapath.) stopped ofproto-dpif from trying to use the DPIF_FP_PROBE > feature of the datapath interface, because it doesn't work with Windows > yet. However, i

Re: [ovs-dev] [PATCH] xml2nroff: Allow comments in block XML.

2015-07-12 Thread Justin Pettit
Acked-by: Justin Pettit --Justin > On Jul 12, 2015, at 11:59 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > python/build/nroff.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/python/build/nroff.py b/python/build/nroff.py > index 166f2a4..778ce0f 100644 > --- a/python

Re: [ovs-dev] [PATCH] nicira-ext: Fix typo in comment.

2015-07-12 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jul 12, 2015, at 21:54, Ben Pfaff wrote: > > --- > include/openflow/nicira-ext.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h > index 9154800..16a4a7a 100644 > --- a/inc

[ovs-dev] [PATCH] xml2nroff: Allow comments in block XML.

2015-07-12 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- python/build/nroff.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/python/build/nroff.py b/python/build/nroff.py index 166f2a4..778ce0f 100644 --- a/python/build/nroff.py +++ b/python/build/nroff.py @@ -276,6 +276,8 @@ def block_xml_to_nroff(nodes, para='.PP'

[ovs-dev] [PATCH] nicira-ext: Fix typo in comment.

2015-07-12 Thread Ben Pfaff
--- include/openflow/nicira-ext.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h index 9154800..16a4a7a 100644 --- a/include/openflow/nicira-ext.h +++ b/include/openflow/nicira-ext.h @@ -1,5 +1,5 @@ /* - * Copy

Re: [ovs-dev] About one abort in vswitchd

2015-07-12 Thread 马啸
Hi,all Is anybody know what the problem caused by and how to solve it ? Look forward for your replying. At 2015-07-10 18:32:07, "马啸" wrote: Hi,all The version is 2.1.2 . openvswitch-2.1.2-26.el6.x86_64 The information as bellow: ===