On Sun, Jul 12, 2015 at 02:52:38PM -0700, Gurucharan Shetty wrote:
> On Sat, Jul 11, 2015 at 8:27 AM, Ben Pfaff <b...@nicira.com> wrote:
> > Commit 22b4ccf4f (ofproto-dpif: Don't try to use dpif_probe_feature() with
> > Windows datapath.) stopped ofproto-dpif from trying to use the DPIF_FP_PROBE
> > feature of the datapath interface, because it doesn't work with Windows
> > yet.  However, it was *too* broad--it also stopped ofproto-dpif from
> > using DPIF_FP_PROBE with the netdev datapath, which still does support
> > DPIF_FP_PROBE on Windows.  This commit moves disabling DPIF_FP_PROBE a
> > couple of layers down, to a place where the two datapaths can be easily
> > distinguished.
> >
> > Reported-by: Gurucharan Shetty <shet...@nicira.com>
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> 
> I can confirm that this fixes all unit tests. It also looks sane to
> me. Though, I would prefer that a windows datapath developer confirms
> that this approach is actually Okay for 2.4

Thanks.

OVS-on-Windows developers, will you please review this also?

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to