Acked-by: Alex Wang
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou wrote:
> This file follows a convention that all static functions are grouped
> towards the beginning, ahead of public functions. Re-arrange the code
> to confirm to this convention. No functional changes.
>
> Signed-off-by: Andy Zh
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou wrote:
> Both get_table() and set_cloum() APIs are mostly used within db-ctl-base
> library. This patch makes both private to the library.
>
> Add a new ctl_set_colum() API for library client.
>
> The changes are cleanups. No functional changes.
>
> Signe
Acked-by: Alex Wang
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou wrote:
> Instead, client now pass it via the modified ctl_init() API.
>
> Siigned-off-by: Andy Zhou
> ---
> lib/db-ctl-base.c | 8 +++-
> lib/db-ctl-base.h | 8 ++--
> utilities/ovs-vsctl.c | 4 ++--
> vtep/vtep-ctl
Unfortunately, this commit breaks many unit tests. Now we won't know
whether the unit tests are failing because of this commit or because
of some other regression.
On Thu, Jun 25, 2015 at 9:50 AM, Eitan Eliahu wrote:
> If it gets too involved have your user mode hack instead.
> Thanks Alin.
> Ei
MSVC 2013 does not like designated initializers when
structs are initialized inside structs.
Signed-off-by: Gurucharan Shetty
---
CodingStyle.md |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/CodingStyle.md b/CodingStyle.md
index 0a441e0..54dadf1 100644
--- a/CodingSt
MSVC 2013 does not like designated initializers when
structs are initialized inside structs.
Signed-off-by: Gurucharan Shetty
---
lib/dpif-netdev.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index b53d52a
We haven't had a successful Windows build for a while now. So I decide
to push the original commit to master and branch-2.4. If any of you
feel a better solution is present, please work on top of this commit.
On Mon, Jul 6, 2015 at 1:12 PM, Ansis Atteka wrote:
> On Wed, Jul 1, 2015 at 1:20 PM, Be
On 07/10/15 at 09:57pm, Julian Anastasov wrote:
>
> Hello,
>
> On Fri, 10 Jul 2015, Thomas Graf wrote:
>
> > --- a/net/ipv4/route.c
> > +++ b/net/ipv4/route.c
> > @@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb,
> > __be32 daddr, __be32 saddr,
> >by fib_lo
Hello,
On Fri, 10 Jul 2015, Thomas Graf wrote:
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb,
> __be32 daddr, __be32 saddr,
> by fib_lookup.
>*/
>
> + skb_dst_drop(skb);
> +
Th
On 07/10/2015 05:19 PM, Thomas Graf wrote:
If output device wants to see the dst, inherit the dst of the
original skb and pass it on to generate the ARP request.
Signed-off-by: Thomas Graf
---
net/ipv4/arp.c | 71 +++---
1 file changed,
On Fri, Jul 10, 2015 at 11:09 AM, Jarno Rajahalme wrote:
>> On Jul 7, 2015, at 10:30 PM, Jesse Gross wrote:
>> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
>> index b53d52a..50763bc 100644
>> --- a/lib/dpif-netdev.c
>> +++ b/lib/dpif-netdev.c
>> +static void
>> +xlate_geneve_attr(const stru
On Fri, Jul 10, 2015 at 10:35 AM, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
> ---
> lib/meta-flow.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This one seems like an obvious bugfix that can go in independent of
the rest of the series.
Acked-by: Jesse Gross
__
Jesse,
This is no proper review, but I have two questions below.
Jarno
> On Jul 7, 2015, at 10:30 PM, Jesse Gross wrote:
>
> The kernel implementation of Geneve options stores the TLV option
> data in the flow exactly as received, without any further parsing.
> This is then translated to kno
> On Jul 10, 2015, at 10:37 AM, Ben Pfaff wrote:
>
> On Fri, Jul 10, 2015 at 10:35:19AM -0700, Jarno Rajahalme wrote:
>> I've seen core files appear and then be automatically removed as the
>> test case was successful. Such success is highly doubtful, so fail
>> the test cases if any core files
> On Jul 10, 2015, at 9:38 AM, Traynor, Kevin wrote:
>
>>
>> -Original Message-
>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno Rajahalme
>> Sent: Thursday, July 9, 2015 6:16 PM
>> To: dev@openvswitch.org
>> Subject: [ovs-dev] [RFC PATCH 0/6] Increase miniflow's cap
On Fri, Jul 10, 2015 at 10:35:19AM -0700, Jarno Rajahalme wrote:
> I've seen core files appear and then be automatically removed as the
> test case was successful. Such success is highly doubtful, so fail
> the test cases if any core files exist at the end of the test.
>
> Signed-off-by: Jarno Ra
Use two maps in miniflow to allow for expansion of struct flow past
512 bytes. We now have one map for tunnel related fields, and another
for the rest of the packet metadata and actual packet header fields.
This split has the benefit that for non-tunneled packets the overhead
should be minimal.
S
miniflow_clone() and minimask_clone() are no longer used, remove them
from the API.
Now that miniflow data is always inlined, it makes sense to rename
miniflow_clone_inline() miniflow_clone().
Signed-off-by: Jarno Rajahalme
---
lib/classifier.c|8
lib/flow.c |
MINIFLOW_FOR_EACH_IN_MAPS and NETDEV_FLOW_KEY_FOR_EACH_IN_MAPqS had a
bug where tunnel metadata values remaining after the processing of the
tnl_map was not advanced correctly.
Instead of fixing this bug this patch changes the caller to process
each map separately by splitting MINIFLOW_FOR_EACH_IN
Now that performance critical code already inlines miniflows and
minimasks, we can simplify struct miniflow by always dynamically
allocating miniflows and minimasks to the correct size. This changes
the struct minimatch to always contain pointers to its miniflow and
minimask.
Signed-off-by: Jarno
I've seen core files appear and then be automatically removed as the
test case was successful. Such success is highly doubtful, so fail
the test cases if any core files exist at the end of the test.
Signed-off-by: Jarno Rajahalme
---
tests/ofproto-macros.at |6 +-
1 file changed, 5 inse
Allocate the miniflow and minimask in struct minimatch at once, so
that they are consecutive in memory. This halves the number of
allocations, and allows smaller minimatches to share the same cache
line.
After this a minimatch has one heap allocation for all it's data.
Previously it had either no
Upto now struct miniflow has been limited to 63 64-bit units. This
series increases this capacity to 128 64-bit units. For presimed
performance reasons the new miniflow uses one 64-bit map for tunnel
metadata and another for the rest of the metadata and the fields
extracted from packet headers.
Signed-off-by: Jarno Rajahalme
---
lib/meta-flow.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index 21a13b4..541143c 100644
--- a/lib/meta-flow.c
+++ b/lib/meta-flow.c
@@ -1114,7 +1114,7 @@ mf_set_flow_value(const struct mf_field *mf,
On 7/10/15, 9:54 AM, Thomas Graf wrote:
On 07/10/15 at 05:36pm, Eric Dumazet wrote:
On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote:
From: Roopa Prabhu
+ if (oif)
+ dev = __dev_get_by_index(net, oif);
+ ret = lwtunnel_build_state(dev, encap_type,
+
On 07/10/15 at 05:36pm, Eric Dumazet wrote:
> On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote:
> > From: Roopa Prabhu
>
>
> > + if (oif)
> > + dev = __dev_get_by_index(net, oif);
> > + ret = lwtunnel_build_state(dev, encap_type,
> > + encap, &lwtst
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno Rajahalme
> Sent: Thursday, July 9, 2015 6:16 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [RFC PATCH 0/6] Increase miniflow's capacity.
>
> Upto now struct miniflow has been limited to 63 64-bit
>
> The patch makes sense for branch-2.4 and master. Thanks!
>
> Acked-by: Daniele Di Proietto
+1 from me too - thanks for fixing this!
>
> On 06/07/2015 22:41, "Mussar, Gary" wrote:
>
> >Fix detection of vhost_cuse in dpdk rte_config.h
> >
> >Dpdk allows users to create a config that inclu
On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote:
> From: Roopa Prabhu
> + if (oif)
> + dev = __dev_get_by_index(net, oif);
> + ret = lwtunnel_build_state(dev, encap_type,
> +encap, &lwtstate);
> + if (!ret) {
> + lwtunnel_s
This factors out the device configuration out of the RTNL newlink
API which allows for in-kernel creation of VXLAN net_devices.
Signed-off-by: Thomas Graf
---
drivers/net/vxlan.c | 332
include/net/vxlan.h | 59 ++
2 files changed, 23
This gets rid of all OVS specific VXLAN code in the receive and
transmit path by using a VXLAN net_device to represent the vport.
Only a small shim layer remains which takes care of handling the
VXLAN specific OVS Netlink configuration.
Unexports vxlan_sock_add(), vxlan_sock_release(), vxlan_xmit_
From: Pravin Shelar
Removes all of the OVS specific GRE code and makes OVS use a
GRE net_device.
Signed-off-by: Pravin B Shelar
---
net/core/dev.c | 5 +-
net/ipv4/ip_gre.c | 165 +-
net/openvswitch/Makefile | 1 -
net/openvswitch/vpor
Utilize the new metadata dst to attach encapsulation instructions to
the skb. The existing egress_tun_info via the OVS_CB() is left in
place until all tunnel vports have been converted to the new method.
Signed-off-by: Thomas Graf
Signed-off-by: Pravin B Shelar
---
net/openvswitch/actions.c
This allows to get rid of the get_name() vport ops later on.
Signed-off-by: Thomas Graf
---
net/openvswitch/datapath.c | 4 ++--
net/openvswitch/vport-internal_dev.c | 1 -
net/openvswitch/vport-netdev.c | 6 --
net/openvswitch/vport-netdev.h | 1 -
net/openvswitch/vpor
This add the ability to select a routing table based on the tunnel
id which allows to maintain separate routing tables for each virtual
tunnel network.
ip rule add from all tunnel-id 100 lookup 100
ip rule add from all tunnel-id 200 lookup 200
Signed-off-by: Thomas Graf
---
include/net/fib_rule
This is the first step in representing all OVS vports as regular
struct net_devices. Move the net_device pointer into the vport
structure itself to get rid of struct vport_netdev.
Signed-off-by: Thomas Graf
Signed-off-by: Pravin B Shelar
---
net/openvswitch/datapath.c | 7 +--
net/op
This introduces a new IP tunnel lightweight tunnel type which allows
to specify IP tunnel instructions per route. Only IPv4 is supported
at this point.
Signed-off-by: Thomas Graf
---
drivers/net/vxlan.c| 10 +++-
include/net/dst_metadata.h | 12 -
include/net/ip_tunnels.h
From: Roopa Prabhu
Signed-off-by: Roopa Prabhu
---
net/mpls/af_mpls.c | 11 ---
net/mpls/internal.h | 3 +++
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 1f93a59..6e66911 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af
Introduces a new dst_metadata which enables to carry per packet metadata
between forwarding and processing elements via the skb->dst pointer.
The structure is set up to be a union. Thus, each separate type of
metadata requires its own dst instance. If demand arises to carry
multiple types of metad
If output device wants to see the dst, inherit the dst of the
original skb and pass it on to generate the ARP request.
Signed-off-by: Thomas Graf
---
net/ipv4/arp.c | 71 +++---
1 file changed, 43 insertions(+), 28 deletions(-)
diff --git a/ne
Allows putting a VXLAN device into a new flow-based mode in which it
will populate a ip_tunnel_info struct for each packet received and
attach it to the skb using the new metadata dst. The metadata structure
will contain the outer header and tunnel header fields which have been
stripped off. Layers
From: Roopa Prabhu
This is similar to ipv4 redirect of dst output to lwtunnel
output function for encapsulation and xmit.
Signed-off-by: Roopa Prabhu
---
net/ipv6/route.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index acfe25d..6c328bb 100644
--- a
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to
allow routes to match on tunnel metadata. For now, the tunnel id is
added to flowi_tunnel which allows for routes to be bound to specific
virtual tunnels.
Signed-off-by: Thomas Graf
---
include/net/flow.h | 7 +++
net/ipv
From: Roopa Prabhu
This implementation uses lwtunnel infrastructure to register
hooks for mpls tunnel encaps.
It picks cues from iptunnel_encaps infrastructure and previous
mpls iptunnel RFC patches from Eric W. Biederman and Robert Shearman
Signed-off-by: Roopa Prabhu
---
include/linux/mpls_
From: Roopa Prabhu
This patch introduces lwtunnel_output function to call corresponding
lwtunnels output function to xmit the packet.
It adds two variants lwtunnel_output and lwtunnel_output6 for ipv4 and
ipv6 respectively today. But this is subject to change when lwtstate will
reside in dst or
From: Roopa Prabhu
For input routes with tunnel encap state this patch redirects
dst output functions to lwtunnel_output which later resolves to
the corresponding lwtunnel output function.
This has been tested to work with mpls ip tunnels.
Open items: Support for tunnel mtu, pmtu, fragmentation
From: Roopa Prabhu
Provides infrastructure to parse/dump/store encap information for
light weight tunnels like mpls. Encap information for such tunnels
is associated with fib routes.
This infrastructure is based on previous suggestions from
Eric Biederman to follow the xfrm infrastructure.
Sign
From: Roopa Prabhu
This patch introduces two new RTA attributes to attach encap
data to fib routes.
Example iproute2 command to attach mpls encap data to ipv4 routes
$ip route add 10.1.1.0/30 encap mpls 200 via inet 10.1.1.1 dev swp1
Signed-off-by: Roopa Prabhu
Suggested-by: Eric W. Biederman
From: Roopa Prabhu
This patch adds support in ipv4 fib functions to parse user
provided encap attributes and attach encap state data to fib_nh
and rtable.
Signed-off-by: Roopa Prabhu
---
include/net/ip_fib.h | 5 ++-
include/net/route.h | 1 +
net/ipv4/fib_frontend.c | 8
From: Roopa Prabhu
This patch adds support in ipv6 fib functions to parse Netlink
RTA encap attributes and attach encap state data to rt6_info.
Signed-off-by: Roopa Prabhu
---
include/net/ip6_fib.h | 3 +++
net/ipv6/ip6_fib.c| 2 ++
net/ipv6/route.c | 33
This series combines the work previously posted by Roopa, Robert and
myself. It's according to what we discussed at NFWS. The series
accomplishes:
* Lightweight tunnel infrastructure to attach encapsulation
instructions to routes.
* Metadata dst to carry metadata between forwarding elements.
From: Niti
This patch adds support for Openflow1.4 set/get asynchronous configuration
messages. OpenVSwitch already supports set/get asynchronous configuration
messages for Openflow1.3. In this patch OFPT_SET_ASYNC_CONFIG message
allows the controllers to set the configuration for OFPT_ROLE_STATU
Hi Ben,
Thanks for the review.
All the comments have been incorporated in Version 2 of the patch.
Thanks
Niti Rohilla
On Thu, Jul 9, 2015 at 5:36 AM, Ben Pfaff wrote:
> On Tue, Jul 07, 2015 at 01:17:36PM +0530, niti1...@gmail.com wrote:
> > From: Niti
> >
> > This patch adds support for Open
Hi,all
The version is 2.1.2 . openvswitch-2.1.2-26.el6.x86_64
The information as bellow:
=
Core was generated by `ovs-vswitchd unix:/var/run/openvswitch/db.sock
-vconsole:emer -vsyslog:err -vfi'.
Program term
Solved some spelling errors observed in the datapath code.
Signed-off-by: Sorin Vinturis
---
datapath-windows/ovsext/TunnelFilter.c | 22 +++---
datapath-windows/ovsext/TunnelIntf.h | 20 ++--
datapath-windows/ovsext/Vport.c| 2 +-
datapath-windows/ovse
When removing vport also remove the vxlan tunnel port.
Signed-off-by: Sorin Vinturis
Reported-by: Sorin Vinturis
Reported-at: https://github.com/openvswitch/ovs-issues/issues/94
---
datapath-windows/ovsext/Vport.c | 6 ++
datapath-windows/ovsext/Vxlan.c | 6 +++---
2 files changed, 9 insert
56 matches
Mail list logo
