On 07/10/15 at 09:57pm, Julian Anastasov wrote: > > Hello, > > On Fri, 10 Jul 2015, Thomas Graf wrote: > > > --- a/net/ipv4/route.c > > +++ b/net/ipv4/route.c > > @@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb, > > __be32 daddr, __be32 saddr, > > by fib_lookup. > > */ > > > > + skb_dst_drop(skb); > > + > > This is not very safe. There are places that > call ip_route_input() for temporary lookups and they > do not set NULL. For example, icmp_route_lookup(), > may be there are other such places...
Wow. What a tremendous hack ;-) It saves and restores the original dst ref to avoid the leaked reference. > OTOH, ip_options_rcv_srr() looks correct to use > skb_dst_set(skb, NULL), may be such call should be > added if it is missing... Agreed. This seems to be the right fix. I'll apply to this icmp_route_lookup() as well. Thanks! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
