Re: [ovs-dev] please f#ck me tonite

2015-05-27 Thread NewHookUpBuddy
Send me a F#ckFriends request so we can hook up My usename is Suck4Fun2 y profile is here http://cc4.co/CYRZP SPEAK SOON ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/4] util: Library routines for printing and scanning large hex integers.

2015-05-27 Thread Jesse Gross
On Wed, May 27, 2015 at 3:25 PM, Ben Pfaff wrote: > On Wed, May 27, 2015 at 10:48:40AM -0700, Jesse Gross wrote: >> Geneve options are variable length and up to 124 bytes long, which means >> that they can't be easily manipulated by the integer string functions >> like we do for other fields. This

[ovs-dev] [PATCH] bash_completion shouldn't modify user environment

2015-05-27 Thread Zang MingJie
Signed-off-by: Zang MingJie --- utilities/ovs-appctl-bashcomp.bash | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/utilities/ovs-appctl-bashcomp.bash b/utilities/ovs-appctl-bashcomp.bash index 67a268e..f7fb830 100755 --- a/utilities/ovs-appctl-bashcomp.bash +++ b/utilitie

Re: [ovs-dev] [PATCH 4/4] odp-util: Geneve netlink decoding.

2015-05-27 Thread Jesse Gross
On Wed, May 27, 2015 at 3:18 PM, Andy Zhou wrote: > On Wed, May 27, 2015 at 10:48 AM, Jesse Gross wrote: >> Even though userspace does not yet support Geneve options, >> the kernel does and there is some basic support for decoding >> those attributes. This adds the ability to print Geneve >> attr

Re: [ovs-dev] [PATCH 3/4] util: Library routines for printing and scanning large hex integers.

2015-05-27 Thread Jesse Gross
On Wed, May 27, 2015 at 3:15 PM, Andy Zhou wrote: > On Wed, May 27, 2015 at 10:48 AM, Jesse Gross wrote: >> diff --git a/lib/util.c b/lib/util.c >> index bcf7700..3dc06d0 100644 >> --- a/lib/util.c >> +++ b/lib/util.c >> +int >> +parse_int_string(const char *s, uint8_t *valuep, int field_width, c

Re: [ovs-dev] [PATCH 3/4] util: Library routines for printing and scanning large hex integers.

2015-05-27 Thread Ben Pfaff
On Wed, May 27, 2015 at 10:48:40AM -0700, Jesse Gross wrote: > Geneve options are variable length and up to 124 bytes long, which means > that they can't be easily manipulated by the integer string functions > like we do for other fields. This adds a few helper routines to make > these operations e

Re: [ovs-dev] [PATCH 1/4] odp-util: Correctly generate wildcards when formating nested attributes.

2015-05-27 Thread Jesse Gross
On Wed, May 27, 2015 at 3:03 PM, Andy Zhou wrote: > On Wed, May 27, 2015 at 10:48 AM, Jesse Gross wrote: >> When formatting netlink attributes if no mask is present a wildcarded >> attribute is synthesized for the purposes of later processing. In >> the case of nested attributes this must be done

Re: [ovs-dev] [PATCH 4/4] odp-util: Geneve netlink decoding.

2015-05-27 Thread Andy Zhou
On Wed, May 27, 2015 at 10:48 AM, Jesse Gross wrote: > Even though userspace does not yet support Geneve options, > the kernel does and there is some basic support for decoding > those attributes. This adds the ability to print Geneve > attributes that might potentially come from the kernel. > > S

Re: [ovs-dev] [PATCH 3/4] util: Library routines for printing and scanning large hex integers.

2015-05-27 Thread Andy Zhou
On Wed, May 27, 2015 at 10:48 AM, Jesse Gross wrote: > Geneve options are variable length and up to 124 bytes long, which means > that they can't be easily manipulated by the integer string functions > like we do for other fields. This adds a few helper routines to make > these operations easier.

Re: [ovs-dev] [PATCH 2/4] odp-util: Format tunnel attributes directly from netlink.

2015-05-27 Thread Andy Zhou
On Wed, May 27, 2015 at 10:48 AM, Jesse Gross wrote: > When we format most netlink attributes we do so from the netlink > itself, iterating through each one and printing the contents out. > However, for tunnels we don't do this - we first convert to the > OVS userspace representation and then form

Re: [ovs-dev] [PATCH 1/4] odp-util: Correctly generate wildcards when formating nested attributes.

2015-05-27 Thread Andy Zhou
On Wed, May 27, 2015 at 10:48 AM, Jesse Gross wrote: > When formatting netlink attributes if no mask is present a wildcarded > attribute is synthesized for the purposes of later processing. In > the case of nested attributes this must be done recursively, filling > in the correct attributes at eac

Re: [ovs-dev] [RFC PATCH kernel 01/10] openvswitch: fix CHECKSUM_PARTIAL with tunnels

2015-05-27 Thread Jesse Gross
On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > When the packet ovs gets from a NIC driver is CHECKSUM_PARTIAL and it goes > through decapsulation, csum_start may point before the skb->data after the > decapsulation. This triggers a BUG_ON in skb_checksum_help. > > As we don't need to calcula

Re: [ovs-dev] [PATCH] datapath: do not add vlan_hwaccel_push_inside() for kernel >= 3.18.13

2015-05-27 Thread Jesse Gross
On Wed, May 27, 2015 at 2:07 PM, Hauke Mehrtens wrote: > On 05/27/2015 10:14 PM, Jesse Gross wrote: >> On Tue, May 26, 2015 at 4:59 PM, Ben Pfaff wrote: >>> diff --git a/datapath/linux/compat/include/linux/if_vlan.h >>> b/datapath/linux/compat/include/linux/if_vlan.h >>> index 05c2876..0750bbe 1

Re: [ovs-dev] [PATCH] datapath: do not add vlan_hwaccel_push_inside() for kernel >= 3.18.13

2015-05-27 Thread Hauke Mehrtens
On 05/27/2015 10:14 PM, Jesse Gross wrote: > On Tue, May 26, 2015 at 4:59 PM, Ben Pfaff wrote: >> diff --git a/datapath/linux/compat/include/linux/if_vlan.h >> b/datapath/linux/compat/include/linux/if_vlan.h >> index 05c2876..0750bbe 100644 >> --- a/datapath/linux/compat/include/linux/if_vlan.h >

Re: [ovs-dev] [PATCH ovn] controller: Fix crash on binding with no chassis.

2015-05-27 Thread Ben Pfaff
On Wed, May 27, 2015 at 03:59:26PM -0400, Russell Bryant wrote: > The current code crashes when it encounters a binding that does not > yet have a chassis set. This patch restores the intended behavior of > ignoring it in that case. > > Signed-off-by: Russell Bryant Thanks! Applied. __

Re: [ovs-dev] [PATCH] datapath: do not add vlan_hwaccel_push_inside() for kernel >= 3.18.13

2015-05-27 Thread Jesse Gross
On Tue, May 26, 2015 at 4:59 PM, Ben Pfaff wrote: > diff --git a/datapath/linux/compat/include/linux/if_vlan.h > b/datapath/linux/compat/include/linux/if_vlan.h > index 05c2876..0750bbe 100644 > --- a/datapath/linux/compat/include/linux/if_vlan.h > +++ b/datapath/linux/compat/include/linux/if_vla

[ovs-dev] [PATCH ovn] controller: Fix crash on binding with no chassis.

2015-05-27 Thread Russell Bryant
The current code crashes when it encounters a binding that does not yet have a chassis set. This patch restores the intended behavior of ignoring it in that case. Signed-off-by: Russell Bryant --- ovn/controller/physical.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ovn/controller/ph

Re: [ovs-dev] [PATCH v2] datapath-windows: Removed memory barrier and master lock

2015-05-27 Thread Ben Pfaff
On Wed, May 27, 2015 at 05:08:00PM +, Sorin Vinturis wrote: > There is no need to enforce Netlink serialization on transactions > sent from userspace. The access to the driver's shared resources > is synchronized anyway. Thus I have removed the master lock. > > I also removed the memory barrie

Re: [ovs-dev] [PATCH v9 0/3] datapath-windows: Multiple VXLAN tunnel support

2015-05-27 Thread Ben Pfaff
On Wed, May 27, 2015 at 07:12:01PM +, Sorin Vinturis wrote: > Ben, > > I have fixed the whitespace issue from this patch series. > > Thanks, > Sorin Hmm, I still got a reject on patch 1 but it was easy to fix up by hand so I applied all three patches anyway. Thanks! Ben ___

Re: [ovs-dev] [PATCH 1/2] Increase prerequisite from Python 2.4 to Python 2.7.

2015-05-27 Thread Terry Wilson
- Original Message - > On Wed, May 27, 2015 at 12:11:55AM -0400, Russell Bryant wrote: > > On 05/26/2015 10:14 PM, Ben Pfaff wrote: > > > On Tue, May 26, 2015 at 10:31:57AM -0400, Russell Bryant wrote: > > >> On 05/21/2015 10:23 PM, Andy Hill wrote: > > As a consequence, this require

Re: [ovs-dev] [PATCH] ofp-actions: Improve conjunction error message.

2015-05-27 Thread Ben Pfaff
On Wed, May 27, 2015 at 11:19:12AM -0700, Joe Stringer wrote: > Signed-off-by: Joe Stringer Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v9 0/3] datapath-windows: Multiple VXLAN tunnel support

2015-05-27 Thread Sorin Vinturis
Ben, I have fixed the whitespace issue from this patch series. Thanks, Sorin -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis Sent: Wednesday, 27 May, 2015 19:58 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH v9 0/3] datapath-windows: Multi

Re: [ovs-dev] [RFC HSA 0/4] HSA for OVS prototype.

2015-05-27 Thread Alex Wang
Yeah, I think it will be useful. I think current OVN's flow should be simpler and allow us to make more optimization/adjustment as OVN grows. Thanks, Alex Wang, On Wed, May 27, 2015 at 9:56 AM, Ben Pfaff wrote: > On Mon, Mar 30, 2015 at 03:46:25PM -0700, Alex Wang wrote: > > This series implem

Re: [ovs-dev] I want to be in your bed

2015-05-27 Thread NewHookUpBuddy
Send me a F#ckFriends request so we can hook up My usename is BadChristina93 y profile is here http://cc4.co/SNILI SEE YOU SOON ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ofp-actions: Improve conjunction error message.

2015-05-27 Thread Joe Stringer
Signed-off-by: Joe Stringer --- lib/ofp-actions.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index 2240b86..e18229d 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.c @@ -5721,8 +5721,9 @@ ofpacts_verify(const struct ofpact o

Re: [ovs-dev] [PATCH 4/4] tests: Check that ofproto/trace accepts dpctl output.

2015-05-27 Thread Joe Stringer
On 26 May 2015 at 18:06, Ben Pfaff wrote: > On Thu, May 21, 2015 at 03:11:52PM -0700, Joe Stringer wrote: >> Signed-off-by: Joe Stringer > > Acked-by: Ben Pfaff Thanks, applied to master. ___ dev mailing list dev@openvswitch.org http://openvswitch.org

Re: [ovs-dev] [PATCH 3/4] tests: Fix in_port(name) test for ofproto/trace.

2015-05-27 Thread Joe Stringer
On 26 May 2015 at 18:04, Ben Pfaff wrote: > On Thu, May 21, 2015 at 03:11:51PM -0700, Joe Stringer wrote: >> Reported-by: Gurucharan Shetty >> Signed-off-by: Joe Stringer > > Acked-by: Ben Pfaff Thanks, applied to master and branch-2.3. ___ dev maili

Re: [ovs-dev] [PATCH 2/4] odp-util: Skip UFID when parsing datapath key.

2015-05-27 Thread Joe Stringer
On 26 May 2015 at 18:03, Ben Pfaff wrote: > On Thu, May 21, 2015 at 03:11:50PM -0700, Joe Stringer wrote: >> Signed-off-by: Joe Stringer > > ... >> +s += strspn(s, "0123456789abcdef"); > > It would be kind to skip capital hex digits too, just in case someone > manually retypes one with ca

Re: [ovs-dev] [PATCH 1/4] ofproto-dpif: Make odp/ofp parse errors more clear.

2015-05-27 Thread Joe Stringer
On 26 May 2015 at 18:14, Andy Zhou wrote: > Acked-by: Andy Zhou Thanks, applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCHv2] extract-ofp-fields: Detect duplicate fields.

2015-05-27 Thread Joe Stringer
On 26 May 2015 at 18:26, Ben Pfaff wrote: > On Wed, May 20, 2015 at 02:53:22PM -0700, Joe Stringer wrote: >> Figure out if a developer accidentally defines new NXM fields using an >> existing number, and warn them. Useful particularly if new fields are >> introduced upstream while rebasing an in-p

[ovs-dev] [PATCH 2/4] odp-util: Format tunnel attributes directly from netlink.

2015-05-27 Thread Jesse Gross
When we format most netlink attributes we do so from the netlink itself, iterating through each one and printing the contents out. However, for tunnels we don't do this - we first convert to the OVS userspace representation and then format that. While convienient, this isn't really ideal as the pri

[ovs-dev] [PATCH 4/4] odp-util: Geneve netlink decoding.

2015-05-27 Thread Jesse Gross
Even though userspace does not yet support Geneve options, the kernel does and there is some basic support for decoding those attributes. This adds the ability to print Geneve attributes that might potentially come from the kernel. Signed-off-by: Jesse Gross --- lib/odp-util.c | 206

[ovs-dev] [PATCH 3/4] util: Library routines for printing and scanning large hex integers.

2015-05-27 Thread Jesse Gross
Geneve options are variable length and up to 124 bytes long, which means that they can't be easily manipulated by the integer string functions like we do for other fields. This adds a few helper routines to make these operations easier. Signed-off-by: Jesse Gross --- lib/dynamic-string.c | 24 ++

[ovs-dev] [PATCH 1/4] odp-util: Correctly generate wildcards when formating nested attributes.

2015-05-27 Thread Jesse Gross
When formatting netlink attributes if no mask is present a wildcarded attribute is synthesized for the purposes of later processing. In the case of nested attributes this must be done recursively, filling in the correct attributes at each level rather than just generating a set of zeros of the corr

Re: [ovs-dev] FW: performance issue with ovs + dpdk2.0 with vhost

2015-05-27 Thread Thomas F Herbert
On 5/24/15 9:55 AM, Ravi Rao wrote: Hi Below are the exact sequence of steps that I followed.. This is what I am trying to Do. Below is the setup.. | +--+ | | guest| | | | |

[ovs-dev] [PATCH v2] datapath-windows: Removed memory barrier and master lock

2015-05-27 Thread Sorin Vinturis
There is no need to enforce Netlink serialization on transactions sent from userspace. The access to the driver's shared resources is synchronized anyway. Thus I have removed the master lock. I also removed the memory barrier from filter dispatch routine. A memory barrier is already in place in Ov

[ovs-dev] [PATCH v9 2/3] datapath-windows: Support for multiple VXLAN tunnels

2015-05-27 Thread Sorin Vinturis
At the moment the OVS extension supports only one VXLAN tunnel that is cached in the extension switch context. Replaced the latter cached pointer with an array list that contains all VXLAN tunnel vports. Signed-off-by: Sorin Vinturis Reported-by: Alin Gabriel Serdean Reported-at: https://github.

[ovs-dev] [PATCH v9 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Sorin Vinturis
The kernel datapath supports only port 4789 for VXLAN tunnel creation. Added support in order to allow for the VXLAN tunnel port to be configurable to any port number set by the userspace. The patch also checks to see if an existing WFP filter, for the necessary UDP tunnel port, is already created

[ovs-dev] [PATCH v9 3/3] datapath-Windows: document OVS tunnel filter callout

2015-05-27 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju --- datapath-windows/ovsext/TunnelFilter.c | 225 - 1 file changed, 221 insertions(+), 4 deletions(-) diff --git a/datapath-windows/ovsext/TunnelFilter.c b/datapath-windows/ovsext/TunnelFilter.c index a47e0aa..

[ovs-dev] [PATCH v9 0/3] datapath-windows: Multiple VXLAN tunnel support

2015-05-27 Thread Sorin Vinturis
This patch series adds support for custom VXLAN tunnel port and for multiple VXLAN tunnels. Sorin Vinturis (3): [PATCH v9 1/3] datapath-windows: Support for custom VXLAN tunnel port [PATCH v9 2/3] datapath-windows: Support for multiple VXLAN tunnels [PATCH v9 3/3] datapath-Windows: document

Re: [ovs-dev] [RFC HSA 0/4] HSA for OVS prototype.

2015-05-27 Thread Ben Pfaff
On Mon, Mar 30, 2015 at 03:46:25PM -0700, Alex Wang wrote: > This series implements a prototype of using Header Space Analysis (HSA) > for OVS OpenFlow table analysis. The implementation allows users to find > all possible output ports with the input header format reachable from a > specified inpu

[ovs-dev] installing Python 2.7 on Xenserver (was: Re: [PATCH 1/2] Increase prerequisite from Python 2.4 to Python 2.7.)

2015-05-27 Thread Ben Pfaff
On Thu, May 21, 2015 at 07:23:49PM -0700, Andy Hill wrote: > > As a consequence, this requires dropping support for old versions of > > XenServer. I don't expect that to be much of a problem. > > Unfortunately, the most recent release of XenServer (6.5) still ships > with Python 2.4. How hard is

Re: [ovs-dev] [PATCH v2] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation

2015-05-27 Thread Ben Pfaff
On Wed, May 27, 2015 at 04:38:36PM +, Nithin Raju wrote: > > On May 27, 2015, at 9:11 AM, Eitan Eliahu wrote: > > > > This change include an initial implementable of STT. > > The following should be added: > > [1] Checksum offload (SW and HW) > > [2] LSO (SW and HW) > > [3] IP layer WFP callo

[ovs-dev] Refresh your marriage! Use best ED medications.

2015-05-27 Thread Erwin Wood
If you are looking for ultimate male enhancement, this is the right moment! http://cc4.co/KMBPS ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] ovs_threads: Avoid running pthread destructors from main thread exit.

2015-05-27 Thread Gurucharan Shetty
On Wed, May 27, 2015 at 9:21 AM, Ben Pfaff wrote: > On Wed, Apr 22, 2015 at 12:20:23PM -0700, Gurucharan Shetty wrote: >> Windows uses pthreads-win32 library to provide the Linux pthread >> functionality. It is observed that when the main thread calls >> a pthread destructor after it exits, undefi

Re: [ovs-dev] [PATCH v7 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Nithin Raju
> On May 27, 2015, at 9:30 AM, Ben Pfaff wrote: > > Hi Sorin, I'd like to apply this but I get a patch failure: > >Applying: datapath-windows: Support for custom VXLAN tunnel port >/home/blp/nicira/ovs/.git/rebase-apply/patch:917: trailing whitespace. > >/home/blp/nicira/ovs/.git/re

Re: [ovs-dev] [PATCH] utilities: Add new pipeline generator script.

2015-05-27 Thread Ethan Jackson
> This is useful and I think we would like to use it here. I have a few > questions. Great! I really hope this moves the community in the direction of more realistic test cases. > How come the pipeline is set up with metadata instead of a chain of tables > as I presume that would also work? I

Re: [ovs-dev] [PATCH v2] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation

2015-05-27 Thread Nithin Raju
> On May 27, 2015, at 9:11 AM, Eitan Eliahu wrote: > > This change include an initial implementable of STT. > The following should be added: > [1] Checksum offload (SW and HW) > [2] LSO (SW and HW) > [3] IP layer WFP callout for IP segments > > Testing: link layer connection through ping works.

Re: [ovs-dev] [PATCH v8 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Ben Pfaff
Unfortunately I'm still seeing a patch failure against current master: Applying: datapath-windows: Support for custom VXLAN tunnel port /home/blp/nicira/ovs/.git/rebase-apply/patch:919: trailing whitespace. /home/blp/nicira/ovs/.git/rebase-apply/patch:1959: trailing whitespace. NT

Re: [ovs-dev] [PATCH v7 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Ben Pfaff
On Wed, May 27, 2015 at 04:35:19PM +, Sorin Vinturis wrote: > Hi Ben, > > I'll test the patches to solve the issue. > The v8 version was sent before seeing your mail. Thanks. (I didn't see this email before I tested v8.) ___ dev mailing list dev@op

Re: [ovs-dev] [PATCH] ofproto-dpif: Avoid creating OpenFlow ports for duplicate tunnels.

2015-05-27 Thread Ben Pfaff
Oh, unfortunately it breaks test 629 "tunnel_push_pop - action". I haven't had a chance to fully investigate yet. On Wed, May 27, 2015 at 09:33:07AM -0700, Ben Pfaff wrote: > Wow, thanks! > > I added a Tested-by for you also, and I'll apply this to master in a > minute. > > On Wed, May 27, 2015

Re: [ovs-dev] [PATCH v7 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Sorin Vinturis
Hi Ben, I'll test the patches to solve the issue. The v8 version was sent before seeing your mail. Thanks, Sorin -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Wednesday, 27 May, 2015 19:31 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v7 1/

Re: [ovs-dev] [PATCH] ofproto-dpif: Avoid creating OpenFlow ports for duplicate tunnels.

2015-05-27 Thread Ben Pfaff
Wow, thanks! I added a Tested-by for you also, and I'll apply this to master in a minute. On Wed, May 27, 2015 at 09:17:23AM -0700, Alex Wang wrote: > Tested, > > > Acked-by: Alex Wang > > On Tue, May 26, 2015 at 6:48 PM, Ben Pfaff wrote: > > > Until now, when two tunnels had an identical c

[ovs-dev] [PATCH v8 3/3] datapath-Windows: document OVS tunnel filter callout

2015-05-27 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju --- v8: No changes from previous version. --- datapath-windows/ovsext/TunnelFilter.c | 225 - 1 file changed, 221 insertions(+), 4 deletions(-) diff --git a/datapath-windows/ovsext/TunnelFilter.c b/datapath-win

[ovs-dev] [PATCH v8 2/3] datapath-windows: Support for multiple VXLAN tunnels

2015-05-27 Thread Sorin Vinturis
At the moment the OVS extension supports only one VXLAN tunnel that is cached in the extension switch context. Replaced the latter cached pointer with an array list that contains all VXLAN tunnel vports. Signed-off-by: Sorin Vinturis Reported-by: Alin Gabriel Serdean Reported-at: https://github.

[ovs-dev] [PATCH v8 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Sorin Vinturis
The kernel datapath supports only port 4789 for VXLAN tunnel creation. Added support in order to allow for the VXLAN tunnel port to be configurable to any port number set by the userspace. The patch also checks to see if an existing WFP filter, for the necessary UDP tunnel port, is already created

[ovs-dev] [PATCH v8 0/3] datapath-windows: Multiple VXLAN tunnel support

2015-05-27 Thread Sorin Vinturis
This patch series adds support for custom VXLAN tunnel port and for multiple VXLAN tunnels. Sorin Vinturis (3): [PATCH v8 1/3] datapath-windows: Support for custom VXLAN tunnel port [PATCH v8 2/3] datapath-windows: Support for multiple VXLAN tunnels [PATCH v8 3/3] datapath-Windows: document

Re: [ovs-dev] [PATCH v7 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Ben Pfaff
Hi Sorin, I'd like to apply this but I get a patch failure: Applying: datapath-windows: Support for custom VXLAN tunnel port /home/blp/nicira/ovs/.git/rebase-apply/patch:917: trailing whitespace. /home/blp/nicira/ovs/.git/rebase-apply/patch:1957: trailing whitespace. NTSTATUS OvsR

Re: [ovs-dev] [PATCH v2] ovs_threads: Avoid running pthread destructors from main thread exit.

2015-05-27 Thread Ben Pfaff
On Wed, Apr 22, 2015 at 12:20:23PM -0700, Gurucharan Shetty wrote: > Windows uses pthreads-win32 library to provide the Linux pthread > functionality. It is observed that when the main thread calls > a pthread destructor after it exits, undefined behavior is seen > (e.g., junk values in data, causi

Re: [ovs-dev] [PATCH] ofproto-dpif: Avoid creating OpenFlow ports for duplicate tunnels.

2015-05-27 Thread Alex Wang
Tested, Acked-by: Alex Wang On Tue, May 26, 2015 at 6:48 PM, Ben Pfaff wrote: > Until now, when two tunnels had an identical configuration, both of them > were assigned OpenFlow ports, but only one of those OpenFlow ports was > functional. With this commit, only one of the two (or more) iden

Re: [ovs-dev] [PATCH v7 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Nithin Raju
> On May 27, 2015, at 9:08 AM, Sorin Vinturis > wrote: > > The kernel datapath supports only port 4789 for VXLAN tunnel creation. > Added support in order to allow for the VXLAN tunnel port to be > configurable to any port number set by the userspace. > > The patch also checks to see if an exis

[ovs-dev] [PATCH v2] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation

2015-05-27 Thread Eitan Eliahu
This change include an initial implementable of STT. The following should be added: [1] Checksum offload (SW and HW) [2] LSO (SW and HW) [3] IP layer WFP callout for IP segments Testing: link layer connection through ping works. File transfer. Signed-off-by: Eitan Eliahu Co-authored-by: Saurabh

Re: [ovs-dev] [PATCH] rhel: add buildrequires for procps-ng

2015-05-27 Thread Ben Pfaff
[getting back from a month of craziness] On Mon, Apr 27, 2015 at 11:00:14PM -0300, Flavio Leitner wrote: > The testsuite is enabled by default and uses some of > the tools provided by procps-ng. > > Signed-off-by: Flavio Leitner Applied, thanks! Please let me know if you want this or the other

Re: [ovs-dev] [PATCH] rhel: fix rundir ownership

2015-05-27 Thread Ben Pfaff
[getting back from a month of craziness] On Mon, Apr 27, 2015 at 11:01:09PM -0300, Flavio Leitner wrote: > Although the ovs-ctl/ovs-lib takes care of creating the rundir, > it is correct to let the systemd manages the directory and let > the rpm know about the ownership too. > > Signed-off-by: Fl

Re: [ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Nithin Raju
> On May 27, 2015, at 9:06 AM, Sorin Vinturis > wrote: > > Nithin, > > I will address your comment in the next version of this patch. Sure. > Regarding the duplicate vport delete request, I have not found a way to > generate such request from userspace. When I use 'ovs-vsctl' application to

[ovs-dev] [PATCH v7 2/3] datapath-windows: Support for multiple VXLAN tunnels

2015-05-27 Thread Sorin Vinturis
At the moment the OVS extension supports only one VXLAN tunnel that is cached in the extension switch context. Replaced the latter cached pointer with an array list that contains all VXLAN tunnel vports. Signed-off-by: Sorin Vinturis Reported-by: Alin Gabriel Serdean Reported-at: https://github.

[ovs-dev] [PATCH v7 3/3] datapath-Windows: document OVS tunnel filter callout

2015-05-27 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju --- v7: No changes from previous version. --- datapath-windows/ovsext/TunnelFilter.c | 225 - 1 file changed, 221 insertions(+), 4 deletions(-) diff --git a/datapath-windows/ovsext/TunnelFilter.c b/datapath-win

[ovs-dev] [PATCH v7 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Sorin Vinturis
The kernel datapath supports only port 4789 for VXLAN tunnel creation. Added support in order to allow for the VXLAN tunnel port to be configurable to any port number set by the userspace. The patch also checks to see if an existing WFP filter, for the necessary UDP tunnel port, is already created

[ovs-dev] [PATCH v7 0/3] datapath-windows: Multiple VXLAN tunnel support

2015-05-27 Thread Sorin Vinturis
This patch series adds support for custom VXLAN tunnel port and for multiple VXLAN tunnels. Sorin Vinturis (3): [PATCH v7 1/3] datapath-windows: Support for custom VXLAN tunnel port [PATCH v7 2/3] datapath-windows: Support for multiple VXLAN tunnels [PATCH v7 3/3] datapath-Windows: document

Re: [ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Sorin Vinturis
Nithin, I will address your comment in the next version of this patch. Regarding the duplicate vport delete request, I have not found a way to generate such request from userspace. When I use 'ovs-vsctl' application to send a second delete request for a VXLAN interface, the app outputs an error

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-27 Thread David Miller
From: Flavio Leitner Date: Wed, 27 May 2015 10:24:14 -0300 > On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote: >> On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: >> > OVS interface for generic networking device operation looks odd. have >> > you considered adding new device ioct

Re: [ovs-dev] [PATCH] datapath-windows: Removed memory barrier and master lock

2015-05-27 Thread Ben Pfaff
On Tue, May 12, 2015 at 06:40:42AM +, Sorin Vinturis wrote: > There is no need to enforce Netlink serialization on transactions > sent from userspace. The access to the driver's shared resources > is synchronized anyway. Thus I have removed the master lock. > > I also removed the memory barrie

Re: [ovs-dev] [PATCH 1/2] Increase prerequisite from Python 2.4 to Python 2.7.

2015-05-27 Thread Ben Pfaff
On Wed, May 27, 2015 at 12:11:55AM -0400, Russell Bryant wrote: > On 05/26/2015 10:14 PM, Ben Pfaff wrote: > > On Tue, May 26, 2015 at 10:31:57AM -0400, Russell Bryant wrote: > >> On 05/21/2015 10:23 PM, Andy Hill wrote: > As a consequence, this requires dropping support for old versions of >

Re: [ovs-dev] [PATCH] datapath: do not add vlan_hwaccel_push_inside() for kernel >= 3.18.13

2015-05-27 Thread Ben Pfaff
On Wed, May 27, 2015 at 02:05:46PM +0900, Simon Horman wrote: > On Tue, May 26, 2015 at 04:59:50PM -0700, Ben Pfaff wrote: > > From: Hauke Mehrtens > > > > The vlan_hwaccel_push_inside() function was backported in this commit > > to kernel 3.18.13: > > > > commit a67e2e88342accd49587d9bad72f6dab

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-27 Thread Flavio Leitner
On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote: > On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: > > OVS interface for generic networking device operation looks odd. have > > you considered adding new device ioctl to do this? > > New ioctls for networking configuration are gen

Re: [ovs-dev] [PATCH] utilities: Add new pipeline generator script.

2015-05-27 Thread Gray, Mark D
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ethan > Jackson > Sent: Sunday, April 26, 2015 11:23 PM > To: Ben Pfaff > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] utilities: Add new pipeline generator script. This is useful and I think w

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-27 Thread Jiri Benc
On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: > OVS interface for generic networking device operation looks odd. have > you considered adding new device ioctl to do this? New ioctls for networking configuration are generally not allowed. The preferred way to configure networking is netl

Re: [ovs-dev] [PATCH RFC 00/13] IPv6 tunneling

2015-05-27 Thread Jiri Benc
On Tue, 26 May 2015 19:20:10 -0700, Ben Pfaff wrote: > Thanks for doing this! I guess that I will review at least some of the > userspace changes. Do you think there is value in that before the > kernel changes have been reviewed? Yes, it is. I have more concerns about the user space part than t

[ovs-dev] [PATCH v2] ovs-vswitchd: Update documentation

2015-05-27 Thread Mijo Safradin
Commit 7a6cf343a410d77e05ebd7bf5b5ade52803879ae raised the MAXFD limit from 7500 to 65535. Signed-off-by: Mijo Safradin --- vswitchd/ovs-vswitchd.8.in |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/vswitchd/ovs-vswitchd.8.in b/vswitchd/ovs-vswitchd.8.in index b9

Re: [ovs-dev] [PATCH] ovs-vswitchd: Update documentation

2015-05-27 Thread Mijo Safradin
On Tue, 26 May 2015, Ben Pfaff wrote: -\fBovs\-vswitchd\fR started through \fBovs\-ctl\fR(8) provides a limit of 7500 +\fBovs\-vswitchd\fR started through \fBovs\-ctl\fR(8) provides a limit of 65535 file descriptors. The limits on the number of bridges and ports is decided by the availabili

Re: [ovs-dev] FW: performance issue with ovs + dpdk2.0 with vhost

2015-05-27 Thread Gray, Mark D
> -Original Message- > From: Flavio Leitner [mailto:f...@sysclose.org] > Sent: Tuesday, May 26, 2015 12:34 PM > To: Rao, Ravi > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] FW: performance issue with ovs + dpdk2.0 with vhost > > On Sun, May 24, 2015 at 08:55:59AM -0500, Ravi Rao wrote: