Re: [ovs-dev] [PATCH] datapath: Account for "udptunnels: Call handle_offloads after inserting vlan tag."

2015-04-09 Thread Jesse Gross
On Thu, Apr 9, 2015 at 2:29 PM, Pravin Shelar wrote: > On Thu, Apr 9, 2015 at 12:22 PM, Jesse Gross wrote: >> Upstream commit: >> udptunnels: Call handle_offloads after inserting vlan tag. >> >> handle_offloads() calls skb_reset_inner_headers() to store >> the layer pointers to the en

Re: [ovs-dev] [PATCH] netdev-dpdk: Change eth rx burst size.

2015-04-09 Thread Traynor, Kevin
> -Original Message- > From: Pravin Shelar [mailto:pshe...@nicira.com] > Sent: Thursday, April 9, 2015 9:10 PM > To: Traynor, Kevin; Daniele Di Proietto > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: Change eth rx burst size. > > On Wed, Apr 8, 2015 at 8:43 AM, Ke

Re: [ovs-dev] [PATCH 1/2] tunneling: Convert tunnel push/pop functions to act on single packets.

2015-04-09 Thread Jesse Gross
On Thu, Apr 9, 2015 at 1:02 PM, Pravin Shelar wrote: > On Wed, Apr 8, 2015 at 1:19 PM, Jesse Gross wrote: >> The userspace tunneling API for pushing and popping tunnel headers >> is currently based on processing batches of packets. However, there >> is no obvious way to take advantage of batching

Re: [ovs-dev] [PATCH] datapath: Account for "udptunnels: Call handle_offloads after inserting vlan tag."

2015-04-09 Thread Pravin Shelar
On Thu, Apr 9, 2015 at 12:22 PM, Jesse Gross wrote: > Upstream commit: > udptunnels: Call handle_offloads after inserting vlan tag. > > handle_offloads() calls skb_reset_inner_headers() to store > the layer pointers to the encapsulated packet. However, we > currently push the vlag

Re: [ovs-dev] [PATCH 2/2] INSTALL.Windows: Add documentation about Windows services.

2015-04-09 Thread Gurucharan Shetty
> Looks like you have the steps to stop services covered. In indicated in the > previous review that it might be good to mention the appctl command. Not sure > if they are necessary now :) > > patch looks good. > > Acked-by: Nithin Raju Thank you. A quick clarification. When we run the daemons w

Re: [ovs-dev] [PATCH 1/2] INSTALL.Windows: Add details about local build and installation.

2015-04-09 Thread Gurucharan Shetty
> Looks good. The only thing I’d add is the location of the log file, and also > the steps to stop the daemon(s) using app-ctl. This can happen in a > subsequent commit if you wish. > > Acked-by: Nithin Raju Thanks. I will add the following diff and push it: diff --git a/INSTALL.Windows.md b/I

Re: [ovs-dev] [PATCH v6 2/6] dpif-netdev: Make datapath and flow stats atomic.

2015-04-09 Thread Ethan Jackson
Acked-by: Ethan Jackson On Tue, Apr 7, 2015 at 12:02 PM, Daniele Di Proietto wrote: > A read operation from a non atomic shared value (without external > locking) can return incorrect values. Using the atomic semantics > prevents this from happening. > > However: > * No memory barriers are use

Re: [ovs-dev] Pay less for the quality! Be a strong man with our store.

2015-04-09 Thread Harold Elmers
Make a step forward to being the man of her dreams! http://zzb.bz/KiWcx ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] netdev-dpdk: Change eth rx burst size.

2015-04-09 Thread Pravin Shelar
On Wed, Apr 8, 2015 at 8:43 AM, Kevin Traynor wrote: > Change eth rx burst size from 192 to 32. This significantly > improves performance for packets that will be forwarded > through dpdkvhost ports, as the max dpdkvhost tx burst > size (32) will not be exceeded. There are negligible > effects in

Re: [ovs-dev] [PATCH 2/2] tunneling: Invalid packets should be cleared.

2015-04-09 Thread Pravin Shelar
On Wed, Apr 8, 2015 at 1:19 PM, Jesse Gross wrote: > If we receive a packet with an invalid tunnel header, we > should drop the packet without further processing. Currently > we do this by removing any parsed tunnel metadata. However, > this is not sufficient to stop processing - this only results

Re: [ovs-dev] [PATCH 1/2] tunneling: Convert tunnel push/pop functions to act on single packets.

2015-04-09 Thread Pravin Shelar
On Wed, Apr 8, 2015 at 1:19 PM, Jesse Gross wrote: > The userspace tunneling API for pushing and popping tunnel headers > is currently based on processing batches of packets. However, there > is no obvious way to take advantage of batching for these operations > and so each tunnel operation has a

Re: [ovs-dev] [PATCH 1/2] ovs-sandbox: Use new ovn-sb database name.

2015-04-09 Thread Justin Pettit
> On Apr 9, 2015, at 8:43 AM, Russell Bryant wrote: > > On 04/09/2015 03:48 AM, Justin Pettit wrote: >> Commit ec78987 (ovn: Rename "ovn" database to "ovn-sb".) changed the >> name of the database, but didn't update ovs-sandbox to use this new >> name. >> >> Signed-off-by: Justin Pettit > > T

Re: [ovs-dev] [ovn 2/2] ovn-nbd: Add basic OVSDB transaction comments.

2015-04-09 Thread Justin Pettit
> On Apr 9, 2015, at 8:50 AM, Russell Bryant wrote: > > On 04/09/2015 03:49 AM, Justin Pettit wrote: >> These comments aren't particularly detailed, but it's helpful to at >> least see what is modifying the database contents. >> >> Signed-off-by: Justin Pettit > > I was trying to think if the

Re: [ovs-dev] [ovn 1/2] ovn-nbctl: Add OVSDB transaction comment.

2015-04-09 Thread Justin Pettit
> On Apr 9, 2015, at 8:48 AM, Russell Bryant wrote: > > On 04/09/2015 03:49 AM, Justin Pettit wrote: >> Add a comment to the transaction that contains the command that was >> executed to aid looking at the transaction log. >> >> Signed-off-by: Justin Pettit >> --- >> ovn/ovn-nbctl.c |5 +++

[ovs-dev] [PATCH] datapath: Account for "udptunnels: Call handle_offloads after inserting vlan tag."

2015-04-09 Thread Jesse Gross
Upstream commit: udptunnels: Call handle_offloads after inserting vlan tag. handle_offloads() calls skb_reset_inner_headers() to store the layer pointers to the encapsulated packet. However, we currently push the vlag tag (if there is one) onto the packet afterwards. This chang

Re: [ovs-dev] [PATCH ovn v3 5/5] expr: Support string fields in expr_to_matches().

2015-04-09 Thread Russell Bryant
On 04/01/2015 12:52 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > ovn/expr.c | 115 > ++- > ovn/expr.h | 6 ++- > tests/test-ovn.c | 6 +-- > 3 files changed, 95 insertions(+), 32 deletions(-) > diff --git a/tests/tes

Re: [ovs-dev] [PATCH ovn v3 0/5] Implement matching expressions for OVN.

2015-04-09 Thread Russell Bryant
On 04/01/2015 12:52 AM, Ben Pfaff wrote: > expr: New module for Boolean expressions on fields, for use in OVN. For some reason I didn't get patch 4/5, so I'm just replying here for this patch. > [PATCH ovn v3 4/5] expr: New module for Boolean expressions on fields, for > use in OVN. > > Known

Re: [ovs-dev] [PATCH 2/2] INSTALL.Windows: Add documentation about Windows services.

2015-04-09 Thread Nithin Raju
> On Apr 9, 2015, at 8:56 AM, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > --- > +* To stop and delete the services, run: > + > + % sc stop ovs-vswitchd > + % sc stop ovsdb-server > + % sc delete ovs-vswitchd > + % sc delete ovsdb-server Looks like you have the steps to s

Re: [ovs-dev] [PATCH 1/2] INSTALL.Windows: Add details about local build and installation.

2015-04-09 Thread Nithin Raju
> On Apr 9, 2015, at 8:56 AM, Gurucharan Shetty wrote: > > This commits adds the following. > > * Clearly callout to set pthread-win32's dll path in $PATH > * Details about running parallel make and parallel unit tests. > * Installing Open vSwitch locally via 'make install' > * Update the steps

[ovs-dev] [PATCH v4] datapath: Update inner offsets when expanding headroom.

2015-04-09 Thread Jesse Gross
skb protocol offsets are relative to the beginning of the buffer and therefore must be updated if the buffer size is expanded. Kernel functions do this automatically for existing fields but obviously not for anything that we backport. This introduces a wrapper for pskb_expand_head() to update the i

[ovs-dev] [PATCH v3] datapath: Add Stateless TCP Tunneling protocol.

2015-04-09 Thread Pravin B Shelar
The Stateless TCP Tunnel (STT) protocol encapsulates traffic in IPv4/TCP packets. STT uses TCP segmentation offload available in most of NIC. On packet xmit STT driver appends STT header along with TCP header to the packet. For GSO packet GSO parameters are set according to tunnel configuration and

Re: [ovs-dev] [PATCH] testsuite: ofproto-dpif: fix test names

2015-04-09 Thread Joe Stringer
On 8 April 2015 at 10:30, Flavio Leitner wrote: > Some tests were not included when running the > make TESTSUITEFLAGS="-k ofproto-dpif" check because > the test name was out of the expected pattern. > > Signed-off-by: Flavio Leitner Thanks, applied. __

[ovs-dev] [PATCH 1/2] INSTALL.Windows: Add details about local build and installation.

2015-04-09 Thread Gurucharan Shetty
This commits adds the following. * Clearly callout to set pthread-win32's dll path in $PATH * Details about running parallel make and parallel unit tests. * Installing Open vSwitch locally via 'make install' * Update the steps to run the user processes by relying on the previous 'make install'.

[ovs-dev] [PATCH 2/2] INSTALL.Windows: Add documentation about Windows services.

2015-04-09 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- INSTALL.Windows.md | 51 +++ 1 file changed, 51 insertions(+) diff --git a/INSTALL.Windows.md b/INSTALL.Windows.md index 1fae4f8..2521cac 100644 --- a/INSTALL.Windows.md +++ b/INSTALL.Windows.md @@ -406,6 +406

Re: [ovs-dev] [ovn 2/2] ovn-nbd: Add basic OVSDB transaction comments.

2015-04-09 Thread Russell Bryant
On 04/09/2015 03:49 AM, Justin Pettit wrote: > These comments aren't particularly detailed, but it's helpful to at > least see what is modifying the database contents. > > Signed-off-by: Justin Pettit I was trying to think if there were any cases where this code would get hit, but the resulting

Re: [ovs-dev] [ovn 1/2] ovn-nbctl: Add OVSDB transaction comment.

2015-04-09 Thread Russell Bryant
On 04/09/2015 03:49 AM, Justin Pettit wrote: > Add a comment to the transaction that contains the command that was > executed to aid looking at the transaction log. > > Signed-off-by: Justin Pettit > --- > ovn/ovn-nbctl.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff

Re: [ovs-dev] [PATCH 2/2] ovn: Update comments related to "ovn" to "ovn-sb" switch.

2015-04-09 Thread Russell Bryant
On 04/09/2015 03:48 AM, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] ovs-sandbox: Use new ovn-sb database name.

2015-04-09 Thread Russell Bryant
On 04/09/2015 03:48 AM, Justin Pettit wrote: > Commit ec78987 (ovn: Rename "ovn" database to "ovn-sb".) changed the > name of the database, but didn't update ovs-sandbox to use this new > name. > > Signed-off-by: Justin Pettit Thanks for fixing this. I should have thought about it when I review

Re: [ovs-dev] [PATCH v2] INSTALL.Windows: update documentation

2015-04-09 Thread Gurucharan Shetty
On Wed, Apr 8, 2015 at 4:41 PM, Nithin Raju wrote: > The documentation to run the executables has fallen behind quite > a bit. In this patch, we make a few updates. There's more to come. > > The patch assumes the user has not run 'make install' or does not > have access to an installer. > > Signed

Re: [ovs-dev] Want to be thin

2015-04-09 Thread Bernadette Charlson
Do you want to have a slender frame Get slim and look great. http://catcut.net/yH3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Afraid of awkward situations? New ED meds won't let you down!

2015-04-09 Thread Lorna Fulton
Your erection is something that should be really cherished! Be grateful for what you have right now! http://zzb.bz/tY1I7 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Get your men's source of energy and power!

2015-04-09 Thread Johnny Bosworth
Feel free to enlarge your penis and be happy! http://zzb.bz/G3pqA ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] datapath-windows: extension fails to be enabled

2015-04-09 Thread Sorin Vinturis
The extension failed to be activated during booting due to the failure to initialize tunnel filter. This happened because the Base Filtering Engine (BFE) is not started and no session to the engine could be acquired. The solution for this was to registered a BFE notification callback that is calle

Re: [ovs-dev] Are you still interested

2015-04-09 Thread Victor Miller
This is what I wanted to show you My arms are much thinner. http://catcut.net/MH3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Afraid of awkward situations? New ED meds won't let you down!

2015-04-09 Thread Sharon Babcock
Erectile dysfunction was a complete surprise for me but now I almost got used to it, unfortunately! http://zzb.bz/BTCJA ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Fwd: unexpected syntax between ofpraw types

2015-04-09 Thread Kuljaree Tantayakul
-- Forwarded message -- From: Kuljaree Tantayakul Date: Fri, Apr 3, 2015 at 5:15 PM Subject: unexpected syntax between ofpraw types To: disc...@openvswitch.org Hello. I'm a new developer. I read in FAQ about how to develop the new openflow message from this link: http://git.openv

[ovs-dev] [ovn v2] ovn: Introduce ovn-controller.

2015-04-09 Thread Justin Pettit
Add new ovn-controller daemon that runs locally on transport nodes. This initial version registers itself in the Chassis table and registers logical ports to the appropriate rows in the Bindings table. Signed-off-by: Justin Pettit --- v1->v2: Feedback from Ben. --- Makefile.am

[ovs-dev] [ovn 2/2] ovn-nbd: Add basic OVSDB transaction comments.

2015-04-09 Thread Justin Pettit
These comments aren't particularly detailed, but it's helpful to at least see what is modifying the database contents. Signed-off-by: Justin Pettit --- ovn/ovn-nbd.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ovn/ovn-nbd.c b/ovn/ovn-nbd.c index 28bc000..54cd3c8 1

[ovs-dev] [ovn 1/2] ovn-nbctl: Add OVSDB transaction comment.

2015-04-09 Thread Justin Pettit
Add a comment to the transaction that contains the command that was executed to aid looking at the transaction log. Signed-off-by: Justin Pettit --- ovn/ovn-nbctl.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/ovn/ovn-nbctl.c b/ovn/ovn-nbctl.c index 3178105..17e52

[ovs-dev] [PATCH 2/2] ovn: Update comments related to "ovn" to "ovn-sb" switch.

2015-04-09 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ovn/ovn-architecture.7.xml |7 --- ovn/ovn-nbd.c | 18 +- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml index 57e3042..c7a4f37 100644 --- a/ovn/ovn-ar

[ovs-dev] [PATCH 1/2] ovs-sandbox: Use new ovn-sb database name.

2015-04-09 Thread Justin Pettit
Commit ec78987 (ovn: Rename "ovn" database to "ovn-sb".) changed the name of the database, but didn't update ovs-sandbox to use this new name. Signed-off-by: Justin Pettit --- tutorial/ovs-sandbox | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tutor

Re: [ovs-dev] [PATCH] ovn: Introduce ovn-controller.

2015-04-09 Thread Justin Pettit
> On Apr 6, 2015, at 4:00 PM, Ben Pfaff wrote: > > On Mon, Apr 06, 2015 at 03:14:59PM -0700, Justin Pettit wrote: >> Add new ovn-controller daemon that runs locally on transport nodes. >> This initial version registers itself in the Chassis table and registers >> logical ports to the appropriate

Re: [ovs-dev] [PATCH] DPDK: add support for v2.0.0

2015-04-09 Thread Panu Matilainen
On 04/08/2015 06:34 PM, Mark Kavanagh wrote: Update relevant artifacts to add support for DPDK v2.0.0 - INSTALL.DPDK.md - travis build script - netdev-dpdk: fix build with unified offload types in DPDK v2.0.0 Note that this breaks compatibility with DPDK v1.8.0 Signed-off-by: Mark Kavanag