> On Apr 9, 2015, at 8:50 AM, Russell Bryant <rbry...@redhat.com> wrote: > > On 04/09/2015 03:49 AM, Justin Pettit wrote: >> These comments aren't particularly detailed, but it's helpful to at >> least see what is modifying the database contents. >> >> Signed-off-by: Justin Pettit <jpet...@nicira.com> > > I was trying to think if there were any cases where this code would get > hit, but the resulting transaction would be empty other than this added > comment, but I can't think of any. > > I can think of some cases right now, but they're just things that > haven't been implemented yet, so I think it's OK to ignore them. > > Acked-by: Russell Bryant <rbry...@redhat.com>
I definitely think there's room for improvement, but at least having some attribution to changes in the database is nice when debugging. Thanks for the review. I pushed the change with your ack. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
