[ovs-dev] Dev@openvswitch.org

2015-03-13 Thread Mail Delivery Subsystem
2¦²OEùÆRÐÇä<¬?Âê»ïV tÙêƒ4šÊ³t(])1ù92>û¨ÈÀù®v£ðÜ% 1XA²Œ¾ØõN3õÀB 4‚  ^Á]AžOæò“Ò\œb¾È>™%°Ázþ`³ ˜6¿èéÒÃoÓÅ´—1ŸUîuéOP¦™C‰1‘˜Fֆš¼x®|P’†VlzãhI)‡†Qm©–¥es†Ä$Œ7Ÿj%¹G0¯pÍ'^`²:~°>Á{ÍI Cãá;¾ëF¹¥$Ê\Dý.‚rXȉÞR4ÂÛ¥WÇ[–%F?Ÿ³S³I.?[® ^Šöë°>Ÿû(Æ*¡×aÂ^8oÔ1÷”Ÿb'ç„-òí¤•-³$ˆÃÌ/ãºUÊWÜðÉZH«µµWñè÷CIGç/`ÊςÕÕÄþÀ:-X\

Re: [ovs-dev] [PATCH] Enable getopt function.

2015-03-13 Thread Ben Pfaff
On Fri, Mar 13, 2015 at 09:16:29PM -0700, Linda Sun wrote: > Define REPLACE_GETOPT to use our definition of getopt. > > Signed-off-by: Linda Sun Presumably this fixes some visible bug. What is it? Thanks, Ben. ___ dev mailing list dev@openvswitch.or

[ovs-dev] [PATCH] Enable getopt function.

2015-03-13 Thread Linda Sun
Define REPLACE_GETOPT to use our definition of getopt. Signed-off-by: Linda Sun --- include/windows/getopt.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/windows/getopt.h b/include/windows/getopt.h index 9b526ff..e9e8bfb 100644 --- a/include/windows/getopt.h +++ b/include/window

Re: [ovs-dev] Are you one? Well I hope that you are.

2015-03-13 Thread Roberta Roger
Hey Macho? Are you one? Are you brave enough to protect your love in any situation? Will you do anything in life for her? Are you ready to love a girl till death separates you? Well, I am in search of some macho and gentleman like that. I am Victoriya, a Russian girl, and I am from a university

Re: [ovs-dev] [RFC bashcomp] ovs-vsctl-bashcomp: Avoid setting the COMP_WORDBREAKS.

2015-03-13 Thread Alex Wang
Hey Ben, Peter, I did some hack to avoid setting the $COMP_WORDBREAKS (based on this link http://stackoverflow.com/questions/10528695/how-to-reset-comp-wordbreaks-without-effecting-other-completion-script ). This patch breaks the unittest. Want to hear some feedback before fixing the tests. Tha

[ovs-dev] [RFC bashcomp] ovs-vsctl-bashcomp: Avoid setting the COMP_WORDBREAKS.

2015-03-13 Thread Alex Wang
Modifying $COMP_WORDBREAKS in completion script is not the recommended as it is a global variable and the modification could affect the behavior of other completion scripts. As a workaround, this commit uses the _get_comp_words_by_ref which allows user to exclude characters out of $COMP_WORDBREAKS

[ovs-dev] [PATCH v3 8/8] ofproto-dpif-xlate: Fix MPLS recirculation.

2015-03-13 Thread Jarno Rajahalme
Prior to this patch MPLS recirculation was not performed on a table lookup following an MPLS_POP action. This patch refactors MPLS recirculation triggering so that a table action can be re-done after recirculation if that table action follows an MPLS_POP action. Recirculation for a patch port tra

[ovs-dev] [PATCH v3 6/8] Sanitize remaining recirculation parameters.

2015-03-13 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 0e28c77..9dfe77d 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofprot

[ovs-dev] [PATCH v3 5/8] ofproto-dpif-xlate: Do not exit if peer bridge exits.

2015-03-13 Thread Jarno Rajahalme
The fact that the peer bridge exits (for any reason) does not mean that the original bridge should exit. Specifically, if the peer bridge recirculates (which typically modifies the packet), the original bridge must continue processing with the original, not the recirculated packet! Signed-off-by:

[ovs-dev] [PATCH v3 4/8] ofproto-dpif-xlate: Preserve and execute action_set on a patch port.

2015-03-13 Thread Jarno Rajahalme
Prevent a peer bridge from seeing or modifying the action_set of the first bridge. Also execute the accumulated action set on the peer bridge, if any. Found by inspection. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 15 ++- 1 file changed, 14 insertions(+),

[ovs-dev] [PATCH v3 3/8] ofproto-dpif-xlate: Preserve stack accross patch port.

2015-03-13 Thread Jarno Rajahalme
Prevent a peer patch port bridge from popping data off or pushing data to the stack of the first bridge. Found by inspection. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c |5 + 1 file changed, 5 insertions(+) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofprot

[ovs-dev] [PATCH v3 2/8] Test stack accross patch port.

2015-03-13 Thread Jarno Rajahalme
This added test should fail. Next patch fixes OVS to pass this test. Signed-off-by: Jarno Rajahalme --- lib/nx-match.c|2 +- tests/ofproto-dpif.at | 52 + 2 files changed, 53 insertions(+), 1 deletion(-) diff --git a/lib/nx-match.c b

[ovs-dev] [PATCH v3 1/8] match: Do not skip formatting a zero dp_hash.

2015-03-13 Thread Jarno Rajahalme
The dp_hash match should be printed whenever it is being matched. We keep the old behavior for flow_format(), which is mostly used to format PACKET_IN messages. This keeps those messages tidier and avoids changing a lot of test cases. Signed-off-by: Jarno Rajahalme --- lib/flow.c|

Re: [ovs-dev] ofpact alignment problem on Windows

2015-03-13 Thread Ben Pfaff
I think that just deleting the "pad" member would fix the problem in the short-term. I don't know whether it's the fix we want long-term, since it wastes memory. On Fri, Mar 13, 2015 at 09:47:59PM +, Nithin Raju wrote: > Thanks Ben for reporting this. One of the Hyper-V developers will provid

Re: [ovs-dev] Patch adding additional QoS strategies to OVS

2015-03-13 Thread Ben Pfaff
Thanks for the additional information. I did some more experiments with your example. I posted a v2 of my patch: http://openvswitch.org/pipermail/dev/2015-March/052394.html You'll need to implement the tc_load callback now since otherwise you'll get a segfault when tc_query_qdisc() tries

Re: [ovs-dev] ofpact alignment problem on Windows

2015-03-13 Thread Nithin Raju
Thanks Ben for reporting this. One of the Hyper-V developers will provide a fix, if not for Jarno. -- Nithin > On Mar 13, 2015, at 1:57 PM, Ben Pfaff wrote: > > The appveyor build on Windows failed (see > https://urldefense.proofpoint.com/v2/url?u=https-3A__ci.appveyor.com_project_blp_ovs_buil

[ovs-dev] [PATCH v2] netdev-linux: Avoid RTM_GETQDISC bug workaround on new-enough kernels.

2015-03-13 Thread Ben Pfaff
Otherwise we can't detect classless qdiscs. This has no useful effect for the currently supported qdiscs, which all have classes, but it makes it possible to add support for new classless qdiscs. This suddenly makes netdev-linux complain about qdiscs it doesn't know about (e.g. pfifo_fast), which

[ovs-dev] ofpact alignment problem on Windows

2015-03-13 Thread Ben Pfaff
The appveyor build on Windows failed (see https://ci.appveyor.com/project/blp/ovs/build/1.0.41): c:\openvswitch\lib\ofp-actions.h(461) : error C2229: struct 'ofpact_nest' has an illegal zero-sized array c:\openvswitch\lib\ofp-actions.h(756) : error C2719: 'a': formal parameter with __de

Re: [ovs-dev] [PATCH] FAQ.md: Add a few more details on how to support a new field.

2015-03-13 Thread Ben Pfaff
On Fri, Mar 13, 2015 at 03:27:01PM +0100, Thomas Graf wrote: > On 03/04/15 at 05:33pm, Ben Pfaff wrote: > > + If you want kernel datapath support for your new field, you also > > + need to modify the kernel module under the datapath/ (the Linux > > + datapath) or datapath-windows/ directory.

[ovs-dev] [PATCH branch-2.3] ofproto: Prevent deleting flows from hidden tables.

2015-03-13 Thread Ben Pfaff
Trying to delete a hidden flow should return an "EPERM" error, but the code here allowed it instead. Reported-by: Vijaya Mohan Guvva Signed-off-by: Ben Pfaff --- This bug is not present on master, so this patch is for branch-2.3 only. AUTHORS |1 + ofproto/ofproto.c | 24 ++

Re: [ovs-dev] Some questions about DPDK+OVS

2015-03-13 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Friday, March 13, 2015 4:02 PM > To: lin > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] Some questions about DPDK+OVS > > On Fri, Mar 13, 2015 at 04:16:25PM +0800, lin wrote: > > 1.DPD

Re: [ovs-dev] [PATCH] netdev-linux: Be more careful about integer overflow in policing.

2015-03-13 Thread Ben Pfaff
On Tue, Mar 10, 2015 at 09:28:22PM -0700, Ansis Atteka wrote: > On Tue, Mar 10, 2015 at 1:37 PM, Ben Pfaff wrote: > > Otherwise the policing limits could make no sense if large rates were > > specified. > > > > Reported-by: Zhangguanghui > > Signed-off-by: Ben Pfaff > > --- > > AUTHORS

Re: [ovs-dev] [PATCH] netdev-dpdk: Silence DPDK Wbad-function-cast warning

2015-03-13 Thread Pravin Shelar
On Fri, Mar 13, 2015 at 10:23 AM, John McNamara wrote: > This patch turns off the Wbad-function-cast warning locally in netdev-dpdk.c. > This warning is output 50+ times during compilation with the --with-dpdk > config option. > > The warning is generated by including DPDK's rte_common.h header fi

Re: [ovs-dev] [PATCH] ovs-vsctl-bashcomp: Fix build failure when bash version < 4.0.

2015-03-13 Thread Alex Wang
Tested and applied to master~ Thanks, Alex Wang, On Fri, Mar 13, 2015 at 10:36 AM, Ben Pfaff wrote: > On Fri, Mar 13, 2015 at 10:34:09AM -0700, Alex Wang wrote: > > The ovs-vsctl-bashcomp script does not work properly on bash (version > > < 4.0). This commit adds test for the bash version and

Re: [ovs-dev] [PATCH] ovs-vsctl-bashcomp: Fix build failure when bash version < 4.0.

2015-03-13 Thread Ben Pfaff
On Fri, Mar 13, 2015 at 10:34:09AM -0700, Alex Wang wrote: > The ovs-vsctl-bashcomp script does not work properly on bash (version > < 4.0). This commit adds test for the bash version and avoids running > the script/test when the bash version is not supported. > > Signed-off-by: Alex Wang Acke

[ovs-dev] [PATCH] ovs-vsctl-bashcomp: Fix build failure when bash version < 4.0.

2015-03-13 Thread Alex Wang
The ovs-vsctl-bashcomp script does not work properly on bash (version < 4.0). This commit adds test for the bash version and avoids running the script/test when the bash version is not supported. Signed-off-by: Alex Wang --- tests/completion.at |6 +++--- utilities/ovs-vsctl-

[ovs-dev] [PATCH] netdev-dpdk: Silence DPDK Wbad-function-cast warning

2015-03-13 Thread John McNamara
This patch turns off the Wbad-function-cast warning locally in netdev-dpdk.c. This warning is output 50+ times during compilation with the --with-dpdk config option. The warning is generated by including DPDK's rte_common.h header file. It is a valid warning but applies to a function that isn't us

Re: [ovs-dev] [PATCH] travis: Generate new secret key for bu...@openvswitch.org

2015-03-13 Thread Thomas Graf
On 03/13/15 at 08:55am, Ben Pfaff wrote: > On Fri, Mar 13, 2015 at 03:21:06PM +0100, Thomas Graf wrote: > > > > Signed-off-by: Thomas Graf > > Thanks! > > Acked-by: Ben Pfaff Thanks, pushed. Let's see if it helps. ___ dev mailing list dev@openvswitc

Re: [ovs-dev] Some questions about DPDK+OVS

2015-03-13 Thread Ben Pfaff
On Fri, Mar 13, 2015 at 04:16:25PM +0800, lin wrote: > 1.DPDK+OVS take advantage of OVS's user space bridge to do packet > forwarding, are there any plans to support user space vxlan tunneling? Already supported, please read README-native-tunneling.md. > 2.Are there any plans to merge user space

Re: [ovs-dev] build mailing list down?

2015-03-13 Thread Ben Pfaff
On Fri, Mar 13, 2015 at 03:20:18PM +0100, Thomas Graf wrote: > On 03/05/15 at 08:11am, Ben Pfaff wrote: > > [moving to ovs-dev, hope that's OK] > > > > On Thu, Mar 05, 2015 at 03:52:42PM +, Gurucharan Shetty wrote: > > > It looks like there have been no emails for a while. > > > http://openvsw

Re: [ovs-dev] [PATCH] travis: Generate new secret key for bu...@openvswitch.org

2015-03-13 Thread Ben Pfaff
On Fri, Mar 13, 2015 at 03:21:06PM +0100, Thomas Graf wrote: > > Signed-off-by: Thomas Graf Thanks! Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Are you one?

2015-03-13 Thread Paul Erickson
Hey Macho? Are you one? Are you brave enough to protect your love in any situation? Will you do anything in life for her? Are you ready to love a girl till death separates you? Well, I am in search of some macho and gentleman like that. I am Victoriya, a Russian girl, and I am from a university

Re: [ovs-dev] [PATCH] FAQ.md: Add a few more details on how to support a new field.

2015-03-13 Thread Thomas Graf
On 03/04/15 at 05:33pm, Ben Pfaff wrote: > + If you want kernel datapath support for your new field, you also > + need to modify the kernel module under the datapath/ (the Linux > + datapath) or datapath-windows/ directory. This isn't mandatory, > + since fields understood only by userspac

Re: [ovs-dev] build mailing list down?

2015-03-13 Thread Thomas Graf
On 03/05/15 at 08:11am, Ben Pfaff wrote: > [moving to ovs-dev, hope that's OK] > > On Thu, Mar 05, 2015 at 03:52:42PM +, Gurucharan Shetty wrote: > > It looks like there have been no emails for a while. > > http://openvswitch.org/pipermail/build/ > > Hmm, looking at travis, there are definite

[ovs-dev] [PATCH] travis: Generate new secret key for bu...@openvswitch.org

2015-03-13 Thread Thomas Graf
Signed-off-by: Thomas Graf --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1838bb2..ffb9744 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,4 +25,4 @@ script: ./.travis/build.sh $OPTS notifications: email: recipients:

[ovs-dev] Blimey! I have never ever thought my penis may look like that!

2015-03-13 Thread Alexander Biggs
Blimey! I have never ever thought my penis may look like that! If you want to make your wife happy every night, our premium medication is for you! hh 99% off only this weekend! http://b1941.tabsbestusa.ru/catalog/4/ANTI-DEPRESSANT/index.html ___

[ovs-dev] Some questions about DPDK+OVS

2015-03-13 Thread lin
Hi everybody, I have some questions about DPDK+OVS: 1.DPDK+OVS take advantage of OVS's user space bridge to do packet forwarding, are there any plans to support user space vxlan tunneling? 2.Are there any plans to merge user space vhost driver into OVS mainline? Also, how about the offload featu