On Fri, Mar 13, 2015 at 10:23 AM, John McNamara <john.mcnam...@intel.com> wrote: > This patch turns off the Wbad-function-cast warning locally in netdev-dpdk.c. > This warning is output 50+ times during compilation with the --with-dpdk > config option. > > The warning is generated by including DPDK's rte_common.h header file. > It is a valid warning but applies to a function that isn't used in OVS. > > Signed-off-by: John McNamara <john.mcnam...@intel.com> > --- > lib/netdev-dpdk.h | 3 +++ > tests/dpdk/ring_client.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/lib/netdev-dpdk.h b/lib/netdev-dpdk.h > index d3840f9..7d55d46 100644 > --- a/lib/netdev-dpdk.h > +++ b/lib/netdev-dpdk.h > @@ -12,6 +12,9 @@ struct dp_packet; > > #ifdef DPDK_NETDEV > > +/* Ignore warning in DPDK includes. */ > +#pragma GCC diagnostic ignored "-Wbad-function-cast" > +
This applies to all functions that may or may not be used in OVS. This can hide real warning. So we should work on fixing these issues in upstream DPDK rather than ignoring them. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
