On Fri, Feb 20, 2015 at 08:15:37PM -0500, Russell Bryant wrote:
> On 02/20/2015 06:46 PM, Ben Pfaff wrote:
> > * Not yet scoped:
> >
> > ** Neutron plugin.
> >
> >I'd appreciate input on this.
>
> I've just started looking into this. As a start, from a high level my
> to-do thoughts are:
>
On Fri, Feb 20, 2015 at 06:23:32PM -0800, Jesse Gross wrote:
> On Fri, Feb 20, 2015 at 4:36 PM, Ben Pfaff wrote:
> > On Fri, Feb 20, 2015 at 04:03:21PM -0800, Jesse Gross wrote:
> >> On Fri, Feb 20, 2015 at 3:46 PM, Ben Pfaff wrote:
> >> > *** Tunnel encapsulation to publish.
> >> >
> >> > We
On Fri, Feb 20, 2015 at 11:18 AM, Michael Smalley
wrote:
> Reported-by: Michael J. Smalley
> Tested-by: Michael J. Smalley
> Signed-off-by: Michael J. Smalley
Thank you for the fix.
As Ben mentioned in the other email, this patch potentially introduces
2 more bugs. Both 'which' and '!' (outside
On Fri, Feb 20, 2015 at 8:23 PM, Jesse Gross wrote:
> On Fri, Feb 20, 2015 at 4:36 PM, Ben Pfaff wrote:
> > On Fri, Feb 20, 2015 at 04:03:21PM -0800, Jesse Gross wrote:
> >> On Fri, Feb 20, 2015 at 3:46 PM, Ben Pfaff wrote:
> >> > *** Tunnel encapsulation to publish.
> >> >
> >> > We can pr
On Fri, Feb 20, 2015 at 7:15 PM, Russell Bryant wrote:
> On 02/20/2015 06:46 PM, Ben Pfaff wrote:
> > * Not yet scoped:
> >
> > ** Neutron plugin.
> >
> >I'd appreciate input on this.
>
> I've just started looking into this. As a start, from a high level my
> to-do thoughts are:
>
> *** Crea
On Fri, Feb 20, 2015 at 4:36 PM, Ben Pfaff wrote:
> On Fri, Feb 20, 2015 at 04:03:21PM -0800, Jesse Gross wrote:
>> On Fri, Feb 20, 2015 at 3:46 PM, Ben Pfaff wrote:
>> > *** Tunnel encapsulation to publish.
>> >
>> > We can probably default to GRE. VXLAN is more modern but it only
>> >
On 02/20/2015 06:46 PM, Ben Pfaff wrote:
> * Not yet scoped:
>
> ** Neutron plugin.
>
>I'd appreciate input on this.
I've just started looking into this. As a start, from a high level my
to-do thoughts are:
*** Create stackforge/networking-ovn repository based on OpenStack's
cookiecutter g
On Fri, Feb 20, 2015 at 4:34 PM, Pravin Shelar wrote:
> On Fri, Feb 20, 2015 at 3:37 PM, Jesse Gross wrote:
>> There are two important GSO tunnel features that were introduced
>> after the 3.12 cutoff for our current out of tree GSO implementation:
>> * 3.16 introduced support for outer UDP chec
On Fri, Feb 20, 2015 at 04:03:21PM -0800, Jesse Gross wrote:
> On Fri, Feb 20, 2015 at 3:46 PM, Ben Pfaff wrote:
> > *** Tunnel encapsulation to publish.
> >
> > We can probably default to GRE. VXLAN is more modern but it only
> > has a 24-bit key. STT has a 64-bit key but it's not ubiqu
On Fri, Feb 20, 2015 at 3:37 PM, Jesse Gross wrote:
> There are two important GSO tunnel features that were introduced
> after the 3.12 cutoff for our current out of tree GSO implementation:
> * 3.16 introduced support for outer UDP checksums.
> * 3.18 introduced support for verifying hardware s
On Fri, Feb 20, 2015 at 3:46 PM, Ben Pfaff wrote:
> *** Tunnel encapsulation to publish.
>
> We can probably default to GRE. VXLAN is more modern but it only
> has a 24-bit key. STT has a 64-bit key but it's not ubiquitously
> available.
What does ubiquitously available mean in this
I spent a lot of my day assembling the following detailed to-do list
for OVN. It's in Emacs' outline-mode format, that is, the number of
"*"s indicates a nesting level.
I'm mostly posting this as a status report for people interested in
OVN. (But if anyone really wants to volunteer for some piec
On Fri, Feb 20, 2015 at 3:21 PM, Andy Zhou wrote:
> There is a style warning:
>
> WARNING: line over 80 characters
> #63: FILE: datapath/datapath.c:2132:
> +hlist_for_each_entry(vport, &dp->ports[i], dp_hash_node) {
>
This is fine from code reading perspective, so I kept it as it is a
There are two important GSO tunnel features that were introduced
after the 3.12 cutoff for our current out of tree GSO implementation:
* 3.16 introduced support for outer UDP checksums.
* 3.18 introduced support for verifying hardware support for protocols
other than VXLAN.
In cases where the
On Fri, Feb 20, 2015 at 3:27 PM, Pravin Shelar wrote:
> On Fri, Feb 20, 2015 at 3:17 PM, Jesse Gross wrote:
>> On Fri, Feb 20, 2015 at 2:15 PM, Pravin Shelar wrote:
>>> On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
This series backports much of the UDP tunnel infrastructure, ultimat
On Fri, Feb 20, 2015 at 3:17 PM, Jesse Gross wrote:
> On Fri, Feb 20, 2015 at 2:15 PM, Pravin Shelar wrote:
>> On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
>>> This series backports much of the UDP tunnel infrastructure, ultimately
>>> in support of syncing Geneve with upstream and provi
There is a style warning:
WARNING: line over 80 characters
#63: FILE: datapath/datapath.c:2132:
+hlist_for_each_entry(vport, &dp->ports[i], dp_hash_node) {
Otherwise, looks good.
Acked-by: Andy Zhou
On Fri, Feb 20, 2015 at 2:59 PM, Pravin B Shelar wrote:
> Open vSwitch allows movi
On Fri, Feb 20, 2015 at 2:15 PM, Pravin Shelar wrote:
> On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
>> This series backports much of the UDP tunnel infrastructure, ultimately
>> in support of syncing Geneve with upstream and providing outer UDP
>> checksum support.
>>
>> During the backp
Open vSwitch allows moving internal vport to different namespace
while still connected to the bridge. But when namespace deleted
OVS does not detach these vports, that results in dangling
pointer to netdevice which causes kernel panic as follows.
This issue is fixed by detaching all ovs ports from
Thank you!
On Fri, Feb 20, 2015 at 02:31:55PM -0800, Alex Wang wrote:
> Backported it to branch-2.3,
>
> On Fri, Feb 20, 2015 at 11:36 AM, Ben Pfaff wrote:
>
> > Thanks. I added you as coauthor and applied both patches to master.
> >
> > On Fri, Feb 20, 2015 at 11:26:12AM -0800, Alex Wang wrot
Backported it to branch-2.3,
On Fri, Feb 20, 2015 at 11:36 AM, Ben Pfaff wrote:
> Thanks. I added you as coauthor and applied both patches to master.
>
> On Fri, Feb 20, 2015 at 11:26:12AM -0800, Alex Wang wrote:
> > Sure,
> >
> > Signed-off-by: Alex Wang
> >
> > On Fri, Feb 20, 2015 at 11:17
On Fri, Feb 20, 2015 at 2:15 PM, Pravin Shelar wrote:
> On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
>> This series backports much of the UDP tunnel infrastructure, ultimately
>> in support of syncing Geneve with upstream and providing outer UDP
>> checksum support.
>>
>> During the backp
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> This series backports much of the UDP tunnel infrastructure, ultimately
> in support of syncing Geneve with upstream and providing outer UDP
> checksum support.
>
> During the backporting process, I realized that there are several
> other lurk
On Fri, Feb 20, 2015 at 1:53 PM, Pravin Shelar wrote:
> On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
>> diff --git a/datapath/linux/compat/include/net/udp_tunnel.h
>> b/datapath/linux/compat/include/net/udp_tunnel.h
>> index f25023f..16b150c 100644
>> --- a/datapath/linux/compat/include/
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> There are two important GSO tunnel features that were introduced
> after the 3.12 cutoff for our current out of tree GSO implementation:
> * 3.16 introduced support for outer UDP checksums.
> * 3.18 introduced support for verifying hardware
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> Upstream commit:
> openvswitch: Add support for checksums on UDP tunnels.
>
> Currently, it isn't possible to request checksums on the outer UDP
> header of tunnels - the TUNNEL_CSUM flag is ignored. This adds
> support for req
On 02/20/15 at 10:50am, Jesse Gross wrote:
> This series backports much of the UDP tunnel infrastructure, ultimately
> in support of syncing Geneve with upstream and providing outer UDP
> checksum support.
I reviewed the series although it's not as in-depth as I would
have liked. Still wanted to d
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> This resolves the differences between the OVS Geneve implementation
> and the upstream kernel, particularly in the area of the split
> between vport-geneve.c and the generic Geneve data plane.
>
> Signed-off-by: Jesse Gross
Acked-by: Pravin
On Fri, Feb 20, 2015 at 1:52 PM, Thomas Graf wrote:
> On 02/20/15 at 10:50am, Jesse Gross wrote:
>> Upstream commit:
>> openvswitch: Add support for checksums on UDP tunnels.
>>
>> Currently, it isn't possible to request checksums on the outer UDP
>> header of tunnels - the TUNNEL_CSUM
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> Upstream commit:
> udp: Do not require sock in udp_tunnel_xmit_skb
>
> The UDP tunnel transmit functions udp_tunnel_xmit_skb and
> udp_tunnel6_xmit_skb include a socket argument. The socket being
> passed to the functions (from
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> Upstream commit:
> vlan: introduce *vlan_hwaccel_push_inside helpers
>
> Use them to push skb->vlan_tci into the payload and avoid code
> duplication.
>
> Signed-off-by: Jiri Pirko
> Acked-by: Pravin B Shelar
> Signed
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> LISP can also take advantage of setup_udp_tunnel_sock() and
> udp_tunnel_xmit_skb() to increase code reuse.
>
> Signed-off-by: Jesse Gross
> ---
Acked-by: Pravin B Shelar
___
dev mailing list
dev@o
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> Upstream commit:
> vxlan: Refactor vxlan driver to make use of the common UDP tunnel
> functions.
>
> Simplify vxlan implementation using common UDP tunnel APIs.
>
> Signed-off-by: Andy Zhou
> Signed-off-by: David S. Miller
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> skb->inner_protocol is used by GSO and TSO for tunnels on new
> kernels. Since we are setting up packets to be handled by the
> kernel's GSO and not just our own, we need to initialize this
> field properly.
>
> Signed-off-by: Jesse Gross
Ac
On Fri, Feb 20, 2015 at 10:50 AM, Jesse Gross wrote:
> Upstream commit:
> udp-tunnel: Add a few more UDP tunnel APIs
>
> Added a few more UDP tunnel APIs that can be shared by UDP based
> tunnel protocol implementation. The main ones are highlighted below.
>
> setup_udp_tunnel_sock
On 02/20/15 at 10:50am, Jesse Gross wrote:
> Upstream commit:
> openvswitch: Add support for checksums on UDP tunnels.
>
> Currently, it isn't possible to request checksums on the outer UDP
> header of tunnels - the TUNNEL_CSUM flag is ignored. This adds
> support for requesting th
On Fri, Feb 20, 2015 at 1:39 PM, Thomas Graf wrote:
> On 02/20/15 at 10:50am, Jesse Gross wrote:
>> Upstream commit:
>> vlan: introduce *vlan_hwaccel_push_inside helpers
>>
>> Use them to push skb->vlan_tci into the payload and avoid code
>> duplication.
>>
>> Signed-off-by: Jiri P
On 02/20/15 at 10:50am, Jesse Gross wrote:
> This resolves the differences between the OVS Geneve implementation
> and the upstream kernel, particularly in the area of the split
> between vport-geneve.c and the generic Geneve data plane.
>
> Signed-off-by: Jesse Gross
Acked-by: Thomas Graf
On 02/20/15 at 10:50am, Jesse Gross wrote:
> Upstream commit:
> udp: Do not require sock in udp_tunnel_xmit_skb
>
> The UDP tunnel transmit functions udp_tunnel_xmit_skb and
> udp_tunnel6_xmit_skb include a socket argument. The socket being
> passed to the functions (from VXLAN) is
On 02/20/15 at 10:50am, Jesse Gross wrote:
> Upstream commit:
> vlan: introduce *vlan_hwaccel_push_inside helpers
>
> Use them to push skb->vlan_tci into the payload and avoid code
> duplication.
>
> Signed-off-by: Jiri Pirko
> Acked-by: Pravin B Shelar
> Signed-off-by:
On 02/20/15 at 10:50am, Jesse Gross wrote:
> LISP can also take advantage of setup_udp_tunnel_sock() and
> udp_tunnel_xmit_skb() to increase code reuse.
>
> Signed-off-by: Jesse Gross
Lori should look this over as well but it looks like a straight
forward translation to me.
Acked-by: Thomas Gra
On Fri, Feb 20, 2015 at 1:30 PM, Ben Pfaff wrote:
> On Fri, Feb 20, 2015 at 1:27 PM, Jesse Gross wrote:
>> On Fri, Feb 20, 2015 at 1:11 PM, Thomas Graf wrote:
>>> This is an extremely nice cleanup overall.
>>>
>>> On 02/20/15 at 10:50am, Jesse Gross wrote:
+#if LINUX_VERSION_CODE < KERNEL_V
On Fri, Feb 20, 2015 at 1:27 PM, Jesse Gross wrote:
> On Fri, Feb 20, 2015 at 1:11 PM, Thomas Graf wrote:
>> This is an extremely nice cleanup overall.
>>
>> On 02/20/15 at 10:50am, Jesse Gross wrote:
>>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,9,0)
>>> +#define SKB_GSO_GRE 0
>>> +#endif
>>> +
On 02/20/15 at 01:27pm, Jesse Gross wrote:
> On Fri, Feb 20, 2015 at 1:11 PM, Thomas Graf wrote:
> > This is an extremely nice cleanup overall.
> >
> > On 02/20/15 at 10:50am, Jesse Gross wrote:
> >> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,9,0)
> >> +#define SKB_GSO_GRE 0
> >> +#endif
> >> +
>
On 02/20/15 at 10:50am, Jesse Gross wrote:
> Upstream commit:
> vxlan: Refactor vxlan driver to make use of the common UDP tunnel
> functions.
>
> Simplify vxlan implementation using common UDP tunnel APIs.
>
> Signed-off-by: Andy Zhou
> Signed-off-by: David S. Miller
>
> Usin
On Fri, Feb 20, 2015 at 1:11 PM, Thomas Graf wrote:
> This is an extremely nice cleanup overall.
>
> On 02/20/15 at 10:50am, Jesse Gross wrote:
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,9,0)
>> +#define SKB_GSO_GRE 0
>> +#endif
>> +
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,16,0)
>> +#defi
Signed-off-by: Andy Zhou
---
tutorial/Tutorial.md | 3 ++-
tutorial/ovs-sandbox | 9 +++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/tutorial/Tutorial.md b/tutorial/Tutorial.md
index d9e8004..1d8bbf5 100644
--- a/tutorial/Tutorial.md
+++ b/tutorial/Tutorial.md
@@ -115,7 +
When debugging multiple programs under GDB, it will be easier to
identify xterms with the program name displayed as title. Without
this patch, xterms will have the title of "gdb", which is the first
program the xterm executes. This change is useful for the next patch.
Signed-off-by: Andy Zhou
---
On 02/20/15 at 10:50am, Jesse Gross wrote:
> skb->inner_protocol is used by GSO and TSO for tunnels on new
> kernels. Since we are setting up packets to be handled by the
> kernel's GSO and not just our own, we need to initialize this
> field properly.
>
> Signed-off-by: Jesse Gross
Acked-by: Th
On 02/20/15 at 10:50am, Jesse Gross wrote:
> Upstream commit:
> udp-tunnel: Add a few more UDP tunnel APIs
>
> Added a few more UDP tunnel APIs that can be shared by UDP based
> tunnel protocol implementation. The main ones are highlighted below.
>
> setup_udp_tunnel_sock() config
This is an extremely nice cleanup overall.
On 02/20/15 at 10:50am, Jesse Gross wrote:
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,9,0)
> +#define SKB_GSO_GRE 0
> +#endif
> +
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,16,0)
> +#define SKB_GSO_GRE_CSUM 0
> +#endif
You might as well just check wi
On Fri, Feb 20, 2015 at 09:35:49PM +0100, Thomas Graf wrote:
> On 02/20/15 at 11:16am, Ben Pfaff wrote:
> > This should keep more uses from creeping in again.
> >
> > Signed-off-by: Ben Pfaff
>
> Nice
>
> Acked-by: Thomas Graf
Thanks, applied.
___
d
On 02/20/15 at 11:16am, Ben Pfaff wrote:
> This should keep more uses from creeping in again.
>
> Signed-off-by: Ben Pfaff
Nice
Acked-by: Thomas Graf
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Pravin B Shelar
Date: Tue, 17 Feb 2015 11:23:10 -0800
> Open vSwitch allows moving internal vport to different namespace
> while still connected to the bridge. But when namespace deleted
> OVS does not detach these vports, that results in dangling
> pointer to netdevice which causes kernel
On Fri, Feb 20, 2015 at 09:28:16PM +0100, Thomas Graf wrote:
> On 02/20/15 at 11:16am, Ben Pfaff wrote:
> > diff --git a/lib/ovs-router.c b/lib/ovs-router.c
> > index 8de2e2d..bf205d6 100644
> > --- a/lib/ovs-router.c
> > +++ b/lib/ovs-router.c
> > @@ -72,7 +72,7 @@ ovs_router_lookup(ovs_be32 ip_ds
On 02/20/15 at 11:16am, Ben Pfaff wrote:
> diff --git a/lib/ovs-router.c b/lib/ovs-router.c
> index 8de2e2d..bf205d6 100644
> --- a/lib/ovs-router.c
> +++ b/lib/ovs-router.c
> @@ -72,7 +72,7 @@ ovs_router_lookup(ovs_be32 ip_dst, char output_bridge[],
> ovs_be32 *gw)
> if (cr) {
> str
On Fri, Feb 20, 2015 at 11:19:42AM -0800, Gurucharan Shetty wrote:
> While adding support to Github markup language, the sentence had
> gotten malformed.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
While adding support to Github markup language, the sentence had
gotten malformed.
Signed-off-by: Gurucharan Shetty
---
INSTALL.Docker.md |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md
index 0086a60..6bd5660 100644
--- a/INSTAL
On Fri, Feb 20, 2015 at 03:18:38PM -0500, Russell Bryant wrote:
> On 02/20/2015 02:14 PM, Ben Pfaff wrote:
> > On Fri, Feb 20, 2015 at 01:55:49PM -0500, Russell Bryant wrote:
> >> On 02/20/2015 01:42 PM, Ben Pfaff wrote:
> >>> strncpy() has a lot of pitfalls. A while back we replaced all its uses
On 02/20/2015 02:14 PM, Ben Pfaff wrote:
> On Fri, Feb 20, 2015 at 01:55:49PM -0500, Russell Bryant wrote:
>> On 02/20/2015 01:42 PM, Ben Pfaff wrote:
>>> strncpy() has a lot of pitfalls. A while back we replaced all its uses by
>>> calls to ovs_strlcpy() or ovs_strzcpy(), but some more have crept
Thanks. I added you as coauthor and applied both patches to master.
On Fri, Feb 20, 2015 at 11:26:12AM -0800, Alex Wang wrote:
> Sure,
>
> Signed-off-by: Alex Wang
>
> On Fri, Feb 20, 2015 at 11:17 AM, Ben Pfaff wrote:
>
> > On Fri, Feb 20, 2015 at 11:15:24AM -0800, Alex Wang wrote:
> > > Te
Sure,
Signed-off-by: Alex Wang
On Fri, Feb 20, 2015 at 11:17 AM, Ben Pfaff wrote:
> On Fri, Feb 20, 2015 at 11:15:24AM -0800, Alex Wang wrote:
> > Tested on Freebsd 9.3~ works fine, with the following addition:
> >
> > Acked-by: Alex Wang
> > Thx a lot for fixing~~~
>
> I'll fold that in, can
Acked-by: Alex Wang
On Fri, Feb 20, 2015 at 8:44 AM, Ben Pfaff wrote:
> This function is really of marginal utility. This commit drops it and
> makes the existing callers instead open a new pstream with the desired
> dscp.
>
> The ulterior motive here is that the set_dscp() function that actua
On Fri, Feb 20, 2015 at 11:15:24AM -0800, Alex Wang wrote:
> Tested on Freebsd 9.3~ works fine, with the following addition:
>
> Acked-by: Alex Wang
> Thx a lot for fixing~~~
I'll fold that in, can you give me a Signed-off-by?
Thanks,
Ben.
___
dev ma
Reported-by: Michael J. Smalley
Tested-by: Michael J. Smalley
Signed-off-by: Michael J. Smalley
This logic was breaking on a CentOS 6.6 box with all dependencies (ovs-vsctl,
docker, and uuidgen) installed and working. The check_command_avail function
checks to see if the commands exist by runni
From: Dennis Flynn
Signed-off-by: Ludovic Beliveau
Signed-off-by: Dennis Flynn
diff --git a/lib/bfd.c b/lib/bfd.c
index 3db1d57..490dbd0 100644
--- a/lib/bfd.c
+++ b/lib/bfd.c
@@ -515,10 +515,12 @@ bfd_unref(struct bfd *bfd) OVS_EXCLUDED(mutex)
}
}
-void
+long long int
bfd_wait(const
This should keep more uses from creeping in again.
Signed-off-by: Ben Pfaff
---
v1->v2: No change.
Makefile.am | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 0480d20..479f1af 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -244,6 +244,21 @@
strncpy() has a lot of pitfalls. A while back we replaced all its uses by
calls to ovs_strlcpy() or ovs_strzcpy(), but some more have crept in. This
commit fixes them.
Reported-by: Russell Bryant
Signed-off-by: Ben Pfaff
---
v1->v2: Use sizeof destination instead of IFNAMSIZ, in multiple place
From: Dennis Flynn
This is the final commit in the series of commits that deliver initial support
for Auto-Attach. Specifically this commit delivers auto-attach support to the
OVS bridge layer as well as the new auto-attach commands. The OVSDB schema is
modified to define the new auto-attach entr
From: Dennis Flynn
This patch sequence provides OVS support for the IETF Auto-Attach SPBM draft
standard. This standard describes a compact method of using IEEE 802.1AB Link
Layer Discovery Protocol (LLDP) together with a IEEE 802.1aq Shortest Path
Bridging (SPB) network to automatically attach n
Tested on Freebsd 9.3~ works fine, with the following addition:
Acked-by: Alex Wang
Thx a lot for fixing~~~
diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py
index 1af6474..416784e 100644
--- a/python/ovs/socket_util.py
+++ b/python/ovs/socket_util.py
@@ -213,14 +213,16 @@ def
On Fri, Feb 20, 2015 at 01:55:49PM -0500, Russell Bryant wrote:
> On 02/20/2015 01:42 PM, Ben Pfaff wrote:
> > strncpy() has a lot of pitfalls. A while back we replaced all its uses by
> > calls to ovs_strlcpy() or ovs_strzcpy(), but some more have crept in. This
> > commit fixes them.
> >
>
>
On 02/20/2015 01:42 PM, Ben Pfaff wrote:
> strncpy() has a lot of pitfalls. A while back we replaced all its uses by
> calls to ovs_strlcpy() or ovs_strzcpy(), but some more have crept in. This
> commit fixes them.
>
Great, I like this a lot more than what I did.
> @@ -110,7 +110,7 @@ ovs_rou
On Fri, Feb 20, 2015 at 9:15 AM, Jesse Gross wrote:
> On Fri, Feb 20, 2015 at 2:38 AM, Thomas Graf wrote:
>> On 02/19/15 at 04:42pm, Pravin Shelar wrote:
>>> Did you considered getting rid of USE_KERNEL_TUNNEL_API and various
>>> kernel version check. And just have one version check of 3.18 kern
This resolves the differences between the OVS Geneve implementation
and the upstream kernel, particularly in the area of the split
between vport-geneve.c and the generic Geneve data plane.
Signed-off-by: Jesse Gross
---
datapath/linux/.gitignore | 1 +
datapath/linux/Modules.m
LISP can also take advantage of setup_udp_tunnel_sock() and
udp_tunnel_xmit_skb() to increase code reuse.
Signed-off-by: Jesse Gross
---
datapath/vport-lisp.c | 101 +-
1 file changed, 26 insertions(+), 75 deletions(-)
diff --git a/datapath/vport-
Upstream commit:
udp: Do not require sock in udp_tunnel_xmit_skb
The UDP tunnel transmit functions udp_tunnel_xmit_skb and
udp_tunnel6_xmit_skb include a socket argument. The socket being
passed to the functions (from VXLAN) is a UDP created for receive
side. The only thing tha
Upstream commit:
vlan: introduce *vlan_hwaccel_push_inside helpers
Use them to push skb->vlan_tci into the payload and avoid code
duplication.
Signed-off-by: Jiri Pirko
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Upstream: 5968250c ("vlan: introduce *vlan_
Upstream commit:
openvswitch: Add support for checksums on UDP tunnels.
Currently, it isn't possible to request checksums on the outer UDP
header of tunnels - the TUNNEL_CSUM flag is ignored. This adds
support for requesting that UDP checksums be computed on transmit
and proper
This series backports much of the UDP tunnel infrastructure, ultimately
in support of syncing Geneve with upstream and providing outer UDP
checksum support.
During the backporting process, I realized that there are several
other lurking bugs that were fixed through a more complete UDP
tunnel layer
skb->inner_protocol is used by GSO and TSO for tunnels on new
kernels. Since we are setting up packets to be handled by the
kernel's GSO and not just our own, we need to initialize this
field properly.
Signed-off-by: Jesse Gross
---
datapath/linux/compat/gre.c | 2 ++
datapath/linux/
Upstream commit:
udp-tunnel: Add a few more UDP tunnel APIs
Added a few more UDP tunnel APIs that can be shared by UDP based
tunnel protocol implementation. The main ones are highlighted below.
setup_udp_tunnel_sock() configures UDP listener socket for
receiving UDP encapsulat
There are two important GSO tunnel features that were introduced
after the 3.12 cutoff for our current out of tree GSO implementation:
* 3.16 introduced support for outer UDP checksums.
* 3.18 introduced support for verifying hardware support for protocols
other than VXLAN.
In cases where the
Upstream commit:
vxlan: Refactor vxlan driver to make use of the common UDP tunnel functions.
Simplify vxlan implementation using common UDP tunnel APIs.
Signed-off-by: Andy Zhou
Signed-off-by: David S. Miller
Using the upstream functions where available also has the side effec
strncpy() has a lot of pitfalls. A while back we replaced all its uses by
calls to ovs_strlcpy() or ovs_strzcpy(), but some more have crept in. This
commit fixes them.
Reported-by: Russell Bryant
Signed-off-by: Ben Pfaff
---
lib/netdev-bsd.c | 20 ++--
lib/ovs-ro
On Fri, Feb 20, 2015 at 01:22:15PM -0500, Russell Bryant wrote:
> strncpy() has pretty annoying semantics. One bit that is odd is that
> it does not guarantee that the destination string will be null
> terminated. If no terminator is found in the first N bytes of the
> source, it just fills the d
This should keep more uses from creeping in again.
Signed-off-by: Ben Pfaff
---
Makefile.am | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 0480d20..479f1af 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -244,6 +244,21 @@ printf-check:
On Fri, Feb 20, 2015 at 01:22:14PM -0500, Russell Bryant wrote:
> init_clock begins with a memset of 0 of the full clock struct. This
> memset at the end of a single struct member just makes extra sure that
> it's set to 0, which is unnecessary.
>
> Signed-off-by: Russell Bryant
Applied, thanks
On Fri, Feb 20, 2015 at 09:10:09AM -0800, Gurucharan Shetty wrote:
> On Fri, Feb 20, 2015 at 9:01 AM, Ben Pfaff wrote:
> > The 2.3 branch has been the long-term release for a while now, but somehow
> > we forgot to update the FAQ.
> >
> > Reported-by: Kentaro Ebisawa
> > Signed-off-by: Ben Pfaff
init_clock begins with a memset of 0 of the full clock struct. This
memset at the end of a single struct member just makes extra sure that
it's set to 0, which is unnecessary.
Signed-off-by: Russell Bryant
---
lib/timeval.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/timeval.c b/lib/
strncpy() has pretty annoying semantics. One bit that is odd is that
it does not guarantee that the destination string will be null
terminated. If no terminator is found in the first N bytes of the
source, it just fills the destination buffer and doesn't terminate it.
The changes here all just s
strncpy() has pretty annoying semantics. One bit that is odd is that
it does not guarantee that the destination string will be null
terminated. If no terminator is found in the first N bytes of the
source, it just fills the destination buffer and doesn't terminate it.
The changes here are to add
strncpy() has pretty annoying semantics. One bit that is odd is that
it does not guarantee that the destination string will be null
terminated. If no terminator is found in the first N bytes of the
source, it just fills the destination buffer and doesn't terminate it.
The changes here are to add
[PATCH 1/4] Remove duplicate memset()
A trivial one-liner.
[PATCH 2/4] netdev-bsd: Fix strncpy() errors
[PATCH 3/4] userspace: Fix strncpy() errors
[PATCH 4/4] datapath: Fix strncpy() errors
These 3 are all the same thing, just split for different sections of the code.
I can't build the BSD
On Fri, Feb 20, 2015 at 12:27:13PM -0500, Michael Smalley wrote:
> Reported-by: Michael J. Smalley
> Tested-by: Michael J. Smalley
>
> This logic was breaking on a CentOS 6.6 box with all dependencies (ovs-vsctl,
> docker, and uuidgen) installed and working. The check_command_avail function
> ch
Bug reported by: Atanu Ghosh
I'll review + test this series soon~
On Fri, Feb 20, 2015 at 8:44 AM, Ben Pfaff wrote:
> The set_dscp() function, until now, tried to set the DSCP as IPv4 and as
> IPv6. This worked OK on Linux, where an ENOPROTOOPT error made it really
> clear which one was wrong,
Reported-by: Michael J. Smalley
Tested-by: Michael J. Smalley
This logic was breaking on a CentOS 6.6 box with all dependencies (ovs-vsctl,
docker, and uuidgen) installed and working. The check_command_avail function
checks to see if the commands exist by running "$command --version". This is
fl
On Fri, Feb 20, 2015 at 2:38 AM, Thomas Graf wrote:
> On 02/19/15 at 04:42pm, Pravin Shelar wrote:
>> Did you considered getting rid of USE_KERNEL_TUNNEL_API and various
>> kernel version check. And just have one version check of 3.18 kernel
>> to implement all tunnel backports?
>> At this point
On Fri, Feb 20, 2015 at 9:01 AM, Ben Pfaff wrote:
> The 2.3 branch has been the long-term release for a while now, but somehow
> we forgot to update the FAQ.
>
> Reported-by: Kentaro Ebisawa
> Signed-off-by: Ben Pfaff
Acked-by: Gurucharan Shetty
___
The 2.3 branch has been the long-term release for a while now, but somehow
we forgot to update the FAQ.
Reported-by: Kentaro Ebisawa
Signed-off-by: Ben Pfaff
---
FAQ.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/FAQ.md b/FAQ.md
index 1a44d11..c2f3c5d 100644
--- a/FAQ.md
1 - 100 of 107 matches
Mail list logo
