[ovs-dev] [PATCHv3 net-next] openvswitch: Introduce ovs_tunnel_route_lookup

2015-01-13 Thread Fan Du
Introduce ovs_tunnel_route_lookup to consolidate route lookup shared by vxlan, gre, and geneve ports. Signed-off-by: Fan Du --- Change log: v3: - Use ovs_tunnel_route_lookup for ovs_tunnel_get_egress_info - Constantify tun_key structure for gre, vxlan, geneve ports to surpress warnings. v

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Log if an OFPACT_CONJUNCTION action is executed.

2015-01-13 Thread Ben Pfaff
Thanks! Applied. On Tue, Jan 13, 2015 at 05:13:21PM -0800, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > Jarno > > On Jan 13, 2015, at 4:47 PM, Ben Pfaff wrote: > > > Conjunction actions shouldn't normally get executed, so it's worth > > logging if it happens. > > > > Suggested-b

Re: [ovs-dev] [PATCH] ovs-numa.h: Add a missing OVS_UNUSED

2015-01-13 Thread Ben Pfaff
On Wed, Jan 14, 2015 at 12:18:26PM +0900, YAMAMOTO Takashi wrote: > Suppress the following warning: > > > cc1: warnings being treated as errors > > In file included from ../lib/dpif.h:394:0, > > from ../lib/netdev.c:28: > > ../lib/ovs-numa.h: In function 'ovs_numa_dump_cores_on_nu

[ovs-dev] [PATCH] ovs-numa.h: Add a missing OVS_UNUSED

2015-01-13 Thread YAMAMOTO Takashi
Suppress the following warning: > cc1: warnings being treated as errors > In file included from ../lib/dpif.h:394:0, > from ../lib/netdev.c:28: > ../lib/ovs-numa.h: In function 'ovs_numa_dump_cores_on_numa': > ../lib/ovs-numa.h:150:33: error: unused parameter 'numa_id' The proble

Re: [ovs-dev] [PATCH 2/2] route-table-bsd: Retry logic

2015-01-13 Thread YAMAMOTO Takashi
> On Wed, Dec 17, 2014 at 08:59:57AM +0900, YAMAMOTO Takashi wrote: >> Retry routing requests as the routing socket is unreliable. >> >> Also, add some error checks and logs. >> >> Signed-off-by: YAMAMOTO Takashi > > Seems reasonable to me. > > Acked-by: Ben Pfaff thank you. applied. YAMAM

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Log if an OFPACT_CONJUNCTION action is executed.

2015-01-13 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme Jarno On Jan 13, 2015, at 4:47 PM, Ben Pfaff wrote: > Conjunction actions shouldn't normally get executed, so it's worth > logging if it happens. > > Suggested-by: Jarno Rajahalme > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c |9 - >

Re: [ovs-dev] [PATCH V2] ovs-command-completion: Autotest integration.

2015-01-13 Thread Alex Wang
Must have done something wrong, just resend the correct patch, On Tue, Jan 13, 2015 at 4:26 PM, Ben Pfaff wrote: > On Sat, Jan 03, 2015 at 10:45:44PM -0800, Alex Wang wrote: > > Upon testing the script in my FreeBSD vm, I found many of the csh bash > > syntax issues can be avoided by using the m

[ovs-dev] [PATCH V3] ovs-command-completion: Autotest integration.

2015-01-13 Thread Alex Wang
This commit integrates the unit tests defined in utilities/ovs-command-compgen-test.bash into 'make check'. The tests will be skipped if the current shell is not bash. Signed-off-by: Alex Wang --- V2->V3 - use $BASH_VERSION to check if currently running under bash. - revert the bash function to

[ovs-dev] [PATCH 1/3] autotest: refactor OVS_VSWITCHD_START MACRO

2015-01-13 Thread Andy Zhou
Refactor in preparation for the next patch. Signed-off-by: Andy Zhou --- tests/ofproto-macros.at | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index cbf0ad6..93d8a77 100644 --- a/tests/o

[ovs-dev] [PATCH 3/3] Vagrantfile: add test_ovs_kmod provision

2015-01-13 Thread Andy Zhou
Add 'test_ovs_kmod' provision. Command: # vagrant provision --provision-with=test_ovs_kmod will run "make check-kmod" in the vagrant launched VM. It turns out to be more convenient to test within as root. Switch Vagrantfile provisions to run as root user. However, vagrant can still be launch

[ovs-dev] [PATCH 2/3] autotest: add autotest framework for adding kernel module unit tests

2015-01-13 Thread Andy Zhou
This patch adds a basic infrastructure for developing and running kernel module unit tests. Currently OVS contains thousands of useful unit tests for user space programs. It is desirable to have corresponding kernel module unit tests. This commit adds basic framework for adding kernel module tests

[ovs-dev] [PATCH] ofproto-dpif-xlate: Log if an OFPACT_CONJUNCTION action is executed.

2015-01-13 Thread Ben Pfaff
Conjunction actions shouldn't normally get executed, so it's worth logging if it happens. Suggested-by: Jarno Rajahalme Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto

Re: [ovs-dev] [PATCH v3 2/2] [RFC] classifier: Add support for conjunctive matches.

2015-01-13 Thread Ben Pfaff
On Mon, Jan 12, 2015 at 10:44:19AM -0800, Jarno Rajahalme wrote: > > On Jan 11, 2015, at 1:29 PM, Ben Pfaff wrote: > > > On Fri, Jan 09, 2015 at 04:54:42PM -0800, Jarno Rajahalme wrote: > >> With the small nits below: > >> > >> Acked-by: Jarno Rajahalme > > > > Thanks. I fixed up everything

Re: [ovs-dev] [PATCH] test-atomic: Stop testing when running slow.

2015-01-13 Thread Jarno Rajahalme
On Jan 13, 2015, at 2:09 PM, Ben Pfaff wrote: > On Mon, Jan 12, 2015 at 01:27:47PM -0800, Jarno Rajahalme wrote: >> When the test suite is run on an OS with 1 core (e.g., a VM with one >> core assigned to it), some of the atomic memory model tests take a >> long time, with the effect that the te

Re: [ovs-dev] [PATCH V2] ovs-command-completion: Autotest integration.

2015-01-13 Thread Ben Pfaff
On Sat, Jan 03, 2015 at 10:45:44PM -0800, Alex Wang wrote: > Upon testing the script in my FreeBSD vm, I found many of the csh bash > syntax issues can be avoided by using the m4 macros (e.g. array definition > for 'for loop' statement). So, I'd keep the 'm4_define's and using > 'foreach'. > > Se

Re: [ovs-dev] [PATCH v4 1/1] lib: Set-field actions for IPv6 ND fields (nd_target, nd_sll, and nd_tll)

2015-01-13 Thread Ben Pfaff
On Tue, Dec 23, 2014 at 11:42:05PM +, Sharo, Randall A CIV SPAWARSYSCEN-ATLANTIC, 55200 wrote: > This patch adds set-field operations for nd_target, nd_sll, and nd_tll > fields, with and without masks, using Nicira extensions and OpenFlow 1.2 > protocol. > > This version defines protocol st

Re: [ovs-dev] [PATCH] upcall: Simplify enable_ufid debug option.

2015-01-13 Thread Ben Pfaff
On Fri, Dec 19, 2014 at 01:17:56PM -0800, Joe Stringer wrote: > We previously tracked the debug enable/disable of UFID in each udpif, > and allowed the ovs-appctl debug option to turn on UFID features even if > the datapath doesn't support it. > > This commit shifts the enable_ufid debug flag to a

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-13 Thread Ben Pfaff
On Fri, Jan 02, 2015 at 05:41:58PM +0530, Saloni Jain wrote: > Please find attached the updated patch for eviction feature, rebased with the > latest ovs-master as on 02 Jan 2015. > > This patch has correct code indentation. Kindly review it and provide your > comments/inputs. I can't get it to

Re: [ovs-dev] [PATCH] FAQ: Explain how to quickly add many ports.

2015-01-13 Thread Ben Pfaff
On Tue, Jan 13, 2015 at 01:51:31PM +0100, Thomas Graf wrote: > On 01/12/15 at 07:41pm, Ben Pfaff wrote: > > This comes up from time to time. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Thomas Graf Thanks, applied. ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH] FAQ: Explain how to quickly add many ports.

2015-01-13 Thread Ben Pfaff
On Tue, Jan 13, 2015 at 08:35:17AM -0800, Justin Pettit wrote: > > > On Jan 12, 2015, at 7:41 PM, Ben Pfaff wrote: > > > > + takes seconds, not minutes or hours, in the OVS sandbox environment.. > > This ends in two periods, but otherwise looks good. Thanks, fixed. _

Re: [ovs-dev] [PATCH 0/3] auto-attach: Add support for IETF Auto Attach standard (v4)

2015-01-13 Thread Ben Pfaff
[adding ovs-dev back, hope that's OK] On Tue, Jan 13, 2015 at 09:19:53PM +, Flynn, Dennis R (Dennis) wrote: > Just wondering if you have been able to make any progress on this. > We are very excited about the prospects of this being included in OvS 2.4 One place I've become a little hung up i

Re: [ovs-dev] [PATCH] ipv6: Add support for setting ipv6 flow label.

2015-01-13 Thread Pritesh Kothari (pritkoth)
> On Jan 13, 2015, at 2:14 PM, Ben Pfaff wrote: > > On Mon, Jan 12, 2015 at 05:46:49PM -0800, Pritesh Kothari wrote: >> IPv6 Flow Label is currently read only. This patch adds support >> to allow actions like actions=set_field:0x12345->ipv6_label. >> >> Signed-off-by: Pritesh Kothari > > Than

Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-13 Thread Thomas Graf
On 01/13/15 at 02:15pm, Jesse Gross wrote: > On Mon, Jan 12, 2015 at 5:02 PM, Thomas Graf wrote: > > What about if we only apply tun_info->options on Geneve if > > TUNNEL_GENEVE_OPT is set and vice versa? > > That seems nice and simple to me. Great! I have implemented this in v4 of the series as

Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-13 Thread Jesse Gross
On Mon, Jan 12, 2015 at 5:02 PM, Thomas Graf wrote: > On 01/12/15 at 01:54pm, Jesse Gross wrote: >> On Mon, Jan 12, 2015 at 4:26 AM, Thomas Graf wrote: >> > + if (!is_mask) >> > + SW_FLOW_KEY_PUT(match, tun_opts_len, sizeof(opts), false); >> > + else >> > +

Re: [ovs-dev] [PATCH] ipv6: Add support for setting ipv6 flow label.

2015-01-13 Thread Ben Pfaff
On Mon, Jan 12, 2015 at 05:46:49PM -0800, Pritesh Kothari wrote: > IPv6 Flow Label is currently read only. This patch adds support > to allow actions like actions=set_field:0x12345->ipv6_label. > > Signed-off-by: Pritesh Kothari Thanks, applied. I didn't realize before that this was modifiable

Re: [ovs-dev] [PATCH] test-atomic: Stop testing when running slow.

2015-01-13 Thread Ben Pfaff
On Mon, Jan 12, 2015 at 01:27:47PM -0800, Jarno Rajahalme wrote: > When the test suite is run on an OS with 1 core (e.g., a VM with one > core assigned to it), some of the atomic memory model tests take a > long time, with the effect that the test seems stuck. > > This patch stops these tests afte

Re: [ovs-dev] [PATCH] test-atomic: Stop testing when running slow.

2015-01-13 Thread Ben Pfaff
On Tue, Jan 13, 2015 at 01:03:31PM -0800, Jarno Rajahalme wrote: > > On Jan 12, 2015, at 11:48 PM, Motonori Shindo wrote: > > > Jarno, > > > > Thanks for the patch. With this patch, I confirmed that I no longer > > encounter the problem I reported before. Just curious but where is > > VLOG_IN

Re: [ovs-dev] [PATCHv3] Update SECURITY.md

2015-01-13 Thread Ben Pfaff
On Tue, Jan 13, 2015 at 07:38:52AM +1300, Andrew Kampjes wrote: > Add bit about reporting vulns with GPG. > Add generalised rules for vulnerabilties. > > Signed-off-by: Andrew Kampjes Thanks, I applied this with a few edits. ___ dev mailing list dev@op

Re: [ovs-dev] [PATCH] test-atomic: Stop testing when running slow.

2015-01-13 Thread Jarno Rajahalme
On Jan 12, 2015, at 11:48 PM, Motonori Shindo wrote: > Jarno, > > Thanks for the patch. With this patch, I confirmed that I no longer encounter > the problem I reported before. Just curious but where is VLOG_INFO() written > to in this case? Thanks for the report. The blog output goes to st

Re: [ovs-dev] OVN architecture

2015-01-13 Thread Thomas Graf
On 01/13/15 at 11:29am, Ben Pfaff wrote: > Open Virtual Network (OVN) Proposed Architecture > > > The Open vSwitch team is pleased to announce OVN, a new subproject in > development within the Open vSwitch. The full project announcement is > at Net

Re: [ovs-dev] [ovs-discuss] OVN, Bringing Native Virtual Networking to OVS

2015-01-13 Thread Kyle Mestery
On Tue, Jan 13, 2015 at 1:28 PM, Justin Pettit wrote: > The Open vSwitch team is pleased to announce OVN, a new subproject in > development within the Open vSwitch. The full project announcement is at > Network Heresy and reproduced below. OVN complements the existing > capabilities of OVS to a

Re: [ovs-dev] [PATCH 1/1 net-next] openvswitch: Remove unnecessary version.h inclusion

2015-01-13 Thread David Miller
From: Syam Sidhardhan Date: Mon, 12 Jan 2015 20:49:35 +0530 > version.h inclusion is not necessary as detected by versioncheck. > > Signed-off-by: Syam Sidhardhan > Acked-by: Pravin B Shelar > --- > No code changes. Add net-next prefix flag for net-next tree. Applied, thanks.

[ovs-dev] OVN architecture

2015-01-13 Thread Ben Pfaff
Open Virtual Network (OVN) Proposed Architecture The Open vSwitch team is pleased to announce OVN, a new subproject in development within the Open vSwitch. The full project announcement is at Network Heresy and reproduced at: http://openvs

[ovs-dev] OVN, Bringing Native Virtual Networking to OVS

2015-01-13 Thread Justin Pettit
The Open vSwitch team is pleased to announce OVN, a new subproject in development within the Open vSwitch. The full project announcement is at Network Heresy and reproduced below. OVN complements the existing capabilities of OVS to add native support for virtual network abstractions, such as v

Re: [ovs-dev] [PATCH net] gso: do GSO for local skb with size bigger than MTU

2015-01-13 Thread Thomas Graf
On 01/12/15 at 10:55am, Jesse Gross wrote: > There are at least two parts to this: > * Calculating the right MTU for the guest device. > * Transferring the MTU from the host to the guest. > > The first would presumably involve exposing some kind of API that the > component that does know the rig

Re: [ovs-dev] [PATCH] FAQ: Explain how to quickly add many ports.

2015-01-13 Thread Justin Pettit
> On Jan 12, 2015, at 7:41 PM, Ben Pfaff wrote: > > + takes seconds, not minutes or hours, in the OVS sandbox environment.. This ends in two periods, but otherwise looks good. --Justin ___ dev mailing list dev@openvswitch.org http://openvswitch.

[ovs-dev] [PATCH 5/5] openvswitch: Support VXLAN Group Policy extension

2015-01-13 Thread Thomas Graf
Introduces support for the group policy extension to the VXLAN virtual port. The extension is disabled by default and only enabled if the user has provided the respective configuration. ovs-vsctl add-port br0 vxlan0 -- \ set Interface vxlan0 type=vxlan options:exts=gbp The configuration in

[ovs-dev] [PATCH 2/5] vxlan: Only bind to sockets with correct extensions enabled

2015-01-13 Thread Thomas Graf
A VXLAN net_device looking for an appropriate socket may only consider a socket which has a matching set of extensions enabled. If the extensions don't match, return a conflict to have the caller create a distinct socket with distinct port. The OVS VXLAN port is kept unaware of extensions at this

[ovs-dev] [PATCH 0/5 net-next v4] VXLAN Group Policy Extension

2015-01-13 Thread Thomas Graf
Implements supports for the Group Policy VXLAN extension [0] to provide a lightweight and simple security label mechanism across network peers based on VXLAN. The security context and associated metadata is mapped to/from skb->mark. This allows further mapping to a SELinux context using SECMARK, to

[ovs-dev] [PATCH 3/5] openvswitch: Rename GENEVE_TUN_OPTS() to TUN_METADATA_OPTS()

2015-01-13 Thread Thomas Graf
Also factors out Geneve validation code into a new separate function validate_geneve_opts(). A subsequent patch will introduce VXLAN options. Rename the existing GENEVE_TUN_OPTS() to reflect its extended purpose of carrying generic tunnel metadata options. Signed-off-by: Thomas Graf --- v3->v4:

[ovs-dev] [PATCH 4/5] openvswitch: Allow for any level of nesting in flow attributes

2015-01-13 Thread Thomas Graf
nlattr_set() is currently hardcoded to two levels of nesting. This change introduces struct ovs_len_tbl to define minimal length requirements plus next level nesting tables to traverse the key attributes to arbitrary depth. Signed-off-by: Thomas Graf --- v3->v4: - No change. The spotted bug is u

[ovs-dev] [PATCH 1/5] vxlan: Group Policy extension

2015-01-13 Thread Thomas Graf
Implements supports for the Group Policy VXLAN extension [0] to provide a lightweight and simple security label mechanism across network peers based on VXLAN. The security context and associated metadata is mapped to/from skb->mark. This allows further mapping to a SELinux context using SECMARK, to

Re: [ovs-dev] [PATCH 2/6] vxlan: Group Policy extension

2015-01-13 Thread Tom Herbert
On Tue, Jan 13, 2015 at 3:32 AM, Thomas Graf wrote: > On 01/12/15 at 06:28pm, Tom Herbert wrote: >> On Mon, Jan 12, 2015 at 5:03 PM, Thomas Graf wrote: >> >> >> >> Creating a level of indirection for extensions seems overly >> >> complicated to me. Why not just define IFLA_VXLAN_GBP as just anoth

Re: [ovs-dev] Out of tree building OVS on Ubuntu

2015-01-13 Thread Motonori Shindo
Andy, Sorry about my ignorance but I just don't know how to build OVS out of tree on Ubuntu. I've been using "fakeroot debian/rules binary" that builds OVS as *.deb in upper directory from the current directory. Assuming the source tree sits on /vagrant, how can I build on OVS under some other d

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-13 Thread Traynor, Kevin
Hi Jarno, I ran perf top before and after the miniflow patches. It looks like it is missing in the emc after the patches and hence the performance drops. Before: b2623fdbb31570e7e3e39ac9c074b0978b4dd2dc ~13 mpps 22.83% ovs-vswitchd[.] ixgbe_recv_pkts 19.69% ovs-vswitchd[.]

Re: [ovs-dev] [PATCH] vconn: Avoid using C++ keyword 'class' as variable name in headers

2015-01-13 Thread Thomas Graf
On 01/12/15 at 07:54pm, Ben Pfaff wrote: > On Mon, Jan 12, 2015 at 05:51:23PM +0100, Thomas Graf wrote: > > From: Amit Bose > > > > Signed-off-by: Amit Bose > > Signed-off-by: Thomas Graf > > Acked-by: Ben Pfaff Thanks, pushed to master. ___ dev ma

Re: [ovs-dev] [PATCH] FAQ: Explain how to quickly add many ports.

2015-01-13 Thread Thomas Graf
On 01/12/15 at 07:41pm, Ben Pfaff wrote: > This comes up from time to time. > > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/6] vxlan: Group Policy extension

2015-01-13 Thread Thomas Graf
On 01/12/15 at 06:28pm, Tom Herbert wrote: > On Mon, Jan 12, 2015 at 5:03 PM, Thomas Graf wrote: > >> > >> Creating a level of indirection for extensions seems overly > >> complicated to me. Why not just define IFLA_VXLAN_GBP as just another > >> enum above? > > > > I think it's cleaner to group t

Re: [ovs-dev] [PATCH 2/6] vxlan: Group Policy extension

2015-01-13 Thread Nicolas Dichtel
Le 12/01/2015 18:59, David Miller a écrit : Can you PLEASE, PLEASE, not quote and entire full patch just to add two lines of commentary. Quote _only_ the _RELEVANT_ portions of the email you are replying to. Will do, sorry for that. ___ dev mailing