[ovs-dev] OVS + BPF, make sense?

2014-12-19 Thread Andy Zhou
Hi, OVS and netdev developers: On 12/17/2014, Alexei Starovoiov and a few of the OVS developers (Joe, Andy, Jesse, Pravin and Justin) got together to discuss possible ways for OVS to harness the power BPF in recent Linux kernels. During the meeting, we feel that the content of the discussion may

Re: [ovs-dev] Xmas Gift

2014-12-19 Thread Angel Silva Perez
I'm making a free-will financial donation. Reply to partake {m_schaeff...@aol.com} Maria Schaeffler??? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] OVS DPDK support technical direction

2014-12-19 Thread John Xiao
Thanks Kevin, There is a librte_vhost dir in upstream DPDK repo, would that be the base of DPDK vhost library you are talking about? BTW, could you help to elaborate what would be exactly included in the library? John On Fri, Dec 19, 2014 at 11:53 PM, Traynor, Kevin wrote: > >> -Original Me

[ovs-dev] [PATCH 2/2] datapath: Simplify vport_send() error handling.

2014-12-19 Thread Pravin B Shelar
Today vport-send has complex error handling because it involves freeing skb and updating stats depending on return value from vport send implementation. This can be simplified by delegating responsibility of freeing skb to the vport implementation for all cases. So that vport-send needs just update

[ovs-dev] [PATCH 1/2] datapath: compat: introduce ovs_iptunnel_handle_offloads()

2014-12-19 Thread Pravin B Shelar
handle offload code is replicated for different tunneling protocols define compat function to simplify the code. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/gre.c| 32 +++--- datapath/linux/compat/include/net/ip_tunnels.h |3 + datapath/linux/compat

Re: [ovs-dev] [per-pmd ftb/cls 3/3] dpif-netdev: Add per-pmd flow-table/classifier.

2014-12-19 Thread Alex Wang
Hey Pravin, Thx for the review, please see my comments below, > +if (poller_id != f.poller_id) { > > +if (f.poller_id == NON_PMD_CORE_ID) { > > +ds_put_format(&ds, "flow-dump from non-dpdk > interfaces:\n"); > > +} else { > > +ds_pu

Re: [ovs-dev] [PATCH 1/3] datapath-windows: Cleanup OVS

2014-12-19 Thread Nithin Raju
Sorry for the delay. Thanks for making this change. Acked-by: Nithin Raju On Dec 11, 2014, at 4:51 AM, Sorin Vinturis wrote: > Removed duplicate include of "Switch.h" header. > Removed useless usage of UNREFERENCED_PARAMETER macro for a > referenced parameter. > Added debug logs for dropped p

Re: [ovs-dev] [PATCH 0/3] ovs-dpctl UFID improvements

2014-12-19 Thread Joe Stringer
I pushed this series to master (with v2 of "odp-util: Fix UFID string parsing." and a test for ovs-appctl dpctl/get-flow). On 17 December 2014 at 10:34, Joe Stringer wrote: > > This series addresses a few of the quirks around unique flow identifiers > and > the way that they interact with ovs-dpc

[ovs-dev] [PATCH] upcall: Simplify enable_ufid debug option.

2014-12-19 Thread Joe Stringer
We previously tracked the debug enable/disable of UFID in each udpif, and allowed the ovs-appctl debug option to turn on UFID features even if the datapath doesn't support it. This commit shifts the enable_ufid debug flag to a single flag, and provides a helper to determine whether UFID features s

Re: [ovs-dev] [PATCH] datapath: Fix MPLS action validation.

2014-12-19 Thread Pravin Shelar
On Fri, Dec 19, 2014 at 12:15 PM, Andy Zhou wrote: > It may be nice to check for inner protocol being set when executing > the set tunnel action. > > On Fri, Dec 19, 2014 at 11:10 AM, Jarno Rajahalme > wrote: >> LGTM, >> >> Acked-by: Jarno Rajahalme >> >> Jarno >> Thanks for both reviews, I

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2014-12-19 Thread Pravin Shelar
On Fri, Dec 19, 2014 at 11:17 AM, Joe Stringer wrote: > On 15 December 2014 at 12:37, Pravin B Shelar wrote: >> vSwitchd does not generate correct MPLS actions for multiple >> MPLS push or pop action. >> Datapath can handle multiple push action for in single action list. >> But for after first MP

Re: [ovs-dev] [PATCH] datapath: Fix MPLS action validation.

2014-12-19 Thread Andy Zhou
It may be nice to check for inner protocol being set when executing the set tunnel action. On Fri, Dec 19, 2014 at 11:10 AM, Jarno Rajahalme wrote: > LGTM, > > Acked-by: Jarno Rajahalme > > Jarno > >> On Dec 19, 2014, at 10:50 AM, Pravin B Shelar wrote: >> >> Linux stack do not allow GSO for

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2014-12-19 Thread Joe Stringer
On 15 December 2014 at 12:37, Pravin B Shelar wrote: > vSwitchd does not generate correct MPLS actions for multiple > MPLS push or pop action. > Datapath can handle multiple push action for in single action list. > But for after first MPLS pop it needs to recirculate packet to > refill packet key.

Re: [ovs-dev] [PATCH] datapath: Fix MPLS action validation.

2014-12-19 Thread Jarno Rajahalme
LGTM, Acked-by: Jarno Rajahalme Jarno > On Dec 19, 2014, at 10:50 AM, Pravin B Shelar wrote: > > Linux stack do not allow GSO for packet with multiple > encapsulations. Therefore there was check in MPLS action > validation to detect such case, But is it not really required > since we alrea

Re: [ovs-dev] [PATCH 2/3] dpif: Shift ufid support checking up to dpif_backer.

2014-12-19 Thread Joe Stringer
On 19 December 2014 at 10:43, Andy Zhou wrote: > On Fri, Dec 19, 2014 at 10:26 AM, Joe Stringer wrote: >> On 18 December 2014 at 17:16, Andy Zhou wrote: >>> I don't strongly object the current version either (with the fix >>> above), but this version seems simpler. >> >> OK, but this is tangenti

[ovs-dev] [PATCH] datapath: Fix MPLS action validation.

2014-12-19 Thread Pravin B Shelar
Linux stack do not allow GSO for packet with multiple encapsulations. Therefore there was check in MPLS action validation to detect such case, But is it not really required since we already have check in action execution. Removing this check also fixes bug in action copy to no skip multiple set ac

Re: [ovs-dev] [PATCH 2/3] dpif: Shift ufid support checking up to dpif_backer.

2014-12-19 Thread Andy Zhou
On Fri, Dec 19, 2014 at 10:26 AM, Joe Stringer wrote: > On 18 December 2014 at 17:16, Andy Zhou wrote: >> I don't strongly object the current version either (with the fix >> above), but this version seems simpler. > > OK, but this is tangential to the original patch so I'll send it separately. >

Re: [ovs-dev] [PATCH 2/3] dpif: Shift ufid support checking up to dpif_backer.

2014-12-19 Thread Joe Stringer
On 18 December 2014 at 17:16, Andy Zhou wrote: > I don't strongly object the current version either (with the fix > above), but this version seems simpler. OK, but this is tangential to the original patch so I'll send it separately. > Is it worth while to make it inline? From CodingStyle: Func

[ovs-dev] Bug#771863: [PKG-Openstack-devel] Bug#771863: Bug#771863: Service does not start or parse interfaces correctly

2014-12-19 Thread Simon Horman
On Fri, Dec 19, 2014 at 11:43:42PM +0800, Thomas Goirand wrote: > On 12/19/2014 11:32 PM, Thomas Goirand wrote: > > On 12/19/2014 10:25 PM, Simon Horman wrote: > >> On Fri, Dec 19, 2014 at 06:39:39PM +0800, Thomas Goirand wrote: > >>> On 12/19/2014 11:50 AM, Simon Horman wrote: > On Thu, Dec 1

[ovs-dev] '27: test atomic operations' unit test hanging

2014-12-19 Thread Finucane, Stephen
Hi, I'm seeing the following unit test hanging on multiple boards, while it passes on one board: 27: test atomic operations Before I invest time debugging, has anyone seen similar issues with this test? Regards, Stephen Finucane --- PS: The boards are on different kernels (failing: 3

[ovs-dev] Have You Receive Alert?

2014-12-19 Thread Mrs.Anita Okoli
 Attn My Dear, I have deposited your funds today with (UBA) Bank Office and we agreed up that the Delivery of your £1,000,000,00 compensation fund will take off today.So contact (UBA Bank) office with your full info: (1) Full names: (2) Phone line:-- (3) Country of origin:

Re: [ovs-dev] OVS DPDK support technical direction

2014-12-19 Thread Traynor, Kevin
> -Original Message- > From: John Xiao [mailto:johnxiao.cl...@gmail.com] > Sent: Thursday, December 18, 2014 2:46 PM > To: Traynor, Kevin > Subject: Re: [ovs-dev] OVS DPDK support technical direction > > Hi Kevin, > > The performance number looks great! > - For DPDK OVS, the number only

[ovs-dev] Bug#771863: [PKG-Openstack-devel] Bug#771863: Bug#771863: Service does not start or parse interfaces correctly

2014-12-19 Thread Thomas Goirand
On 12/19/2014 11:32 PM, Thomas Goirand wrote: > On 12/19/2014 10:25 PM, Simon Horman wrote: >> On Fri, Dec 19, 2014 at 06:39:39PM +0800, Thomas Goirand wrote: >>> On 12/19/2014 11:50 AM, Simon Horman wrote: On Thu, Dec 18, 2014 at 05:30:42PM -0800, Joe Stringer wrote: > On 18 December 2014

[ovs-dev] Have You Receive Alert?

2014-12-19 Thread Mrs.Anita Okoli
 Attn My Dear, I have deposited your funds today with (UBA) Bank Office and we agreed up that the Delivery of your £1,000,000,00 compensation fund will take off today.So contact (UBA Bank) office with your full info: (1) Full names: (2) Phone line:-- (3) Country of origin:

[ovs-dev] Bug#771863: [PKG-Openstack-devel] Bug#771863: Bug#771863: Service does not start or parse interfaces correctly

2014-12-19 Thread Thomas Goirand
On 12/19/2014 10:25 PM, Simon Horman wrote: > On Fri, Dec 19, 2014 at 06:39:39PM +0800, Thomas Goirand wrote: >> On 12/19/2014 11:50 AM, Simon Horman wrote: >>> On Thu, Dec 18, 2014 at 05:30:42PM -0800, Joe Stringer wrote: On 18 December 2014 at 01:00, Fabio Fantoni wrote: > One maintaine

[ovs-dev] Bug#771863: Bug#771863: [PKG-Openstack-devel] Bug#771863: Service does not start or parse interfaces correctly

2014-12-19 Thread Fabio Fantoni
Il 19/12/2014 15:25, Simon Horman ha scritto: On Fri, Dec 19, 2014 at 06:39:39PM +0800, Thomas Goirand wrote: On 12/19/2014 11:50 AM, Simon Horman wrote: On Thu, Dec 18, 2014 at 05:30:42PM -0800, Joe Stringer wrote: On 18 December 2014 at 01:00, Fabio Fantoni wrote: One maintainer or debian

[ovs-dev] [PATCH 3/3] auto-attach: Add auto-attach support to bridge layer and command set

2014-12-19 Thread drflynn
From: Dennis Flynn This is the final commit in the series of commits that deliver initial support for Auto-Attach. Specifically this commit delivers auto-attach support to the OVS bridge layer as well as the new auto-attach commands. The OVSDB schema is modified to define the new auto-attach entr

[ovs-dev] [PATCH 2/3] auto-attach: Add auto-attach support to ofproto layer

2014-12-19 Thread drflynn
From: Dennis Flynn Signed-off-by: Ludovic Beliveau Signed-off-by: Dennis Flynn diff --git a/lib/bfd.c b/lib/bfd.c index 3db1d57..490dbd0 100644 --- a/lib/bfd.c +++ b/lib/bfd.c @@ -515,10 +515,12 @@ bfd_unref(struct bfd *bfd) OVS_EXCLUDED(mutex) } } -void +long long int bfd_wait(const

[ovs-dev] [PATCH 0/3] auto-attach: Add support for IETF Auto Attach standard (v4)

2014-12-19 Thread drflynn
From: Dennis Flynn This patch sequence provides OVS support for the IETF Auto-Attach SPBM draft standard. This standard describes a compact method of using IEEE 802.1AB Link Layer Discovery Protocol (LLDP) together with a IEEE 802.1aq Shortest Path Bridging (SPB) network to automatically attach n

[ovs-dev] Bug#771863: Bug#771863: [PKG-Openstack-devel] Bug#771863: Service does not start or parse interfaces correctly

2014-12-19 Thread Simon Horman
On Fri, Dec 19, 2014 at 06:39:39PM +0800, Thomas Goirand wrote: > On 12/19/2014 11:50 AM, Simon Horman wrote: > > On Thu, Dec 18, 2014 at 05:30:42PM -0800, Joe Stringer wrote: > >> On 18 December 2014 at 01:00, Fabio Fantoni wrote: > >>> One maintainer or debian developer can do a new build of ovs

[ovs-dev] Bug#771863: [PKG-Openstack-devel] Bug#771863: Service does not start or parse interfaces correctly

2014-12-19 Thread Thomas Goirand
On 12/19/2014 11:50 AM, Simon Horman wrote: > On Thu, Dec 18, 2014 at 05:30:42PM -0800, Joe Stringer wrote: >> On 18 December 2014 at 01:00, Fabio Fantoni wrote: >>> One maintainer or debian developer can do a new build of ovs with the fix >>> available in 2.3.1 please? >>> * Version 2.3.0+

[ovs-dev] Bug#771863: Bug#771863: Bug#771863: Service does not start or parse interfaces correctly, updating severity

2014-12-19 Thread Stig Sandbeck Mathisen
Joe Stringer writes: > I agree that this should be treated as a separate bug, yes please (I'm > just following up as it wasn't clear to me whether you're working on > this or not). Ok, I'll report it as a new bug. -- Stig Sandbeck Mathisen ___ dev ma

[ovs-dev] [PATCH] configure.ac: Enable 'tar-ustar' by default

2014-12-19 Thread Stephen Finucane
Automake defaults to the 'v7' legacy tar format in GNU tar, through passing of the '-o' parameter to GNU tar. Enabling this option results in errors for users with 32 bit UIDs: $ make dist ... tardir=openvswitch-2.3.90 && ${TAR-tar} chof - "$tardir" | GZIP=--best gzip -c >openvswitch-

Re: [ovs-dev] [RFC recirc fix] recirculation: Map recirc_id to ofproto_dpif.

2014-12-19 Thread Andy Zhou
Alex, thanks for the fast turn around in sending out the patch. A few comments in line. On Thu, Dec 18, 2014 at 9:46 PM, Alex Wang wrote: > After commit 0c7812e5e (recirculation: Do not drop packet when > there is no match from internal table.), if flow keys are modified > before the recirculatio