On 19 December 2014 at 10:43, Andy Zhou <az...@nicira.com> wrote:
> On Fri, Dec 19, 2014 at 10:26 AM, Joe Stringer <joestrin...@nicira.com> wrote:
>> On 18 December 2014 at 17:16, Andy Zhou <az...@nicira.com> wrote:
>>> I don't strongly object the current version either (with the fix
>>> above), but this version seems simpler.
>>
>> OK, but this is tangential to the original patch so I'll send it separately.
>>
>>> Is it worth while to make it inline?
>>
>> From CodingStyle:
>>
>> Functions in .c files should not normally be marked "inline", because
>> it does not usually help code generation and it does suppress
>> compilers warnings about unused functions. (Functions defined in .h
>> usually should be marked inline.)
>
> If inline make sense, it should be in a header file. This is not a big deal.
I doubt that we need to micromanage the compiler in this way. If this
function shows up in perf, I would prefer to cache its result in the
callers of delete_op_init{,__}() and pass that down. For the time
being I will leave it as is.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
