Re: [ovs-dev] [RFC recirc-fix] recirculation: Do not change handling of packets after recirculation.

2014-12-17 Thread YAMAMOTO Takashi
i agree that the suggested patch was too bond specific. ofp port number is not enough. you need to encode (bridge, ofp_port) pair in some way. it's why i suggested to assign odp port numbers to every pseudo ports. YAMAMOTO Takashi > This is probably obvious: the bond internal flows now should

[ovs-dev] Kernel/Userspace Action Mismatch

2014-12-17 Thread Justin Pettit
Hi, Pravin. I think commit a36de77 (openvswitch: Userspace tunneling.) introduces a problem when new actions are added in the kernel. This part makes the kernel's idea of actions defined after _TUNNEL_POP different from userspace: -=-=-=-=-=-=-=- @@ -636,6 +663,10 @@ enum ovs_action_attr {

Re: [ovs-dev] [PATCH 1/2] route-table-bsd: Update vlog.h inclusion

2014-12-17 Thread YAMAMOTO Takashi
> On 12/17/14 at 08:59am, YAMAMOTO Takashi wrote: >> This fixes a build failure introduced by the recent vlog change >> commit e6211adce42c28453e0004c7a3e342a3d52bb97d. >> ("lib: Move vlog.h to ") >> >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Thomas Graf thank you. applied. YAMAMOTO Ta

Re: [ovs-dev] [PATCH] ovs-docker : Handle pre-existing fake bridges.

2014-12-17 Thread Gurucharan Shetty
On Wed, Dec 17, 2014 at 4:32 PM, Paul-Emmanuel Raoul wrote: > From 095b942e31767a9bac2164b2bb12445974273223 Mon Sep 17 00:00:00 2001 > From: Paul-Emmanuel Raoul > Date: Thu, 18 Dec 2014 00:25:46 +0100 > Subject: [PATCH] ovs-docker : Handle pre-existing fake bridges. > > Signed-off-by: Paul-Emmanu

[ovs-dev] [PATCH] ovs-docker : Handle pre-existing fake bridges.

2014-12-17 Thread Paul-Emmanuel Raoul
From 095b942e31767a9bac2164b2bb12445974273223 Mon Sep 17 00:00:00 2001 From: Paul-Emmanuel Raoul Date: Thu, 18 Dec 2014 00:25:46 +0100 Subject: [PATCH] ovs-docker : Handle pre-existing fake bridges. Signed-off-by: Paul-Emmanuel Raoul --- utilities/ovs-docker |3 ++- 1 file changed, 2 insert

Re: [ovs-dev] [RFC recirc-fix] recirculation: Do not change handling of packets after recirculation.

2014-12-17 Thread Andy Zhou
This is probably obvious: the bond internal flows now should only match 16 bits. On Wed, Dec 17, 2014 at 3:56 PM, Alex Wang wrote: > This sounds reasonable, > > I'll just use the 'ofport' in the 'recirc_id' instead of 'OFPP_LOCAL' > in my implementation. > > Thanks, > Alex Wang, > > On Wed, Dec 1

Re: [ovs-dev] [RFC recirc-fix] recirculation: Do not change handling of packets after recirculation.

2014-12-17 Thread Alex Wang
This sounds reasonable, I'll just use the 'ofport' in the 'recirc_id' instead of 'OFPP_LOCAL' in my implementation. Thanks, Alex Wang, On Wed, Dec 17, 2014 at 3:44 PM, Andy Zhou wrote: > > This solution seems too bond specific. How about the following: > > We use the top 16 bits of the recirc_

Re: [ovs-dev] [RFC recirc-fix] recirculation: Do not change handling of packets after recirculation.

2014-12-17 Thread Andy Zhou
This solution seems too bond specific. How about the following: We use the top 16 bits of the recirc_id, as how we use it today. For example, in bond implementation, it represents a bond port. The lower 16 bits can then be used to represent OF port number within the bridge. This representation i

Re: [ovs-dev] [PATCH] ovs-docker : add fake bridges support.

2014-12-17 Thread Gurucharan Shetty
On Wed, Dec 17, 2014 at 2:03 PM, Paul-Emmanuel Raoul wrote: > Thanks for your quick answer. > > In fact, I already use several fake bridges and I can't use the > ovs-docker script to attach a Docker container to an Open vSwitch > bridge without applying my patch. > > If I use the command given in

Re: [ovs-dev] [RFC recirc-fix] recirculation: Do not change handling of packets after recirculation.

2014-12-17 Thread Alex Wang
This patch currently causes MPLS unittests failure, because it treats all pkts with 'recirc_id' as bond traffic. I'm thinking if we could reserve a range of 'recirc_id' for bonding so that 'recirc_id' used for other traffic will be unaffected, Anyway, hope to hear any comments,~ Thanks, Alex Wan

Re: [ovs-dev] [PATCH] ovs-docker : add fake bridges support.

2014-12-17 Thread Gurucharan Shetty
On Wed, Dec 17, 2014 at 12:56 PM, Paul-Emmanuel Raoul wrote: > From 7b693f8f8b5028e445c116531d9d960603222e06 Mon Sep 17 00:00:00 2001 > From: Paul-Emmanuel Raoul > Date: Wed, 17 Dec 2014 02:25:30 +0100 > Subject: [PATCH] ovs-docker : add fake bridges support. > > Also updates ovs-docker README do

[ovs-dev] [RFC recirc-fix] recirculation: Do not change handling of packets after recirculation.

2014-12-17 Thread Alex Wang
After commit 0c7812e5e (recirculation: Do not drop packet when there is no match from internal table.), if flow keys are modified before the recirculation action (e.g. set vlan ID), the miss handling of recirculated packets may take different path than the ones. This commit adds an unittest that c

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Madhu Challa
Thanks for the helpful explanation. Thanks. On Wed, Dec 17, 2014 at 12:45 PM, Jarno Rajahalme wrote: > > > On Dec 17, 2014, at 12:07 PM, Madhu Challa > wrote: > > Jarno, > > I did some simple tests increasing flow_tnl size and trying to match on it > looks good. Thanks for solving this. I have

[ovs-dev] [PATCH] ovs-docker : add fake bridges support.

2014-12-17 Thread Paul-Emmanuel Raoul
From 7b693f8f8b5028e445c116531d9d960603222e06 Mon Sep 17 00:00:00 2001 From: Paul-Emmanuel Raoul Date: Wed, 17 Dec 2014 02:25:30 +0100 Subject: [PATCH] ovs-docker : add fake bridges support. Also updates ovs-docker README documentation. Signed-off-by: Paul-Emmanuel Raoul --- INSTALL.Docker.md

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Jarno Rajahalme
On Dec 17, 2014, at 12:07 PM, Madhu Challa wrote: > Jarno, > > I did some simple tests increasing flow_tnl size and trying to match on it > looks good. Thanks for solving this. I have a question inline around > miniflow_extract. Other than that the diff looks good to me. > > Thanks. > > On

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Madhu Challa
Jarno, I did some simple tests increasing flow_tnl size and trying to match on it looks good. Thanks for solving this. I have a question inline around miniflow_extract. Other than that the diff looks good to me. Thanks. On Wed, Dec 17, 2014 at 10:30 AM, Jarno Rajahalme wrote: > > So far the com

[ovs-dev] [PATCH 3/3] dpctl: Add 'get-flow' command.

2014-12-17 Thread Joe Stringer
This allows users to fetch a flow by giving a particular UFID. Usage: 'ovs-dpctl get-flow ufid:' Signed-off-by: Joe Stringer --- lib/dpctl.c | 96 + lib/dpctl.man |4 +++ utilities/ovs-dpctl.c |1 + 3 files changed, 86

[ovs-dev] [PATCH 0/3] ovs-dpctl UFID improvements

2014-12-17 Thread Joe Stringer
This series addresses a few of the quirks around unique flow identifiers and the way that they interact with ovs-dpctl. The first patch is a straightforward bugfix, the second addresses the issue of ovs-dpctl performing feature probing and modifying the flow table even when executing a flow dump. L

[ovs-dev] [PATCH 1/3] odp-util: Fix UFID string parsing.

2014-12-17 Thread Joe Stringer
Commit 534a19b (dpctl: Add support for using UFID to add/del flows.) introduced string parsing functions for UFIDs, but provided a broken implementation where the upper 64 bits would be ignored, then the lower 64 bits would be read into both the lower and upper UFID positions. Fix the implementatio

[ovs-dev] [PATCH 2/3] dpif: Shift ufid support checking up to dpif_backer.

2014-12-17 Thread Joe Stringer
Previously, the dpif layer was responsible for determining datapath support for UFIDs, which resulted in all ovs-dpctl utilities inserting/deleting flows from the datapath each time they are run. Shift this responsibility up to the dpif_backer. There are two users of this functionality: Revalidato

[ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Jarno Rajahalme
So far the compressed flow data in struct miniflow has been in 32-bit words with a 63-bit map, allowing for a maximum size of struct flow of 252 bytes. With the forthcoming Geneve options this is not sufficient any more. This patch solves the problem by changing the miniflow data to 64-bit words,

[ovs-dev] [PATCH 1/2] hash: Add hash_add64().

2014-12-17 Thread Jarno Rajahalme
Add support for adding 64-bit words to hashes. This will be used by subsequent patches. Signed-off-by: Jarno Rajahalme --- lib/classifier-private.h |3 +-- lib/dpif-netdev.c|3 +-- lib/hash.h | 33 + ofproto/tunnel.c |4

Re: [ovs-dev] [PATCH] revalidator: Don't delete non-existent flow.

2014-12-17 Thread Joe Stringer
On 17 December 2014 at 07:45, Thomas Graf wrote: > On 12/16/14 at 07:04pm, Joe Stringer wrote: >> If ukey_acquire() returns ENOENT, then it is unable to locate the ukey >> corresponding to the flow and the flow has disappeared since it was >> dumped. Don't bother deleting the flow in this case, as

Re: [ovs-dev] Enquiry LED lights

2014-12-17 Thread Bruce
Hi dear, Nice day for you. Our company used to produce many kinds of LED products,and since the 2013,we turned to professional LED high bay producer,our products cover all different LED high bays,here is some information for your reference: Different rank and warranty products A.5 year warrant

Re: [ovs-dev] [PATCH] revalidator: Don't delete non-existent flow.

2014-12-17 Thread Thomas Graf
On 12/16/14 at 07:04pm, Joe Stringer wrote: > If ukey_acquire() returns ENOENT, then it is unable to locate the ukey > corresponding to the flow and the flow has disappeared since it was > dumped. Don't bother deleting the flow in this case, as it will fail. > > Signed-off-by: Joe Stringer Acked

Re: [ovs-dev] [PATCH 1/2] route-table-bsd: Update vlog.h inclusion

2014-12-17 Thread Thomas Graf
On 12/17/14 at 08:59am, YAMAMOTO Takashi wrote: > This fixes a build failure introduced by the recent vlog change > commit e6211adce42c28453e0004c7a3e342a3d52bb97d. > ("lib: Move vlog.h to ") > > Signed-off-by: YAMAMOTO Takashi Acked-by: Thomas Graf _

Re: [ovs-dev] Support for MCAST_Snooping

2014-12-17 Thread Gandharva S Murthy
Hi, Thank you for everything its working fine now. Its able to send only report from the port, after enabling flood report command. Thanks, Gandharva S On Mon, Dec 15, 2014 at 7:20 PM, Gandharva S Murthy wrote: > > Hi, > Sorry it was mistake with the local system. Its working fine now. > > Thank