From: Pravin Shelar
Date: Mon, 27 Oct 2014 17:27:11 -0700
> On Mon, Oct 27, 2014 at 2:47 PM, Thomas Graf wrote:
>> The patch also brings additional flexibility to users of
>> distributions. Distros typically ship something like an allmodconfig
>> so a user can either run openvswitch.ko with all
--
www.facebook.com
Herzlichen Glückwunsch,
Wie feiern wir unseren 10 Jahre der Internet-Reise und globale
Kommunikation / Sozialisation wir sind froh, Ihnen mitzuteilen, dass
Ihre Facebook-Account haben, nach dem Zufallsprinzip als Begünstigter
von $ 1,000,000.00usd im 2014 Facebook-Konto d
Signed-off-by: Nithin Raju
---
INSTALL.Windows |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/INSTALL.Windows b/INSTALL.Windows
index 24d0bb7..bba0710 100644
--- a/INSTALL.Windows
+++ b/INSTALL.Windows
@@ -83,14 +83,14 @@ To get SSL support for Open vSwitch on Windows
On Mon, Oct 27, 2014 at 2:47 PM, Thomas Graf wrote:
> On 10/27/14 at 10:14am, Pravin Shelar wrote:
>> On Fri, Oct 24, 2014 at 2:57 PM, Thomas Graf wrote:
>> > I was refering to how many other kernel APIs have been designed, a
>> > registration API allowing a vport to be implemented exclusively in
With comments below:
Acked-by: Jarno Rajahalme
On Oct 16, 2014, at 11:38 AM, Pravin B Shelar wrote:
> diff --git a/README-native-tunneling b/README-native-tunneling
> new file mode 100644
> index 000..5cc17ec
> --- /dev/null
> +++ b/README-native-tunneling
> @@ -0,0 +1,83 @@
> +
> +Open vS
On 10/27/14 at 10:14am, Pravin Shelar wrote:
> On Fri, Oct 24, 2014 at 2:57 PM, Thomas Graf wrote:
> > I was refering to how many other kernel APIs have been designed, a
> > registration API allowing a vport to be implemented exclusively in the
> > scope of a single file tends to be cleaner than h
Acked-by: Jarno Rajahalme
One comment below:
On Oct 16, 2014, at 11:38 AM, Pravin B Shelar wrote:
> +void
> +ovs_router_flush(void)
> +{
> +struct ovs_router_entry *rt;
> +
> +CLS_FOR_EACH_SAFE(rt, cr, &cls) {
> +if (rt->priority == rt->plen) {
> +classifier_remove(&
On Oct 24, 2014, at 10:55 AM, Ben Pfaff wrote:
> On Fri, Oct 24, 2014 at 05:46:39PM -0700, Eitan Eliahu wrote:
>> The instance should be removed from pid-hash when vswitchd.exe terminates so
>> the driver won't access it during packet miss (causing BSOD)
>>
>> Signed-off-by: Eitan Eliahu
>> Ack
On Oct 24, 2014, at 4:13 PM, Ben Pfaff wrote:
> On Fri, Oct 24, 2014 at 01:36:35PM -0700, Jarno Rajahalme wrote:
>> We already implement OFPFUTIL_FF_RESET_COUNTS.
>>
>> Signed-off-by: Jarno Rajahalme
>
> Acked-by: Ben Pfaff
Pushed to master,
Jarno
___
Thanks for the review!
Pushed to master,
Jarno
On Oct 24, 2014, at 4:15 PM, Ben Pfaff wrote:
> On Fri, Oct 24, 2014 at 01:36:37PM -0700, Jarno Rajahalme wrote:
>> Currently, OVSRCU_TYPE_INITIALIZER always initializes the RCU pointer
>> as NULL. There is no reason why the RCU pointer could n
On Oct 24, 2014, at 4:14 PM, Ben Pfaff wrote:
> On Fri, Oct 24, 2014 at 01:36:36PM -0700, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme
>
> Acked-by: Ben Pfaff
Pushed,
Jarno
___
dev mailing list
dev@openvswitch.org
http://openvswitch.
If the OVS extension is enabled, Driver Verifier will issue a BSOD
due to memory leaks. This issue reproduces each time and the problem
is in the filter attach routine when the switch context is initialized.
Signed-off-by: Sorin Vinturis
Reported-by: Sorin Vinturis
Reported-at: https://github.co
Eitan, thanks for the review. I'll address the changes you mentioned.
-Original Message-
From: Eitan Eliahu [mailto:elia...@vmware.com]
Sent: Monday, October 27, 2014 8:53 PM
To: Sorin Vinturis; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: BSOD cause by DV due to m
thanx for clearing that !
On Mon, Oct 27, 2014 at 9:24 PM, Ben Pfaff wrote:
> Please don't drop the list.
>
> handle_packet_out().
>
> On Mon, Oct 27, 2014 at 11:13:01AM +0530, Sree Vidya S D wrote:
> > So which function should I monitor for handling packet_out messages from
> > controller?
> >
Sorin thank you for fixing the memory leaks.
Minor issues:
Can you please set both the lock pointers to NULL after freeing them ?
Also, since OvsCleanupSwitchContext() reverses OvsInitSwitchContext() it would
better to call OvsInitSwitchContext() as OvsDeinitSwitchContext.
Beside that LG.
Acked-b
> >> /**
> >> * enum ovs_action_attr - Action types.
> >> *
> >> @@ -633,6 +642,10 @@ enum ovs_action_attr {
> >> * data immediately followed by a
> mask.
> >> * The data must be zero for the
> unmasked
> >>
On Fri, Oct 24, 2014 at 3:16 PM, Thomas Graf wrote:
> On 10/24/14 at 12:23pm, Pravin Shelar wrote:
>> >> * enum ovs_action_attr - Action types.
>> >> *
>> >> @@ -633,6 +642,10 @@ enum ovs_action_attr {
>> >> * data immediately followed by a
>> >> mask.
>>
On Fri, Oct 24, 2014 at 3:44 PM, Thomas Graf wrote:
> On 10/24/14 at 01:43pm, Pravin Shelar wrote:
>> On Fri, Oct 24, 2014 at 12:41 PM, Kyle Mestery wrote:
>> > Neutron uses those for the physical bridge mappings when using the OVS
>> > agent with the ML2 plugin [1] and VLANs.
>> >
>> > [1]
>> >
On Fri, Oct 24, 2014 at 2:57 PM, Thomas Graf wrote:
> On 10/24/14 at 10:47am, Pravin Shelar wrote:
>> On Wed, Oct 22, 2014 at 8:29 AM, Thomas Graf wrote:
>> > The internal and netdev vport remain part of openvswitch.ko. Encap
>> > vports including vxlan, gre, and geneve can be built as separate
>
Please don't drop the list.
handle_packet_out().
On Mon, Oct 27, 2014 at 11:13:01AM +0530, Sree Vidya S D wrote:
> So which function should I monitor for handling packet_out messages from
> controller?
> Can you please help?
>
> On Mon, Oct 27, 2014 at 12:52 AM, Ben Pfaff wrote:
>
> > On Sun,
On Mon, Oct 27, 2014 at 05:17:36PM +0530, Rishi Bamba wrote:
> This patch ensures setting of importance parameter of a flow
> everywhere it should be. This also correct formatting issues
> as per the coding guidelines.
>
> Signed-off-by: Rishi Bamba
This does not apply with "git am":
Applyi
You need to repost the patches in a way that "git am" can apply then one
after another. "git send-email" is the easiest way.
On Mon, Oct 27, 2014 at 05:25:37PM +0530, Rishi Bamba wrote:
> Hi Ben,
>
> Thanks for the review. As far as I can understand the commit message has only
> one line differ
On 10/21/14 at 04:02pm, Scott Mann wrote:
> lib/libopenvswitch.sym.in | 4
> lib/libsflow.sym.in | 4
> ofproto/libofproto.sym.in | 4
> ovsdb/libovsdb.sym.in | 4
Scott,
Can you add the generated .sym files to .gitignore?
Hi Ben,
Thanks for the review. As far as I can understand the commit message has only
one line difference and that might look that the two commits are same but they
are not. Patch 1 is related to setting of importance parameter in a rule and
Patch 2 is related to addition of the test cases for
Hi Ben,
Taking care of the points mentioned in the last review , we are submitting this
patch which ensures the following :
- Importance is set everywhere where it is meant to be.Also we have identified
two structures i.e ofputil_flow_removed & ofputil_flow_update where changes
related to impo
This patch ensures setting of importance parameter of a flow
everywhere it should be. This also correct formatting issues
as per the coding guidelines.
Signed-off-by: Rishi Bamba
---
include/openflow/openflow-1.1.h | 4 ++--
lib/learn.c | 1 +
lib/learning-switch.c
If the OVS extension is enabled, Driver Verifier will issue a BSOD
due to memory leaks. This issue reproduces each time and the problem
is in the filter attach routine when the switch context is initialized.
Signed-off-by: Sorin Vinturis
Reported-by: Sorin Vinturis
Reported-at: https://github.co
On 10/24/14 at 04:17pm, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Acked-by: Thomas Graf
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 10/27/14 at 04:12pm, Simon Horman wrote:
> The original motivation for this change was to allow the helper to be used
> in files other than actions.c as part of work on an odp select group
> action.
>
> It was as pointed out by Thomas Graf that this helper would be best off
> living in netlink.
On Thu, Oct 16, 2014 at 02:33:03PM -0700, Jarno Rajahalme wrote:
> flow inserts and removals are simplified:
>
> - No need for classifier internal mutex, as dpif-netdev already has a
> 'flow_mutex'.
> - Number of memory allocations/frees can be halved.
>
> Lookup code path is a bit more effcien
On Fri, Oct 10, 2014 at 09:40:56AM -0700, Ben Pfaff wrote:
> On Wed, Oct 08, 2014 at 02:09:53PM -0700, Daniele Di Proietto wrote:
> > Signed-off-by: Daniele Di Proietto
>
> Can you estimate the additional memory overhead per-datapath flow that
> this adds? Our recent review of customer data (for
The original motivation for this change was to allow the helper to be used
in files other than actions.c as part of work on an odp select group
action.
It was as pointed out by Thomas Graf that this helper would be best off
living in netlink.h. Furthermore, I think that the generic nature of this
32 matches
Mail list logo
