Acked-by: Jarno Rajahalme <jrajaha...@nicira.com>
One comment below:
On Oct 16, 2014, at 11:38 AM, Pravin B Shelar <pshe...@nicira.com> wrote:
> +void
> +ovs_router_flush(void)
> +{
> + struct ovs_router_entry *rt;
> +
> + CLS_FOR_EACH_SAFE(rt, cr, &cls) {
> + if (rt->priority == rt->plen) {
> + classifier_remove(&cls, &rt->cr);
> + }
> + }
Just a note: Classifier ‘SAFE’ iteration (as in master) is not safe when other
threads may modify the classifier at the same time.
I have posted a patch series last week to remedy this, so this should not be a
blocker for this patch.
Also, it seems to me that all the changes to the route table would come from
the main thread, so the race would not be triggered in practice anyway.
> +}
> +
Jarno
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
