Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-09-01 Thread Jamal Hadi Salim
On 09/01/14 16:28, Jiri Pirko wrote: Jamal, please be ensured that no one I know of is against future different classifiers. Ok, glad to hear that. The patches and/or some of the discussion were not projecting that view. Even for the flow case, I am pretty sure we are going to need a few iter

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-09-01 Thread Jiri Pirko
Mon, Sep 01, 2014 at 06:37:05PM CEST, j...@mojatatu.com wrote: >On 09/01/14 04:13, Simon Horman wrote: >>On Fri, Aug 29, 2014 at 10:20:55AM -0400, Jamal Hadi Salim wrote: > >>>I actually have no issues with whatever classifier someone decides >>>to use. To each their poison. But I do take issue man

[ovs-dev] [PATCH] Broken build on MSVC

2014-09-01 Thread Alin Serdean
MSVC does not like variable length array either. This patch treats the following error: lib/dpif-netdev.c(2272) : error C2057: expected constant expression lib/dpif-netdev.c(2272) : error C2466: cannot allocate an array of constant size 0 lib/dpif-netdev.c(2272) : error C2133: 'batches' : unknown

Re: [ovs-dev] [dpdk patch 6/8] netdev-dpdk: Add function for configuring rx queues for all dpdk interfaces.

2014-09-01 Thread Alex Wang
> > > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > > index 012ee68..3013df5 100644 > > --- a/lib/netdev-dpdk.c > > +++ b/lib/netdev-dpdk.c > > @@ -130,6 +130,8 @@ enum { DRAIN_TSC = 20ULL }; > > > > static int rte_eal_init_ret = ENODEV; > > > > +static size_t dpdk_rx_queues OVS_GUARD

Re: [ovs-dev] [dpdk patch 5/8] dpif-netdev: Create 'number of dpdk ifaces on cpu socket' pmd threads for each cpu socket.

2014-09-01 Thread Alex Wang
> > > static struct dp_netdev_port *dp_netdev_lookup_port(const struct > dp_netdev *dp, > > @@ -281,6 +281,15 @@ struct dp_netdev_actions > *dp_netdev_flow_get_actions( > > const struct dp_netdev_flow *); > > static void dp_netdev_actions_free(struct dp_netdev_actions *); > > > > +/* Represe

Re: [ovs-dev] [dpdk patch 4/8] netdev-dpdk: Create 'number of dpdk ifaces on same cpu socket' rx queues and 'number of cpu cores' tx queues for each dpdk interface.

2014-09-01 Thread Alex Wang
On Sat, Aug 30, 2014 at 12:02 PM, Pravin Shelar wrote: > On Mon, Aug 11, 2014 at 9:56 PM, Alex Wang wrote: > > Before this commit, ovs only creates one tx/rx queue for each > > dpdk interface and uses only one poll thread for handling the > > I/O of all dpdk interfaces. As one step toward using

Re: [ovs-dev] [dpdk patch 2/8] netdev-dpdk: Add function for getting the socket_id of netdev-dpdk.

2014-09-01 Thread Alex Wang
> > > This should be part of netdev_class api rather than dpdk specific API. > we should try to minimize dpdk specific call in dpif-netdev layer. > > One more issue I noticed in this series is that socket and numa is > used interchangeably, can we use just one? > > I'll add it to netdev_class api.

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-09-01 Thread Jamal Hadi Salim
On 09/01/14 04:13, Simon Horman wrote: On Fri, Aug 29, 2014 at 10:20:55AM -0400, Jamal Hadi Salim wrote: I actually have no issues with whatever classifier someone decides to use. To each their poison. But I do take issue mandating the specified classifer it as THE CLASSIFIER as in this case,

[ovs-dev] [PATCH] test-bitmap: Fix multiple minor memory leaks

2014-09-01 Thread Thomas Graf
Signed-off-by: Thomas Graf --- tests/test-bitmap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/test-bitmap.c b/tests/test-bitmap.c index b1274e3..3644419 100644 --- a/tests/test-bitmap.c +++ b/tests/test-bitmap.c @@ -56,6 +56,9 @@ test_bitmap_equal(void) assert(!bitmap_equ

[ovs-dev] [PATCH] test-stp: Fix leak of open file descriptor for input_file

2014-09-01 Thread Thomas Graf
Signed-off-by: Thomas Graf --- tests/test-stp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-stp.c b/tests/test-stp.c index 9ca9c6c..c4e5933 100644 --- a/tests/test-stp.c +++ b/tests/test-stp.c @@ -666,6 +666,7 @@ test_stp_main(int argc, char *argv[]) free(bridge);

[ovs-dev] [PATCH] ovs-vsctl: Fix leaked error string in cmd_remove()

2014-09-01 Thread Thomas Graf
Signed-off-by: Thomas Graf --- utilities/ovs-vsctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index 37d8b3c..2cd389b 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -3529,11 +3529,11 @@ cmd_remove(struct vs

[ovs-dev] [PATCH] travis: Announce travis CI and new build list in NEWS and CONTRIBUTING

2014-09-01 Thread Thomas Graf
Signed-off-by: Thomas Graf --- CONTRIBUTING | 6 ++ NEWS | 3 +++ 2 files changed, 9 insertions(+) diff --git a/CONTRIBUTING b/CONTRIBUTING index f4d2c97..dfbb171 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -41,6 +41,12 @@ Testing is also important: - A patch that modifi

Re: [ovs-dev] [RFC] Proposal for enhanced select groups

2014-09-01 Thread Simon Horman
2014/09/01 21:40 "Thomas Graf" : > > On 09/01/14 at 05:10pm, Simon Horman wrote: > > We are left with two questions for you: > > > > 1. Would you look at a proposal (I have some rough code that even works) > >for a select group action in the datapath prior to the finalisation > >of the ques

Re: [ovs-dev] [RFC] Proposal for enhanced select groups

2014-09-01 Thread Thomas Graf
On 09/01/14 at 05:10pm, Simon Horman wrote: > We are left with two questions for you: > > 1. Would you look at a proposal (I have some rough code that even works) >for a select group action in the datapath prior to the finalisation >of the question of offloads infrastructure in the kernel?

[ovs-dev] Gentile utente

2014-09-01 Thread ADMIN
Gentile utente La tua email è superato 2 GB creati dal webmaster, State attualmente in esecuzione a 2.30GB, che non può inviare o ricevere nuovi messaggi Entro il prossimo 24 ore prima di averne verificato email account. Inserisci i tuoi dati qui sotto per verificare il tuo account: (1) E

Re: [ovs-dev] how to match and set pkt_mark field in ofctl?

2014-09-01 Thread Thomas Graf
On 09/01/14 at 11:38am, loy wolfe wrote: > Hi, > > I see in the doc[1] that there is pkt_mark field, but I didn't find any > description in the ofctl manual. So, can I match against this field, and > set it in the action? pkt_mark seems covered in ovs-ofctl(8): pkt_mark=value[/mask]

[ovs-dev] Open Vswitch Feature Enhancement- Provider Bridging Feature

2014-09-01 Thread Hiteshi Madan
Hi Ben and Team, I have checked the features list supported in open Vswitch.I found that following feature is not yet supported:  -    802.1ad (provider bridging) We are thinking to contribute in above feature. Can you please provide your inputs/opinions and suggestion for it? Also can you ple

[ovs-dev] Regarding implementation of Importance field in flow.

2014-09-01 Thread Shashwat Srivastava
Hi Team, I am working on addition of the "IMPORTANCE" field in the add-flow command as per the Openflow-specs 1.4. As I am new to openvswitch and have just started exploring its code, can anyone tell me from where to start, this addition of IMPORTANCE field in the flow. I mean the files where c

Re: [ovs-dev] BFD integration into FastFailover Group Table

2014-09-01 Thread Niels van Adrichem
1) Ok, I will read up on OFPPS_LIVE, clean up my code and send in an appropriate Patch for BFD support 2) This was mainly a point of discussion that I am curious towards. I am concerned that checking all BFD, OAM, CFM, etc., sequentially may harm the throughput of the function odp_port_is_alive

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-09-01 Thread Simon Horman
On Fri, Aug 29, 2014 at 10:20:55AM -0400, Jamal Hadi Salim wrote: > On 08/26/14 16:54, Thomas Graf wrote: > >On 08/26/14 at 01:13pm, Alexei Starovoitov wrote: > >>I think it's important distinction. In-kernel OVS is not OF. > >>It's a networking function that has hard-coded packet parser, > >>N-tup

Re: [ovs-dev] [RFC] Proposal for enhanced select groups

2014-09-01 Thread Simon Horman
On Thu, Aug 28, 2014 at 10:12:49AM +0900, Simon Horman wrote: > On Wed, Aug 27, 2014 at 03:03:53PM -0500, Jesse Gross wrote: > > On Wed, Aug 27, 2014 at 11:51 AM, Ben Pfaff wrote: > > > On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote: > > >> On Fri, Aug 22, 2014 at 08:30:08AM -0700, B

Re: [ovs-dev] [RFC] Proposal for enhanced select groups

2014-09-01 Thread Simon Horman
On Thu, Aug 28, 2014 at 10:11:57AM +0900, Simon Horman wrote: > On Wed, Aug 27, 2014 at 09:51:59AM -0700, Ben Pfaff wrote: > > On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote: [snip] > > The proposal seems reasonable on its own but given that EXT-350 allows a > > standardized way to