Signed-off-by: Alex Wang
---
vswitchd/vswitch.xml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 6c49250..42e944b 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -2096,7 +2096,7 @@
default is 00:23
On Mon, Aug 25, 2014 at 3:24 PM, Andy Zhou wrote:
> If recirc action is the last action of a action list, the SKB triggers
> the recirc will be freed twice. This patch fixes this bug.
>
> Reported-by: Justin Pettit
> Signed-off-by: Andy Zhou
> ---
> datapath/actions.c | 6 ++
> 1 file chang
An RFC to get back early feedback on exposing Linux's kernel connection
tracker to OVS. The code has a few rough spots that will be addressed
in the next version:
- Need better interface than setting individual flags for the state.
- Need support for IP frags.
- Need support for zones
On Mon, Aug 25, 2014 at 7:19 PM, Jarno Rajahalme wrote:
>
> On Aug 11, 2014, at 3:46 PM, Jesse Gross wrote:
>
>> On Mon, Aug 11, 2014 at 9:14 AM, Jarno Rajahalme
>> wrote:
>>> diff --git a/tests/odp.at b/tests/odp.at
>>> index e725f70..58e3ff1 100644
>>> --- a/tests/odp.at
>>> +++ b/tests/odp.a
The branch is unused as size < sizeof dst->inline_values must
always be true for inlined values. Hitting the branch would lead
to corruption as inline_values is accessed out of bounds.
Remove branch and add assertion.
Cc: Jarno Rajahalme
Signed-off-by: Thomas Graf
---
lib/flow.c | 7 ++-
1
On Thu, Aug 21, 2014 at 10:25 AM, Lorand Jakab wrote:
> struct ovs_skb_cb is full on kernels < 3.11 due to compatibility code.
> This patch removes the 'flow' member in order to make room for data
> needed by layer 3 flow/port support that will be added in an upcoming
> patch. The 'flow' memeber
tun_key_to_attr() accesses tp_src and tp_dst which are currently
uinitialized.
Signed-off-by: Thomas Graf
---
lib/odp-util.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index ffc3673..19d0627 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -1784,6 +
On Aug 11, 2014, at 3:46 PM, Jesse Gross wrote:
> On Mon, Aug 11, 2014 at 9:14 AM, Jarno Rajahalme
> wrote:
>> diff --git a/tests/odp.at b/tests/odp.at
>> index e725f70..58e3ff1 100644
>> --- a/tests/odp.at
>> +++ b/tests/odp.at
> +set(ipv4(src=35.8.2.41/255.255.255.255,dst=172.16.0.20/255.255
On 08/25/14 at 12:15pm, Jamal Hadi Salim wrote:
> On 08/25/14 10:17, Thomas Graf wrote:
> >On 08/25/14 at 09:53am, Jamal Hadi Salim wrote:
>
> >fdb_add() *is* flow based. At least in my understanding, the whole
> >point here is to extend the idea of fdb_add() and make it understand
> >L2-L4 in a m
Hi Samuel,
>Hello Saurabh,
>
>Thanks for the clarifications!
>The param name "copySize" was very ambiguous.
What name do you think will make it easy to understand? I can take this in
to account when I post a patch for -
https://github.com/openvswitch/ovs-issues/issues/28.
>
>I did not debug this
If recirc action is the last action of a action list, the SKB triggers
the recirc will be freed twice. This patch fixes this bug.
Reported-by: Justin Pettit
Signed-off-by: Andy Zhou
---
datapath/actions.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/datapath/actions.c b/datapath/ac
First of all, thanks for the animated discussion, wouldn't
want to miss our arguments ;-)
On 08/25/14 at 12:48pm, Jamal Hadi Salim wrote:
> On 08/25/14 10:54, Thomas Graf wrote:
> >On 08/24/14 at 11:15am, Jamal Hadi Salim wrote:
>
> >Let's keep vendors out of this discussion.
>
> The API is from
On Mon, Aug 25, 2014 at 10:44:12AM -0700, Jarno Rajahalme wrote:
> Btw, is there an Emacs setting that I could use to indent function
> calls like this by pressing the tab-key? Mine wants the parameters to
> be indented after the opening parenthesis.
I'll respond to the review bits later (I'm at V
Amato di Dio, Ciao
Se ti sto scrivendo questa mail, sanno che è l'opera di Dio che mi ha portato a
scegliere tra i tanti dei miei corrispondenti a fidarsi di lei con questa
grande responsabilità che sono convinto che si prende come una benedizione e un
dono venuto da una donna in buona fede.
On Aug 12, 2014, at 2:44 PM, Ben Pfaff wrote:
> On Mon, Aug 11, 2014 at 09:14:58AM -0700, Jarno Rajahalme wrote:
>> Add a new action type OVS_ACTION_ATTR_SET_MASKED, and support for
>> parsing, printing, and committing them.
>>
>> Masked set actions add a mask, immediately following the netlink
LGTM, Also tested the change.
Acked-by: Andy Zhou
On Thu, Aug 14, 2014 at 11:14 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> debian/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/debian/.gitignore b/debian/.gitignore
> index b612eec..e8d9d31 100644
> --- a/debi
On 08/25/14 10:54, Thomas Graf wrote:
On 08/24/14 at 11:15am, Jamal Hadi Salim wrote:
Let's keep vendors out of this discussion.
The API is from a vendor. It is clearly labelled as an OF API.
It covers well abstracting that vendors SDK to enable OF. That
is relevant info.
If it covers all ot
While we work out whether nl_sock_join_mcgroup() will be the mechanism
to support VPORT events, it is easy to add support for
nl_lookup_genl_mcgroup() and make progress on the other commands.
In this patch, we implement support for nl_lookup_genl_mcgroup() only
for the VPORT family though, which i
dpif-linux.c makes a nl_lookup_genl_mcgroup(OVS_VPORT_FAMILY) that is not
implemented yet on Windows yet. Multicast group is used currently to
subscribe to events related to VPORTs. Whether the exact same mechanism
would be used is unclear yet.
In the interim, we can implement code to support nl_l
On 08/25/14 10:17, Thomas Graf wrote:
On 08/25/14 at 09:53am, Jamal Hadi Salim wrote:
fdb_add() *is* flow based. At least in my understanding, the whole
point here is to extend the idea of fdb_add() and make it understand
L2-L4 in a more generic way for the most common protocols.
The reason f
On 08/25/14 at 09:01am, Ben Pfaff wrote:
> On Mon, Aug 25, 2014 at 05:58:09PM +0200, Thomas Graf wrote:
> > On 08/25/14 at 08:50am, Ben Pfaff wrote:
> > > Is there a way to get emailed build success/failure reports?
> >
> > Yes:
> >
> > 1. You can connect the main ovs git repo to travis-ci. This
On Mon, Aug 25, 2014 at 05:58:09PM +0200, Thomas Graf wrote:
> On 08/25/14 at 08:50am, Ben Pfaff wrote:
> > Is there a way to get emailed build success/failure reports?
>
> Yes:
>
> 1. You can connect the main ovs git repo to travis-ci. This will
>result in a email to both the author and comm
On 08/25/14 at 08:50am, Ben Pfaff wrote:
> This sounds great. Applied.
Thanks
> Is there a way to get emailed build success/failure reports?
Yes:
1. You can connect the main ovs git repo to travis-ci. This will
result in a email to both the author and commiter if a new
commit to any bran
On Mon, Aug 25, 2014 at 04:07:40PM +1200, Joe Stringer wrote:
> On 23 August 2014 10:47, Ben Pfaff wrote:
>
> > OpenFlow packet and byte counters have always been something of an
> > approximation in Open vSwitch. First, they are updated only periodically.
> > Second, they can be misattributed b
On Mon, Aug 25, 2014 at 03:07:05PM +1200, Joe Stringer wrote:
> On 23 August 2014 10:47, Ben Pfaff wrote:
>
> > Both existing callers calculated 'may_learn' as 'stats->n_packets > 0', so
> > it was redundant. Because xlate_push_stats() is now entirely a no-op if
> > 'stats->n_packets' is 0, we c
On Mon, Aug 25, 2014 at 02:51:00PM +0200, Thomas Graf wrote:
> This enables the use of travis-ci via github. Linking any ovs
> github repo to travis-ci [0] will automatically lead to a build
> and testsuite run being triggered for each new commit or pull
> requests against the repo.
>
> The introd
On 08/24/14 at 11:15am, Jamal Hadi Salim wrote:
> The focus of the patches is on offloading flows (uses the
> ovs or shall i say the broadcom OF-DPA API, which is one
> vendor's view of the world).
Let's keep vendors out of this discussion. I have no affiliation
with this vendor. In fact I'm perso
Hi,
A quick email to follow up and see if you had a chance to review my previous
email.
I would really appreciate if you can get back to me with your questions or
queries.
Look forward to your response.
Thanks,
Cathy Collins
Cathy Collins| Business Coordinator
E-Data List
On 08/25/14 at 09:53am, Jamal Hadi Salim wrote:
> On 08/24/14 22:42, John Fastabend wrote:
>
> >In the L2 case we already have the fdb_add and fdb_del semantics that
> >are being used today by NICs with embedded switches. And we have a DSA
> >patch we could dig out of patchwork for those drivers.
On 08/24/14 22:42, John Fastabend wrote:
In the L2 case we already have the fdb_add and fdb_del semantics that
are being used today by NICs with embedded switches. And we have a DSA
patch we could dig out of patchwork for those drivers.
Indeed. That is an excellent starting point of something
On 08/24/14 22:24, Scott Feldman wrote:
On Aug 24, 2014, at 8:15 AM, Jamal Hadi Salim wrote:
With respect to focus on L2/L3, I have a pretty *good* hunch someone could
> write a kernel module that gleans from the L2/L3 netlink echoes
already flying
around and translates to sw_flows and i
On 08/25/14 at 02:51pm, Thomas Graf wrote:
> This enables the use of travis-ci via github. Linking any ovs
> github repo to travis-ci [0] will automatically lead to a build
> and testsuite run being triggered for each new commit or pull
> requests against the repo.
Given the above, we can consider
This enables the use of travis-ci via github. Linking any ovs
github repo to travis-ci [0] will automatically lead to a build
and testsuite run being triggered for each new commit or pull
requests against the repo.
The introduction of any warnings will cause the build to fail as
both gcc and clang
33 matches
Mail list logo
