Re: [ovs-dev] RFC: conntrack Initial Design

2014-07-13 Thread loy wolfe
1) it's better to support connmark: save__mark & restore__mark, this is very useful. 2) besides conntrack callback as an action, can we support other netfilter chain hook callback(PREROUTING-raw, FORWARDING-filter...), also as an action in the OVS flow table? This is not same as linuxbridge iptabl

Re: [ovs-dev] [RFC 1/2] datapath: Refactor ovs_flow_cmd_fill_info().

2014-07-13 Thread Joe Stringer
On 14 July 2014 13:05, Pravin Shelar wrote: > > @@ -734,9 +722,25 @@ static int ovs_flow_cmd_fill_info(struct datapath > *dp, > > err = ovs_nla_put_flow(dp, &flow->key, &flow->mask->key, skb); > > if (err) > > goto error; > > - > > nla_nest_end(skb, nla); >

Re: [ovs-dev] [RFC 1/2] datapath: Refactor ovs_flow_cmd_fill_info().

2014-07-13 Thread Joe Stringer
On 10 July 2014 20:41, Thomas Graf wrote: > On 07/10/14 at 05:29pm, Joe Stringer wrote: > > Split up ovs_flow_cmd_fill_info() to make it easier to cache parts of a > > dump reply. This will be used to streamline flow_dump in the next patch. > > > > Signed-off-by: Joe Stringer > > LGTM > > Acked-

Re: [ovs-dev] [RFC 1/2] datapath: Refactor ovs_flow_cmd_fill_info().

2014-07-13 Thread Pravin Shelar
On Wed, Jul 9, 2014 at 10:29 PM, Joe Stringer wrote: > Split up ovs_flow_cmd_fill_info() to make it easier to cache parts of a > dump reply. This will be used to streamline flow_dump in the next patch. > Nice refactoring. > Signed-off-by: Joe Stringer > --- > datapath/datapath.c | 87 > +