On 10 July 2014 20:41, Thomas Graf <tg...@noironetworks.com> wrote: > On 07/10/14 at 05:29pm, Joe Stringer wrote: > > Split up ovs_flow_cmd_fill_info() to make it easier to cache parts of a > > dump reply. This will be used to streamline flow_dump in the next patch. > > > > Signed-off-by: Joe Stringer <joestrin...@nicira.com> > > LGTM > > Acked-by: Thomas Graf <tg...@noironetworks.com> >
Thanks for the review. > @@ -734,9 +722,25 @@ static int ovs_flow_cmd_fill_info(struct datapath > *dp, > > err = ovs_nla_put_flow(dp, &flow->key, &flow->mask->key, skb); > > if (err) > > goto error; > > - > > nla_nest_end(skb, nla); > > nitpick: unneeded change above > The spacing was previously inconsistent between filling the key and the mask, which is why I made this change. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
