Thank you for the contribution! As you know, a team at VMware is close to
releasing its port as well. Since we'll have two ports, the core OVS
developers will need to evaluate each approach. I've asked the team at
VMware to send out to ovs-dev an architectural description of the approach
that th
On 6/11/14, Jesse Gross wrote:
> On Wed, Jun 11, 2014 at 7:26 AM, Avinash wrote:
>> On 6/10/14, Thomas Graf wrote:
>>> On 06/10/14 at 07:03pm, Avinash wrote:
@@ -471,10 +497,14 @@ int ovs_flow_extract(struct sk_buff *skb, u16
in_port, struct sw_flow_key *key)
if (vlan
OFPRR_METER_DELETE was introduced in OF1.4 however meters were introduced
in OF1.3.
Regardless of the OF version when flows are deleted cause flows to be
deleted handle_delete_meter() calls delete_flows__() with
OFPRR_METER_DELETE as the reason.
In order to avoid sending OFPRR_METER_DELETE to con
On Wed, Jun 11, 2014 at 10:53:43AM -0700, Ben Pfaff wrote:
> On Fri, May 30, 2014 at 05:14:47PM +0900, Simon Horman wrote:
> > OFPRR_METER_DELETE was introduced in OF1.4 however meters were introduced
> > in OF1.3.
> >
> > Regardless of the OF version when flows are deleted cause flows to be
> > d
On Wed, Jun 11, 2014 at 10:50:51AM -0700, Ben Pfaff wrote:
> On Fri, May 30, 2014 at 05:14:14PM +0900, Simon Horman wrote:
> > Use OFPRR_GROUP_DELETE as the reason for deleting flows due
> > to the removal of a group that they use.
> >
> > This implementation adds an delete_reason member to struct
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Sim
On Wed, Jun 11, 2014 at 09:28:04AM +0900, Simon Horman wrote:
> This is to allow a recirculation id to be associated with a rule
> in the case that its actions cause recirculation.
>
> In such a case if the recirc_id field is non-zero then that value should be
> used, otherwise a value should be o
On Wed, Jun 11, 2014 at 09:28:05AM +0900, Simon Horman wrote:
> This is in preparation for using the same helper as part of support
> for using recirculation in conjunction series of actions including
> with MPLS actions that are currently not able to be translated.
>
> In that scenario the idle t
On Wed, Jun 11, 2014 at 09:28:03AM +0900, Simon Horman wrote:
> This is in preparation for using this value
> in ofproto-dpif-xlate.c when composing recirculation
> actions added as a result of processing (MPLS) actions.
>
> Signed-off-by: Simon Horman
Applied, thanks!
__
On Tue, Jun 03, 2014 at 02:14:01PM -0700, Ryan Wilson wrote:
> Previously, DPDK buffers were freed using 'struct ofpbuf' pointers
> passed to free_dpdk_buf(). However, if a new ofpbuf allocated on the
> stack shares data with the old ofpbuf and the new ofpbuf is to be
> freed with free_dpdk_buf(),
Agreed.
Acked-by: Ethan Jackson
On Mon, Jun 9, 2014 at 3:20 PM, Thomas Graf wrote:
> On 06/05/14 at 10:02pm, Ben Pfaff wrote:
>> Open vSwitch has supported datapaths that cannot update their flow tables
>> synchronously for many versions. In that time, I have talked to many
>> hardware implem
On Wed, Jun 11, 2014 at 1:58 PM, Thomas Graf wrote:
> On 06/11/14 at 11:23am, Jesse Gross wrote:
>> These two pieces are actually related.
>>
>> All of the operations during flow lookup (flow extraction, masking,
>> hashing, and comparison) are now variable length to the relevant data.
>> For non-
On Wed, Jun 11, 2014 at 1:52 PM, Thomas Graf wrote:
> On 06/11/14 at 11:11am, Jesse Gross wrote:
>> On Wed, Jun 11, 2014 at 3:04 AM, Thomas Graf wrote:
>> > On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> >> In some cases, the names of tunnel protocols are longer than the
>> >> maximum allowed afte
On Mon, Jun 09, 2014 at 03:06:22PM -0700, Jarno Rajahalme wrote:
> When reaching the end of a prefix trie, we checked one bit off the end
> to the intended data. However, since the trie node in that case has
> NULLs for both edge links, this did not result in incorrect
> functionality.
>
> Found
When deleting a mask from the mask array, we always move the last entry
into its current location. Another approach can be NULL in its current
place, and periodically compact it.
The approach taken by this patch is more efficient during run time.
During look up, fast path packet don't have to skip
Simplify flow mask cache replacement without using expensive atomic
memory access to the mask pointers.
Signed-off-by: Andy Zhou
---
datapath/flow_table.c | 44 +---
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/datapath/flow_table.c b/da
>
> I think you could make it work as you stop iterating upon deletion,
> like this:
>
> for (i = 0; i < ma->count - 1; i++) {
> if (mask == ma->masks[i]) {
> [...]
> break;
> }
> }
>
> This is also how other similar kernel code looks like.
You are right. The mask insertion
On Sat, May 31, 2014 at 01:53:21AM -0300, Flavio Leitner wrote:
> Signed-off-by: Flavio Leitner
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sat, May 31, 2014 at 01:53:20AM -0300, Flavio Leitner wrote:
> If the packet is multicast and the snooping feature is enabled,
> update the multicast snooping database accordingly and send it
> to the right ports.
>
> If the packet is not multicast or the snooping feature is disabled,
> let the
On 06/11/14 at 11:23am, Jesse Gross wrote:
> These two pieces are actually related.
>
> All of the operations during flow lookup (flow extraction, masking,
> hashing, and comparison) are now variable length to the relevant data.
> For non-Geneve packets, the option field won't be part of the
> sig
On 06/11/14 at 11:11am, Jesse Gross wrote:
> On Wed, Jun 11, 2014 at 3:04 AM, Thomas Graf wrote:
> > On 06/10/14 at 04:47pm, Jesse Gross wrote:
> >> In some cases, the names of tunnel protocols are longer than the
> >> maximum allowed after concatenating port numbers. This truncates
> >> names to
On 06/11/14 at 11:10am, Jesse Gross wrote:
> On Wed, Jun 11, 2014 at 3:00 AM, Thomas Graf wrote:
> > On 06/10/14 at 04:47pm, Jesse Gross wrote:
> >> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> >> index 33423ad..57d40e3 100644
> >> --- a/include/linux/openvswitch.h
> >>
On Sat, May 31, 2014 at 01:53:19AM -0300, Flavio Leitner wrote:
> This patch adds the command 'ovs-appctl mdb/show bridge'
> to show learned groups on a bridge from the multicast
> snooping database.
>
> It also adds the command 'ovs-appctl mdb/flush [bridge]'
> to flush learned groups on a bridge
On Sat, May 31, 2014 at 01:53:18AM -0300, Flavio Leitner wrote:
> Signed-off-by: Flavio Leitner
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
DEMANDE DE PARTEANRIAT
Mes sincères salutations et mes excuses à votre égard. Avant tout chose, je
voudrais m'excuser de mon intrusion dans votre vie privée. Bref, je me nomme
Mme. Leanna Ntali, Cadre au Département de la Comptabilité à Ecobank Côte
d'Ivoire. Un compte a été ouvert au sein de n
On Sat, May 31, 2014 at 01:53:17AM -0300, Flavio Leitner wrote:
> It follows mac learning, but since the multicast snooping feature
> can be disabled, the locking is handled in the library.
>
> Signed-off-by: Flavio Leitner
Acked-by: Ben Pfaff
___
dev
On Sat, May 31, 2014 at 01:53:16AM -0300, Flavio Leitner wrote:
> Add IGMP support to struct flow, flow compose and flow extract.
>
> Signed-off-by: Flavio Leitner
If the ofproto code is going to match on particular IGMP type or code
or group internally, then we need to also modify odp-util.c
pa
On Wed, Jun 11, 2014 at 4:58 AM, Thomas Graf wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> diff --git a/datapath/flow.h b/datapath/flow.h
>> index 0ecf78b..5d8383c 100644
>> --- a/datapath/flow.h
>> +++ b/datapath/flow.h
>> @@ -53,11 +53,20 @@ struct ovs_key_ipv4_tunnel {
>>
>> struct ov
On Sat, May 31, 2014 at 01:53:15AM -0300, Flavio Leitner wrote:
> This patch adds generic IGMP snooping library code
> that is used in follow-up patches.
>
> Signed-off-by: Cong Wang
> Signed-off-by: Daniel Borkmann
> Acked-by: Thomas Graf
> Signed-off-by: Flavio Leitner
Thanks for the revisi
Thanks for the reviews!
On Jun 10, 2014, at 1:47 PM, Ethan Jackson wrote:
> Nice, thing we could do something similar for the classifier loop?
>
I have it in the pipeline, also integrating locking to the iterators, so that
the change to RCU will not be so visible.
> Acked-by: Ethan Jackson
Pushed to master (but I forgot to add the Acked-by, sorry),
Jarno
On Jun 10, 2014, at 12:20 PM, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
>
> On Mon, Jun 9, 2014 at 11:53 AM, Jarno Rajahalme
> wrote:
>> This bug did not manifest due to 'hmap_node' being in the same offset
>> in bo
Pushed to master (but I forgot to add the Acked-by, sorry),
Jarno
On Jun 10, 2014, at 12:21 PM, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
>
> On Mon, Jun 9, 2014 at 11:53 AM, Jarno Rajahalme
> wrote:
>> Remove unnecessary includes from lib/classifier.h and add them to
>> lib/class
On Wed, Jun 11, 2014 at 3:04 AM, Thomas Graf wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> In some cases, the names of tunnel protocols are longer than the
>> maximum allowed after concatenating port numbers. This truncates
>> names to the correct size rather than assert-failing on the as
On Wed, Jun 11, 2014 at 3:00 AM, Thomas Graf wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
>> index 33423ad..57d40e3 100644
>> --- a/include/linux/openvswitch.h
>> +++ b/include/linux/openvswitch.h
>> @@ -340,6 +340,7
On Wed, Jun 11, 2014 at 1:50 AM, Thomas Graf wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
>> index a1e2b2b..af9a71e 100644
>> --- a/datapath/vport-lisp.c
>> +++ b/datapath/vport-lisp.c
>> @@ -173,8 +173,12 @@ static u16 get_src_p
On Mon, May 26, 2014 at 02:57:40AM -0700, Arun Sharma wrote:
> If ovs-vswitchd or ovsdb-server is trying to connect to a controller
> over SSL that isn't up yet, and the connection is set to bootstrap
> the CA cert, the following annoying thing happens: - The connection
> will go into backoff mode,
On Fri, May 30, 2014 at 05:15:14PM +0900, Simon Horman wrote:
> My reading of handle_delete_meter() is that OFPRR_METER_DELETE is used.
> Accordingly delete the entry relating to it from OPENFLOW-1.1+.
>
> Signed-off-by: Simon Horman
Applied, thanks!
_
On Wed, Jun 11, 2014 at 7:26 AM, Avinash wrote:
> On 6/10/14, Thomas Graf wrote:
>> On 06/10/14 at 07:03pm, Avinash wrote:
>>> @@ -471,10 +497,14 @@ int ovs_flow_extract(struct sk_buff *skb, u16
>>> in_port, struct sw_flow_key *key)
>>>
>>> if (vlan_tx_tag_present(skb))
>>>
On Fri, May 30, 2014 at 05:14:47PM +0900, Simon Horman wrote:
> OFPRR_METER_DELETE was introduced in OF1.4 however meters were introduced
> in OF1.3.
>
> Regardless of the OF version when flows are deleted cause flows to be
> deleted handle_delete_meter() calls delete_flows__() with
> OFPRR_METER_
On Fri, May 30, 2014 at 05:14:14PM +0900, Simon Horman wrote:
> Use OFPRR_GROUP_DELETE as the reason for deleting flows due
> to the removal of a group that they use.
>
> This implementation adds an delete_reason member to struct ofputil_flow_mod
> as a convenient way to set the reason used by del
Thanks. Applied to master, branch-2.[23].
On Mon, Jun 09, 2014 at 11:04:09PM +, Pritesh Kothari (pritkoth) wrote:
> Acked-by: Pritesh Kothari
>
> On Jun 9, 2014, at 3:58 PM, Ben Pfaff wrote:
>
> > I think these were leftovers from the removal of %z for MSVC that happened
> > some time ago
On 6/10/14, Thomas Graf wrote:
> On 06/10/14 at 07:02pm, Avinash wrote:
>> Hello,
>
> As a general remark. It would be nice to have such a mail formatted as
> the cover letter of the patches series and all the patches as reply to
> it. That way all patches and are neatly bundled in a single email
On 6/10/14, Thomas Graf wrote:
> On 06/10/14 at 07:03pm, Avinash wrote:
>> Kernel recognizes and accepts ethertype of provider VLANs (ETH_P_8021AD)
>> along with normal VLAN (ETH_P_8021Q). Also in flow key formation,
>> only the outermost VLAN is considered. Remaining stacked VLANs are
>> skipped.
On 06/10/14 at 04:47pm, Jesse Gross wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index f1bb95d..7b108ed 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -455,6 +455,13 @@ int ovs_flow_extract(struct sk_buff *skb, u16 in_port,
> struct sw_flow_key *key)
> struc
On 06/10/14 at 04:47pm, Jesse Gross wrote:
> As the size of the flow key grows, it can put some pressure on the
> stack. This is particularly true in ovs_flow_cmd_set(), which needs several
> copies of the key on the stack. One of those uses is logically separate,
> so this factors it out to reduce
On 06/10/14 at 04:47pm, Jesse Gross wrote:
> In some cases, the names of tunnel protocols are longer than the
> maximum allowed after concatenating port numbers. This truncates
> names to the correct size rather than assert-failing on the assumption
> that collisions between names of protocols are
On 06/10/14 at 04:47pm, Jesse Gross wrote:
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> index 33423ad..57d40e3 100644
> --- a/include/linux/openvswitch.h
> +++ b/include/linux/openvswitch.h
> @@ -340,6 +340,7 @@ enum ovs_tunnel_key_attr {
> OVS_TUNNEL_KEY_ATTR_TT
On 06/10/14 at 04:47pm, Jesse Gross wrote:
> Currently, the flow information that is matched for tunnels and
> the tunnel data passed around with packets is the same. However,
> as additional information is added this is not necessarily desirable,
> as in the case of pointers.
>
> This adds a new
On 06/10/14 at 04:47pm, Jesse Gross wrote:
> As new protocols are added, the size of the flow key tends to
> increase although few protocols care about all of the fields. In
> order to optimize this for hashing and matching, OVS uses a varible
> length portion of the key. However, when fields are e
On 06/10/14 at 04:47pm, Jesse Gross wrote:
> When calculating the source port for the UDP header, LISP primarily
> uses skb_get_hash() but needs a backup in case this fails. The
> current backup is a hash of the entire flow key but this includes
> many fields that probably would not be considered t
50 matches
Mail list logo
