On Fri, May 30, 2014 at 05:14:47PM +0900, Simon Horman wrote: > OFPRR_METER_DELETE was introduced in OF1.4 however meters were introduced > in OF1.3. > > Regardless of the OF version when flows are deleted cause flows to be > deleted handle_delete_meter() calls delete_flows__() with > OFPRR_METER_DELETE as the reason. > > In order to avoid sending OFPRR_METER_DELETE to controllers connected > using OF1.3 map OFPRR_METER_DELETE to OFPRR_DELETE which exists in that > version. > > Signed-off-by: Simon Horman <ho...@verge.net.au>
I'd prefer to keep knowledge of the particular protocol in use outside ofproto/ to the extent that it is practicable. In this case, I think that would be to use OFPRR_METER_DELETE unconditionally within ofproto/ and then to translate it into some other code (OFPRR_DELETE I guess?) in ofputil_encode_flow_removed(). Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
