Signed-off-by: Flavio Leitner
---
NEWS | 1 +
tests/ovs-vsctl.at | 2 ++
utilities/ovs-vsctl.8.in | 30
vswitchd/bridge.c | 49 +
vswitchd/vswitch.ovsschema | 6 --
vswitchd/vs
If the packet is multicast and the snooping feature is enabled,
update the multicast snooping database accordingly and send it
to the right ports.
If the packet is not multicast or the snooping feature is disabled,
let the MAC learning handle the packet as before.
Signed-off-by: Flavio Leitner
-
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif.c | 52 ++
ofproto/ofproto-provider.h | 25 ++
ofproto/ofproto.c | 27
ofproto/ofproto.h | 13
4 files changed, 117 in
This patch adds the command 'ovs-appctl mdb/show bridge'
to show learned groups on a bridge from the multicast
snooping database.
It also adds the command 'ovs-appctl mdb/flush [bridge]'
to flush learned groups on a bridge or on all bridges.
Acked-by: Thomas Graf
Acked-by: Daniel Borkmann
Signe
It follows mac learning, but since the multicast snooping feature
can be disabled, the locking is handled in the library.
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-xlate.c | 21 -
ofproto/ofproto-dpif-xlate.h | 2 ++
ofproto/ofproto-dpif.c | 17 +++
This patch adds generic IGMP snooping library code
that is used in follow-up patches.
Signed-off-by: Cong Wang
Signed-off-by: Daniel Borkmann
Acked-by: Thomas Graf
Signed-off-by: Flavio Leitner
---
lib/automake.mk | 2 +
lib/mcast-snooping.c | 759 ++
Currently it supports IGMPv1 and IGMPv2 only.
Flavio Leitner (7):
lib: Add IGMP snooping library bits
flow: Add support for IGMP protocol
ofproto-dpif: Introduce multicast snooping handler
ofproto: Add functions to configure multicast snooping
ofproto-dpif: Add mcast snooping db show and
Add IGMP support to struct flow, flow compose and flow extract.
Signed-off-by: Flavio Leitner
---
lib/flow.c | 22 --
lib/flow.h | 11 ++-
lib/match.c | 8 +++-
lib/nx-match.c | 2 +-
lib/ofp-uti
> I agree with the sentiment that it shouldn't be optional; that was my first
> thought. Although, feedback from V1 was concerned about additional system
> resources required to run it like that.
>
> Perhaps a compromise is to have it configurable like this, but default to
> -j8?
I don't feel all
Applied, thx!
On Fri, May 30, 2014 at 5:30 PM, Alex Wang wrote:
> LGTM,
>
> Acked-by: Alex Wang
>
>
> On Fri, May 30, 2014 at 4:59 PM, Ryan Wilson wrote:
>
>> Older versions of Python do not have ctypes as a default installed
>> package. This patch puts the 'import ctypes' statement inside a
LGTM,
Acked-by: Alex Wang
On Fri, May 30, 2014 at 4:59 PM, Ryan Wilson wrote:
> Older versions of Python do not have ctypes as a default installed
> package. This patch puts the 'import ctypes' statement inside a try
> statement.
>
> This fixes a bug introduced by commit 8396f (timeval: Use m
Older versions of Python do not have ctypes as a default installed
package. This patch puts the 'import ctypes' statement inside a try
statement.
This fixes a bug introduced by commit 8396f (timeval: Use monotonic
time in OVS Python timeval library).
Signed-off-by: Ryan Wilson
---
python/ovs/ti
On Fri, May 23, 2014 at 11:04 AM, Daniele Di Proietto
wrote:
> Signed-off-by: Daniele Di Proietto
> ---
> lib/dpif-netdev.c | 238
> +++---
> 1 file changed, 157 insertions(+), 81 deletions(-)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
On Fri, May 23, 2014 at 11:04 AM, Daniele Di Proietto
wrote:
> Signed-off-by: Daniele Di Proietto
LGTM
Acked-by: Pravin B Shelar
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, May 23, 2014 at 11:04 AM, Daniele Di Proietto
wrote:
> Signed-off-by: Daniele Di Proietto
> ---
> lib/netdev-dpdk.c | 139
> +++---
> 1 file changed, 80 insertions(+), 59 deletions(-)
>
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
On Fri, May 23, 2014 at 11:04 AM, Daniele Di Proietto
wrote:
> This change in dpif-netdev allows faster packet receiving for devices
> like netdev-dpdk which implement batch receiving.
>
> Signed-off-by: Daniele Di Proietto
> ---
> This patchset allows dpif-netdev to process packets in batches.
>
I'm happy with this. It's been merged.
Ethan
On Fri, May 30, 2014 at 3:38 PM, Ryan Wilson wrote:
> Python's time.time() function uses the system wall clock. However,
> if NTP resets the wall clock to be a time in the past, then this
> causes any applications that poll block based on time, such
From: Simon Horman
Date: Fri, 30 May 2014 14:35:19 +0900
> If an MPLS packet requires segmentation then use mpls_features
> to determine if the software implementation should be used.
>
> As no driver advertises MPLS GSO segmentation this will always be
> the case.
>
> I had not noticed that th
Python's time.time() function uses the system wall clock. However,
if NTP resets the wall clock to be a time in the past, then this
causes any applications that poll block based on time, such as
ovs-xapi-sync, to poll block indefinitely since the time is
unexpectedly negative.
This patch fixes the
Python's time.time() function uses the system wall clock. However,
if NTP resets the wall clock to be a time in the past, then this
causes NVPd threads to poll block indefinitely since the time is
unexpectedly negative.
This patch fixes the issue by using time.monotonic() if Python's
version >= 3.
On May 22, 2014, at 11:06 AM, Ben Pfaff wrote:
> On Thu, May 22, 2014 at 10:13:22AM -0700, Daniele Di Proietto wrote:
>> The new function mimics the semantics of 'hmap''s hmap_at_position().
>> It can be used to iterate through the classifier's rules when locking can't
>> be used
>>
>> Signed-o
Thx a lot for fixing this, pushed to branch-2.3
On Fri, May 30, 2014 at 1:07 PM, Alex Wang wrote:
> Acked-by: Alex Wang
>
> I'm about to apply it with the following additional fold in.
>
> Basically, move the 'bool force' before the struct which holds
> returned bfd/cfm status.
>
> diff --git
Ben,
How about just running something like this as the last test:
find tests -name core -print
and creating a test failure on non-empty output, even if no other test failures
were found?
Jarno
On May 29, 2014, at 5:16 PM, Jarno Rajahalme wrote:
> On May 29, 2014, at 3:06 PM, Ben Pfaff wr
Acked-by: Alex Wang
I'm about to apply it with the following additional fold in.
Basically, move the 'bool force' before the struct which holds
returned bfd/cfm status.
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index bae5e6a..7f59b94 100644
--- a/ofproto/ofproto-dpif.c
+++ b/
Skip some of the tests that uses '--monitor' as an option as
it is not implemented on Windows.
When a 'kill pid' is done on windows (through 'taskkill //F'),
pidfiles are not deleted (because it is force kill), so use
'ovs-appctl exit' instead.
Signed-off-by: Gurucharan Shetty
---
tests/daemon.
Some of the tests in test-lockfile.c uses fork to test a
child's ability to acquire lock. We do not fork in Windows.
We also do not support symlinks on Windows. So, comment out
those tests.
The error messages output is different in Windows and Linux. So
adjust the tests accordingly.
Signed-off-b
file_name.at tests dirname(), basename() and symlinks tests
that are POSIX related.
Though we run the unit tests on msys, msys
automatically converts '/' to a Windows equivalent 'C:/foo/bar'
So, dirname() and basename() wouldn't really work.
Also, Windows does not have a one-one symlink functiona
There is no 'kill -l' type functionality available on Windows.
So instead of looking for the string 'ABRT', check for the exit
code which when run on msys (unit test environment) is 9.
Also, after a call to abort(), on Windows, stderr does not get
flushed to any file. So, do not look for it.
Sign
And also disable the corresponding python tests.
Signed-off-by: Gurucharan Shetty
---
tests/jsonrpc-py.at |6 +++---
tests/test-jsonrpc.c |1 +
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/jsonrpc-py.at b/tests/jsonrpc-py.at
index 026d49a..08ffb6c 100644
--- a/te
We do not yet have a port for unixctl in Python. Till
deemed necessary, there is no plan to port it.
Signed-off-by: Gurucharan Shetty
---
tests/unixctl-py.at | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/unixctl-py.at b/tests/unixctl-py.at
index b54d409
This just makes ovs-benchmark compile on windows.
This lets us go ahead with just a 'make' instead of
picking and choosing executables that are tested to work on
windows as arguments for make.
This commit does not make ovs-benchmark a supported utility
on windows.
Signed-off-by: Gurucharan Shetty
Python daemon functions haven't been ported for Windows. As of now,
there is no use for it on Windows. If such a use case comes up,
we will have to port them. Till then don't run those tests on
Windows.
Signed-off-by: Gurucharan Shetty
---
tests/daemon-py.at | 18 +-
1 file cha
Fix the bug which did not kill the processes with pids that had
a zero in them. Also, some tests do a AT_CHECK([kill `cat pid`]) which
on windows prints something on the stdout causing the tests to fail.
So supress it.
Signed-off-by: Gurucharan Shetty
---
tests/testsuite.at |8
1 fi
Signed-off-by: Gurucharan Shetty
---
.gitignore |2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index bd87a7f..22ea3ec 100644
--- a/.gitignore
+++ b/.gitignore
@@ -15,6 +15,7 @@
*.pdb
*.pyc
*.so
+*.suo
*~
*,cover
.#*
@@ -25,6 +26,7 @@
.dirstamp
.libs
.tmp
There are a couple of upcoming users.
Signed-off-by: Gurucharan Shetty
---
lib/automake.mk |1 +
lib/socket-util-windows.c | 41 +
lib/socket-util.h |2 ++
lib/stream.c | 21 -
4 files changed,
With Visual Studio and Msys combination, something is going
wrong when we do a '3
---
tests/library.at |2 +-
tests/test-flows.c |9 ++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests/library.at b/tests/library.at
index e3e8df2..bea9feb 100644
--- a/tests/libr
When a OVS daemon is configured to run as a Windows service,
when the service is stopped by calling service_stop(), the
windows services manager does not give enough time to do
everything in the atexit handler. So call the exit handler
directly from service_stop().
Signed-off-by: Gurucharan Shetty
After the change, both of them compile. test-netflow related
unit tests pass.
test-sflow related tests do not pass because
of LOOPBACK_INTERFACE constraints for 'agent'.
(It should be revisited later.)
Signed-off-by: Gurucharan Shetty
---
tests/test-netflow.c | 11 +--
tests/test-sflo
The constant MAX_PATH is already defined in Windows.
Signed-off-by: Gurucharan Shetty
---
lib/cmap.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/cmap.c b/lib/cmap.c
index a760235..0823dd1 100644
--- a/lib/cmap.c
+++ b/lib/cmap.c
@@ -516,7 +516,7 @@ static
According to msdn documentation, one is discouraged from using
IP_TOS for ipv4 sockets (it apparently does not actually set
anything). Also, IPV6_TCLASS does not exist in
Windows. Looks like Microsoft recommends QoS2 APIs to achieve
the same. Till we add those API calls, simply return on Windows.
On Mon, May 26, 2014 at 6:47 PM, Joe Stringer wrote:
> This was causing failures in 'make distcleancheck'.
>
> Signed-off-by: Joe Stringer
LGTM
Acked-by: Pravin B Shelar
> ---
> datapath/linux/Makefile.main.in |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/datap
Bridge, port and interface status changes are not sent to the
database if the connectivity and netdev sequence numbers have not
changed. However, if the previous database transaction fails, then
status changes will not be updated in the database until the
connectivity and netdev sequence numbers ch
On Fri, May 16, 2014 at 5:33 PM, Andy Zhou wrote:
> When deleting a mask from the mask array, we always move the last entry
> into its current location. Another approach can be NULL in its current
> place, and periodically compact it.
>
> The approach taken by this patch is more efficient during r
Bridge, port and interface status changes are not sent to the
database if the connectivity and netdev sequence numbers have not
changed. However, if the previous database transaction fails, then
status changes will not be updated in the database until the
connectivity and netdev sequence numbers ch
Hi,
Are you be interested to procure our latest Release of VMware ESX Server/
Citrix XenApp Users Database for your lead generation, marketing, business
development, sales, campaign, tele-marketing etc.
A few of the most popular technology database in Virtualization:
. Workstation
.
Ah.
I'll mark this as "deferred" in patchwork, then, and let Pravin or Jesse
resurrect it if they think it's worthwhile.
On Fri, May 30, 2014 at 01:55:38PM +1200, Joe Stringer wrote:
> Pravin,
>
> If we're not really expecting distcleancheck to work as a separate target
> from its call in distcl
On Fri, May 30, 2014 at 05:30:31PM +0200, Jelle de Jong wrote:
> It would be nice if 2.1.0+git20140411-2 or 2.1.2 would hit testing and
> can be back-ported, but I don't know what is holding this back.
Build failures (really, failures in the testsuite) on non-x86. It's my
fault; I'm overdue to tr
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello everybody,
I would like to see openvswitch from unstable available in
wheezy-backports.
The current ingratiation with the debian/interface file is broken.
People on the openvswitch mailinglist have been saying the situation
is better with a new
My reading of handle_delete_meter() is that OFPRR_METER_DELETE is used.
Accordingly delete the entry relating to it from OPENFLOW-1.1+.
Signed-off-by: Simon Horman
---
OPENFLOW-1.1+ | 5 -
1 file changed, 5 deletions(-)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
index 4d7f836..9763a39 10064
OFPRR_METER_DELETE was introduced in OF1.4 however meters were introduced
in OF1.3.
Regardless of the OF version when flows are deleted cause flows to be
deleted handle_delete_meter() calls delete_flows__() with
OFPRR_METER_DELETE as the reason.
In order to avoid sending OFPRR_METER_DELETE to con
Use OFPRR_GROUP_DELETE as the reason for deleting flows due
to the removal of a group that they use.
This implementation adds an delete_reason member to struct ofputil_flow_mod
as a convenient way to set the reason used by delete_flows__() when it is
called indirectly from delete_group__().
Signe
51 matches
Mail list logo
