Based on the policy of 'OVS_VPORT_ATTR_UPCALL_PID', if upcall should
not be sent to userspace (i.e. the number of handler threads is zero),
the netlink message for creating vport should be an one-element array of
value 0. However, dpif_linux_port_add__() fails to obey it and generates
zero-payload
Commit 05bf6d3c62e1d (ovs-thread: Add checking for mutex and
rwlock initialization.) helps find an use of uninitialized
mutex (netdev_class_mutex) during upgrade. The assertion
check aborts the ovs.
This commit fixes the issue by adding the proper initialization.
Bug #1239914.
Bug #1240598.
Bug
This reverts commit 82e413df because bug fix bf52ed4 (datapath: Check for
backported skb_orphan_frags().) was required.
Signed-off-by: Justin Pettit
---
NEWS |4
configure.ac |2 +-
debian/changelog |6 --
3 files changed, 1 insertions(+), 11 deletions(-)
di
I normally wait for the announcement and the tarball, just in case some
last minute bug fix gets slipped in.
On Tue, Apr 29, 2014 at 01:40:46PM +1200, Joe Stringer wrote:
> Will you push a tag for this too?
>
>
> On 29 April 2014 10:31, Ben Pfaff wrote:
>
> > On Mon, Apr 28, 2014 at 02:57:17PM
Applied to branch-2.1 as well.
On 29 April 2014 10:21, Joe Stringer wrote:
> Thanks, applied.
>
>
> On 29 April 2014 09:27, Jesse Gross wrote:
>
>> On Sun, Apr 27, 2014 at 7:07 PM, Joe Stringer
>> wrote:
>> > This was causing build failures on debian wheezy. Check for the feature
>> > rather
On Tue, Apr 29, 2014 at 9:43 AM, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
> I'm not sure I totally follow Kmindg's comment, perhaps he could
> explain further? At any rate, once addressed I"m happy with this.
>
After a second look into this, I found that I misunderstood these code befor
The comment of miniflow_and_mask_matches_flow() need to be reworded.
Do we really need that function? Is it really that much faster?
Having two functions which do the exact same thing is a bit confusing.
So I suppose the only reason for a non zero inline_values array is for
those callers who can
Acked-by: Ethan Jackson
I'm not sure I totally follow Kmindg's comment, perhaps he could
explain further? At any rate, once addressed I"m happy with this.
Ethan
On Sat, Apr 19, 2014 at 10:09 PM, Kmindg G wrote:
> On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme
> wrote:
>> This allows use o
Will you push a tag for this too?
On 29 April 2014 10:31, Ben Pfaff wrote:
> On Mon, Apr 28, 2014 at 02:57:17PM -0700, Justin Pettit wrote:
> > Signed-off-by: Justin Pettit
>
> For both:
> Acked-by: Ben Pfaff
> ___
> dev mailing list
> dev@openvswit
Thanks for the review, pushed to master,
Jarno
On Apr 25, 2014, at 1:48 PM, Jesse Gross wrote:
> On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme
> wrote:
>> Key attributes relating to actual packet headers are ignored for
>> OVS_PACKET_CMD_EXECUTE as the header key attributes are retrieved
Thanks for the review, pushed to master,
Jarno
On Apr 14, 2014, at 7:25 PM, YAMAMOTO Takashi wrote:
>> Signed-off-by: Jarno Rajahalme
>
> Reviewed-by: YAMAMOTO Takashi
>
>> ---
>> lib/odp-util.c |2 +-
>> tests/odp.at |1 +
>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>
>>
Pushed to master,
Jarno
On Apr 25, 2014, at 1:47 PM, Jesse Gross wrote:
> On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme
> wrote:
>> In general, all Netlink 64-bit data may be 4-byte aligned, due to
>> netlink header and attributes being 4-aligned.
>>
>> To avoid unaligned access the dat
Pushed to master,
Jarno
On Apr 14, 2014, at 1:23 PM, Jarno Rajahalme wrote:
>
>> On Apr 14, 2014, at 1:00 PM, Justin Pettit wrote:
>>
>> It looks like there are a few other places that need to get updated, too.
>> Did you want me to take a pass at them?
>>
>
> Why not, seems you found
On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gross wrote:
> On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrote:
> > On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
> >> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
> >> wrote:
> >> >> On Thu, Apr 24, 2014 at 05:57:29PM +0900
Thanks, applied.
On Mon, Apr 28, 2014 at 03:57:24PM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
>
>
> On April 28, 2014 at 3:45:26 PM, Ben Pfaff (b...@nicira.com) wrote:
> > Commit 1335a8d578b03e (tests: Fix race condition waiting for monitor
> > thread.) fixed a race condition in
Currently physical ports stats are collected from kernel datapath.
However, those counter do not reflect actual wire packet counters
when LSO or TSO are enabled by the NIC. In the meantime, the stats
collected form routing stack does. While both stats are valid, Reporting
netlink stats for packet c
On Thu, Apr 24, 2014 at 10:34:15PM -0700, Andy Zhou wrote:
> Bond rebalancing was disabled for bonds not using recirculation. The
> patch fixes this bug.
>
> While fixing the bug, the bond_rebalance() was also restructured
> slightly to move bond related logic back into ofproto/bond.c
>
> Signed-
Acked-by: Justin Pettit
On April 28, 2014 at 3:45:26 PM, Ben Pfaff (b...@nicira.com) wrote:
> Commit 1335a8d578b03e (tests: Fix race condition waiting for monitor
> thread.) fixed a race condition in a test. Commit 8ba0a5227f6 (ovs-thread:
> Make caller provide thread name when creating a threa
On Thu, Apr 24, 2014 at 10:34:14PM -0700, Andy Zhou wrote:
> When recirc pool is exhausted, a new bond won't be allocate a new
> recirc_id. The bond->recirc_id will remain zero. This condition
> should prevent the bond from use recirculation. This check was missing
> before this patch.
>
> Signed-
On Mar 20, 2014, at 10:05 AM, Ben Pfaff wrote:
> On Fri, Mar 14, 2014 at 04:19:52PM +0900, Simon Horman wrote:
>> When creating a flow in the datapath as the result of an upcall
>> the match itself is the match supplied in the upcall while
>> the mask of the match, if supplied, is generated base
Acked-by: Ethan Jackson
I don't really like the API we've ended up with here. But I think
it's fine for now. As discussed offline, I intend to change it later.
Ethan
On Thu, Apr 24, 2014 at 6:25 PM, Ethan Jackson wrote:
> I haven't read this patch yet, but a high level question. Why not
> j
Thanks, I applied these.
On Fri, Apr 25, 2014 at 11:50:43AM -0700, Andy Zhou wrote:
> Looks great. Thanks!
>
> On Fri, Apr 25, 2014 at 9:56 AM, Ben Pfaff wrote:
> > If 'lacp' is NULL, then lacp_create() might not have been called to
> > indirectly initialize the mutex via lacp_init(), so call la
Commit 1335a8d578b03e (tests: Fix race condition waiting for monitor
thread.) fixed a race condition in a test. Commit 8ba0a5227f6 (ovs-thread:
Make caller provide thread name when creating a thread.) slightly changed
the output that the test checked, breaking the test. However, I was used
to the
On Mon, Apr 28, 2014 at 02:48:56PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
For both patches:
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Apr 28, 2014 at 02:57:17PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
For both:
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thank you for the reviews. I'll push these patches in a minute.
On Mon, Apr 28, 2014 at 02:10:27PM -0700, Alex Wang wrote:
> Acked-by: Alex Wang
>
>
> On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff wrote:
>
> > This made it easier for me to find a thread that was causing stalls.
> >
> > Signed-o
On Mon, Apr 28, 2014 at 11:48:34AM -0700, Alex Wang wrote:
> This is helpful,??? just two comments,
>
> On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff wrote:
>
> > This patch is a prerequisite for making RCU report the name of a thread
> > that is blocking RCU synchronization,
> > *because the easie
Thanks, applied.
On 29 April 2014 09:27, Jesse Gross wrote:
> On Sun, Apr 27, 2014 at 7:07 PM, Joe Stringer
> wrote:
> > This was causing build failures on debian wheezy. Check for the feature
> > rather than the version.
> >
> > Signed-off-by: Joe Stringer
>
> Acked-by: Jesse Gross
>
__
We now increment the version immediately after a release.
Signed-off-by: Justin Pettit
---
NEWS |4
configure.ac |2 +-
debian/changelog |6 ++
3 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index 32dc352..a31740e 100644
--- a/NEW
Signed-off-by: Justin Pettit
---
NEWS |3 ++-
configure.ac |2 +-
debian/changelog |9 +
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index eeba849..32dc352 100644
--- a/NEWS
+++ b/NEWS
@@ -1,7 +1,8 @@
-Post-v2.1.0
+v2.1.1 - 28 Ap
Signed-off-by: Justin Pettit
---
NEWS |4
configure.ac |2 +-
debian/changelog |7 +++
3 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index 98db34e..74b57ff 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+Post-v2.2.0
+---
Signed-off-by: Justin Pettit
---
NEWS |4 ++--
configure.ac |2 +-
debian/changelog | 24
3 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/NEWS b/NEWS
index 02ecf5b..98db34e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@
-Post-v2.1.0
On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrote:
> On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
>> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
>> wrote:
>> >> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
>> >>> hi,
>> >>>
>> >>> > + * Due to the sam
On Sun, Apr 27, 2014 at 7:07 PM, Joe Stringer wrote:
> This was causing build failures on debian wheezy. Check for the feature
> rather than the version.
>
> Signed-off-by: Joe Stringer
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
ht
Acked-by: Alex Wang
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff wrote:
> This made it easier for me to find a thread that was causing stalls.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ovs-rcu.c| 24 +++-
> lib/ovs-thread.c |4 +++-
> 2 files changed, 26 insertions
This is helpful, just two comments,
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff wrote:
> This patch is a prerequisite for making RCU report the name of a thread
> that is blocking RCU synchronization,
> *because the easiest way to do that gets the name of the thread in
> ovsrcu_quiesce_end(), *w
This is a hard to notice one~,
Acked-by: Alex Wang
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff wrote:
> Otherwise ovsrcu_synchronize() busy-waits in its loop because its
> poll_block() un-quiesces, causing the global_seqno to increase, which is
> what it waits for.
>
> Reported-by: Alex Wang
thx for fixing this,
Acked-by: Alex Wang
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff wrote:
> Otherwise the udpif revalidator threads can postpone RCU callbacks
> essentially forever, especially if there are many revalidator threads and
> little network traffic.
>
> Reported-by: Alex Wang
> S
On Sun, Mar 30, 2014 at 12:26:55PM +0100, Dave Tucker wrote:
> The Open vSwitch daemons written in C support user-configured logging
> patterns as described in ovs-appctl(8). This commit adds this capability
> to the daemons written in Python.
>
> - Add a '__log_patterns' attribute to the Vlog cla
Alex Wang pointed out that the RCU postpone thread can end up busy-waiting.
The first two patches in this series fix the problem. The remaining two
patches make it easier to track down threads that never quiesce.
Ben Pfaff (4):
timeval: Preserve quiescence across time_poll().
ovs-thread: Quie
Otherwise ovsrcu_synchronize() busy-waits in its loop because its
poll_block() un-quiesces, causing the global_seqno to increase, which is
what it waits for.
Reported-by: Alex Wang
Signed-off-by: Ben Pfaff
---
lib/ovs-rcu.c |7 +++
lib/ovs-rcu.h |1 +
lib/timeval.c | 14 +-
Thread names are occasionally very useful for debugging, but from time to
time we've forgotten to set one. This commit adds the new thread's name
as a parameter to the function to start a thread, to make that mistake
impossible. This also simplifies code, since two function calls become
only one.
This made it easier for me to find a thread that was causing stalls.
Signed-off-by: Ben Pfaff
---
lib/ovs-rcu.c| 24 +++-
lib/ovs-thread.c |4 +++-
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/lib/ovs-rcu.c b/lib/ovs-rcu.c
index c1ac61a..8a12564 1
Otherwise the udpif revalidator threads can postpone RCU callbacks
essentially forever, especially if there are many revalidator threads and
little network traffic.
Reported-by: Alex Wang
Signed-off-by: Ben Pfaff
---
lib/ovs-thread.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/lib
On Apr 28, 2014, at 2:09 AM, Martino Fornasa wrote:
> Jarno Rajahalme wrote:
>
>> move_rstp() does not check ‘changes’ before clearing it. Consider enforcing
>> the invariant,
>> or maybe do not bother setting ‘changes’ right before calling ‘move_rstp()’ ?
>>
> Not clear to me. Function mov
Sehr geehrter Damen und Herren,
Vorname/ Martins
Name/ U.Ezoh
Nationalitaet/ Sierra Leonean
Ich habe die Summe von USD 7.2millionen von meinen verstorbenen Eltern geebrt.
Meine Eltern wurden Diamanten Haendler.
Das Geld wurde von meinen Eltern in der Sicherheitsfirma fuer sicheres Behalten
Jarno Rajahalme wrote:
move_rstp() does not check ‘changes’ before clearing it. Consider enforcing the
invariant,
or maybe do not bother setting ‘changes’ right before calling ‘move_rstp()’ ?
Not clear to me. Function move_rstp does check 'changes':
move_rstp(struct rstp *rstp )
{
int port_n
Hi All,
I want to print the netlink statistics of vswitchd process. My requirement
is to get all the netlink count for flow additions from vswitchd process.
Is there any way to get the netlink statistics?
Please help me to get these statistics.
--
Thanks & Regards
Neelakantam Gaddam
__
On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
> wrote:
> >> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
> >>> hi,
> >>>
> >>> > + * Due to the sample action there may be multiple possible eth types.
> >>> > +
49 matches
Mail list logo
