On Apr 28, 2014, at 2:09 AM, Martino Fornasa <m...@fornasa.it> wrote:

> Jarno Rajahalme wrote:
> 
>> move_rstp() does not check ‘changes’ before clearing it. Consider enforcing 
>> the invariant, 
>> or maybe do not bother setting ‘changes’ right before calling ‘move_rstp()’ ?
>>  
> Not clear to me. Function move_rstp does check 'changes':
> 

I missed that, sorry.

  Jarno
>> move_rstp(struct rstp *rstp )
>> {
>>     int port_no, num_iterations;
>>     num_iterations = 0;
>>     
>>     while (rstp->changes == true && num_iterations < MAX_RSTP_ITERATIONS) {
>>  [...]
> 
> 
> 

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to