Thx for the comments Joe,
Please see my reply inline:
On Thu, Apr 10, 2014 at 7:49 PM, Joe Stringer wrote:
> I see two primary functional changes here:
>
Great summary. This also makes me feel bad about my commit message. I'll
add these two points!!! ;D
> (1) Do not wake up the main th
I see two primary functional changes here:
(1) Do not wake up the main thread every 100ms.
This means that if nothing is changing, the main thread will wake up less
often, so it does less work. This sounds good.
(2) Allow the database to be updated more often than every 100ms for
instant_stats (i
On Thu, Apr 10, 2014 at 1:11 PM, Ben Pfaff wrote:
> On Thu, Apr 10, 2014 at 12:27:45PM -0700, Andy Zhou wrote:
>> From: Andy Zhou
>>
>>
>> Signed-off-by: Andy Zhou
>
> In ofputil_group_stats_to_ofp11__(), s/packet/byte/ here:
> + bucket_cnts[i].byte_count = htonll(gs->bucket_stats[i].packe
On Thu, Apr 10, 2014 at 8:43 AM, Zoltan Kiss wrote:
> This is the ported version of commit 36d5fe6a with the same name from
> net-next.
> Apart from the small datapath.c changes it adjust the compat layer files as
> well. This is the original commit message:
>
> "skb_zerocopy can copy elements of
This commit removes the 'Instant' stats related logic in bridge.c.
Instead, the corresponding status is updated immediately after the
global connectivity sequence number changes. This will slightly
increase the update speed, since the 'Instant' stats update period
is 100 millisecond. Moreover, th
This commit adds boolean flag in bfd/cfm module for checking
status change. If there is no status change, the current
update to OVS database will skip the bfd/cfm session.
In the experiment with 5K bfd sessions, when one session is
flapping at rate of every 0.3 second, this patch reduces the
cpu
On Tue, Feb 25, 2014 at 3:44 PM, Pritesh Kothari
wrote:
> This patch adds support for Network Service Headers (nsh) over VXLAN
> as mentioned in [1]. Here changes are made to datapath to add nsh
> headers whenever a vxlan port with destination port as 6633 (which is
> IANA allocated port for nsh o
On Thu, Mar 20, 2014 at 4:37 AM, Lori Jakab wrote:
> On 1/6/14, 7:55 PM, Jesse Gross wrote:
>> On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
>>> diff --git a/datapath/actions.c b/datapath/actions.c
>>> index 30ea1d2..b90e715 100644
>>> --- a/datapath/actions.c
>>> +++ b/datapath/actions.c
I have had a single MPLS label system working with OVS, now I am trying to
stack multiple labels and am having issues maybe you all have some insightŠ
here¹s the setup:
H1 ‹ S1 ‹ S2 ‹ S3 ‹ H3
|
H2
S1 S2 has MPLS label 12, and S2 S1 has MPLS label 21
S2 S3 has MPLS labe
Removed the 'inline' and applied all three patches.
Thanks,
On Thu, Apr 10, 2014 at 12:20 PM, Ben Pfaff wrote:
> On Thu, Apr 10, 2014 at 11:06:14AM -0700, Alex Wang wrote:
> > This commit can be seen as a partial revert of commit
> > da4a619179d (netdev: Globally track port status changes)
> >
Thanks!
On Thu, Apr 10, 2014 at 12:31:20PM -0700, Alex Wang wrote:
> After discussing with Ben, offline, I decide to discard the patch 7/8 and
> 8/8.
>
> Instead, I'll add an option that allows users to change the stats update
> frequency.
>
>
> On Wed, Apr 9, 2014 at 4:23 PM, Ben Pfaff wrote:
On Thu, Apr 10, 2014 at 11:06:16AM -0700, Alex Wang wrote:
> This commit uses the 'change_seq' in 'struct netdev' to determine
> whether to update the 'ofport'. This helps eliminate unnecessary
> update.
>
> In the experiment of configuring 5K internal port, there is neither
> observable configur
On Thu, Apr 10, 2014 at 11:06:15AM -0700, Alex Wang wrote:
> This commit makes the netdev-dpdk module signal the change of
> etheraddr and mtu by changing the global sequence number and
> incrementing its 'change_seq'.
>
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
___
On Thu, Apr 10, 2014 at 12:27:45PM -0700, Andy Zhou wrote:
> From: Andy Zhou
>
>
> Signed-off-by: Andy Zhou
In ofputil_group_stats_to_ofp11__(), s/packet/byte/ here:
+ bucket_cnts[i].byte_count = htonll(gs->bucket_stats[i].packet_count);
Otherwise:
Acked-by: Ben Pfaff
_
On Thu, Apr 10, 2014 at 12:27:44PM -0700, Andy Zhou wrote:
> From: Andy Zhou
>
> Uncomment bucket_stats definition in struct ofp13_group_stats
> to better match OpenFlow spec 1.3.3's definition on page 91.
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
__
Hello Guys,
Currently we are working on SDN project with OVS. so we are doing some exp
on OVS. Here is our configuration.
We have created a bridge br1 and add two ports eth2 and eth3
"
ovs:~% sudo ovs-ofctl show br1
OFPT_FEATURES_REPLY (xid=0x1): dpid:da75f850764d
n_tables:255, n_buffers:256
On Thu, Apr 10, 2014 at 12:27:43PM -0700, Andy Zhou wrote:
> From: Andy Zhou
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
After discussing with Ben, offline, I decide to discard the patch 7/8 and
8/8.
Instead, I'll add an option that allows users to change the stats update
frequency.
On Wed, Apr 9, 2014 at 4:23 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 03:00:42PM -0700, Alex Wang wrote:
> > This command adds
From: Andy Zhou
Uncomment bucket_stats definition in struct ofp11_group_stats
to better match OpenFlow spec 1.1's definition on page 48.
Signed-off-by: Andy Zhou
---
include/openflow/openflow-1.1.h | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/include/
From: Andy Zhou
Signed-off-by: Andy Zhou
---
lib/ofp-util.c | 85 +---
1 file changed, 44 insertions(+), 41 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index b3d86e9..87c30c3 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@
From: Andy Zhou
Uncomment bucket_stats definition in struct ofp13_group_stats
to better match OpenFlow spec 1.3.3's definition on page 91.
Signed-off-by: Andy Zhou
---
include/openflow/openflow-1.3.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/openflow/
On Thu, Apr 10, 2014 at 11:06:14AM -0700, Alex Wang wrote:
> This commit can be seen as a partial revert of commit
> da4a619179d (netdev: Globally track port status changes)
> by adding the 'change_seq' to 'struct netdev'.
>
> Signed-off-by: Alex Wang
I would not inline netdev_change_seq_changed
On Fri, Apr 04, 2014 at 11:58:31AM +0300, Alexandru Copot wrote:
> These tests can now properly print packets with the new protocol version.
>
> Signed-off-by: Alexandru Copot
> Cc: Daniel Baluta
I guess these tests got broken by the ofp_print_version() change in
the first patch. I would break
On Fri, Apr 04, 2014 at 11:58:30AM +0300, Alexandru Copot wrote:
> This also enables OF1.4 for all the tests.
>
> Signed-off-by: Alexandru Copot
> Cc: Daniel Baluta
It's good as far as it goes, but ideally we'd add bundle support to
ovs-ofctl so that we don't have to send all these messages wit
On Fri, Apr 04, 2014 at 11:58:29AM +0300, Alexandru Copot wrote:
> This is only the communication part of the bundles functionality.
> The actual message pre-validation and commits are not implemented.
>
> Signed-off-by: Alexandru Copot
> Cc: Daniel Baluta
Hi Alexandru. Thank you for the patch
This commit uses the 'change_seq' in 'struct netdev' to determine
whether to update the 'ofport'. This helps eliminate unnecessary
update.
In the experiment of configuring 5K internal port, there is neither
observable configuration overhead nor additional cpu consumption
after configuration finis
This commit makes the netdev-dpdk module signal the change of
etheraddr and mtu by changing the global sequence number and
incrementing its 'change_seq'.
Signed-off-by: Alex Wang
---
PATCH -> V2:
- rebase.
---
lib/netdev-dpdk.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/netdev
Hey Ben,
Just resent the first 3 patches, with one more simplification.
Could you look at it?
Thanks,
Alex Wang
On Wed, Apr 9, 2014 at 4:26 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 03:00:38PM -0700, Alex Wang wrote:
> > This commit uses the 'change_seq' in 'struct netdev' to determine
This commit can be seen as a partial revert of commit
da4a619179d (netdev: Globally track port status changes)
by adding the 'change_seq' to 'struct netdev'.
Signed-off-by: Alex Wang
---
PATCH -> V2:
- simplify the code by moving the change of global connectivity seq to
netdev_change_seq_chang
On Thu, Apr 10, 2014 at 05:14:46PM +0200, Santiago wrote:
> Package: ovsdbmonitor
> Version: 2.1.0+git20140325-1
> Severity: important
>
> Hi,
>
> ovsdbmonitor requires these two packages to run.
Oops.
I think the best solution is probably to remove ovsdbmonitor entirely,
since it isn't well ma
Thanks, applied to master, branch-2.1, branch-2.0.
On Mon, Mar 31, 2014 at 09:27:32AM +1300, Joe Stringer wrote:
> Acked-by: Joe Stringer
>
>
> On 18 March 2014 10:35, Ben Pfaff wrote:
>
> > 'created' is supposed to be the time the flow was created, but it was
> > getting reset to zero on eve
Thanks, applied to master.
On Sun, Apr 06, 2014 at 04:58:31PM -0700, Alex Wang wrote:
> Acked-by: Alex Wang
>
>
>
> On Mon, Feb 10, 2014 at 12:08 PM, Ben Pfaff wrote:
>
> > This should prevent timing out.
> >
> > Reported-by: Andrey Korolyov
> > Signed-off-by: Ben Pfaff
> > ---
> > tests/
A Debian bug was recently filed against ovsdbmonitor:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=744136
I suspect that, if fixed, additional bugs will follow, because
ovsdbmonitor was poorly maintained and not widely used, which is why
ovsdbmonitor was removed from master. Does any
This is the ported version of commit 36d5fe6a with the same name from net-next.
Apart from the small datapath.c changes it adjust the compat layer files as
well. This is the original commit message:
"skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
orphan them. Also,
On 09/04/14 22:52, Jesse Gross wrote:
On Wed, Apr 9, 2014 at 9:20 AM, Zoltan Kiss wrote:
This is the ported version of commit 36d5fe6a with the same name from net-next.
Apart from the small datapath.c changes it adjust the compat layer files as
well. This is the original commit message:
"skb_z
On Thu, Apr 10, 2014 at 04:57:51PM +1200, j...@wand.net.nz wrote:
> From: Joe Stringer
>
> This makes the GitHub interface aware of the contribution guidelines,
> so it will be displayed to contributors when they submit issues or pull
> requests.
>
> Signed-off-by: Joe Stringer
Applied, thanks
Package: ovsdbmonitor
Version: 2.1.0+git20140325-1
Severity: important
Hi,
ovsdbmonitor requires these two packages to run.
Regards,
Santiago RR.
-- System Information:
Debian Release: 7.4
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable'), (10, 'unstable')
Ar
On Thu, Apr 10, 2014 at 06:36:44PM +0800, ZhengLingyun wrote:
>
>
> Signed-off-by: ZhengLingyun
Thanks, applied to master, branch-2.1, branch-2.0.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Store the error condition of a failed port configuration in a new
column 'error' in the Interface table.
Example:
$ ovs-vsctl add-port br0 test -- \
set Interface test type=vxlan options:unknown=1
ovs-vsctl: Error detected while setting up 'test'. [...]
$ ovs-vsctl list Interface test | gre
An ofport value of -1 already indicates an error occured during configuration
but does not provide any details. The now introduced error column allows
storing a human readable error string for every failed Interface object.
Thomas Graf (3):
vlog: Provide convenience macros to additionally store
a425a102-c317-4743-b0ba-79d59ff04a74
Bridge "br0"
[...]
Port test
Interface test
type: vxlan
options: {unknown="1"}
error: "test: could not set configuration (Invalid argument)"
ovs_version: "2.1.90"
Signed-off-by:
Signed-off-by: Thomas Graf
---
lib/vlog.h | 12
1 file changed, 12 insertions(+)
diff --git a/lib/vlog.h b/lib/vlog.h
index 0f791af..e5af21d 100644
--- a/lib/vlog.h
+++ b/lib/vlog.h
@@ -205,6 +205,11 @@ void vlog_rate_limit(const struct vlog_module *, enum
vlog_level,
#define VLOG
Signed-off-by: ZhengLingyun
---
lib/vlandev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vlandev.c b/lib/vlandev.c
index 382487c..d2f5a37 100644
--- a/lib/vlandev.c
+++ b/lib/vlandev.c
@@ -374,7 +374,7 @@ static int
vlandev_del__(const char *vlan_dev)
{
st
> Thanks. I am not a committer, could you push this for me?
pushed.
YAMAMOTO Takashi
> On 10 Apr 2014 17:32, "YAMAMOTO Takashi" wrote:
>
>> > From: Joe Stringer
>>
>> thanks.
>>
>> Acked-by: YAMAMOTO Takashi
>>
>> >
>> > Signed-off-by: Joe Stringer
>> > ---
>> > tests/ofproto-dpif.at |
44 matches
Mail list logo
