Looks good, thank you.
On Apr 8, 2014 9:00 PM, "YAMAMOTO Takashi" wrote:
> Leftovers from commit commit 1f317cb5.
> ("ofpbuf: Introduce access api for base, data and size.")
>
> This fixes regressons introduced by commit 3f976e12.
> ("lib/ofpbuf: Rename private fields to discourage direct use.")
Leftovers from commit commit 1f317cb5.
("ofpbuf: Introduce access api for base, data and size.")
This fixes regressons introduced by commit 3f976e12.
("lib/ofpbuf: Rename private fields to discourage direct use.")
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 12 ++--
1 file ch
Thanks for the review. I am happy about the simple solution also.
Pushed to the master.
On Tue, Apr 8, 2014 at 5:15 PM, Ben Pfaff wrote:
> On Mon, Apr 07, 2014 at 10:32:31PM -0700, Andy Zhou wrote:
>> This patch took advantage of the recirculation infrastructure
>> introduced in commit adcf00ba35
On Fri, Apr 4, 2014 at 9:20 PM, wei zhang wrote:
> At 2014-04-05 07:05:59,"Jesse Gross" wrote:
>>On Tue, Apr 1, 2014 at 5:23 PM, Wei Zhang wrote:
>>>
>>> v2 -> v1: use the same logic of the gre_rcv() to distinguish which packet is
>>> intended to us!
>>
>>As a tip on kernel process: if you put t
On Mon, Apr 07, 2014 at 10:32:31PM -0700, Andy Zhou wrote:
> This patch took advantage of the recirculation infrastructure
> introduced in commit adcf00ba35a0, allowing megaflows to be generated
> when the flow output to bond ports.
>
> Without recirculation, it is necessary flows output to Bond p
Applied to master, thanks!
On Tue, Apr 08, 2014 at 04:46:19PM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
>
>
> On April 8, 2014 at 4:43:09 PM, Ben Pfaff (b...@nicira.com) wrote:
> > The Open vSwitch repository has moved to Github.
> >
> > CC: Ethan Jackson
> > Signed-off-by: Ben
Acked-by: Justin Pettit
On April 8, 2014 at 4:43:09 PM, Ben Pfaff (b...@nicira.com) wrote:
> The Open vSwitch repository has moved to Github.
>
> CC: Ethan Jackson
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-dev.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --g
The Open vSwitch repository has moved to Github.
CC: Ethan Jackson
Signed-off-by: Ben Pfaff
---
utilities/ovs-dev.py |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
index 3f32e58..f73899b 100755
--- a/utilities/ovs-dev.py
++
Masked set actions allow more megaflow wildcarding. All other key
types than the tunnel key that can be set, can now be set with a mask.
It is not clear wether masked set is useful for skb_priority.
However, we already use the LSB of pkt_mark for IPSec in tunnels, so
it might be useful to be able
Key attributes relating to actual packet headers are ignored for
OVS_PACKET_CMD_EXECUTE as the header key attributes are retrieved
from the packet itself.
Signed-off-by: Jarno Rajahalme
---
include/linux/openvswitch.h |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/incl
Sorry for the typo in subject :-)
Jarno
On Apr 8, 2014, at 4:38 PM, Jarno Rajahalme wrote:
> Currently, if any field in IP header is set with a set action, all the
> IP header fields need to be matched exactly in the megaflow. This
> series adds support for masked set actions, requiring only
It is better to not abort().
Signed-off-by: Jarno Rajahalme
---
lib/ofp-actions.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 5a3bf70..ce14004 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -2589,6 +2589,8 @@ o
Later patches rely on the DSCP and ECN masks to be properly set when
the fields are read. Also, avoid reading nw_tos if tunnel's inner
packet is not IP.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-xlate.c |2 +-
ofproto/tunnel.c | 37 ---
It would seem that we should set the 'tun_dst' in 'wc' when calling
tnl_port_should_receive(), as it is reading that flow field.
However, tnl_port_should_receive() returns true, if the flow has
tunnel metadata. If there is no tunnel metadata, then there is
nothing to mask, so we do not set the 'i
If the field does not exist, nothing is set. However, we must
unwildcard the bits we used to make the decision, and we need not
unwildcard the field and it's prerequisities, if nothing is set.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-xlate.c | 17 -
1 file chang
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-xlate.c |8 -
ofproto/ofproto-dpif-xlate.h |3 +-
ofproto/ofproto-dpif.c | 70 +-
3 files changed, 78 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofpr
Signed-off-by: Jarno Rajahalme
---
lib/odp-util.c | 397 +-
lib/odp-util.h |5 +-
ofproto/ofproto-dpif-xlate.c | 12 +-
tests/ofproto-dpif.at| 49 +++---
tests/tunnel.at |8 +-
5 files changed, 3
ofproto/trace incorrectly reported the megaflow based on the modified
flow, rather than the original flow key. Now the original flow key is
stored before any modifications and is used for reporting the megaflow.
Also, flow reporting is suppressed only for resubmit flows, so that
the final flow wi
Masked set actions add a mask, immediately following the netlink
attribute data, within the netlink attribute itself. Thus the key
attribute size for a masked set action is exactly double of the
non-masked set action.
Signed-off-by: Jarno Rajahalme
---
lib/odp-execute.c | 241 +
Currently, if any field in IP header is set with a set action, all the
IP header fields need to be matched exactly in the megaflow. This
series adds support for masked set actions, requiring only the header
bits actually read or set to be matched exactly by the resulting
megaflow.
As an example,
Signed-off-by: Pritesh Kothari
---
v2: Use OVS_GREP_IFELSE instead of upstream kernel versions as Thomas suggested.
---
FAQ |2 +-
NEWS |2 +-
acinclude.m4 |
On Tue, Apr 8, 2014 at 3:51 PM, Nicholas Bastin wrote:
> If you have the rev. 2 (blue) hardware, that is more of an unknown (I don't
> have one of these to look at or tinker with) - the 9558 has a 720Mhz MIPS
> core, so that's better, but I found images of a different AP that uses this
> chip on t
On Tue, Apr 8, 2014 at 4:29 PM, Alison Chan wrote:
> I was able to take the router back up to the lab (I had been testing
> it with laptops in my office). With two gigabit ethernet hosts on the
> data plane, throughput (tcp iperf) is 450~460 Mbit/s. I will test
> things a bit more tomorrow (e.g.
On Tue, Apr 08, 2014 at 02:33:55PM -0700, Jesse Gross wrote:
> On Mon, Apr 7, 2014 at 3:35 PM, Ben Pfaff wrote:
> > Flow statistics need to take into account the TCP flags from the packet
> > currently being processed (in 'key'), not the TCP flags matched by the
> > flow found in the kernel flow t
On Mon, Apr 7, 2014 at 3:35 PM, Ben Pfaff wrote:
> Flow statistics need to take into account the TCP flags from the packet
> currently being processed (in 'key'), not the TCP flags matched by the
> flow found in the kernel flow table (in 'flow').
>
> This bug made the Open vSwitch userspace fin_ti
Thanks Ben. I just subscribed to dev@ovs list.
I was able to take the router back up to the lab (I had been testing
it with laptops in my office). With two gigabit ethernet hosts on the
data plane, throughput (tcp iperf) is 450~460 Mbit/s. I will test
things a bit more tomorrow (e.g. adding 802.11
Thanks for review, pushed to master.
Jarno
On Apr 8, 2014, at 10:22 AM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 08:59:03AM -0700, Jarno Rajahalme wrote:
>> A recent commit reintroduced some direct use of the ofpbuf 'data' and
>> 'size'. Use the access API instead.
>>
>> Signed-off-
Thanks for review!
Pushed to master,
Jarno
On Apr 8, 2014, at 10:12 AM, Alex Wang wrote:
> Really like this one!
>
> For both:
> Acked-by: Alex Wang
>
>
> On Tue, Apr 8, 2014 at 8:59 AM, Jarno Rajahalme wrote:
> Direct use of 'data', 'base', and 'size' will break DPDK builds. Try
>
>> Also, if someone programmatically creates bridges using OVSDB, he is
>> now forced to add those bridges to some startup script. I don't think
>> it is feasible.
>
> Good point, but how you handle the networking configuration in this
> case? For instance, when the new bridge needs an IP address
---
lib/dpif-netdev.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 9fc51db..9ad9386 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -2151,10 +2151,7 @@ dp_execute_cb(void *aux_, struct ofpbuf *packet,
Packet metadata fields may be modified when execute post recirculation
actions. Current implementation only preserves recirc_id and dp_hash,
but not other fields. With this patch, a copy of metadata is supplied
instead of the original metadata for recirculation to preserve
the original value.
---
On Apr 8, 2014, at 8:54 AM, Thomas Graf wrote:
>> #endif
>> diff --git a/datapath/linux/compat/include/linux/skbuff.h
>> b/datapath/linux/compat/include/linux/skbuff.h
>> index de0c56a..812ed00 100644
>> --- a/datapath/linux/compat/include/linux/skbuff.h
>> +++ b/datapath/linux/compat/include/
Ethan,
I have not worked on this since, so this is the current version.
Jarno
On Apr 8, 2014, at 12:04 PM, Ethan Jackson wrote:
> Should I review this version of the patch? Or do you have a non-RFC
> version ready?
>
> Ethan
>
> On Mon, Mar 10, 2014 at 6:44 PM, Jarno Rajahalme
> wrote:
>
On Tue, Apr 08, 2014 at 11:10:01AM -0700, Gurucharan Shetty wrote:
> On Mon, Mar 31, 2014 at 1:19 PM, Ben Pfaff wrote:
> > On Tue, Mar 25, 2014 at 02:50:17PM -0300, Flavio Leitner wrote:
> >> It should be an administrator task to bring up devices as they
> >> are configured properly.
> >>
> >> Cur
Should I review this version of the patch? Or do you have a non-RFC
version ready?
Ethan
On Mon, Mar 10, 2014 at 6:44 PM, Jarno Rajahalme wrote:
> Intended to send this as an RFC,
>
> Jarno
>
> On Mar 10, 2014, at 6:43 PM, Jarno Rajahalme wrote:
>
>> This should optimize port masks for megafl
On Tue, Apr 08, 2014 at 10:39:42AM +0900, YAMAMOTO Takashi wrote:
> > On Sun, Apr 06, 2014 at 11:30:13AM +0900, YAMAMOTO Takashi wrote:
> >> Signed-off-by: YAMAMOTO Takashi
> >
> > Acked-by: Ben Pfaff
> >
> > Thanks a lot for fixing all these tests! Most of them do not
> > regularly fail for m
On Tue, Apr 08, 2014 at 09:46:51AM +0900, YAMAMOTO Takashi wrote:
> > Pravin, this patch includes a change to , will
> > you look at that part?
>
> thanks for review.
>
> does that file need special treatments?
It's part of the ABI for the kernel module, so I generally think it's
good to get the
On Tue, Apr 08, 2014 at 11:17:32AM -0700, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 09:35:20AM +0900, Simon Horman wrote:
> > Uniformly wait for calls to ovs-ofctl exit using
> > OVS_APP_EXIT_AND_WAIT() in the test-suite.
> >
> > Signed-off-by: Simon Horman
> >
> > v2
> > * Always use OVS_APP_E
On Tue, Apr 08, 2014 at 09:35:20AM +0900, Simon Horman wrote:
> Uniformly wait for calls to ovs-ofctl exit using
> OVS_APP_EXIT_AND_WAIT() in the test-suite.
>
> Signed-off-by: Simon Horman
>
> v2
> * Always use OVS_APP_EXIT_AND_WAIT(ovs-ofctl) instead of
> OVS_WAIT_UNTIL([ovs-appctl -t ovs-of
On 4/8/14, 3:34 AM, Simon Horman wrote:
[ Added CC to dev@openvswitch.org which was strangely missing
even though I recived the post via the list. Is the list
configuration broken somehow? ]
Not sure, I don't receive all messages from dev@ and thought it was a
problem on our side, but di
On Mon, Mar 31, 2014 at 1:19 PM, Ben Pfaff wrote:
> On Tue, Mar 25, 2014 at 02:50:17PM -0300, Flavio Leitner wrote:
>> It should be an administrator task to bring up devices as they
>> are configured properly.
>>
>> Currently, Fedora is deleting the bridges when the interface is
>> brought down. T
Jesse, I believe that Pravin is traveling today. Will you review this?
On Mon, Apr 07, 2014 at 03:35:26PM -0700, Ben Pfaff wrote:
> Flow statistics need to take into account the TCP flags from the packet
> currently being processed (in 'key'), not the TCP flags matched by the
> flow found in the
[adding ovs-dev since there might be interest there]
On Tue, Apr 08, 2014 at 11:56:28AM -0400, Alison Chan wrote:
> Hi everyone,
>
> I was able to get OpenVswitch running on one of our TL-WR1043ND
> routers running OpenWrt Attitude Adjustment. I was expecting somewhat
> better performance than Pa
On Tue, Apr 08, 2014 at 08:59:03AM -0700, Jarno Rajahalme wrote:
> A recent commit reintroduced some direct use of the ofpbuf 'data' and
> 'size'. Use the access API instead.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Ben Pfaff
___
dev mailing list
Really like this one!
For both:
Acked-by: Alex Wang
On Tue, Apr 8, 2014 at 8:59 AM, Jarno Rajahalme wrote:
> Direct use of 'data', 'base', and 'size' will break DPDK builds. Try
> to wean us off the habit by renaming the fields.
>
> Signed-off-by: Jarno Rajahalme
> ---
> lib/ofpbuf.h | 18
On 04/08/2014 12:00 AM, Pravin wrote:
diff --git a/datapath/flow_table.c b/datapath/flow_table.c
index 159572b..75c1b82 100644
--- a/datapath/flow_table.c
+++ b/datapath/flow_table.c
@@ -259,11 +259,11 @@ skip_flows:
__table_instance_destroy(ti);
}
-void ovs_flow_tbl_destroy(st
A recent commit reintroduced some direct use of the ofpbuf 'data' and
'size'. Use the access API instead.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
in
Direct use of 'data', 'base', and 'size' will break DPDK builds. Try
to wean us off the habit by renaming the fields.
Signed-off-by: Jarno Rajahalme
---
lib/ofpbuf.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h
index ea863d
On 04/07/2014 07:54 PM, Pritesh Kothari wrote:
diff --git a/datapath/linux/compat/include/linux/etherdevice.h
b/datapath/linux/compat/include/linux/etherdevice.h
index 556729d..88f8ee3 100644
--- a/datapath/linux/compat/include/linux/etherdevice.h
+++ b/datapath/linux/compat/include/linux/etherd
Thanks for fixing this,
Jarno
Acked-by: Jarno Rajahalme
On Apr 7, 2014, at 3:35 PM, Ben Pfaff wrote:
> Flow statistics need to take into account the TCP flags from the packet
> currently being processed (in 'key'), not the TCP flags matched by the
> flow found in the kernel flow table (in '
> On 8 Apr 2014 12:56, "YAMAMOTO Takashi" wrote:
>
>> > On 7 April 2014 20:12, YAMAMOTO Takashi wrote:
>> >
>> >> > I've been looking at some races in the megaflow testcases recently as
>> >> well,
>> >> > with a slightly different approach, could you a look at my patch
>> below?
>> >> >
>> >> >
51 matches
Mail list logo
