> >> Also, if someone programmatically creates bridges using OVSDB, he is >> now forced to add those bridges to some startup script. I don't think >> it is feasible. > > Good point, but how you handle the networking configuration in this > case? For instance, when the new bridge needs an IP address.
I think I agree with the thought process that says - "What good is an UPped bridge that has no IP address?". So I am fine with sticking with the changed behavior that this commit introduces. > >> I feel that a default UP has less negative consequences than a default down. > > Currently there is no clear boundary between ovsdb and system's admin tools, > so it's hard to tell which one is correct. > > I am not happy with Fedora's script deleting the bridges at shutdown > because the startup scripts can't restore all the possible configuration > ovsdb offers. However, somehow we need to know when the device should or > should not be restored/configured at the initialization and by that I mean, > bring the device to live with the proper networking configuration. I agree with you here too. I did not think through the consequence of the problem you solved and I think it is important to solve it. Your change does help. > > Today if the bridge doesn't exist, it's created and configured. If the > bridge exists, but it's down, then it is configured. Otherwise it's assumed > that the bridge is properly running. > >> Thanks, >> Guru >> >> > >> > Please give a title when referring to a commit in a log message, e.g.: >> > >> > This patch partially reverts the commit >> > bef071a5fdf8e2dd87677b04b3cf7a8f5094edcb (bridge: Always "up" internal >> > devices.). >> > >> > Finally, I would have just fixed all of the above and pushed it, >> > except that it also breaks half a dozen tests in the testsuite. >> > Please fix those and submit a v3. >> > >> > Thanks, >> > >> > Ben. >> > _______________________________________________ >> > dev mailing list >> > dev@openvswitch.org >> > http://openvswitch.org/mailman/listinfo/dev >> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
