Re: [ovs-dev] [bond megaflow v5 4/4] ofproto/bond: Implement bond megaflow using recirculation

2014-04-07 Thread Andy Zhou
You are right, it is not related. The sleep 1 is not needed to the machines I have tried it on. But since you are working on testing racing recently, I will leave it up to you. But it is not related to recirculation at any rate, as you pointed out. On Mon, Apr 7, 2014 at 8:48 PM, YAMAMOTO Takashi

[ovs-dev] [PATCH] dpif: Wildcard bond output port with recirculation

2014-04-07 Thread Andy Zhou
This patch took advantage of the recirculation infrastructure introduced in commit adcf00ba35a0, allowing megaflows to be generated when the flow output to bond ports. Without recirculation, it is necessary flows output to Bond ports in balance_tcp mode to unmask all hash fields. With recirculatio

[ovs-dev] [PATCH] ofproto-dpif: Remove the flow_dumper thread.

2014-04-07 Thread Joe Stringer
From: Ethan Jackson Previously, we had a separate flow_dumper thread that fetched flows from the datapath to distribute to revalidator threads. This patch takes the logic for dumping and pushes it into the revalidator threads, resulting in simpler code with similar performance to the current code

Re: [ovs-dev] [bond megaflow v5 4/4] ofproto/bond: Implement bond megaflow using recirculation

2014-04-07 Thread YAMAMOTO Takashi
> @@ -3859,7 +4001,7 @@ ovs-appctl time/stop > ovs-appctl time/warp 5000 > AT_CHECK([ovs-appctl netdev-dummy/receive p7 > 'in_port(1),eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0a),eth_type(0x0800),ipv4(src=10.0.0.2,dst=10.0.0.1,proto=1,tos=0,ttl=64,frag=no),icmp(type=8,code=0)']) > AT_CHECK(

[ovs-dev] [PATCH] datapath: recirculation infrastructure.

2014-04-07 Thread Andy Zhou
Recirculation implementation for Linux kernel data path. Signed-off-by: Andy Zhou --- datapath/actions.c | 55 ++- datapath/datapath.c | 35 ++ datapath/datapath.h |3 ++- datapath/flow.h |4

Re: [ovs-dev] [bond megaflow v5 4/4] ofproto/bond: Implement bond megaflow using recirculation

2014-04-07 Thread Andy Zhou
Thanks Ben for many review comments for this patch series. Pushed to master. On Mon, Apr 7, 2014 at 5:10 PM, Ben Pfaff wrote: > On Fri, Apr 04, 2014 at 04:03:02PM -0700, Andy Zhou wrote: >> Infrastructure to enable megaflow support for bond ports using >> recirculation. This patch adds the follow

Re: [ovs-dev] [PATCH] tests/ofproto-dpif: Use vlog to test dpif behaviour.

2014-04-07 Thread Joe Stringer
On 8 April 2014 13:53, YAMAMOTO Takashi wrote: > > To clarify, this patch is aimed at the following type of situation: > > * netdev-dummy puts the packet on the queue. > > * Upcall handler receives the packet, installs a flow. > > * Revalidator decides to delete the flow (examples are the flow fa

Re: [ovs-dev] [PATCH 04/11] ofproto-dpif.at: Fix some races in megaflow tests

2014-04-07 Thread Joe Stringer
On 8 Apr 2014 12:56, "YAMAMOTO Takashi" wrote: > > On 7 April 2014 20:12, YAMAMOTO Takashi wrote: > > > >> > I've been looking at some races in the megaflow testcases recently as > >> well, > >> > with a slightly different approach, could you a look at my patch > below? > >> > > >> > http://open

Re: [ovs-dev] [PATCH] tests/ofproto-dpif: Use vlog to test dpif behaviour.

2014-04-07 Thread YAMAMOTO Takashi
> To clarify, this patch is aimed at the following type of situation: > * netdev-dummy puts the packet on the queue. > * Upcall handler receives the packet, installs a flow. > * Revalidator decides to delete the flow (examples are the flow fails > revalidation, or flow is deemed unimportant, other

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

2014-04-07 Thread Simon Horman
On Tue, Apr 08, 2014 at 10:20:54AM +0900, YAMAMOTO Takashi wrote: > > On Tue, Apr 08, 2014 at 10:00:47AM +0900, YAMAMOTO Takashi wrote: > >> > Uniformly wait for calls to ovs-ofctl exit using > >> > OVS_APP_EXIT_AND_WAIT() in the test-suite. > >> > >> are they all necessary to avoid some races? >

[ovs-dev] Von Dr. Andrea Orcel

2014-04-07 Thread Dr. Andrea Orcel
Von Dr. Andrea Orcel Ich bin Dr. Andrea Orcel von Harlesden , North West London, hier in England. Ich arbeite für UBS Bank , London . Ich schreibe Ihnen über ein Unternehmen Vorschlag, dass einer immensen Nutzen für beide von uns sein wird . In meiner Abteilung , wobei der Leiter Investment Ba

Re: [ovs-dev] [PATCH 11/11] ofproto-dpif.at: Fix a race in "idle_age and hard_age increase over time"

2014-04-07 Thread YAMAMOTO Takashi
> On Sun, Apr 06, 2014 at 11:30:13AM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff > > Thanks a lot for fixing all these tests! Most of them do not > regularly fail for me, but I can believe that they do for you in a > different configuration. i can

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

2014-04-07 Thread YAMAMOTO Takashi
> On Tue, Apr 08, 2014 at 10:00:47AM +0900, YAMAMOTO Takashi wrote: >> > Uniformly wait for calls to ovs-ofctl exit using >> > OVS_APP_EXIT_AND_WAIT() in the test-suite. >> >> are they all necessary to avoid some races? >> >> in commit 0c473314, i intended to make it wait only when necessary. >>

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

2014-04-07 Thread Simon Horman
On Tue, Apr 08, 2014 at 10:00:47AM +0900, YAMAMOTO Takashi wrote: > > Uniformly wait for calls to ovs-ofctl exit using > > OVS_APP_EXIT_AND_WAIT() in the test-suite. > > are they all necessary to avoid some races? > > in commit 0c473314, i intended to make it wait only when necessary. > ie. only

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

2014-04-07 Thread YAMAMOTO Takashi
> Uniformly wait for calls to ovs-ofctl exit using > OVS_APP_EXIT_AND_WAIT() in the test-suite. are they all necessary to avoid some races? in commit 0c473314, i intended to make it wait only when necessary. ie. only tests which have multiple "ovs-ofctl --pidfile". YAMAMOTO Takashi > > Signed-

Re: [ovs-dev] [PATCH] ofproto-dpif: Wait for output for all MPLS tests

2014-04-07 Thread Simon Horman
On Tue, Apr 08, 2014 at 09:39:57AM +0900, YAMAMOTO Takashi wrote: > > This corrects an inconsistency in the MPLS tests and > > avoids a race by waiting for sufficient output before > > checking its contents > > this one looks identical to: http://patchwork.openvswitch.org/patch/3579/ Agreed. >

Re: [ovs-dev] [PATCH] recirculation: Some cosmetic fixes

2014-04-07 Thread YAMAMOTO Takashi
> Pravin, this patch includes a change to , will > you look at that part? thanks for review. does that file need special treatments? YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ofproto-dpif: Wait for output for all MPLS tests

2014-04-07 Thread YAMAMOTO Takashi
> This corrects an inconsistency in the MPLS tests and > avoids a race by waiting for sufficient output before > checking its contents this one looks identical to: http://patchwork.openvswitch.org/patch/3579/ YAMAMOTO Takashi > > Signed-off-by: Simon Horman > --- > tests/ofproto-dpif.at | 3 +

Re: [ovs-dev] [PATCH 04/11] ofproto-dpif.at: Fix some races in megaflow tests

2014-04-07 Thread YAMAMOTO Takashi
> On 7 April 2014 20:12, YAMAMOTO Takashi wrote: > >> > I've been looking at some races in the megaflow testcases recently as >> well, >> > with a slightly different approach, could you a look at my patch below? >> > >> > http://openvswitch.org/pipermail/dev/2014-April/038536.html >> >> my patch

[ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

2014-04-07 Thread Simon Horman
Uniformly wait for calls to ovs-ofctl exit using OVS_APP_EXIT_AND_WAIT() in the test-suite. Signed-off-by: Simon Horman v2 * Always use OVS_APP_EXIT_AND_WAIT(ovs-ofctl) instead of OVS_WAIT_UNTIL([ovs-appctl -t ovs-ofctl exit]) --- tests/ofproto-dpif.at | 36 ++-

Re: [ovs-dev] Commit "ofproto-dpif.at: Wait for the monitor's pidfile disappears where necessary" breaks test 700

2014-04-07 Thread Simon Horman
[ Added CC to dev@openvswitch.org which was strangely missing even though I recived the post via the list. Is the list configuration broken somehow? ] On Mon, Apr 07, 2014 at 10:50:57AM +0300, Lori Jakab wrote: > Hi, > > On some of my systems the commit "0c47331 ofproto-dpif.at: Wait for > th

Re: [ovs-dev] [PATCH] ofproto-dpif-monitor: Fix deadlock.

2014-04-07 Thread Alex Wang
Yes, I can reproduce it, for example I have 2 vms, and I configure 2K bfd monitored tunnel together at the same time. And then, I can see one end will be deadlocked. On Mon, Apr 7, 2014 at 5:20 PM, Ben Pfaff wrote: > On Thu, Apr 03, 2014 at 09:02:48PM -0700, Alex Wang wrote: > > Commit 6b59b54

Re: [ovs-dev] [PATCH] ofproto-dpif-monitor: Fix deadlock.

2014-04-07 Thread Ben Pfaff
On Thu, Apr 03, 2014 at 09:02:48PM -0700, Alex Wang wrote: > Commit 6b59b543 (ovs-thread: Use fair (but nonrecursive) > rwlocks on glibc.) changed the rwlocks to nonrecursive, > writer-biased lock. It also made the following deadlock > situation possible. > > Assume BFD is used on both end of a l

Re: [ovs-dev] [bond megaflow v5 4/4] ofproto/bond: Implement bond megaflow using recirculation

2014-04-07 Thread Ben Pfaff
On Fri, Apr 04, 2014 at 04:03:02PM -0700, Andy Zhou wrote: > Infrastructure to enable megaflow support for bond ports using > recirculation. This patch adds the following features: > * Generate RECIRC action when bond can benefit from recirculation. > * Populate post recirculation rules in a hidden

Re: [ovs-dev] [PATCH] ofproto-dpif: Always wait for ovs-ofctl exit

2014-04-07 Thread Simon Horman
On Mon, Apr 07, 2014 at 11:19:17AM -0700, Ben Pfaff wrote: > On Mon, Apr 07, 2014 at 05:39:38PM +0900, Simon Horman wrote: > > Uniformly wait for calls to ovs-ofctl exit in the test-suite. > > > > Signed-off-by: Simon Horman > > This inserts two OVS_APP_EXIT_AND_WAITs and two OVS_WAIT_UNTILs. T

[ovs-dev] Problem while deleting bridge in OVS 2.1.0

2014-04-07 Thread Raghu Ram
Hi All, We are facing issues in deleting bridge after creating group in OVS 2.1.0 release. It appears like the issue is in ofproto_destroy function: = static void ofproto_destroy__(struct ofproto *ofproto) OVS_EXCLUDED(ofproto_mutex) { struct oftab

[ovs-dev] [PATCH] datapath: Fix tracking of flags seen in TCP flows.

2014-04-07 Thread Ben Pfaff
Flow statistics need to take into account the TCP flags from the packet currently being processed (in 'key'), not the TCP flags matched by the flow found in the kernel flow table (in 'flow'). This bug made the Open vSwitch userspace fin_timeout action have no effect in many cases. Bug #1219516. R

[ovs-dev] [PATCH 2/4] datapath: Add flow mask cache.

2014-04-07 Thread Pravin
From: Pravin Shelar On every packet OVS needs to lookup flow-table with every mask. the packet flow-key is first masked with mask in the list and then the masked key is looked up in flow-table. Therefore number of masks can affect packet processing performance. Following patch adds mask pointer

[ovs-dev] [PATCH 3/4] datapath: Convert mask list in mask array.

2014-04-07 Thread Pravin
From: Pravin Shelar mask caches index of mask in mask_list. On packet recv OVS need to traverse mask-list to get cached mask. Therefore array is better for retrieving cached mask. This also allows better cache replacement algorithm by directly checking mask's existence. Signed-off-by: Pravin

[ovs-dev] [PATCH 1/4] datapath: Move table destroy to dp-rcu callback.

2014-04-07 Thread Pravin
From: Pravin Shelar Ths simplifies flow-table-destroy API. This change is required for following patches. Signed-off-by: Pravin B Shelar --- datapath/datapath.c |5 ++--- datapath/flow_table.c |6 +++--- datapath/flow_table.h |2 +- 3 files changed, 6 insertions(+), 7 deletions(

[ovs-dev] [PATCH 4/4] datapath: Compact mask list array.

2014-04-07 Thread Pravin
From: Pravin Shelar Along with flow-table rehashing OVS can compact masks array. This allows us to calculate highest index for mask array. Signed-off-by: Pravin B Shelar --- datapath/flow_table.c | 24 datapath/flow_table.h |2 +- 2 files changed, 21 insertions(

Re: [ovs-dev] [PATCH 04/11] ofproto-dpif.at: Fix some races in megaflow tests

2014-04-07 Thread Joe Stringer
On 7 April 2014 20:12, YAMAMOTO Takashi wrote: > > I've been looking at some races in the megaflow testcases recently as > well, > > with a slightly different approach, could you a look at my patch below? > > > > http://openvswitch.org/pipermail/dev/2014-April/038536.html > > my patch inserts sle

Re: [ovs-dev] [PATCH 1/5] dpif: Introduce ofproto flow lookup function.

2014-04-07 Thread Ben Pfaff
On Thu, Apr 03, 2014 at 05:47:04PM -0700, Pravin Shelar wrote: > On Thu, Apr 3, 2014 at 2:41 PM, Ben Pfaff wrote: > > I don't like seeing this as a global variable. Can it be per-datapath > > (probably set using a new provider callback function)? > > > There can be only one definition of this cal

Re: [ovs-dev] [PATCH 4/5] ofproto: Define ofproto_flow_lookup()

2014-04-07 Thread Ben Pfaff
On Thu, Apr 03, 2014 at 05:52:01PM -0700, Pravin Shelar wrote: > On Thu, Apr 3, 2014 at 3:09 PM, Ben Pfaff wrote: > > I don't think that ofproto_flow_lookup() modifies its 'flow' argument, > > but dp_handle_miss() makes a writable copy and passes in that copy. I > > think that we could drop makin

Re: [ovs-dev] [PATCH] ofproto-dpif: Wait for output for all MPLS tests

2014-04-07 Thread Ben Pfaff
On Mon, Apr 07, 2014 at 05:41:50PM +0900, Simon Horman wrote: > This corrects an inconsistency in the MPLS tests and > avoids a race by waiting for sufficient output before > checking its contents > > Signed-off-by: Simon Horman Yamamoto-san, this seems to be close to some of your patches (maybe

Re: [ovs-dev] [PATCH] recirculation: Some cosmetic fixes

2014-04-07 Thread Pravin Shelar
On Wed, Mar 26, 2014 at 11:38 PM, YAMAMOTO Takashi wrote: > Wrap long lines, fix whitespaces, and fix a typo in a comment. > No functional changes are intended. > > Cc: Andy Zhou > Signed-off-by: YAMAMOTO Takashi for openvswitch.h. Acked-by: Pravin B Shelar > --- > include/linux/openvswitch.h

Re: [ovs-dev] [PATCH] ofproto-dpif: Always wait for ovs-ofctl exit

2014-04-07 Thread Ben Pfaff
On Mon, Apr 07, 2014 at 05:39:38PM +0900, Simon Horman wrote: > Uniformly wait for calls to ovs-ofctl exit in the test-suite. > > Signed-off-by: Simon Horman This inserts two OVS_APP_EXIT_AND_WAITs and two OVS_WAIT_UNTILs. The latter do not actually wait for ovs-ofctl to exit. _

Re: [ovs-dev] [PATCH 11/11] ofproto-dpif.at: Fix a race in "idle_age and hard_age increase over time"

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:13AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff Thanks a lot for fixing all these tests! Most of them do not regularly fail for me, but I can believe that they do for you in a different configuration. I don't think that i

Re: [ovs-dev] [PATCH 09/11] learn.at: Fix a race in "self-modifying flow with hard_timeout"

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:11AM +0900, YAMAMOTO Takashi wrote: > Also, add a comment to explain the expected sequences. > > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/

Re: [ovs-dev] [PATCH 08/11] ofproto-dpif.at: Fix races in "NetFlow flow expiration" tests

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:10AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 07/11] ofproto-dpif.at: Fix a race in "flow stats" test

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:09AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 06/11] ofproto-dpif.at: Fix a race in fin_timeout test

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:08AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 10/11] learn.at: Fix a race in "learn refreshes hard_age" test

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:12AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 02/11] ofproto-dpif.at: Avoid races in table miss tests

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:04AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 05/11] ofproto-dpif.at: Fix some races in MPLS actions tests

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:07AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 03/11] learn.at: Fix a race in "self-modifying flow with idle_timeout" test

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:05AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 01/11] ofproto-dpif.at: Fix a race in "ofproto-dpif - controller"

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:30:03AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] recirculation: Some cosmetic fixes

2014-04-07 Thread Ben Pfaff
On Thu, Mar 27, 2014 at 03:38:57PM +0900, YAMAMOTO Takashi wrote: > Wrap long lines, fix whitespaces, and fix a typo in a comment. > No functional changes are intended. > > Cc: Andy Zhou > Signed-off-by: YAMAMOTO Takashi For files other than include/linux/openvswitch.h: Acked-by: Ben Pfaff __

[ovs-dev] [PATCH] datapath: Add support for kernel 3.14.

2014-04-07 Thread Pritesh Kothari
Signed-off-by: Pritesh Kothari --- FAQ |2 +- NEWS |2 +- acinclude.m4 |4 ++-- datapath/actions.c|2 +- datapath/linux/

Re: [ovs-dev] [PATCH] recirculation: Some cosmetic fixes

2014-04-07 Thread Ben Pfaff
Pravin, this patch includes a change to , will you look at that part? On Thu, Mar 27, 2014 at 03:38:57PM +0900, YAMAMOTO Takashi wrote: > Wrap long lines, fix whitespaces, and fix a typo in a comment. > No functional changes are intended. > > Cc: Andy Zhou > Signed-off-by: YAMAMOTO Takashi > --

Re: [ovs-dev] [PATCH 2/2] ovsdb-server: Improve message for "add-db" of database already open.

2014-04-07 Thread Ben Pfaff
Thanks for the reviews. I applied both of these to master. On Mon, Apr 07, 2014 at 09:53:32AM -0700, Alex Wang wrote: > Acked-by: Alex Wang > > > On Tue, Mar 25, 2014 at 3:51 PM, Ben Pfaff wrote: > > > Otherwise you get a fairly obscure message about a lockfile already being > > locked. > >

Re: [ovs-dev] [PATCH 2/2] tests: Fix typo in ovsdb-server test.

2014-04-07 Thread Ben Pfaff
On Sun, Apr 06, 2014 at 11:08:18AM +0900, YAMAMOTO Takashi wrote: > > 25 kB is about 25000 bytes, not 2500. > > > > Signed-off-by: Ben Pfaff > > Acked-by: YAMAMOTO Takashi Thanks for the acks, I applied both of these to master. ___ dev mailing list d

Re: [ovs-dev] [PATCH 1/2] lockfile: Improve log message when a process tries to relock a file.

2014-04-07 Thread Alex Wang
Acked-by: Alex Wang On Tue, Mar 25, 2014 at 3:51 PM, Ben Pfaff wrote: > "Resource deadlock avoided" is a pretty obscure message. > > Signed-off-by: Ben Pfaff > --- > lib/lockfile.c|6 +- > tests/lockfile.at | 20 ++-- > 2 files changed, 15 insertions(+), 11 dele

Re: [ovs-dev] [PATCH 2/2] ovsdb-server: Improve message for "add-db" of database already open.

2014-04-07 Thread Alex Wang
Acked-by: Alex Wang On Tue, Mar 25, 2014 at 3:51 PM, Ben Pfaff wrote: > Otherwise you get a fairly obscure message about a lockfile already being > locked. > > Signed-off-by: Ben Pfaff > --- > ovsdb/ovsdb-server.c | 40 +++- > tests/ovsdb-server.at |

Re: [ovs-dev] error when building openvswitch klm

2014-04-07 Thread Jesse Gross
On Mon, Apr 7, 2014 at 9:36 AM, sowmini varadhan wrote: >> All of these versions of OVS long predate the kernel that you are >> trying to use, so they don't support it. However, you should just be >> able to use the version of the OVS kernel module packaged with the >> upstream kernel that you are

Re: [ovs-dev] error when building openvswitch klm

2014-04-07 Thread Jesse Gross
On Sun, Apr 6, 2014 at 6:11 PM, sowmini varadhan wrote: > I've built and booted up a kernel built from a recent-ish kernel.git. > Uname -r reports: 3.14.0-rc3+ > > Then I try to set up openvswitch 1.10.2 thus: > ./configure --with-linux=/lib/modules/`uname -r`/build > make > > but now actions.

Re: [ovs-dev] [PATCH] ofp-parse: Handle buffer resize when parsing actions

2014-04-07 Thread Jarno Rajahalme
Thanks for catching this, Simon. Pushed to master, Jarno Acked-by: Jarno Rajahalme On Apr 7, 2014, at 1:43 AM, Simon Horman wrote: > A call to ofpbuf_put() may cause the data of the passed to be resized and > its base address to change. Thus the address returned by ofpbuf_put() > should

[ovs-dev] [PATCH] ofp-parse: Handle buffer resize when parsing actions

2014-04-07 Thread Simon Horman
A call to ofpbuf_put() may cause the data of the passed to be resized and its base address to change. Thus the address returned by ofpbuf_put() should be used as the base address rather than relying on the base address prior to ofpbuf_put(). This avoids the following assertion in ofpact_update_le

[ovs-dev] [PATCH] ofproto-dpif: Wait for output for all MPLS tests

2014-04-07 Thread Simon Horman
This corrects an inconsistency in the MPLS tests and avoids a race by waiting for sufficient output before checking its contents Signed-off-by: Simon Horman --- tests/ofproto-dpif.at | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.

[ovs-dev] [PATCH] ofproto-dpif: Always wait for ovs-ofctl exit

2014-04-07 Thread Simon Horman
Uniformly wait for calls to ovs-ofctl exit in the test-suite. Signed-off-by: Simon Horman --- tests/ofproto-dpif.at | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index f2ddda9..6f70ba0 100644 --- a/tests/ofproto-dpif.at

Re: [ovs-dev] [PATCH 04/11] ofproto-dpif.at: Fix some races in megaflow tests

2014-04-07 Thread YAMAMOTO Takashi
> I've been looking at some races in the megaflow testcases recently as well, > with a slightly different approach, could you a look at my patch below? > > http://openvswitch.org/pipermail/dev/2014-April/038536.html my patch inserts sleeps between two netdev-dummy/receive calls, where it's expect

[ovs-dev] Commit "ofproto-dpif.at: Wait for the monitor's pidfile disappears where necessary" breaks test 700

2014-04-07 Thread Lori Jakab
Hi, On some of my systems the commit "0c47331 ofproto-dpif.at: Wait for the monitor's pidfile disappears where necessary" consistently breaks test "700: ofproto-dpif - controller". Reverting the commit makes the test pass again. This happens on a physical machine (Sandy Bridge laptop with L