Re: [ovs-dev] [PATCH] Makefile: Remove unnecessary includes of SSL_LIBS.

2014-03-04 Thread Ben Pfaff
On Tue, Mar 04, 2014 at 02:28:19PM -0800, Gurucharan Shetty wrote: > SSL_LIBS are needed for libopenvswitch and we include that > in lib/automake.mk. It is not necessary to include it > for every executable. > > Signed-off-by: Gurucharan Shetty As long as this links, I'm happy with it. Acked-by

Re: [ovs-dev] [PATCH] timeval: localtime_r, gmtime_r for Windows.

2014-03-04 Thread Ben Pfaff
On Tue, Mar 04, 2014 at 02:33:50PM -0800, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty > --- > lib/timeval.h |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/lib/timeval.h b/lib/timeval.h > index c207f23..f745855 100644 > --- a/lib/timeval.h > +++ b/lib/timeval.h

Re: [ovs-dev] [PATCHv5 2/2] ofproto-dpif: Remove the flow_dumper thread.

2014-03-04 Thread Ben Pfaff
On Fri, Feb 28, 2014 at 01:42:14PM -0800, Joe Stringer wrote: > From: Ethan Jackson > > Previously, we had a separate flow_dumper thread that fetched flows from > the datapath to distribute to revalidator threads. This patch takes the > logic for dumping and pushes it into the revalidator threads

[ovs-dev] [PATCH] timeval: localtime_r, gmtime_r for Windows.

2014-03-04 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- lib/timeval.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/timeval.h b/lib/timeval.h index c207f23..f745855 100644 --- a/lib/timeval.h +++ b/lib/timeval.h @@ -40,6 +40,13 @@ BUILD_ASSERT_DECL(TYPE_IS_SIGNED(time_t)); #define TIME_MAX TYPE

[ovs-dev] [PATCH] Makefile: Remove unnecessary includes of SSL_LIBS.

2014-03-04 Thread Gurucharan Shetty
SSL_LIBS are needed for libopenvswitch and we include that in lib/automake.mk. It is not necessary to include it for every executable. Signed-off-by: Gurucharan Shetty --- ovsdb/automake.mk |6 ++--- tests/automake.mk | 58 - utilitie

Re: [ovs-dev] [PATCHv2] ovs-thread: Add xpthread_barrier_*() wrappers.

2014-03-04 Thread Ben Pfaff
On Tue, Mar 04, 2014 at 01:15:41PM -0800, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > v2: Make xpthread_barrier_wait() return non-error code. Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo

[ovs-dev] [PATCHv2] ovs-thread: Add xpthread_barrier_*() wrappers.

2014-03-04 Thread Joe Stringer
Signed-off-by: Joe Stringer --- v2: Make xpthread_barrier_wait() return non-error code. --- lib/ovs-thread.c | 26 ++ lib/ovs-thread.h |6 ++ 2 files changed, 32 insertions(+) diff --git a/lib/ovs-thread.c b/lib/ovs-thread.c index 4dfccaf..b6b51c7 100644 --- a/l

Re: [ovs-dev] [PATCHv5 1/2] ovs-thread: Add xpthread_barrier_*() wrappers.

2014-03-04 Thread Ben Pfaff
It's not really necessary, patch 1/2 makes sense on its own. On Tue, Mar 04, 2014 at 10:06:28AM -0800, Joe Stringer wrote: > Shall I wait for feedback on patch #2 before posting a fresh version of > this? > > > On 1 March 2014 10:43, Ben Pfaff wrote: > > > Please. > > > > On Fri, Feb 28, 2014

Re: [ovs-dev] [RFC] bfd: Replace bfd.{c, h} with generic implementation.

2014-03-04 Thread Alex Wang
On Mon, Mar 3, 2014 at 11:38 PM, Ben Pfaff wrote: > OK. > > I didn't review the whole patch, by the way, I just noticed this > glancing at the first little bit. Sure, I'm aware of that. After checking the random.c code, I think it may be require converting more ovs code (e.g. pthread data, en

Re: [ovs-dev] [PATCHv5 1/2] ovs-thread: Add xpthread_barrier_*() wrappers.

2014-03-04 Thread Joe Stringer
Shall I wait for feedback on patch #2 before posting a fresh version of this? On 1 March 2014 10:43, Ben Pfaff wrote: > Please. > > On Fri, Feb 28, 2014 at 02:43:27PM -0800, Joe Stringer wrote: > > I figured that if we're not using the retval currently, then it doesn't > > matter too much. But

Re: [ovs-dev] RFC: the meaning of LINUX_DATAPATH and HAVE_IF_DL

2014-03-04 Thread Ben Pfaff
Oh, also I posted two patches as a place to get started. Would one of you please look them over? http://patchwork.openvswitch.org/patch/2858/ http://patchwork.openvswitch.org/patch/2859/ Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://ope

Re: [ovs-dev] [PATCH 1/2] timeval: clock_gettime() for Windows.

2014-03-04 Thread Ben Pfaff
On Tue, Mar 04, 2014 at 09:10:14AM -0800, Gurucharan Shetty wrote: > On Tue, Mar 4, 2014 at 8:59 AM, Ben Pfaff wrote: > > On Mon, Mar 03, 2014 at 02:46:27PM -0800, Gurucharan Shetty wrote: > >> QueryPerformanceCounter() retrieves the current value of the performance > >> counter, which is a high r

Re: [ovs-dev] [PATCHv5] upcall: Configure datapath max-idle through ovs-vsctl.

2014-03-04 Thread Justin Pettit
I had assumed Joe was going to revise this, since I don't think he's pushed it yet. --Justin On Mar 4, 2014, at 9:46 AM, Ben Pfaff wrote: > Justin, are you planning to apply this then? Or, Joe, are you planning > to post a new version? Just trying to figure out what's happening. > > On Thu

Re: [ovs-dev] [PATCH] vxlan: Support for receiving "ethernet over VXLAN-gpe" packets.

2014-03-04 Thread Ben Pfaff
On Mon, Mar 03, 2014 at 03:27:49PM -0800, Pritesh Kothari wrote: > Current VXLAN VTEP receives only VXLAN packets and ethernet over VXLAN-gpe [1] > packets are rejected. This patch adds support for receiving "ethernet over > VXLAN-gpe" packets which have same inner ethernet frame but a different VX

Re: [ovs-dev] [PATCHv5] upcall: Configure datapath max-idle through ovs-vsctl.

2014-03-04 Thread Joe Stringer
Sorry, I hadn't got around to it yet. I'll repost. On 4 March 2014 09:46, Ben Pfaff wrote: > Justin, are you planning to apply this then? Or, Joe, are you planning > to post a new version? Just trying to figure out what's happening. > > On Thu, Feb 27, 2014 at 10:59:00AM -0800, Justin Pettit

Re: [ovs-dev] [PATCHv5] upcall: Configure datapath max-idle through ovs-vsctl.

2014-03-04 Thread Ben Pfaff
Justin, are you planning to apply this then? Or, Joe, are you planning to post a new version? Just trying to figure out what's happening. On Thu, Feb 27, 2014 at 10:59:00AM -0800, Justin Pettit wrote: > I think it's clear enough, since it explicitly mentions datapath > flows. There's a FAQ entr

Re: [ovs-dev] [PATCH] vxlan: Support for receiving "ethernet over VXLAN-gpe" packets.

2014-03-04 Thread Pritesh Kothari (pritkoth)
On Mar 4, 2014, at 5:30 AM, Thomas Graf wrote: > On 03/04/2014 12:27 AM, Pritesh Kothari wrote: >> Current VXLAN VTEP receives only VXLAN packets and ethernet over VXLAN-gpe >> [1] >> packets are rejected. This patch adds support for receiving "ethernet over >> VXLAN-gpe" packets which have sam

[ovs-dev] [PATCH v2 1/2] timeval: clock_gettime() for Windows.

2014-03-04 Thread Gurucharan Shetty
QueryPerformanceCounter() retrieves the current value of the performance counter, which is a high resolution (<1us) time stamp that can be used for time-interval measurements. So, use it for MONOTONIC clock. The GetSystemTimePreciseAsFileTime() function retrieves the current system date and time w

Re: [ovs-dev] [PATCH 1/2] timeval: clock_gettime() for Windows.

2014-03-04 Thread Gurucharan Shetty
On Tue, Mar 4, 2014 at 8:59 AM, Ben Pfaff wrote: > On Mon, Mar 03, 2014 at 02:46:27PM -0800, Gurucharan Shetty wrote: >> QueryPerformanceCounter() retrieves the current value of the performance >> counter, which is a high resolution (<1us) time stamp that can be used for >> time-interval measureme

Re: [ovs-dev] [PATCH 1/2] timeval: clock_gettime() for Windows.

2014-03-04 Thread Gurucharan Shetty
On Tue, Mar 4, 2014 at 8:55 AM, Ben Pfaff wrote: > On Mon, Mar 03, 2014 at 02:46:27PM -0800, Gurucharan Shetty wrote: >> QueryPerformanceCounter() retrieves the current value of the performance >> counter, which is a high resolution (<1us) time stamp that can be used for >> time-interval measureme

[ovs-dev] Announcing an Open vSwitch Hackathon March 26-27

2014-03-04 Thread Kyle Mestery
I'd like to announce that Cisco is going to host an Open vSwitch Hackathon on March 26 and 27. The event is setup through Eventbrite at the link provided here [1]. Please register for either an in-person or remote attendee link if you're interested in spending two days deep-diving into OVS code, pa

Re: [ovs-dev] [PATCH 1/2] timeval: clock_gettime() for Windows.

2014-03-04 Thread Ben Pfaff
On Mon, Mar 03, 2014 at 02:46:27PM -0800, Gurucharan Shetty wrote: > QueryPerformanceCounter() retrieves the current value of the performance > counter, which is a high resolution (<1us) time stamp that can be used for > time-interval measurements. So, use it for MONOTONIC clock. > > The GetSystem

Re: [ovs-dev] [PATCH 1/2] timeval: clock_gettime() for Windows.

2014-03-04 Thread Ben Pfaff
On Mon, Mar 03, 2014 at 02:46:27PM -0800, Gurucharan Shetty wrote: > QueryPerformanceCounter() retrieves the current value of the performance > counter, which is a high resolution (<1us) time stamp that can be used for > time-interval measurements. So, use it for MONOTONIC clock. > > The GetSystem

Re: [ovs-dev] RFC: the meaning of LINUX_DATAPATH and HAVE_IF_DL

2014-03-04 Thread Ben Pfaff
On Tue, Mar 04, 2014 at 11:47:43AM +0100, Luigi Rizzo wrote: > On Fri, Jan 24, 2014 at 1:55 AM, Ben Pfaff wrote: > > > > - Instead of (LINUX_DATAPATH && !HAVE_IF_DL), write just > > __linux__. In the cases I looked at, the interface didn't > > seem too likely to be of

Re: [ovs-dev] [PATCH] vxlan: Support for receiving "ethernet over VXLAN-gpe" packets.

2014-03-04 Thread Thomas Graf
On 03/04/2014 12:27 AM, Pritesh Kothari wrote: Current VXLAN VTEP receives only VXLAN packets and ethernet over VXLAN-gpe [1] packets are rejected. This patch adds support for receiving "ethernet over VXLAN-gpe" packets which have same inner ethernet frame but a different VXLAN and VXLAN-gpe head

Re: [ovs-dev] RFC: the meaning of LINUX_DATAPATH and HAVE_IF_DL

2014-03-04 Thread Luigi Rizzo
On Fri, Jan 24, 2014 at 1:55 AM, Ben Pfaff wrote: > On Thu, Jan 23, 2014 at 04:45:34PM -0800, Luigi Rizzo wrote: > > On Thu, Jan 23, 2014 at 4:43 PM, Ben Pfaff wrote: > > > > > On Fri, Jan 24, 2014 at 01:29:32AM +0100, Daniele Di Proietto wrote: > > > > I'll just attach the patch (just for a qui

[ovs-dev] Bug#740355: openvswitch-datapath-source: module-assistant openvswitch-datapath fails on 7.4 3.2.0-4-amd64

2014-03-04 Thread Frédéric Tournier
apt-get remove openvswitch-datapath-source downloaded the .deb, then dpkg -i openvswitch-datapath-source_1.4.2+git20120612-9.1~deb7u1_all.deb build failed The new log seems more interesting. On 03/03/2014 22:46, Evgeni Golov wrote: Hi, On Mon, Mar 03, 2014 at 09:00:42AM +0100, Frédéric Tourn