Re: [ovs-dev] [PATCH v7] datapath: Per NUMA node flow stats.

2014-02-14 Thread Pravin Shelar
I got following sparse warning. /home/pravin/ovs/w6/datapath/linux/flow_table.c:97:9: warning: incorrect type in argument 1 (different address spaces) /home/pravin/ovs/w6/datapath/linux/flow_table.c:97:9:expected struct spinlock [usertype] *lock /home/pravin/ovs/w6/datapath/linux/flow_table.c:

Re: [ovs-dev] [PATCH 2/3] process: Clean up functions.

2014-02-14 Thread Gurucharan Shetty
On Fri, Feb 14, 2014 at 2:20 PM, Gurucharan Shetty wrote: > Some functions are unused and one of it can be declared as static. I decided to abandon this particular patch as there may be other users that use libopenvswitch. Thanks, Guru > > Signed-off-by: Gurucharan Shetty > --- > lib/process.c

[ovs-dev] [PATCH v2 2/2] process: Make changes for Windows.

2014-02-14 Thread Gurucharan Shetty
As of now, we are using the process subsystem in ovsdb-server to handle the "--run" command line option. That particular option is not used often and till deemed necessary, make it unsupported on Windows platform. Signed-off-by: Gurucharan Shetty --- lib/process.c | 19 ++

[ovs-dev] [PATCH v2 1/2] ovs-vswitchd: Get rid of call to process_init().

2014-02-14 Thread Gurucharan Shetty
It is not needed as we don't use any other process_* calls. Signed-off-by: Gurucharan Shetty --- vswitchd/ovs-vswitchd.c |2 -- 1 file changed, 2 deletions(-) diff --git a/vswitchd/ovs-vswitchd.c b/vswitchd/ovs-vswitchd.c index 9da2f49..b6a6621 100644 --- a/vswitchd/ovs-vswitchd.c +++ b/vsw

[ovs-dev] [PATCH 2/3] process: Clean up functions.

2014-02-14 Thread Gurucharan Shetty
Some functions are unused and one of it can be declared as static. Signed-off-by: Gurucharan Shetty --- lib/process.c | 28 ++-- lib/process.h |4 2 files changed, 2 insertions(+), 30 deletions(-) diff --git a/lib/process.c b/lib/process.c index 5dd34b3..82a76

[ovs-dev] [PATCH 3/3] process: Make changes for Windows.

2014-02-14 Thread Gurucharan Shetty
As of now, we are using the process subsystem in ovsdb-server to handle the "--run" command line option. That particular option is not used often and till deemed necessary, make is unsupported on Windows platform. Signed-off-by: Gurucharan Shetty --- lib/process.c | 15 ++

[ovs-dev] [PATCH 1/3] ovs-vswitchd: Get rid of call to process_init().

2014-02-14 Thread Gurucharan Shetty
It is not needed as we don't use any other process_* calls. Signed-off-by: Gurucharan Shetty --- vswitchd/ovs-vswitchd.c |2 -- 1 file changed, 2 deletions(-) diff --git a/vswitchd/ovs-vswitchd.c b/vswitchd/ovs-vswitchd.c index 9da2f49..b6a6621 100644 --- a/vswitchd/ovs-vswitchd.c +++ b/vsw

Re: [ovs-dev] modify the openflow code in openvswitch

2014-02-14 Thread Justin Pettit
On 2/13/14, 3:02 PM, "ghaith alwerfally" wrote: >i want test the performane of openflow controllers in both modes >proactive and reactive, >so how can i set up the openflow switch to works in proactive mode or >reactive mode as i wish ? > >openflow by default works in reactive mode When people t

Re: [ovs-dev] Question about OFPT_EXPERIMENTER

2014-02-14 Thread Junguk Cho
I got the point. Thanks 2014-02-14 13:27 GMT-07:00 Ben Pfaff : > It wouldn't make sense to put OFPT_EXPERIMENTER in those, because > OFPT_EXPERIMENTER doesn't identify a particular kind of message (it's > a category). > > All of the NXT and NXST messages are experimenter messages. > > On Fri, Fe

Re: [ovs-dev] Question about OFPT_EXPERIMENTER

2014-02-14 Thread Ben Pfaff
It wouldn't make sense to put OFPT_EXPERIMENTER in those, because OFPT_EXPERIMENTER doesn't identify a particular kind of message (it's a category). All of the NXT and NXST messages are experimenter messages. On Fri, Feb 14, 2014 at 11:49:08AM -0700, Junguk Cho wrote: > I already check it. Howeve

[ovs-dev] VLOG for new source file

2014-02-14 Thread Junguk Cho
I add new file in /ofproto/debug.c and automake.mk and recompile ovs. I showed this message. "ofproto/libofproto.a(debug.o): In function `show_tnl_port': /ovs/ofproto/debug.c:23: undefined reference to `VLM_debug'" collect2: ld returned 1 exit status I include "vlog.h" and decalare VLOG_DEFINE_TH

Re: [ovs-dev] [PATCH] upcall: Allow max_idle be configured through ovs-vsctl.

2014-02-14 Thread Jarno Rajahalme
On Feb 13, 2014, at 5:18 PM, Ethan Jackson wrote: > I think the use of the atomic variable in this patch is a bit odd. > ofproto_max_idle, is a regular old variable, even though it can be > written and read from different threads: the flow dumper and the main > thread. But when shared among the

Re: [ovs-dev] Question about OFPT_EXPERIMENTER

2014-02-14 Thread Junguk Cho
I already check it. However there is no "OFPT_EXPERIMENTER" type in enum ofptype or ofpraw. What does "tons of experimenter messages" mean? Thanks 2014-02-14 9:30 GMT-07:00 Ben Pfaff : > On Fri, Feb 14, 2014 at 01:22:18AM -0700, Junguk Cho wrote: > > Can current OVS support OFPT_EXPERIMENTER?

Re: [ovs-dev] [PATCH] tests: Add support for automatically running Ryu tests against OVS.

2014-02-14 Thread Ben Pfaff
On Fri, Feb 14, 2014 at 06:14:02PM +0900, Simon Horman wrote: > On Fri, Feb 07, 2014 at 11:23:57PM -0800, Ben Pfaff wrote: > > On Fri, Feb 07, 2014 at 11:18:53PM -0800, Ben Pfaff wrote: > > > The Ryu controller comes with an extensive library of OpenFlow tests, but > > > it doesn't seem so easy to

[ovs-dev] [PATCH] upcall: Allow max_idle be configured through ovs-vsctl.

2014-02-14 Thread Joe Stringer
Signed-off-by: Joe Stringer --- v2: Don't cache the max_idle in 'struct udpif'. Extend range of valid values to 100-3. --- ofproto/ofproto-dpif-upcall.c |5 ++--- ofproto/ofproto-provider.h|4 ofproto/ofproto.c |9 + ofproto/ofproto.h

Re: [ovs-dev] [PATCH] upcall: Allow max_idle be configured through ovs-vsctl.

2014-02-14 Thread Joe Stringer
On 13 February 2014 17:18, Ethan Jackson wrote: > I think the use of the atomic variable in this patch is a bit odd. > ofproto_max_idle, is a regular old variable, even though it can be > written and read from different threads: the flow dumper and the main > thread. But when shared among the re

Re: [ovs-dev] [PATCH] util: Pre-allocate buffer for ovs_lasterror_to_string().

2014-02-14 Thread Ben Pfaff
On Fri, Feb 14, 2014 at 08:27:08AM -0800, Gurucharan Shetty wrote: > This lets us call ovs_lasterror_to_string() and not having > to do an extra call of LocalFree() on the returned string. > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ d

[ovs-dev] [PATCH] util: Pre-allocate buffer for ovs_lasterror_to_string().

2014-02-14 Thread Gurucharan Shetty
This lets us call ovs_lasterror_to_string() and not having to do an extra call of LocalFree() on the returned string. Signed-off-by: Gurucharan Shetty --- lib/entropy.c |4 +--- lib/lockfile.c|4 +--- lib/socket-util.c | 19 +++ lib/util.c| 25

Re: [ovs-dev] Question about OFPT_EXPERIMENTER

2014-02-14 Thread Ben Pfaff
On Fri, Feb 14, 2014 at 01:22:18AM -0700, Junguk Cho wrote: > Can current OVS support OFPT_EXPERIMENTER? Yes, OVS has tons of experimenter messages. See lib/ofp-msgs.h. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [patch net] ovs: fix dp check in ovs_dp_reset_user_features

2014-02-14 Thread Jiri Pirko
This fixes crash when userspace does "ovs-dpctl add-dp dev" where dev is existing non-dp netdevice. Introduced by: commit 44da5ae5fbea4686f667dc854e5ea16814e44c59 "openvswitch: Drop user features if old user space attempted to create datapath" Signed-off-by: Jiri Pirko --- net/openvswitch/datap

Re: [ovs-dev] [PATCH] tests: Add support for automatically running Ryu tests against OVS.

2014-02-14 Thread Simon Horman
On Fri, Feb 07, 2014 at 11:23:57PM -0800, Ben Pfaff wrote: > On Fri, Feb 07, 2014 at 11:18:53PM -0800, Ben Pfaff wrote: > > The Ryu controller comes with an extensive library of OpenFlow tests, but > > it doesn't seem so easy to me to run all of them against a development > > version of Open vSwitc

[ovs-dev] Question about OFPT_EXPERIMENTER

2014-02-14 Thread Junguk Cho
Hi, Can current OVS support OFPT_EXPERIMENTER? I think it does not support. In handle_openflow__() in ofproto.c, I cannot find OFPTYPE_EXPERIMENTER. Is there anyone who know this?? Thanks ___ dev mailing list dev@openvswitch.org http://openvswitch.org/