On 13 February 2014 17:18, Ethan Jackson <et...@nicira.com> wrote: > I think the use of the atomic variable in this patch is a bit odd. > ofproto_max_idle, is a regular old variable, even though it can be > written and read from different threads: the flow dumper and the main > thread. But when shared among the revalidators, then we create a > special atomic in the struct udpif. > > At any rate, I think it's good enough to just read ofproto_max_idle > directly whenever we need it. If it changes, all the threads may not > get the update at the same time, but I don't think its a big deal. > What do you think?
Right, this had occurred to me when I looked back over it. I can't think of a strong reason for ensuring the threads use the same max_idle for a dump, so we could skip the caching. I'll send a v2.
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
