[ovs-dev] All Earth - Mikrotik - SXT Lite 5 R2 - 5 Ghz 2x2 Mimo 300Mbps 500mW 16dBi

2014-02-10 Thread All Earth - Vendas
All Earth Comercio de Eletronicos LTDA - Mikrotik Brasil Rua Leonida Reimann Trotti, nº 343 - CEP 13065-704 - Campinas Fone (19) 3256-5557 Fax (19) 3342-8689 cont...@allearth.com.br Loja Online www.allearth.com.br Tabela de Precos Tabela 2 - REVENDA Bom Dia COD ADAPTADOR - PCI - USB - POE R$ 22

Re: [ovs-dev] [PATCH] tests: Add missing banner.

2014-02-10 Thread Arun Sharma
Verified & looks good. Thanks Ben. On 11/02/14 12:54 AM, "Ben Pfaff" wrote: >Reported-by: Arun Sharma >Signed-off-by: Ben Pfaff >--- > tests/ovsdb-server.at |2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at >index b01743d..0cc4375 100644

Re: [ovs-dev] Bucket statistics

2014-02-10 Thread Ben Pfaff
No, nothing has changed in this area. A patch is still welcome. On Feb 10, 2014 6:13 PM, "Marco Canini" wrote: > Ben, > > I got detracted with some other higher priority things. Before I take a > look again into this issue and prepare a patch, I'd like to ask if it has > been resolved already in

Re: [ovs-dev] Bucket statistics

2014-02-10 Thread Marco Canini
Ben, I got detracted with some other higher priority things. Before I take a look again into this issue and prepare a patch, I'd like to ask if it has been resolved already in the mean time. Cheers, On Sat, Jan 25, 2014 at 2:00 AM, Marco Canini wrote: > I'll have a look and propose a patch. >

[ovs-dev] [PATCH v6 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jarno Rajahalme
Keep kernel flow stats for each NUMA node rather than each (logical) CPU. This avoids using the per-CPU allocator and removes most of the kernel-side OVS locking overhead otherwise on the top of perf reports and allows OVS to scale better with higher number of threads. With 9 handlers and 4 reval

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jarno Rajahalme
On Feb 10, 2014, at 3:28 PM, Jesse Gross wrote: > On Mon, Feb 10, 2014 at 11:15 AM, Pravin Shelar wrote: >> On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme >> wrote: >>> @@ -80,96 +76,126 @@ void ovs_flow_stats_update(struct sw_flow *flow, >>> struct sk_buff *skb) >>>tcp_flag

[ovs-dev] [PATCH 1/2] datapath: Remove 5-tuple optimization.

2014-02-10 Thread Jarno Rajahalme
The 5-tuple optimization becomes unnecessary with a later per-NUMA node stats patch. Remove it first to make the changes easier to grasp. This patch by itself actually decreases performance, partly because per-CPU stats will be allocated also for ovs_packet_cmd_execute(). This regression will go

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jarno Rajahalme
On Feb 10, 2014, at 3:21 PM, Jesse Gross wrote: > On Mon, Feb 10, 2014 at 11:31 AM, Jarno Rajahalme > wrote: >> On Feb 8, 2014, at 7:01 PM, Jesse Gross wrote: >>> On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme >>> wrote: diff --git a/datapath/flow.h b/datapath/flow.h index eafcfd

Re: [ovs-dev] [PATCH] tunnel: Support all combinations of flow-based and specific tunnel matches.

2014-02-10 Thread Pritesh Kothari (pritkoth)
Hi Ben, > -static const struct tnl_match_pattern patterns[] = { > -{ false, false, IP_SRC_CFG }, /* remote_ip, local_ip, in_key. */ > -{ false, false, IP_SRC_ANY }, /* remote_ip, in_key. */ > -{ true, false, IP_SRC_CFG }, /* remote_ip, local_ip. */ > -{ true

[ovs-dev] Fwd: [PATCH] ofproto-dpif-xlate: Make flows that match ICMP fields revalidate correctly.

2014-02-10 Thread Andy Zhou
-- Forwarded message -- From: Andy Zhou Date: Mon, Feb 10, 2014 at 3:41 PM Subject: Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Make flows that match ICMP fields revalidate correctly. To: Ben Pfaff Looks good to me. Thanks for the fix. Acked-by: Andy Zhou On Mon, Feb 10, 201

[ovs-dev] [PATCH v3 1/3] poll-loop: Make poll_fd_wait_event() cross-platform.

2014-02-10 Thread Gurucharan Shetty
This is helpful if we want to wait either on 'fd' for POSIX or events for Windows. For Windows, if both 'fd' and 'wevent' is specified, we associate that event with the 'fd' using WSAEventSelect() in poll_block(). So any 'events' on that 'fd' will wake us up from WaitForMultipleObjects(). WSAEven

[ovs-dev] [PATCH v3 3/3] stream-ssl: Add support for windows platform.

2014-02-10 Thread Gurucharan Shetty
This commit creates events and through poll_fd_wait_event() associates them with socket file descriptors to get woken up from poll_block(). Some other changes: * Windows does not have sys/fcntl.h but has a fcntl.h On Linux, there is fctnl.h too. * include to handle different C-Runtime linking o

[ovs-dev] [PATCH v3 2/3] socket-util: error number to string for sockets.

2014-02-10 Thread Gurucharan Shetty
For winsock2 functions, error number has to be converted to string using FormatMessage(). Signed-off-by: Gurucharan Shetty --- lib/socket-util.c | 29 + lib/socket-util.h |2 ++ lib/util.c|4 3 files changed, 35 insertions(+) diff --git a/lib/s

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jesse Gross
On Mon, Feb 10, 2014 at 11:15 AM, Pravin Shelar wrote: > On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: >> @@ -80,96 +76,126 @@ void ovs_flow_stats_update(struct sw_flow *flow, struct >> sk_buff *skb) >> tcp_flags = TCP_FLAGS_BE16(tcp_hdr(skb)); >> } >> >> -

[ovs-dev] [PATCH] ofproto-dpif-xlate: Make flows that match ICMP fields revalidate correctly.

2014-02-10 Thread Ben Pfaff
ICMPv4 and ICMPv6 have 8-bit "type" and "code" fields. struct flow uses the low 8 bits of the 16-bit tp_src and tp_dst members to represent these fields. The datapath interface, on the other hand, represents them with just 8 bits each. This means that if the high 8 bits of the masks for these fi

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jesse Gross
On Mon, Feb 10, 2014 at 11:31 AM, Jarno Rajahalme wrote: > On Feb 8, 2014, at 7:01 PM, Jesse Gross wrote: >> On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme >> wrote: >>> diff --git a/datapath/flow.h b/datapath/flow.h >>> index eafcfd8..f6cce35 100644 >>> --- a/datapath/flow.h >>> +++ b/datapat

Re: [ovs-dev] [PATCH v2 3/3] stream-ssl: Add support for windows platform.

2014-02-10 Thread Gurucharan Shetty
On Mon, Feb 10, 2014 at 1:14 PM, Ben Pfaff wrote: > On Mon, Feb 10, 2014 at 11:16:22AM -0800, Gurucharan Shetty wrote: >> This commit creates events and through poll_fd_wait_event() >> associates them with socket file descriptors to get woken up >> from poll_block(). >> >> Some other changes: >> >

Re: [ovs-dev] [PATCH v2 2/3] socket-util: error number to string for sockets.

2014-02-10 Thread Gurucharan Shetty
On Mon, Feb 10, 2014 at 1:01 PM, Ben Pfaff wrote: > On Mon, Feb 10, 2014 at 11:16:21AM -0800, Gurucharan Shetty wrote: >> For winsock2 functions, error number has to be converted to string >> using FormatMessage(). >> >> Signed-off-by: Gurucharan Shetty > > You can just include "ovs-thread.h", it

Re: [ovs-dev] [PATCH] upcall: Add appctl call to set flow_limit.

2014-02-10 Thread Ben Pfaff
On Thu, Feb 06, 2014 at 09:49:19AM -0800, Joe Stringer wrote: > This should assist testing of datapath performance, as it allows us to > skip "warming up" the flow limit value. > > Signed-off-by: Joe Stringer Applied, thanks. ___ dev mailing list dev@o

Re: [ovs-dev] [ovs-discuss] make check failing on 2.x

2014-02-10 Thread Ben Pfaff
On Mon, Feb 10, 2014 at 10:11:07PM +0400, Andrey Korolyov wrote: > On 02/10/2014 10:04 PM, Ben Pfaff wrote: > > On Mon, Feb 10, 2014 at 11:28:04AM +0400, Andrey Korolyov wrote: > >> On 02/10/2014 04:42 AM, Ben Pfaff wrote: > >>> On Mon, Feb 10, 2014 at 01:42:23AM +0400, Andrey Korolyov wrote: > >>>

Re: [ovs-dev] [PATCH v2 3/3] stream-ssl: Add support for windows platform.

2014-02-10 Thread Ben Pfaff
On Mon, Feb 10, 2014 at 11:16:22AM -0800, Gurucharan Shetty wrote: > This commit creates events and through poll_fd_wait_event() > associates them with socket file descriptors to get woken up > from poll_block(). > > Some other changes: > > * Windows does not have sys/fcntl.h but has a fcntl.h >

Re: [ovs-dev] [PATCH v2 1/3] poll-loop: Make poll_fd_wait_event() cross-platform.

2014-02-10 Thread Gurucharan Shetty
On Mon, Feb 10, 2014 at 1:04 PM, Ben Pfaff wrote: > On Mon, Feb 10, 2014 at 12:54:50PM -0800, Ben Pfaff wrote: >> On Mon, Feb 10, 2014 at 11:16:20AM -0800, Gurucharan Shetty wrote: >> > This is helpful if we want to wait either on 'fd' for POSIX or >> > events for Windows. >> > >> > For Windows, i

Re: [ovs-dev] [PATCH v2 1/3] poll-loop: Make poll_fd_wait_event() cross-platform.

2014-02-10 Thread Ben Pfaff
On Mon, Feb 10, 2014 at 12:54:50PM -0800, Ben Pfaff wrote: > On Mon, Feb 10, 2014 at 11:16:20AM -0800, Gurucharan Shetty wrote: > > This is helpful if we want to wait either on 'fd' for POSIX or > > events for Windows. > > > > For Windows, if both 'fd' and 'wevent' is specified, we associate > > t

Re: [ovs-dev] [PATCH v2 2/3] socket-util: error number to string for sockets.

2014-02-10 Thread Ben Pfaff
On Mon, Feb 10, 2014 at 11:16:21AM -0800, Gurucharan Shetty wrote: > For winsock2 functions, error number has to be converted to string > using FormatMessage(). > > Signed-off-by: Gurucharan Shetty You can just include "ovs-thread.h", it shouldn't be necessary to explicitly include . I'd make s

Re: [ovs-dev] [PATCH v2 1/3] poll-loop: Make poll_fd_wait_event() cross-platform.

2014-02-10 Thread Ben Pfaff
On Mon, Feb 10, 2014 at 11:16:20AM -0800, Gurucharan Shetty wrote: > This is helpful if we want to wait either on 'fd' for POSIX or > events for Windows. > > For Windows, if both 'fd' and 'wevent' is specified, we associate > that event with the 'fd' using WSAEventSelect(). So any 'events' > on th

Re: [ovs-dev] [PATCH 6/6] Add recirc_id to ovs_appctl bond/list command

2014-02-10 Thread Ben Pfaff
On Tue, Feb 04, 2014 at 04:36:24PM -0800, Andy Zhou wrote: > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 5/6] ofproto/bond: Use recirculation actions to implemented bond.

2014-02-10 Thread Ben Pfaff
On Tue, Feb 04, 2014 at 04:36:23PM -0800, Andy Zhou wrote: > Added recirculation support for bond. > > A unique per datapath recirculation id is allocated whenever a bond > is configured with balancing mode other than active/backup. This > recirculation ID is freed back when bond configuration cha

Re: [ovs-dev] [PATCH 4/6] lib/odp-util: Add new ODP actions for recirculation

2014-02-10 Thread Ben Pfaff
On Tue, Feb 04, 2014 at 04:36:22PM -0800, Andy Zhou wrote: > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/6] lib/metaflow: add new flow fields for recirculation

2014-02-10 Thread Ben Pfaff
On Tue, Feb 04, 2014 at 04:36:21PM -0800, Andy Zhou wrote: > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 0/6] Bond port megaflow using recirculation

2014-02-10 Thread Ben Pfaff
On Tue, Feb 04, 2014 at 04:36:18PM -0800, Andy Zhou wrote: > This is the first patch series to add megaflow support for bond interface > using recirculation. > > The final goal is that the bonding port selection will be made within the > datapath, using recirculation. Currently, the bonding port

Re: [ovs-dev] [PATCH 1/6] ofproto-dpif: Added Per backer recirculation ID management

2014-02-10 Thread Ben Pfaff
On Tue, Feb 04, 2014 at 04:36:19PM -0800, Andy Zhou wrote: > Recirculation ID needs to be unique per datapath. Its usage will be > tracked by the backer that corresponds to the datapath. > > In theory, Recirculation ID can be any uint32_t value, except 0. This > implementation limits to a smaller

[ovs-dev] [PATCH] tests: Skip queue limit tests if the queues are very large.

2014-02-10 Thread Ben Pfaff
This should prevent timing out. Reported-by: Andrey Korolyov Signed-off-by: Ben Pfaff --- tests/ofproto.at |3 +++ tests/ovsdb-server.at |3 +++ 2 files changed, 6 insertions(+) diff --git a/tests/ofproto.at b/tests/ofproto.at index f6a62cd..58bbe82 100644 --- a/tests/ofproto.at +

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jarno Rajahalme
On Feb 8, 2014, at 7:01 PM, Jesse Gross wrote: > On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: >> diff --git a/datapath/flow.c b/datapath/flow.c >> index abe6789..e86034e 100644 >> --- a/datapath/flow.c >> +++ b/datapath/flow.c >> @@ -80,96 +76,126 @@ void ovs_flow_stats_update(struct

[ovs-dev] [PATCH v2 3/3] stream-ssl: Add support for windows platform.

2014-02-10 Thread Gurucharan Shetty
This commit creates events and through poll_fd_wait_event() associates them with socket file descriptors to get woken up from poll_block(). Some other changes: * Windows does not have sys/fcntl.h but has a fcntl.h On Linux, there is fctnl.h too. * include to handle different C-Runtime linking o

[ovs-dev] [PATCH] tests: Add missing banner.

2014-02-10 Thread Ben Pfaff
Reported-by: Arun Sharma Signed-off-by: Ben Pfaff --- tests/ovsdb-server.at |2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at index b01743d..0cc4375 100644 --- a/tests/ovsdb-server.at +++ b/tests/ovsdb-server.at @@ -876,6 +876,8 @@ cat stdout

[ovs-dev] [PATCH v2 1/3] poll-loop: Make poll_fd_wait_event() cross-platform.

2014-02-10 Thread Gurucharan Shetty
This is helpful if we want to wait either on 'fd' for POSIX or events for Windows. For Windows, if both 'fd' and 'wevent' is specified, we associate that event with the 'fd' using WSAEventSelect(). So any 'events' on that 'fd' will wake us up from WaitForMultipleObjects(). CC: Linda Sun Signed-o

[ovs-dev] [PATCH v2 2/3] socket-util: error number to string for sockets.

2014-02-10 Thread Gurucharan Shetty
For winsock2 functions, error number has to be converted to string using FormatMessage(). Signed-off-by: Gurucharan Shetty --- lib/socket-util.c | 25 + lib/socket-util.h |2 ++ 2 files changed, 27 insertions(+) diff --git a/lib/socket-util.c b/lib/socket-util.c in

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Pravin Shelar
On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: > Keep kernel flow stats for each NUMA node rather than each (logical) > CPU. This avoids using the per-CPU allocator and removes most of the > > diff --git a/datapath/flow.c b/datapath/flow.c > index abe6789..e86034e 100644 > --- a/d

Re: [ovs-dev] [PATCH 3/4] socket-util: errno for winsock related functions.

2014-02-10 Thread Ben Pfaff
On Mon, Feb 10, 2014 at 10:31:02AM -0800, Gurucharan Shetty wrote: > On Thu, Feb 6, 2014 at 4:51 PM, Ben Pfaff wrote: > > On Thu, Feb 06, 2014 at 08:12:32AM -0800, Gurucharan Shetty wrote: > >> For Windows platform, there are different ways to get error numbers > >> for differnt situations. For C

Re: [ovs-dev] [PATCH 4/4] stream-ssl: Add support for windows platform.

2014-02-10 Thread Ben Pfaff
On Mon, Feb 10, 2014 at 10:34:32AM -0800, Gurucharan Shetty wrote: > On Thu, Feb 6, 2014 at 5:00 PM, Ben Pfaff wrote: > > On Thu, Feb 06, 2014 at 08:12:33AM -0800, Gurucharan Shetty wrote: > >> This commit creates events and associates them with > >> socket file descriptors to get woken up from po

Re: [ovs-dev] [PATCH 2/4] poll-loop: Introduce cross-platform poll_fd_wait_event().

2014-02-10 Thread Gurucharan Shetty
On Thu, Feb 6, 2014 at 4:53 PM, Ben Pfaff wrote: > On Thu, Feb 06, 2014 at 08:12:31AM -0800, Gurucharan Shetty wrote: >> This is helpful if we want to wait either on 'fd' for POSIX or >> events for Windows. >> >> Signed-off-by: Gurucharan Shetty > > Patches 1 and 2 seem OK to me. I wonder whethe

Re: [ovs-dev] [PATCH 4/4] stream-ssl: Add support for windows platform.

2014-02-10 Thread Gurucharan Shetty
On Thu, Feb 6, 2014 at 5:00 PM, Ben Pfaff wrote: > On Thu, Feb 06, 2014 at 08:12:33AM -0800, Gurucharan Shetty wrote: >> This commit creates events and associates them with >> socket file descriptors to get woken up from poll_block(). >> One difference with the Linux implementation is that >> we c

Re: [ovs-dev] [PATCH 3/4] socket-util: errno for winsock related functions.

2014-02-10 Thread Gurucharan Shetty
On Thu, Feb 6, 2014 at 4:51 PM, Ben Pfaff wrote: > On Thu, Feb 06, 2014 at 08:12:32AM -0800, Gurucharan Shetty wrote: >> For Windows platform, there are different ways to get error numbers >> for differnt situations. For C library functions, errno is set like the way >> they are set for Linux. For

Re: [ovs-dev] [ovs-discuss] make check failing on 2.x

2014-02-10 Thread Andrey Korolyov
On 02/10/2014 10:04 PM, Ben Pfaff wrote: > On Mon, Feb 10, 2014 at 11:28:04AM +0400, Andrey Korolyov wrote: >> On 02/10/2014 04:42 AM, Ben Pfaff wrote: >>> On Mon, Feb 10, 2014 at 01:42:23AM +0400, Andrey Korolyov wrote: On 02/09/2014 11:14 PM, Ben Pfaff wrote: > On Sat, Feb 08, 2014 at 05

Re: [ovs-dev] [ovs-discuss] make check failing on 2.x

2014-02-10 Thread Ben Pfaff
On Mon, Feb 10, 2014 at 11:28:04AM +0400, Andrey Korolyov wrote: > On 02/10/2014 04:42 AM, Ben Pfaff wrote: > > On Mon, Feb 10, 2014 at 01:42:23AM +0400, Andrey Korolyov wrote: > >> On 02/09/2014 11:14 PM, Ben Pfaff wrote: > >>> On Sat, Feb 08, 2014 at 05:24:16PM +0400, Andrey Korolyov wrote: > >>>

Re: [ovs-dev] [ovs-discuss] make check failing on 2.x

2014-02-10 Thread Andrey Korolyov
On 02/10/2014 11:28 AM, Andrey Korolyov wrote: > On 02/10/2014 04:42 AM, Ben Pfaff wrote: >> On Mon, Feb 10, 2014 at 01:42:23AM +0400, Andrey Korolyov wrote: >>> On 02/09/2014 11:14 PM, Ben Pfaff wrote: On Sat, Feb 08, 2014 at 05:24:16PM +0400, Andrey Korolyov wrote: > 'ofproto - flow moni

Re: [ovs-dev] [PATCH 1/2] datapath: Do not read tcp flags from a later fragment.

2014-02-10 Thread Jarno Rajahalme
On Feb 8, 2014, at 7:02 PM, Jesse Gross wrote: > On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: >>Only the first IP fragment can have a TCP header, check for this. >> >>Signed-off-by: Jarno Rajahalme > > Acked-by: Jesse Gross Pushed, thanks for the review! Jarno ___