On Mon, Feb 10, 2014 at 1:01 PM, Ben Pfaff <b...@nicira.com> wrote: > On Mon, Feb 10, 2014 at 11:16:21AM -0800, Gurucharan Shetty wrote: >> For winsock2 functions, error number has to be converted to string >> using FormatMessage(). >> >> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com> > > You can just include "ovs-thread.h", it shouldn't be necessary to > explicitly include <pthread.h>. Okay. > > I'd make sock_strerror()'s return type "const char *". > Okay
> I'd add a comment to sock_strerror() that explains why one would use > it instead of ovs_strerror(); it might be good to add a comment on > ovs_strerror(), too, explaining why you might need to use > sock_strerror() instead. Okay. I will include it as part of v3 as I need to respin the other 2 patches too. > > Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
