Looks good to me.
Acked-by: Andy Zhou
On Mon, Feb 3, 2014 at 12:55 PM, Ben Pfaff wrote:
> This would have helped me track down a bug I was hunting just now.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-netdev.c |8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --gi
On Mon, Feb 3, 2014 at 5:18 PM, Joe Perches wrote:
> Add "openvswitch: " prefix to OVS_NLERR output
> to match the other OVS_NLERR output of datapath.c
>
> Signed-off-by: Joe Perches
Also applied.
___
dev mailing list
dev@openvswitch.org
http://openvsw
On Mon, Feb 3, 2014 at 5:06 PM, Joe Perches wrote:
> Each use of pr__once has a per-site flag.
>
> Some of the OVS_NLERR messages look as if seeing them
> multiple times could be useful, so use net_ratelimit()
> instead of pr_info_once.
>
> Signed-off-by: Joe Perches
Applied, thanks.
___
Add "openvswitch: " prefix to OVS_NLERR output
to match the other OVS_NLERR output of datapath.c
Signed-off-by: Joe Perches
---
net/openvswitch/flow_netlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
index 4d000ac..c4e1
On Tue, Jan 28, 2014 at 01:20:43AM +, Ken Ajiro wrote:
>
> When two ovs-vsctl update map type column at same time, one ovs-vsctl's
> update will be discarded although all ovs-vsctl succeeded. This patch
> fixes this issue.
>
> Signed-off-by: Ken Ajiro
Thanks, I applied this to master and br
On Wed, Jan 29, 2014 at 12:53:03PM +0900, Simon Horman wrote:
> This reworks lookup of rules for both table 0 and table action translation.
> The result is that Table Mod settings, which can alter the miss-behaviour
> of tables, including table 0, on a per-table basis may be honoured.
>
> Previous
Each use of pr__once has a per-site flag.
Some of the OVS_NLERR messages look as if seeing them
multiple times could be useful, so use net_ratelimit()
instead of pr_info_once.
Signed-off-by: Joe Perches
---
> OK, I guess it's fine. Can you provide a signed-off-by line?
net/openvswitch/datapat
On Tue, Feb 04, 2014 at 09:52:40AM +0900, Simon Horman wrote:
> On Mon, Feb 03, 2014 at 03:27:16PM -0800, Ben Pfaff wrote:
> > Earlier today, I applied your 2-patch series to the mpls branch
> > earlier.
> >
> > Then, I squashed all the patches on that branch, except that I dropped
> > "Add OpenFl
Hi Ben,
On Mon, Feb 03, 2014 at 03:27:16PM -0800, Ben Pfaff wrote:
> Earlier today, I applied your 2-patch series to the mpls branch
> earlier.
>
> Then, I squashed all the patches on that branch, except that I dropped
> "Add OpenFlow support for matching multiple MPLS labels at once." (we
> can
On Fri, Jan 24, 2014 at 07:00:06PM +0100, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
Both applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Jan 29, 2014 at 03:13:19PM +0900, Simon Horman wrote:
> Some functions pass a non-NULL value as this parameter
> but none of those function uses the value xlate_receive()
> returns there. So simply remove the parameter all together.
>
> Also remove the now unused key_fitness field of struc
On Mon, Feb 3, 2014 at 2:08 PM, Joe Perches wrote:
> On Mon, 2014-02-03 at 13:46 -0800, Jesse Gross wrote:
>> On Sun, Feb 2, 2014 at 10:55 PM, Joe Perches wrote:
>> > Perhaps it'd make sense to use net_ratelimit()
>> > instead of printk_once for OVS_NLERR
>>
>> I guess I could see it going either
Earlier today, I applied your 2-patch series to the mpls branch
earlier.
Then, I squashed all the patches on that branch, except that I dropped
"Add OpenFlow support for matching multiple MPLS labels at once." (we
can add it back if there is demand) and rebased against current
master. I applied a
On Mon, Feb 03, 2014 at 02:10:43PM -0800, Gurucharan Shetty wrote:
> On Fri, Jan 31, 2014 at 2:56 PM, Ben Pfaff wrote:
> > On Tue, Jan 28, 2014 at 01:56:21PM -0800, Gurucharan Shetty wrote:
> >> The following code does not add any users yet.
> >>
> >> The visioned workflow that this piece of code
On Fri, Jan 31, 2014 at 2:56 PM, Ben Pfaff wrote:
> On Tue, Jan 28, 2014 at 01:56:21PM -0800, Gurucharan Shetty wrote:
>> The following code does not add any users yet.
>>
>> The visioned workflow that this piece of code should work with is:
>> * Create a windows service through a startup script w
On Thu, Jan 23, 2014 at 2:25 PM, Daniele Di Proietto
wrote:
> This change, firstly, avoids declaring the formal parameter const,
> since it is treated as non const. (to avoid -Wcast-qual)
> Secondly, it cast the pointer from void* to u8*, since it is used
> in arithmetic (to avoid -Wpointer-arith)
On Mon, 2014-02-03 at 13:46 -0800, Jesse Gross wrote:
> On Sun, Feb 2, 2014 at 10:55 PM, Joe Perches wrote:
> > Perhaps it'd make sense to use net_ratelimit()
> > instead of printk_once for OVS_NLERR
>
> I guess I could see it going either way but I'm not sure I see a
> strong argument for changi
On Sun, Feb 2, 2014 at 10:55 PM, Joe Perches wrote:
> Perhaps it'd make sense to use net_ratelimit()
> instead of printk_once for OVS_NLERR
I guess I could see it going either way but I'm not sure I see a
strong argument for changing.
___
dev mailing li
Signed-off-by: Ben Pfaff
---
tests/odp.at |7 +--
tests/ofproto-dpif.at | 17 ++---
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/tests/odp.at b/tests/odp.at
index 7834a74..a968dd3 100644
--- a/tests/odp.at
+++ b/tests/odp.at
@@ -85,8 +85,11 @@ AT_
The check for the innermost BOS should only happen for flows, not for
masks. This fixes a test failure.
Also, check that BOS=0 in labels other than the innermost.
Signed-off-by: Ben Pfaff
---
lib/odp-util.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --gi
I pushed these to my ovs-reviews "mpls" branch at github.
Ben Pfaff (2):
tests: Fix up a couple of tests to match current results.
odp-util: Fix BOS checks in parse_l2_5_onward().
lib/odp-util.c| 19 ---
tests/odp.at |7 +--
tests/ofproto-dpif.at |
This would have helped me track down a bug I was hunting just now.
Signed-off-by: Ben Pfaff
---
lib/dpif-netdev.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index cb64bdc..0268793 100644
--- a/lib/dpif-netdev.c
+++ b/lib/d
On Wed, Jan 29, 2014 at 04:20:53PM +0900, Simon Horman wrote:
> Update the test for an MPLS pop on on a packet whose label stack going to
> userspace to test that it goes to userspace, which is currently the case,
> rather than being dropped, which was the case earlier.
>
> Signed-off-by: Simon Ho
On Mon, Feb 3, 2014 at 9:36 AM, Ben Pfaff wrote:
> On Sun, Feb 02, 2014 at 10:45:29PM -0800, Jesse Gross wrote:
>> On Fri, Jan 31, 2014 at 4:59 PM, Ben Pfaff wrote:
>> > On Fri, Jan 31, 2014 at 10:38:20AM -0800, Jesse Gross wrote:
>> >> On Thu, Jan 30, 2014 at 1:31 PM, Thomas Morin
>> >> wrote:
On Wed, Jan 29, 2014 at 04:20:52PM +0900, Simon Horman wrote:
> If a pop is composed on a flow whose label stack is already full
> it should not call flow_push_mpls() as that function can't do
> anything useful (it aborts) given that the label stack is full.
>
> Signed-off-by: Simon Horman
> ---
On Fri, Jan 24, 2014 at 2:58 PM, Jarno Rajahalme wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 92ae66a..5b12a5d 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -817,11 +840,27 @@ static int ovs_flow_cmd_new_or_set(struct sk_buff *skb,
> struct genl_in
On Fri, Jan 24, 2014 at 2:58 PM, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
> ---
> datapath/datapath.c | 59
> +--
> datapath/flow.h |2 ++
> datapath/flow_netlink.c | 10 +---
> 3 files changed, 41 insertions(+),
On Mon, Feb 03, 2014 at 05:09:53PM +0100, Helmut Schaa wrote:
> On Fri, Jan 31, 2014 at 8:29 PM, Ben Pfaff wrote:
> > On Fri, Jan 17, 2014 at 05:18:17PM +0100, Helmut Schaa wrote:
> >> On Fri, Jan 17, 2014 at 2:44 AM, Ben Pfaff wrote:
> >> > On Mon, Dec 09, 2013 at 09:01:57AM +0100, Helmut Schaa
On Fri, Jan 24, 2014 at 2:58 PM, Jarno Rajahalme wrote:
> Userspace already sets NLM_F_ECHO when it wants a reply, make use of
> it.
>
> For set and del, OVS userspace only sets the NLM_F_ECHO if stats are
> needed back. So, we minimize the data sent back by only responding
> with key and stats f
On Sun, Feb 02, 2014 at 10:45:29PM -0800, Jesse Gross wrote:
> On Fri, Jan 31, 2014 at 4:59 PM, Ben Pfaff wrote:
> > On Fri, Jan 31, 2014 at 10:38:20AM -0800, Jesse Gross wrote:
> >> On Thu, Jan 30, 2014 at 1:31 PM, Thomas Morin
> >> wrote:
> >> > Hi,
> >> >
> >> > I ran into the same issue as t
On Thu, Jan 23, 2014 at 4:43 PM, Jarno Rajahalme wrote:
> Keep kernel flow stats for each NUMA node rather than each (logical)
> CPU. This avoids using the per-CPU allocator and removes most of the
> kernel-side OVS locking overhead otherwise on the top of perf report
> and allows OVS to scale be
Hello.
On 03-02-2014 5:08, Jesse Gross wrote:
From: Pravin B Shelar
ovs_flow_free() is not called under ovs-lock during packet
execute path (ovs_packet_cmd_execute()). Since packet execute
does not touch flow->mask, there is no need to take that
lock either. So move assert in case where flo
Hello.
On 03-02-2014 5:08, Jesse Gross wrote:
From: Thomas Graf
While the zerocopy method is correctly omitted if user space
does not support unaligned Netlink messages. The attribute is
still not padded correctly as skb_zerocopy() will not ensure
padding and the attribute size is no longer
On Fri, Jan 31, 2014 at 8:29 PM, Ben Pfaff wrote:
> On Fri, Jan 17, 2014 at 05:18:17PM +0100, Helmut Schaa wrote:
>> On Fri, Jan 17, 2014 at 2:44 AM, Ben Pfaff wrote:
>> > On Mon, Dec 09, 2013 at 09:01:57AM +0100, Helmut Schaa wrote:
>> >> On Sat, Dec 7, 2013 at 6:20 PM, Ben Pfaff wrote:
>> >> >
34 matches
Mail list logo
