Looks good to me,
On Tue, Dec 31, 2013 at 11:39 AM, Ben Pfaff wrote:
> Anytime there is a VLAN the flow needs to properly reflect that. Keeping
> the TPID in dl_type never makes sense and will probably cause problems.
> The existing code did the right thing in the common case but not in corner
On 2014/1/18 6:56, Ben Pfaff wrote:
I'm still not really happy with the degree of abstraction here. I'm
going to try some experiments of my own to see whether what I want is
practical.
Thanks, I don't have a good idea for abstraction properties before,
I'll try to find a good one and you can
Reported-by: Arun Sharma
Signed-off-by: Ben Pfaff
---
configure.ac |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 9b6c69e..2c04729 100644
--- a/configure.ac
+++ b/configure.ac
@@ -13,7 +13,7 @@
# limitations under the License.
AC_PRER
On Sat, Jan 18, 2014 at 01:12:42AM +0100, Luigi Rizzo wrote:
> I see that you have some helper functions in pcap-file.c
> to read and write a pcap file.
> Unfortunately pcap_read() conflicts with a function exported
> by libpcap, and this causes build problems when configure finds
> an installed li
On Fri, Jan 17, 2014 at 03:55:17PM -0800, Ben Pfaff wrote:
> On Fri, Jan 17, 2014 at 03:41:31PM -0800, Ben Pfaff wrote:
> > On Thu, Jan 09, 2014 at 04:26:12PM -0800, Linda Sun wrote:
> > > Use WaitForMultipleObjects for polling on windows. This works on all
> > > kinds
> > > of objects, e.g. soc
I see that you have some helper functions in pcap-file.c
to read and write a pcap file.
Unfortunately pcap_read() conflicts with a function exported
by libpcap, and this causes build problems when configure finds
an installed libpcap.
Given that pcap got there first and claims 152 (counted them)
d
On Fri, Jan 17, 2014 at 03:41:31PM -0800, Ben Pfaff wrote:
> On Thu, Jan 09, 2014 at 04:26:12PM -0800, Linda Sun wrote:
> > Use WaitForMultipleObjects for polling on windows. This works on all kinds
> > of objects, e.g. sockets, files, especially ioctl calls to the kernel.
> > poll_fd_wait_event
On Thu, Jan 09, 2014 at 04:26:12PM -0800, Linda Sun wrote:
> Use WaitForMultipleObjects for polling on windows. This works on all kinds
> of objects, e.g. sockets, files, especially ioctl calls to the kernel.
> poll_fd_wait_event() is used if events need to be passed to pollfds.
> latch is signa
On Tue, Dec 31, 2013 at 01:08:26PM +0530, Arun Sharma wrote:
> Allows active/passive socket operations to use IPv6 network addresses,
> except in-band control which is not supported for IPv6.
>
> tests: Added tests for socket connections over IPv6.
> Also added tests for NetFlow and sFlow using IP
I'm still not really happy with the degree of abstraction here. I'm
going to try some experiments of my own to see whether what I want is
practical.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Jan 17, 2014 at 1:49 PM, Eitan Eliahu wrote:
>
> Do we specify full path when accessing files?
Is this comment for the following line?
sc create ovsdb-server binpath=
"C:\openvswitch\usr\sbin\ovsdb-server.exe -vconsole:off
-vsyslog:off -vfile:info --remote=ptcp:6632:127.0.0.1 --
Do we specify full path when accessing files?
Thanks,
Eitan
- Original Message -
From: "Gurucharan Shetty"
To: "Ben Pfaff"
Cc: "dev" , "Saurabh Shah"
Sent: Friday, January 17, 2014 1:24:10 PM
Subject: Re: [ovs-dev] [PATCH 3/4] daemon-windows: Ability to handle windows
service calls.
On Fri, Jan 17, 2014 at 01:30:27PM -0800, Gurucharan Shetty wrote:
> On Fri, Jan 17, 2014 at 1:13 PM, Ben Pfaff wrote:
> > On Fri, Jan 17, 2014 at 12:26:23PM -0800, Gurucharan Shetty wrote:
> >> Start with ovs-vswitchd and ovsdb-server.
> >>
> >> Signed-off-by: Gurucharan Shetty
> >
> > Will poll
On Fri, Jan 17, 2014 at 01:22:39PM -0800, Gurucharan Shetty wrote:
> On Fri, Jan 17, 2014 at 1:07 PM, Ben Pfaff wrote:
> > On Fri, Jan 17, 2014 at 12:26:21PM -0800, Gurucharan Shetty wrote:
> >> More users will be added in an upcoming commit.
> >>
> >> Signed-off-by: Gurucharan Shetty
> >
> > Why
On Fri, Jan 17, 2014 at 1:13 PM, Ben Pfaff wrote:
> On Fri, Jan 17, 2014 at 12:26:23PM -0800, Gurucharan Shetty wrote:
>> Start with ovs-vswitchd and ovsdb-server.
>>
>> Signed-off-by: Gurucharan Shetty
>
> Will poll_block() wake up if a service stop has been requested?
> Ideally, it would.
I did
On Fri, Jan 17, 2014 at 1:11 PM, Ben Pfaff wrote:
> On Fri, Jan 17, 2014 at 12:26:22PM -0800, Gurucharan Shetty wrote:
>> The following code does not add any users yet.
>>
>> The visioned workflow that this piece of code should work with is:
>> * Create a windows service through a startup script w
On Fri, Jan 17, 2014 at 1:07 PM, Ben Pfaff wrote:
> On Fri, Jan 17, 2014 at 12:26:21PM -0800, Gurucharan Shetty wrote:
>> More users will be added in an upcoming commit.
>>
>> Signed-off-by: Gurucharan Shetty
>
> Why doesn't ovs_lasterror_to_string() take an appropriate type? (Why
> does the onl
On Fri, Jan 17, 2014 at 12:26:23PM -0800, Gurucharan Shetty wrote:
> Start with ovs-vswitchd and ovsdb-server.
>
> Signed-off-by: Gurucharan Shetty
Will poll_block() wake up if a service stop has been requested?
Ideally, it would.
Why does this change set_program_name__()?
Thanks,
Ben.
__
On Fri, Jan 17, 2014 at 12:26:22PM -0800, Gurucharan Shetty wrote:
> The following code does not add any users yet.
>
> The visioned workflow that this piece of code should work with is:
> * Create a windows service through a startup script with
> a tool like 'sc'
> ex: sc create ovsdb-server bin
On Fri, Jan 17, 2014 at 12:26:21PM -0800, Gurucharan Shetty wrote:
> More users will be added in an upcoming commit.
>
> Signed-off-by: Gurucharan Shetty
Why doesn't ovs_lasterror_to_string() take an appropriate type? (Why
does the only user need a cast to pass the argument?)
__
On Fri, Jan 17, 2014 at 12:26:20PM -0800, Gurucharan Shetty wrote:
> Some functions are unused and some functions can be
> declared as static.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://ope
On Fri, Jan 17, 2014 at 11:33:45AM +0900, Simon Horman wrote:
> On Thu, Jan 16, 2014 at 05:28:53PM -0800, Ben Pfaff wrote:
> > On Fri, Jan 17, 2014 at 09:59:49AM +0900, Simon Horman wrote:
> > > On Thu, Jan 16, 2014 at 04:46:23PM -0800, Ben Pfaff wrote:
> > > > On Wed, Jan 15, 2014 at 04:13:25PM +0
More users will be added in an upcoming commit.
Signed-off-by: Gurucharan Shetty
---
lib/entropy.c | 11 +--
lib/util.c| 13 +
lib/util.h|5 +
3 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/entropy.c b/lib/entropy.c
index fd73566..bdd
Start with ovs-vswitchd and ovsdb-server.
Signed-off-by: Gurucharan Shetty
---
lib/daemon.man |1 +
lib/service.man|1 +
lib/util.c |4
manpages.mk|6 ++
ovsdb/ovsdb-server.1.in|3 +++
ovsdb/ovsdb-server.c
Some functions are unused and some functions can be
declared as static.
Signed-off-by: Gurucharan Shetty
---
lib/daemon.c | 45 ++---
lib/daemon.h |9 -
python/ovs/daemon.py | 11 ---
3 files changed, 6 insertions(+)
The following code does not add any users yet.
The visioned workflow that this piece of code should work with is:
* Create a windows service through a startup script with
a tool like 'sc'
ex: sc create ovsdb-server binpath=
"C:\openvswitch\usr\sbin\ovsdb-server.exe -vconsole:off
-vsyslog:off -vf
Thanks. pushed to master and branch 2.1. Branch 2.0 and 1.11 seem to have
the same issue, but the patch won't apply directly. I will take a closer
look and make similar fixes if necessary.
On Thu, Jan 16, 2014 at 4:46 PM, Joe Stringer wrote:
> I've just tested v4, and haven't seen any further ke
This commit adds two new options, bfd_src_ip and bfd_dst_ip
respectively, which allows user to configure the source and
destination IP address of bfd control packet. If the user
specified address cannot be parsed, the default address
will be used.
Signed-off-by: Alex Wang
---
lib/bfd.c
Fetching the number of flows in the datapath has been causing
unnecessary contention on the kernel ovs_lock in recent TCP CRR tests.
This patch caches this number for up to 100ms in the userspace to reduce
such kernel calls.
Signed-off-by: Joe Stringer
Co-authored-by: Jarno Rajahalme
Signed-off-
On Fri, Jan 17, 2014 at 05:20:13PM +0100, Helmut Schaa wrote:
> On Thu, Jan 9, 2014 at 5:48 PM, Ben Pfaff wrote:
> > On Thu, Jan 09, 2014 at 08:51:00AM +0100, Helmut Schaa wrote:
> >> On Thu, Jan 9, 2014 at 1:59 AM, Ben Pfaff wrote:
> >> > On Wed, Jan 08, 2014 at 04:43:47PM +0100, Helmut Schaa wr
On Thu, Jan 9, 2014 at 5:48 PM, Ben Pfaff wrote:
> On Thu, Jan 09, 2014 at 08:51:00AM +0100, Helmut Schaa wrote:
>> On Thu, Jan 9, 2014 at 1:59 AM, Ben Pfaff wrote:
>> > On Wed, Jan 08, 2014 at 04:43:47PM +0100, Helmut Schaa wrote:
>> >> Due to a race condition when bringing up an internal port o
On Fri, Jan 17, 2014 at 2:44 AM, Ben Pfaff wrote:
> On Mon, Dec 09, 2013 at 09:01:57AM +0100, Helmut Schaa wrote:
>> On Sat, Dec 7, 2013 at 6:20 PM, Ben Pfaff wrote:
>> > On Fri, Dec 06, 2013 at 04:18:42PM +0100, Helmut Schaa wrote:
>> >> When adding a physical port to the main bridge the mac add
32 matches
Mail list logo
