On Fri, Jan 17, 2014 at 2:44 AM, Ben Pfaff <b...@nicira.com> wrote: > On Mon, Dec 09, 2013 at 09:01:57AM +0100, Helmut Schaa wrote: >> On Sat, Dec 7, 2013 at 6:20 PM, Ben Pfaff <b...@nicira.com> wrote: >> > On Fri, Dec 06, 2013 at 04:18:42PM +0100, Helmut Schaa wrote: >> >> When adding a physical port to the main bridge the mac address >> >> of the bridge is updated. We can do the same for fake bridges by >> >> copying the mac address of the parent bridge. >> >> >> >> There exists only one fake bridge per vlan, hence it is safe >> >> to copy the mac address of the parent bridge. >> >> >> >> Signed-off-by: Helmut Schaa <helmut.sc...@googlemail.com> >> > >> > Why do we want to do this? >> >> Same reason as why a regular ovs bridge tries to use the mac address of a >> physical port instead of using a random mac. If the fake bridge is used as >> local >> access port to the specified VLAN it definitely makes sense to use a >> "physical >> MAC" if any is suitable for use to not confuse other network participants >> with a >> random MAC (DHCP server for example). Another option would have been to >> copy the main bridge logic and only consider ports on the same VLAN as the >> fake bridge for MAC inheritance. >> >> Hope this clarifies my intent, >> Helmut > > OK. > > After thinking about this for a while, I decided to apply this.
Thanks Ben. In the meantime I updated my original patch to only consider interfaces using the same vlan. The main reason was the default mode in VMWare dropping all frames with a MAC different then the interface MAC :/ The current patch can be found at: https://github.com/hschaa/openvswitch/commit/5eea0b95388efb72e879ae06c14f4120a9f4cc0a https://github.com/hschaa/openvswitch/commit/3070df9df04c282efb07475c49712fc07dfc0651 I haven't found time to resubmit that yet and I have a couple of other patches also waiting for a respin (with some rework). Helmut _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
