On Wed, Dec 18, 2013 at 09:35:09PM -0800, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
Thanks.
I wanted to get this fixed so I applied this myself.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Dec 18, 2013 at 05:38:09PM -0800, Romain Lenglet wrote:
> Signed-off-by: Romain Lenglet
Didn't my earlier commit bb1329ec3 (ofp-tcpdump: Fix tcpdump patch
breakage due to libtool.) fix the problem? It's better to use libtool
than to hard-code a path internal to libtool.
_
I am testing latest ovs code on debian, using the following
/etc/network/interfaces
---
allow-vmbr0 eth1
iface eth1 inet manual
ovs_type OVSPort
ovs_bridge vmbr0
auto vmbr0
allow-ovs vmbr0
iface vmbr0 inet static
address 192.168.2.8
netmask 255.2
Signed-off-by: Gurucharan Shetty
---
xenserver/openvswitch-xen.spec.in |1 +
1 file changed, 1 insertion(+)
diff --git a/xenserver/openvswitch-xen.spec.in
b/xenserver/openvswitch-xen.spec.in
index 2702601..ae29649 100644
--- a/xenserver/openvswitch-xen.spec.in
+++ b/xenserver/openvswitch-xe
Use WaitForMultipleObjects for polling on windows. This works on all kinds
of objects, e.g. sockets, files, especially ioctl calls to the kernel.
poll_fd_wait_event() is used if events need to be passed to pollfds.
latch is signaled with event, to be waited/polled by WaitForMultipleObjects()
as
Signed-off-by: Romain Lenglet
---
third-party/ofp-tcpdump.patch |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/third-party/ofp-tcpdump.patch b/third-party/ofp-tcpdump.patch
index b1ac9a5..392d6cd 100644
--- a/third-party/ofp-tcpdump.patch
+++ b/third-party/ofp-tcpdump.patc
Signed-off-by: Alin Serdean
---
diff --git a/lib/entropy.c b/lib/entropy.c
index 02f56e0..a7dac34 100644
--- a/lib/entropy.c
+++ b/lib/entropy.c
@@ -20,6 +20,9 @@
#include
#include
#include
+#ifdef _WIN32
+#include
+#endif
#include "socket-util.h"
#include "vlog.h"
@@ -33,6 +36,7 @@ stat
On Wed, Dec 18, 2013 at 12:35:22PM +0900, Simon Horman wrote:
> On Tue, Dec 17, 2013 at 05:13:38PM -0800, Ben Pfaff wrote:
> > On Mon, Dec 16, 2013 at 05:53:22PM +0900, Simon Horman wrote:
> > > Add table config to to struct ofproto and set it
> > > when a table mod message is received.
> > >
> >
On Wed, Dec 18, 2013 at 01:55:53PM -0800, Gurucharan Shetty wrote:
> On Wed, Dec 18, 2013 at 9:21 AM, Ben Pfaff wrote:
> > There's no need for it because we have the equivalent (actually more
> > convenient) function raw_ctz(), which works with any integer type.
> >
> > Signed-off-by: Ben Pfaff
>
On Wed, Dec 18, 2013 at 02:54:35PM -0800, Linda Sun wrote:
> Guru has made changes in Makefile.am in ovs-windows branch to
> include windows platform files. Is it OK if I don't post
> latch-windows.c till that infra is pushed upstream?
I would expect your patch to both add the new file and update
Use WaitForMultipleObjects for polling on windows. This works on all kinds
of objects, e.g. sockets, files, especially ioctl calls to the kernel.
poll_fd_wait_event() is used if events need to be passed to pollfds.
latch is signaled with event, to be waited/polled by WaitForMultipleObjects()
as
- Original Message -
From: "Ben Pfaff"
To: "Linda Sun"
Cc: dev@openvswitch.org
Sent: Tuesday, December 17, 2013 4:46:44 PM
Subject: Re: [ovs-dev] [PATCH] pool-loop: windows poll_block implementation
On Thu, Dec 12, 2013 at 04:28:12PM -0800, Linda Sun wrote:
> Use WaitForMultipleObjects
Yes, I will do it later on today.
I was yesterday on a mini "holiday".
Kind Regards,
Alin.
From: Ben Pfaff [b...@nicira.com]
Sent: Wednesday, December 18, 2013 11:52 PM
To: Alin Serdean
Cc: Saurabh Shah; shet...@nicira.com; dev@openvswitch.org
Subject: Re:
On Wed, Dec 18, 2013 at 9:21 AM, Ben Pfaff wrote:
> There's no need for it because we have the equivalent (actually more
> convenient) function raw_ctz(), which works with any integer type.
>
> Signed-off-by: Ben Pfaff
> CC: Alin Serdean
> CC: Gurucharan Shetty
Looks good to me.
> ---
> ofprot
On Thu, Dec 12, 2013 at 1:59 PM, Alin Serdean
wrote:
> If there are no further remarks I would post in a patch.
Will you do that? Or if you already have can you do it again?
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org
Thanks, applied.
On Wed, Dec 18, 2013 at 01:45:29PM -0800, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
> --Justin
>
>
> On Wed, Dec 18, 2013 at 1:43 PM, Ben Pfaff wrote:
>
> > The recently introduced use of libtool, in commit 38b7a52b618b98
> > (openvswitch: Use libtool and allow buildi
On Wed, Dec 18, 2013 at 1:38 PM, Ben Pfaff wrote:
> On Wed, Dec 18, 2013 at 01:25:15PM -0800, Gurucharan Shetty wrote:
>> Reported-by: Igor Sever
>> Signed-off-by: Gurucharan Shetty
>
> Does at least the one in rhel need to be in () so that later commands
> don't happen in the wrong place?
>
> A
The recently introduced use of libtool, in commit 38b7a52b618b98
(openvswitch: Use libtool and allow building shared libs) broke the
tcpdump patch. This fixes the problem.
Signed-off-by: Ben Pfaff
---
third-party/ofp-tcpdump.patch |9 +
1 file changed, 9 insertions(+)
diff --git a/
On Wed, Dec 18, 2013 at 01:25:15PM -0800, Gurucharan Shetty wrote:
> Reported-by: Igor Sever
> Signed-off-by: Gurucharan Shetty
Does at least the one in rhel need to be in () so that later commands
don't happen in the wrong place?
Acked-by: Ben Pfaff
___
On Wed, Dec 18, 2013 at 1:10 PM, Ben Pfaff wrote:
> On Wed, Dec 18, 2013 at 09:08:56AM -0800, Gurucharan Shetty wrote:
>> Reported-by: Igor Sever
>> Signed-off-by: Gurucharan Shetty
>
> Thanks for fixing the problem.
>
> These commands scare the crap out of me though, because what if
> $RPM_BUIL
Reported-by: Igor Sever
Signed-off-by: Gurucharan Shetty
---
AUTHORS |1 +
rhel/openvswitch-fedora.spec.in |2 +-
rhel/openvswitch.spec.in|2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index fb204a2..595c096 100
On Wed, Dec 18, 2013 at 09:08:56AM -0800, Gurucharan Shetty wrote:
> Reported-by: Igor Sever
> Signed-off-by: Gurucharan Shetty
Thanks for fixing the problem.
These commands scare the crap out of me though, because what if
$RPM_BUILD_ROOT is somehow undefined and we end up blowing away every
li
On Wed, Dec 18, 2013 at 10:57 AM, Pravin B Shelar wrote:
> Patch fixes following build failure:-
>
> make[4]: Entering directory
> `/usr/src/kernels/2.6.32-358.18.1.el6.x86_64'
> CC [M] openvswitch/datapath/linux/actions.o
> In file included from
> openvswitch/datapath/linux/actions.c:21:
> ope
Patch fixes following build failure:-
make[4]: Entering directory
`/usr/src/kernels/2.6.32-358.18.1.el6.x86_64'
CC [M] openvswitch/datapath/linux/actions.o
In file included from
openvswitch/datapath/linux/actions.c:21:
openvswitch/datapath/linux/compat/include/linux/skbuff.h:273:
error: redefin
On Wed, Dec 18, 2013 at 10:45:12PM +0530, Arun Sharma wrote:
> On 18/12/13 4:57 AM, "Ben Pfaff" wrote:
> >GCC reports these errors:
> >
> >../lib/stream-tcp.c:74:51: error: using member 'sin6_addr' in
> >incomplete struct sockaddr_in6
> >../lib/stream-tcp.c:75:52: error: using member 'sin6
On Tue, Dec 17, 2013 at 05:11:05PM -0800, Linda Sun wrote:
> GCC reports:
>
> ../lib/poll-loop.c: In function 'poll_block':
> ../lib/poll-loop.c:304:16: error: unused variable 'i'
> [-Werror=unused-variable]
> ../lib/timeval.c: In function 'time_poll':
> ../lib/timeval.c:235:56: e
I think Alin posted another patch with a format message. Would you like me to
address your comments from that email(attached) and post a final patch?
Saurabh
From: Ben Pfaff mailto:b...@nicira.com>>
Date: Wednesday, December 18, 2013 9:44 AM
To: Saurabh Shah mailto:ssaur...@vmware.com>>
Cc: Alin
Saurabh, can you post a final patch?
On Fri, Dec 13, 2013 at 11:18:17AM -0800, Saurabh Shah wrote:
> I don't have a strong preference about the structuring. Anything that is
> intuitive is fine with me. With regards to keeping all pragma comments
> separate, I actually like keeping them close to
On Fri, Dec 13, 2013 at 02:37:56PM -0800, Jarno Rajahalme wrote:
> We allow zero 'values' in a miniflow for it to have the same map
> as the corresponding minimask. Minimasks themselves never have
> zero data values, though. Document this and optimize the code
> accordingly.
>
> Signed-off-by: J
On Tue, Dec 17, 2013 at 07:49:45AM -0800, Gurucharan Shetty wrote:
> For the files that you add, I think you can add your copyright instead
> of the Nicira one.
Yes, please (of course).
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mail
On Tue, Dec 17, 2013 at 02:02:16AM +, Alin Serdean wrote:
> I added also syslog.h as you suggested(this will help us in the future
> patches).
>
> Regarding the warnings I will send a detailed list iwth their corespondence
> in another mail and we can discuss further if we want to add them o
There's no need for it because we have the equivalent (actually more
convenient) function raw_ctz(), which works with any integer type.
Signed-off-by: Ben Pfaff
CC: Alin Serdean
CC: Gurucharan Shetty
---
ofproto/ofproto-dpif-mirror.c |3 +--
ofproto/ofproto-dpif-mirror.h |6 --
ofp
Thanks Ben for review comments. Couple of queries inline.
On 18/12/13 4:57 AM, "Ben Pfaff" wrote:
>On Mon, Dec 09, 2013 at 04:21:21AM -0800, Arun Sharma wrote:
>> Allows all socket operations to use ipv6 network addresses,
>> except in-band control which is not supported for ipv6
>>
>> Signed-
Reported-by: Igor Sever
Signed-off-by: Gurucharan Shetty
---
AUTHORS |1 +
rhel/openvswitch-fedora.spec.in |2 +-
rhel/openvswitch.spec.in|2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index fb204a2..595c096 100
On Wed, Dec 18, 2013 at 05:21:23PM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Dec 18, 2013 at 05:16:15PM +0900, YAMAMOTO Takashi wrote:
> this is a leftover of commit da4a6191.
> ("netdev: Globally track port status changes")
>
> Signed-off-by: YAMAMOTO Takashi
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
ht
On Wed, Dec 18, 2013 at 1:29 AM, Ben Pfaff wrote:
> On Fri, Dec 13, 2013 at 06:54:28PM +0100, Helmut Schaa wrote:
>> Currently openvswitch builds all libraries static only. However,
>> libopenvswitch is linked into nearly all openvswitch executables
>> making it hardly possible to run openvswitch
v5:
Fix CodingStyle of %zu to PRIuSIZE
Remerge a ofp-util.def to make it work independently.
Fix different return type while translate instruction type.
Remove useless ofp_print_not_implemented function.
Use mutex to protect table-features-set.
Add document for dump-table-features.
v4.
v5:
No change.
v4.1:
Update bitmap_count1 function: call count_1bits to improve
performance.
v4:
Add bitmap_count1 function to count all 1 bits.
Signed-off-by: Alexander Wu
Acked-by: Ben Pfaff
Signed-off-by: Ben Pfaff
---
lib/bitmap.c | 15 +++
lib/bitmap.h |1 +
2
v5:
Add dump-table-features to ovs-ofctl.8.in
v4:
No change.
v3:
No change.
v2:
No change
v1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
utilities/ovs-ofctl.8.in |4
utilities/ovs-ofct
v5:
Remove ofp-util.def from this patch and merge it ofp-actions patch.
Fix %zu to PRIuSIZE according to CodingStyle
Fix different return type in func ovs_instruction_type_from_inst_type
Remove unused function ofp_print_not_implemented.
Use OVS_NOT_REACHED now
v4.3:
Rollback table id 2
v5:
Add mutex lock when process table-features set message
v4.3:
Fix last table features id to 253 according to current
imlement and OpenFlow spec.
v4.2:
Fix last table features id to 255.
v4:
1. update abstract table-features to bitmap
2. update ofproto, reduce copy when reply table
v5:
Merge ofp-util.def to this patch to make it work independent.
Fix different return type in func ovs_instruction_type_from_inst_type
Use OVS_NOT_REACHED now.
v4:
Add enums of ofp13_action_type and make them work.
v3:
Add func to get instruction/action name by OpenFlow instruction typ
Signed-off-by: YAMAMOTO Takashi
---
AUTHORS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index fb204a2..6a56c03 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -112,6 +112,7 @@ Valient Gough vgo...@pobox.com
Vivien Bernet-Rollande v...@soprive.net
Wei Y
this is a leftover of commit da4a6191.
("netdev: Globally track port status changes")
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index 442c384..4a16e5c 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-
On Wed, Dec 18, 2013 at 03:58:27PM +0800, Alexander Wu wrote:
> On 18/12/2013 08:53, Ben Pfaff wrote:
> >On Mon, Dec 09, 2013 at 06:41:12PM +0800, Alexander Wu wrote:
> >>v4.3:
> >> Fix last table features id to 253 according to current
> >> imlement and OpenFlow spec.
> >>
> >>v4.2:
> >> Fix
On 18/12/2013 08:48, Ben Pfaff wrote:
On Mon, Dec 09, 2013 at 06:41:10PM +0800, Alexander Wu wrote:
v4.1:
Update bitmap_count1 function: call count_1bits to improve
performance.
v4:
Add bitmap_count1 function to count all 1 bits.
Acked-by: Ben Pfaff
Can I have a Signed-off-by, plea
47 matches
Mail list logo
