----- Original Message ----- From: "Ben Pfaff" <[email protected]> To: "Linda Sun" <[email protected]> Cc: [email protected] Sent: Tuesday, December 17, 2013 4:46:44 PM Subject: Re: [ovs-dev] [PATCH] pool-loop: windows poll_block implementation
On Thu, Dec 12, 2013 at 04:28:12PM -0800, Linda Sun wrote: > Use WaitForMultipleObjects for polling on windows. This works on all kinds > of objects, e.g. sockets, files, especially ioctl calls to the kernel. > One additional paramater is passed down in poll_fd_wait() to help > WaitForMultipleObjects. > latch is signaled with event, to be waited/polled by WaitForMultipleObjects() > as well. > Changed array of fds to hmap to check for duplicate fds. > > Signed-off-by: Linda Sun <[email protected]> I see that latch.c is completely different on Windows and Linux. I'd rather have two separate sources files, then, such as latch-windows.c and latch-unix.c, rather than one file with piles of ifdefs. I see that Windows also wants different members in struct latch; I guess an #ifdef in the header file is a reasonable way to do that. Ben <LS> Guru has made changes in Makefile.am in ovs-windows branch to include windows platform files. Is it OK if I don't post latch-windows.c till that infra is pushed upstream? Linda _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
