Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: reduce number of wakeup

2013-11-28 Thread Zhou, Han
Hi, On Wed, Sep 25, 2013 at 01:38:58PM +0900, YAMAMOTO Takashi wrote: > if a queue length is long (ie. non-0), the consumer thread should > already be busy working on the queue. there's no need to wake it > up repeatedly. ... > @@ -530,9 +532,13 @@ recv_upcalls(struct udpif *udpif) > ovs

Re: [ovs-dev] [PATCH openvswitch] netlink: Implement & enable memory mapped netlink i/o

2013-11-28 Thread Thomas Graf
On 11/28/2013 08:24 PM, Ben Pfaff wrote: On Wed, Nov 27, 2013 at 11:51:20PM +0100, Thomas Graf wrote: On 11/26/2013 12:02 AM, Ben Pfaff wrote: On Thu, Nov 21, 2013 at 07:16:54PM +0100, Thomas Graf wrote: Based on the initial patch by Cong Wang posted a couple of months ago. This is the user s

Re: [ovs-dev] [PATCH openvswitch] netlink: Implement & enable memory mapped netlink i/o

2013-11-28 Thread Ben Pfaff
On Wed, Nov 27, 2013 at 11:51:20PM +0100, Thomas Graf wrote: > On 11/26/2013 12:02 AM, Ben Pfaff wrote: > >On Thu, Nov 21, 2013 at 07:16:54PM +0100, Thomas Graf wrote: > >>Based on the initial patch by Cong Wang posted a couple of months > >>ago. > >> > >>This is the user space counterpart needed f

[ovs-dev] replacing use of ksize() with krealloc() ?

2013-11-28 Thread Luigi Rizzo
function reserve_sfa_size() uses ksize() (twice!) to figure out whether it is possible to use some extra space in the struct sf_flow_actions, or the buffer should be reallocated. Wouldn't it make more sense to rewrite the function so that it uses krealloc() instead ? There are very few places in