function reserve_sfa_size() uses ksize() (twice!) to figure out whether it is possible to use some extra space in the struct sf_flow_actions, or the buffer should be reallocated.
Wouldn't it make more sense to rewrite the function so that it uses krealloc() instead ? There are very few places in the kernel that use ksize(), and internally krealloc() does not actually reallocate memory if extra space if available so it is as efficient as the current reserve_sfa_size() (and possibly marginally better as it does not call ksize() twice). cheers luigi
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
