> On Thu, Oct 17, 2013 at 02:11:00PM +0900, YAMAMOTO Takashi wrote:
>> > On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote:
>> >> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
>> >> entries no_match rather than action.
>> >>
>> >> Signed-off-by: YAMAMOTO Takashi
On Thu, Oct 17, 2013 at 02:11:00PM +0900, YAMAMOTO Takashi wrote:
> > On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote:
> >> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
> >> entries no_match rather than action.
> >>
> >> Signed-off-by: YAMAMOTO Takashi
> >
> On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote:
>> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
>> entries no_match rather than action.
>>
>> Signed-off-by: YAMAMOTO Takashi
>
> Thanks! I really appreciate that you are working on conformance to
> later
On Thu, Oct 17, 2013 at 09:54:11AM +0900, Simon Horman wrote:
> I did wonder if this solution is slightly sub-optimal as
> now the mutex is taken both in netdev_dummy_rx_recv()
> and netdev_dummy_rx_recv(). Then again, I'm not sure that
> it is critical to optimise netdev-dummy.
I agree, netdev-du
Thanks a lot! Long waited moment~ ;D
On Wed, Oct 16, 2013 at 6:05 PM, Ethan Jackson wrote:
> Oh also, it's best to enclose arguments to macros with parens so I
> folded that in as well.
>
>
> https://www.securecoding.cert.org/confluence/display/seccode/PRE01-C.+Use+parentheses+within+macros+aro
Hi,
This series implements MPLS actions and matches based on work by
Ravi K, Leo Alterman, Yamahata-san and Joe Stringer.
This series provides two changes
* Patches 1 - 3
Provide user-space support for the VLAN/MPLS tag insertion order
up to and including OpenFlow 1.2, and the different ord
From: Joe Stringer
This patch adds new ofpact_from_openflow13() and
ofpacts_from_openflow13() functions parallel to the existing ofpact
handling code. In the OpenFlow 1.3 version, push_mpls is handled
differently, but all other actions are handled by the existing code.
In the case of push_mpls f
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Sim
From: Joe Stringer
This patch modifies the push_mpls behaviour to allow
pushing of an MPLS LSE either before any VLAN tag that may be present.
Pushing the MPLS LSE before any VLAN tag that is present is the
behaviour specified in OpenFlow 1.3.
Pushing the MPLS LSE after the any VLAN tag that is
From: Joe Stringer
OpenFlow 1.1 and 1.2, and 1.3 differ in their handling of MPLS actions in the
presence of VLAN tags. To allow correct behaviour to be committed in
each situation, this patch adds a second round of VLAN tag action
handling to commit_odp_actions(), which occurs after MPLS actions
Break out deacceleration portion of vlan_push into vlan_put
so that it may be re-used by mpls_push.
For both vlan_push and mpls_push if there is an accelerated VLAN tag
present then it should be deaccelerated, adding it to the data of
the skb, before the new tag is added.
Signed-off-by: Simon Hor
Oh also, it's best to enclose arguments to macros with parens so I
folded that in as well.
https://www.securecoding.cert.org/confluence/display/seccode/PRE01-C.+Use+parentheses+within+macros+around+parameter+names
Ethan
On Wed, Oct 16, 2013 at 6:03 PM, Ethan Jackson wrote:
> I renamed the macro
I renamed the macros to something slightly shorter and will merge
this. Thanks a lot.
Ethan
On Tue, Oct 15, 2013 at 12:32 PM, Alex Wang wrote:
> Before this commit, each time ofproto-dpif-monitor thread wakes up,
> all monitored ports will be iterated over. This adds a huge overhead
> to the m
On Wed, Oct 16, 2013 at 01:47:43PM -0700, Ben Pfaff wrote:
> On Wed, Oct 16, 2013 at 01:21:22PM -0700, Jesse Gross wrote:
> > On Tue, Oct 15, 2013 at 8:55 PM, Ben Pfaff wrote:
> > > On Thu, Oct 10, 2013 at 09:31:41AM +0900, Simon Horman wrote:
> > >> I believe this series addresses the feedback th
On Wed, Oct 16, 2013 at 09:09:15AM -0700, Ben Pfaff wrote:
> On Wed, Oct 16, 2013 at 07:17:01PM +0900, Simon Horman wrote:
> > This alters the way rx packets are accounted for by
> > counting them when they are processed by netdev_dummy_rx_recv(),
> > which seems to be a common path used by all rec
This commit makes the ofproto/dpif command show the "Relevant fields"
of each resubmit.
Signed-off-by: Alex Wang
---
ofproto/ofproto-dpif.c | 22 --
tests/ofproto-dpif.at | 35 +++
2 files changed, 51 insertions(+), 6 deletions(-)
diff --
Commit bcd2633a (ofproto-dpif: Store relevant fields for wildcarding
in facet.) introduced the bug that uses original input flow as final
flow to compute the "Relevant fields" in ofproto/trace ouput. This
commit fixes this bug.
Signed-off-by: Alex Wang
---
ofproto/ofproto-dpif.c |2 +-
1 fi
Yes, looks good to me too.
Reviewed-by: Simon Horman
On Wed, Oct 16, 2013 at 08:12:39PM +0300, Lori Jakab wrote:
> Looks good to me, thanks for fixing!
>
> On 10/16/13 7:28 PM, Ben Pfaff wrote:
> >Also, document how to work around it if you use an older OFTest.
> >
> >Reported-by: Simon Horman
On Wed, Oct 16, 2013 at 02:32:55PM +0300, Lori Jakab wrote:
> On 10/16/13 1:17 PM, Simon Horman wrote:
> >This alters the way rx packets are accounted for by
> >counting them when they are processed by netdev_dummy_rx_recv(),
> >which seems to be a common path used by all received packets.
> >
> >P
On Fri, Oct 11, 2013 at 3:55 PM, Andy Zhou wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 9e6df12..859a3b1 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> +static void get_dp_megaflow_stats(struct datapath *dp,
> + struct ovs_dp_megaflow_stat
Simplify some of the ofp-actions interface.
Signed-off-by: Jarno Rajahalme
---
lib/ofp-actions.c | 137 +++--
lib/ofp-actions.h | 17 +++---
lib/ofp-util.c| 77 +--
lib/ofp-util.h|1 +
utilities/
ofpacts_check() now stores the nw_proto field from flow to port number
set actions, so that we later remember which protocol they relate to.
This is needed for an accurate tranlation to OF 1.2+ set field action.
Simplify some of the ofp-actions interface.
Signed-off-by: Jarno Rajahalme
---
lib/
Output set field actions as standard OF1.0/1.1 set actions whenever possible.
Signed-off-by: Jarno Rajahalme
---
lib/ofp-util.c | 160
tests/ovs-ofctl.at |4 +-
2 files changed, 162 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-
Signed-off-by: Jarno Rajahalme
---
lib/meta-flow.h |2 +-
lib/ofp-actions.c| 44 +++---
lib/ofp-actions.h| 48 +-
lib/ofp-parse.c | 14 ++--
lib/ofp-util.c
This is a little bit simpler and marginally more efficient, but also makes
following changes easier.
Signed-off-by: Jarno Rajahalme
---
lib/meta-flow.c | 10 +---
lib/meta-flow.h | 10 +++-
lib/nx-match.c | 131 ++--
Signed-off-by: Jarno Rajahalme
---
lib/ofp-actions.c| 24
lib/ofp-actions.h|9 +
lib/ofp-parse.c | 14 +-
lib/ofp-util.def |2 +-
ofproto/ofproto-dpif-xlate.c |8
tests/ovs-ofctl
union ofp_action cannot remain in the OF 1.0 header as it is expanded
to include actions from later versions. Also, it is not part of the
protocol interface and will be easier to update where it is actually
used.
Signed-off-by: Jarno Rajahalme
---
include/openflow/openflow-1.0.h | 13
Signed-off-by: Jarno Rajahalme
---
lib/ofp-actions.c| 21 +
lib/ofp-actions.h|9 +
lib/ofp-parse.c | 11 ++-
lib/ofp-util.def |2 +-
ofproto/ofproto-dpif-xlate.c | 10 ++
tests/ovs-ofctl.at
Make it clear that match fields are rejected when their prerequisities
are not met, rather than just having their values ignored.
Also state that if decrementing makes a TTL zero, the controller
notification may be sent.
Signed-off-by: Jarno Rajahalme
---
utilities/ovs-ofctl.8.in | 30 +++
This series avoids using the deprecated field setting actions on OF 1.2+,
and logs a warning when they are received over OF 1.2+.
Jarno Rajahalme (9):
include/openflow: Move union ofp_action away from headers.
Fix ovs-ofctl documentation.
Add OF11 set IP ECN action.
Add OF11 SET IP TTL act
On Wed, Oct 16, 2013 at 01:55:41PM -0700, Gurucharan Shetty wrote:
> The new column 'kmod_version' will be used by ovs-ctl to set the
> kernel module version that ovs-vswitchd will be interacting with.
> This column can be quite useful for remote systems to figure out
> any discrepancies in the ker
On Wed, Oct 16, 2013 at 11:22:31AM -0700, Gurucharan Shetty wrote:
> On Tue, Oct 15, 2013 at 5:01 PM, Ben Pfaff wrote:
> > On Mon, Oct 14, 2013 at 08:55:35AM -0700, Gurucharan Shetty wrote:
> >> With mega-flows, many flows in the kernel datapath are wildcarded.
> >> For someone that is debugging a
On Mon, Oct 14, 2013 at 3:26 PM, Pravin B Shelar wrote:
> diff --git a/FAQ b/FAQ
> index d36495c..e904d35 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -148,7 +148,7 @@ A: The following table lists the Linux kernel versions
> against which the
> 1.9.x 2.6.18 to 3.8
> 1.10.x 2.6.18
On Tue, Oct 15, 2013 at 2:54 PM, Alexei Starovoitov wrote:
> The combination of two commits:
> commit 8e4e1713e4
> ("openvswitch: Simplify datapath locking.")
> commit 2537b4dd0a
> ("openvswitch:: link upper device for port devices")
>
> introduced a bug where upper_dev wasn't unlinked upon
> netd
Looks good to me,
On Mon, Sep 30, 2013 at 2:47 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/bfd.c |6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/bfd.c b/lib/bfd.c
> index 6c9e920..dbb0e13 100644
> --- a/lib/bfd.c
> +++ b/lib/bfd.c
> @@ -62
Have a question,
function flow_compose() is called when we specify '-generate' option. in
that case, the packet will not have any l7 data. so, seem to me there is
no change to the output.
Thanks,
On Mon, Sep 30, 2013 at 2:47 PM, Ben Pfaff wrote:
> flow_extract() fills in ->l7 but flow_compo
Thanks, applied to master.
On Wed, Oct 16, 2013 at 08:12:39PM +0300, Lori Jakab wrote:
> Looks good to me, thanks for fixing!
>
> On 10/16/13 7:28 PM, Ben Pfaff wrote:
> >Also, document how to work around it if you use an older OFTest.
> >
> >Reported-by: Simon Horman
> >Reported-by: Lori Jakab
The new column 'kmod_version' will be used by ovs-ctl to set the
kernel module version that ovs-vswitchd will be interacting with.
This column can be quite useful for remote systems to figure out
any discrepancies in the kernel module version being used in all
of the hypervisors under its domain.
On Wed, Oct 16, 2013 at 01:21:22PM -0700, Jesse Gross wrote:
> On Tue, Oct 15, 2013 at 8:55 PM, Ben Pfaff wrote:
> > On Thu, Oct 10, 2013 at 09:31:41AM +0900, Simon Horman wrote:
> >> I believe this series addresses the feedback that each of you
> >> gave with regards to recent previous postings o
On Tue, Oct 15, 2013 at 8:55 PM, Ben Pfaff wrote:
> On Thu, Oct 10, 2013 at 09:31:41AM +0900, Simon Horman wrote:
>> I believe this series addresses the feedback that each of you
>> gave with regards to recent previous postings of this patch-set.
>> I'm wondering if you could find some time to rev
On Tue, Oct 15, 2013 at 2:49 PM, Ben Pfaff wrote:
> On Tue, Oct 15, 2013 at 02:38:11PM -0700, Ansis Atteka wrote:
>> These are auto-generated files, so it would be better not to keep them
>> inside Open vSwitch repository.
>>
>> Behaviour before this patch was that if dot tool was not present on
>
These are auto-generated files, so it would be better not to keep them
inside Open vSwitch repository.
Behaviour before this patch was that if dot tool was not present on
the system, then ovs-vswitchd.conf.db.5 would have used pre-generated
vswitch.pic file that was already checked in the git repo
On Tue, Oct 15, 2013 at 5:01 PM, Ben Pfaff wrote:
> On Mon, Oct 14, 2013 at 08:55:35AM -0700, Gurucharan Shetty wrote:
>> With mega-flows, many flows in the kernel datapath are wildcarded.
>> For someone that is debugging a system and wants to find a particular
>> flow and its actions, it is a lit
Looks good to me, thanks for fixing!
On 10/16/13 7:28 PM, Ben Pfaff wrote:
Also, document how to work around it if you use an older OFTest.
Reported-by: Simon Horman
Reported-by: Lori Jakab
Signed-off-by: Ben Pfaff
---
README-OFTest|7 +++
tests/run-oftest |2 +-
2 files
On Tue, Oct 15, 2013 at 4:41 PM, Ben Pfaff wrote:
> On Mon, Oct 14, 2013 at 01:55:37PM -0700, Gurucharan Shetty wrote:
>> We have a least recently used algorithm for assigning ofport values
>> to newly created ports. i.e., when we don't have any unused ofport
>> numbers, we use ofport numbers from
On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote:
> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
> entries no_match rather than action.
>
> Signed-off-by: YAMAMOTO Takashi
Thanks! I really appreciate that you are working on conformance to
later OpenFlow spe
On Wed, Oct 16, 2013 at 02:21:07PM +0300, Lori Jakab wrote:
> I started looking at this too before Simon sent this email, with the
> same OFtest and OVS revisions. I had to apply the same patch to
> tests/run-oftest to make it work, so I suggest applying it to the
> tree.
I agree, I sent this out
On Wed, Oct 16, 2013 at 07:16:31PM +0900, Simon Horman wrote:
> I also applied the following patch to ovs as OFtest seems
> to want to use a different (the new?) port.
>
> --- begin ---
> --- a/tests/run-oftest
> +++ b/tests/run-oftest
> @@ -74,7 +74,7 @@ for port in p1 p2 p3 p4; do
>
Also, document how to work around it if you use an older OFTest.
Reported-by: Simon Horman
Reported-by: Lori Jakab
Signed-off-by: Ben Pfaff
---
README-OFTest|7 +++
tests/run-oftest |2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/README-OFTest b/README-OFTe
On Wed, Oct 16, 2013 at 02:32:55PM +0300, Lori Jakab wrote:
> On 10/16/13 1:17 PM, Simon Horman wrote:
> >This alters the way rx packets are accounted for by
> >counting them when they are processed by netdev_dummy_rx_recv(),
> >which seems to be a common path used by all received packets.
> >
> >P
On Wed, Oct 16, 2013 at 07:17:01PM +0900, Simon Horman wrote:
> This alters the way rx packets are accounted for by
> counting them when they are processed by netdev_dummy_rx_recv(),
> which seems to be a common path used by all received packets.
>
> Previously accounting was done earlier, in netd
On 10/16/13 1:17 PM, Simon Horman wrote:
This alters the way rx packets are accounted for by
counting them when they are processed by netdev_dummy_rx_recv(),
which seems to be a common path used by all received packets.
Previously accounting was done earlier, in netdev_dummy_receive(),
however t
Hi Ben,
On 10/16/13 1:16 PM, Simon Horman wrote:
Hi Ben,
On Tue, Oct 15, 2013 at 09:55:12AM -0700, Ben Pfaff wrote:
I see that "make check-oftest" reports 8 failures and 1 error. (I
haven't updated OFtest in ages, maybe newer versions would give
different results.) I don't have time to chase
This alters the way rx packets are accounted for by
counting them when they are processed by netdev_dummy_rx_recv(),
which seems to be a common path used by all received packets.
Previously accounting was done earlier, in netdev_dummy_receive(),
however this does not appear to count packets that a
Hi Ben,
On Tue, Oct 15, 2013 at 09:55:12AM -0700, Ben Pfaff wrote:
> I see that "make check-oftest" reports 8 failures and 1 error. (I
> haven't updated OFtest in ages, maybe newer versions would give
> different results.) I don't have time to chase these down this week,
> but it would be a much
no functional changes.
Signed-off-by: YAMAMOTO Takashi
---
lib/ofp-actions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 06f9f6b..d6747b0 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -1092,7 +1092,7 @@ ofpacts_from_
Signed-off-by: YAMAMOTO Takashi
---
lib/nx-match.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index 15143f1..11cbff3 100644
--- a/lib/nx-match.c
+++ b/lib/nx-match.c
@@ -280,8 +280,8 @@ oxm_pull_match__(struct ofpbuf *b, bool strict,
Signed-off-by: YAMAMOTO Takashi
---
lib/ofp-util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 173b534..2bf595a 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -296,8 +296,8 @@ ofputil_pull_ofp11_match(struct ofpbuf *buf, struc
comment fixes and cosmetic clean-up.
YAMAMOTO Takashi (3):
ofp-actins: consistently use a helper function
ofputil_match_from_ofp11_match: fix a comment
nx-match: fix comments
lib/nx-match.c| 6 +++---
lib/ofp-actions.c | 2 +-
lib/ofp-util.c| 4 ++--
3 files changed, 6 insertions(+
As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
entries no_match rather than action.
Signed-off-by: YAMAMOTO Takashi
---
OPENFLOW-1.1+ | 3 ---
include/openflow/openflow-common.h | 5 -
lib/ofp-util.c | 3 +++
ofproto/connmgr.c
60 matches
Mail list logo
